Eclipse/jetty.project
1
0
Fork 0
mirror of https://github.com/jetty/jetty.project.git synced 2025-03-04 04:49:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

458663 Handle null header values

Browse Source
This commit is contained in:
Greg Wilkins 2015-02-11 14:30:26 +11:00
parent 2162455b72
commit ca8015828c
2 changed files with 43 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java
View File

@ -1047,6 +1047,17 @@ public class HttpParser
if (ch==HttpTokens.SPACE || ch==HttpTokens.TAB)
break;
if (ch==HttpTokens.LINE_FEED)
{
_value=null;
_string.setLength(0);
_valueString=null;
_length=-1;
parsedHeader();
setState(State.HEADER);
break;
}
throw new IllegalCharacter(ch,buffer);
case HEADER_IN_VALUE:

29
jetty-http/src/test/java/org/eclipse/jetty/http/HttpParserTest.java
View File

@ -270,7 +270,36 @@ public class HttpParserTest
}
@Test
public void testNoValue() throws Exception
{
ByteBuffer buffer= BufferUtil.toBuffer(
"GET / HTTP/1.0\015\012" +
"Host: localhost\015\012" +
"Name0: \015\012"+
"Name1: \015\012"+
"Connection: close\015\012" +
"\015\012");
HttpParser.RequestHandler handler = new Handler();
HttpParser parser= new HttpParser(handler);
parseAll(parser,buffer);
assertTrue(_headerCompleted);
assertTrue(_messageCompleted);
assertEquals("GET", _methodOrVersion);
assertEquals("/", _uriOrStatus);
assertEquals("HTTP/1.0", _versionOrReason);
assertEquals("Host", _hdr[0]);
assertEquals("localhost", _val[0]);
assertEquals("Name0", _hdr[1]);
assertEquals(null, _val[1]);
assertEquals("Name1", _hdr[2]);
assertEquals(null, _val[2]);
assertEquals("Connection", _hdr[3]);
assertEquals("close", _val[3]);
assertEquals(3, _headers);
}
@Test
public void testHeaderParseDirect() throws Exception