Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

412729 - SPDYClient needs a Promise-based connect() method. 

Implemented the new method, modified the blocking method
(with a better signature) to call the new method.
This commit is contained in:
Simone Bordet 2013-07-11 10:28:58 +02:00
parent cd97b3dcbf
commit cdf6f17b9e
3 changed files with 64 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
jetty-spdy/spdy-client/src/main/java/org/eclipse/jetty/spdy/client/SPDYClient.java
View File

@ -19,7 +19,6 @@
package org.eclipse.jetty.spdy.client;
import java.io.IOException;
import java.net.InetSocketAddress;
import java.net.SocketAddress;
import java.nio.channels.SelectionKey;
import java.nio.channels.SocketChannel;
@ -46,12 +45,29 @@ import org.eclipse.jetty.spdy.api.Session;
import org.eclipse.jetty.spdy.api.SessionFrameListener;
import org.eclipse.jetty.util.Callback;
import org.eclipse.jetty.util.FuturePromise;
import org.eclipse.jetty.util.Promise;
import org.eclipse.jetty.util.component.ContainerLifeCycle;
import org.eclipse.jetty.util.ssl.SslContextFactory;
import org.eclipse.jetty.util.thread.QueuedThreadPool;
import org.eclipse.jetty.util.thread.ScheduledExecutorScheduler;
import org.eclipse.jetty.util.thread.Scheduler;
/**
* A {@link SPDYClient} allows applications to connect to one or more SPDY servers,
* obtaining {@link Session} objects that can be used to send/receive SPDY frames.
* <p />
* {@link SPDYClient} instances are created through a {@link Factory}:
* <pre>
* SPDYClient.Factory factory = new SPDYClient.Factory();
* SPDYClient client = factory.newSPDYClient(SPDY.V3);
* </pre>
* and then used to connect to the server:
* <pre>
* FuturePromise&lt;Session&gt; promise = new FuturePromise&lt;&gt;();
* client.connect("server.com", null, promise);
* Session session = promise.get();
* </pre>
*/
public class SPDYClient
{
private final SPDYClientConnectionFactory connectionFactory = new SPDYClientConnectionFactory();
@ -87,11 +103,42 @@ public class SPDYClient
this.bindAddress = bindAddress;
}
public Future<Session> connect(InetSocketAddress address, SessionFrameListener listener) throws IOException
/**
* Equivalent to:
* <pre>
* Future&lt;Session&gt; promise = new FuturePromise&lt;&gt;();
* connect(address, listener, promise);
* </pre>
*
* @param address the address to connect to
* @param listener the session listener that will be notified of session events
* @return a {@link Future} that provides a {@link Session} when connected
*/
public Future<Session> connect(SocketAddress address, SessionFrameListener listener)
{
FuturePromise<Session> promise = new FuturePromise<>();
connect(address, listener, promise);
return promise;
}
/**
* Connects to the given {@code address}, binding the given {@code listener} to session events,
* and notified the given {@code promise} of the connect result.
* <p />
* If the connect operation is successful, the {@code promise} will be invoked with the {@link Session}
* object that applications can use to perform SPDY requests.
*
* @param address the address to connect to
* @param listener the session listener that will be notified of session events
* @param promise the promise notified of connection success/failure
*/
public void connect(SocketAddress address, SessionFrameListener listener, Promise<Session> promise)
{
if (!factory.isStarted())
throw new IllegalStateException(Factory.class.getSimpleName() + " is not started");
try
{
SocketChannel channel = SocketChannel.open();
if (bindAddress != null)
channel.bind(bindAddress);
@ -102,8 +149,11 @@ public class SPDYClient
channel.connect(address);
factory.selector.connect(channel, result);
return result;
}
catch (IOException x)
{
promise.failed(x);
}
}
public long getIdleTimeout()

2
jetty-spdy/spdy-http-server/src/test/java/org/eclipse/jetty/spdy/server/proxy/ProxySPDYToHTTPLoadTest.java
View File

@ -213,7 +213,7 @@ public class ProxySPDYToHTTPLoadTest
sendSingleClientRequest(proxyAddress, client, serverIdentificationString, serverHost);
}
}
catch (InterruptedException | ExecutionException | TimeoutException | IOException e)
catch (InterruptedException | ExecutionException | TimeoutException e)
{
e.printStackTrace();
fail();

3
jetty-spdy/spdy-http-server/src/test/java/org/eclipse/jetty/spdy/server/proxy/ProxySPDYToSPDYLoadTest.java
View File

@ -19,7 +19,6 @@
package org.eclipse.jetty.spdy.server.proxy;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.net.InetSocketAddress;
import java.util.ArrayList;
import java.util.Arrays;
@ -209,7 +208,7 @@ public class ProxySPDYToSPDYLoadTest
sendSingleClientRequest(proxyAddress, client, serverIdentificationString, serverHost);
}
}
catch (InterruptedException | ExecutionException | TimeoutException | IOException e)
catch (InterruptedException | ExecutionException | TimeoutException e)
{
fail();
e.printStackTrace();