310562 SslSocketConnector fails to start if excludeCipherSuites is set

git-svn-id: svn+ssh://dev.eclipse.org/svnroot/rt/org.eclipse.jetty/jetty/trunk@1624 7e9141cc-0065-0410-87d8-b60c137991c4
This commit is contained in:
Michael Gorovoy 2010-04-29 21:05:21 +00:00
parent b6aba1ceae
commit d24e2901ad
3 changed files with 16 additions and 4 deletions

View File

@ -4,6 +4,7 @@ jetty-7.1.0.RC1-SNAPSHOT
+ 308869 Update test suite to JUnit4 - Module jetty-xml
+ 308868 Update test suite to JUnit4 - Module jetty-websocket
+ 308861 Update test suite to JUnit4 - Module jetty-security
+ 310562 SslSocketConnector fails to start if excludeCipherSuites is set
+ 310634 Get the localport when opening a server socket.
+ 310918 Synchronize content exchange

View File

@ -31,6 +31,7 @@ import org.eclipse.jetty.server.handler.RequestLogHandler;
import org.eclipse.jetty.server.handler.StatisticsHandler;
import org.eclipse.jetty.server.nio.SelectChannelConnector;
import org.eclipse.jetty.server.ssl.SslSelectChannelConnector;
import org.eclipse.jetty.server.ssl.SslSocketConnector;
import org.eclipse.jetty.util.log.Log;
import org.eclipse.jetty.util.thread.QueuedThreadPool;
@ -65,7 +66,7 @@ public class LikeJettyXml
server.setConnectors(new Connector[]
{ connector });
SslSelectChannelConnector ssl_connector = new SslSelectChannelConnector();
SslSocketConnector ssl_connector = new SslSocketConnector();
ssl_connector.setPort(8443);
ssl_connector.setKeystore(jetty_home + "/etc/keystore");
ssl_connector.setPassword("OBF:1vny1zlo1x8e1vnw1vn61x8g1zlu1vn4");
@ -73,6 +74,16 @@ public class LikeJettyXml
ssl_connector.setTruststore(jetty_home + "/etc/keystore");
ssl_connector.setTrustPassword("OBF:1vny1zlo1x8e1vnw1vn61x8g1zlu1vn4");
ssl_connector.setStatsOn(true);
ssl_connector.setExcludeCipherSuites(
new String[] {
"SSL_RSA_WITH_DES_CBC_SHA",
"SSL_DHE_RSA_WITH_DES_CBC_SHA",
"SSL_DHE_DSS_WITH_DES_CBC_SHA",
"SSL_RSA_EXPORT_WITH_RC4_40_MD5",
"SSL_RSA_EXPORT_WITH_DES40_CBC_SHA",
"SSL_DHE_RSA_EXPORT_WITH_DES40_CBC_SHA",
"SSL_DHE_DSS_EXPORT_WITH_DES40_CBC_SHA"
});
server.addConnector(ssl_connector);
HandlerCollection handlers = new HandlerCollection();

View File

@ -411,10 +411,10 @@ public class SslSocketConnector extends SocketConnector implements SslConnector
excludedCSList = new ArrayList<String>();
}
String[] enabledCipherSuites = socket.getEnabledCipherSuites();
List<String> enabledCSList=Arrays.asList(enabledCipherSuites);
List<String> enabledCSList = new ArrayList<String>(Arrays.asList(enabledCipherSuites));
String[] supportedCipherSuites = socket.getSupportedCipherSuites();
List<String> supportedCSList=Arrays.asList(supportedCipherSuites);
List<String> supportedCSList = Arrays.asList(supportedCipherSuites);
for (String cipherName : includedCSList)
{
@ -432,7 +432,7 @@ public class SslSocketConnector extends SocketConnector implements SslConnector
enabledCSList.remove(cipherName);
}
}
enabledCipherSuites=enabledCSList.toArray(new String[0]);
enabledCipherSuites = enabledCSList.toArray(new String[enabledCSList.size()]);
socket.setEnabledCipherSuites(enabledCipherSuites);
}