Issue #515 Alternate start modules

Additional usecases to test for loops in dynamic modules

jetty-start/src/main/java/org/eclipse/jetty/start/Modules.java

@@ -287,6 +287,7 @@ public class Modules implements Iterable<Module>
                 {
                     Path file = _baseHome.getPath("modules/" + dependsOn + ".mod");
                     registerModule(file).expandProperties(_args.getProperties());
+                    sort();
                     providers = _provided.get(dependsOn);
                     if (providers==null || providers.isEmpty())
                         throw new UsageException("Module %s does not provide %s",_baseHome.toShortForm(file),dependsOn);

jetty-start/src/test/resources/usecases/dynamic-loop.0.assert.txt

@@ -0,0 +1,2 @@
+EX|IllegalStateException
+EX|cyclic

jetty-start/src/test/resources/usecases/dynamic-loop.0.prepare.txt

@@ -0,0 +1 @@
+--add-to-startd=tom

jetty-start/src/test/resources/usecases/dynamic-loop.1.prepare.txt

@@ -0,0 +1 @@
+--add-to-startd=other

jetty-start/src/test/resources/usecases/dynamic-loop/modules/branch.mod

@@ -0,0 +1,3 @@
+
+[provides]
+branch

jetty-start/src/test/resources/usecases/dynamic-loop/modules/dick.mod

@@ -0,0 +1,3 @@
+
+[depends]
+dynamic/harry

jetty-start/src/test/resources/usecases/dynamic-loop/modules/dynamic/harry.mod

@@ -0,0 +1,3 @@
+
+[depends]
+tom

jetty-start/src/test/resources/usecases/dynamic-loop/modules/other.mod

@@ -0,0 +1,3 @@
+
+[provides]
+branch

jetty-start/src/test/resources/usecases/dynamic-loop/modules/root.mod

@@ -0,0 +1,3 @@
+[depends]
+branch
+

jetty-start/src/test/resources/usecases/dynamic-loop/modules/tom.mod

@@ -0,0 +1,3 @@
+
+[depends]
+dick

jetty-start/src/test/resources/usecases/dynamic-loop/start.ini

@@ -0,0 +1 @@
+-module=root

jetty-start/src/test/resources/usecases/loop.assert.txt

@@ -0,0 +1,2 @@
+EX|IllegalStateException
+EX|cyclic

jetty-start/src/test/resources/usecases/loop.prepare.txt

@@ -0,0 +1 @@
+--add-to-startd=tom

jetty-start/src/test/resources/usecases/loop/modules/branch.mod

@@ -0,0 +1,3 @@
+
+[provides]
+branch

jetty-start/src/test/resources/usecases/loop/modules/dick.mod

@@ -0,0 +1,2 @@
+[depends]
+harry

jetty-start/src/test/resources/usecases/loop/modules/harry.mod

@@ -0,0 +1,3 @@
+
+[depends]
+tom

jetty-start/src/test/resources/usecases/loop/modules/other.mod

@@ -0,0 +1,3 @@
+
+[provides]
+branch

jetty-start/src/test/resources/usecases/loop/modules/root.mod

@@ -0,0 +1,3 @@
+[depends]
+branch
+

jetty-start/src/test/resources/usecases/loop/modules/tom.mod

@@ -0,0 +1,3 @@
+
+[depends]
+dick

jetty-start/src/test/resources/usecases/loop/start.ini

@@ -0,0 +1 @@
+-module=root