Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in GzipHandler (#1429) 

Looks like this leak shows itself only with asynchronous responses.

Some relevant info: http://www.devguli.com/blog/eng/java-deflater-and-outofmemoryerror/

Signed-off-by: Denis Nedelyaev <denvned@gmail.com>
This commit is contained in:
Denis Nedelyaev 2017-03-30 04:15:32 +03:00 committed by Greg Wilkins
parent 02d4e5d1f6
commit daf61cd294
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
jetty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipHandler.java
View File

@ -542,9 +542,13 @@ public class GzipHandler extends HandlerWrapper implements GzipFactory
@Override @Override
public void recycle(Deflater deflater) public void recycle(Deflater deflater)
{ {
deflater.reset();
if (_deflater.get()==null) if (_deflater.get()==null)
{
deflater.reset();
_deflater.set(deflater); _deflater.set(deflater);
}
else
deflater.end();
} }
/* ------------------------------------------------------------ */ /* ------------------------------------------------------------ */