From 7f9312fe20e7a8db6020844afd9b9ca6efb62cfa Mon Sep 17 00:00:00 2001 From: Joakim Erdfelt Date: Fri, 10 May 2024 10:27:10 +0000 Subject: [PATCH] Issue #11766 - null out ReadListener on recycle to aid GC. --- .../src/main/java/org/eclipse/jetty/ee10/servlet/HttpInput.java | 1 + .../src/main/java/org/eclipse/jetty/ee9/nested/HttpInput.java | 1 + 2 files changed, 2 insertions(+) diff --git a/jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/HttpInput.java b/jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/HttpInput.java index 7b5d756b0d3..de0f83f8a0e 100644 --- a/jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/HttpInput.java +++ b/jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/HttpInput.java @@ -65,6 +65,7 @@ public class HttpInput extends ServletInputStream implements Runnable LOG.debug("recycle {}", this); _blockingContentProducer.recycle(); _contentProducer = _blockingContentProducer; + _readListener = null; } } diff --git a/jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/HttpInput.java b/jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/HttpInput.java index 9f729ca8809..57782e9c297 100644 --- a/jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/HttpInput.java +++ b/jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/HttpInput.java @@ -61,6 +61,7 @@ public class HttpInput extends ServletInputStream implements Runnable if (LOG.isDebugEnabled()) LOG.debug("recycle {}", this); _blockingContentProducer.recycle(); + _readListener = null; } }