414635 Modular start.d and jetty.base property

+ More *.mod definition updates
+ Some safety checks in Module edge addition to prevent duplicates
+ Minor updates to README in jetty-start

jetty-deploy/src/main/config/modules/deploy.mod

@@ -2,6 +2,8 @@
 # Deploy Feature
 #
 
+DEPEND=webapp
+
 # Deploy jars
 LIB=lib/jetty-deploy-${jetty.version}.jar
 

jetty-distribution/src/main/resources/start.d/demo.ini

@@ -11,4 +11,5 @@ jaas.login.conf=webapps.demo/test-jaas.d/login.conf
 # Activate the demo options and configurations
 MODULES=jndi.demo
 
+etc/jetty-demo.xml
 

jetty-jaas/src/main/config/modules/jaas.mod

@@ -2,6 +2,8 @@
 # JAAS Feature
 #
 
+DEPEND=server
+
 # JAAS jars
 LIB=lib/jetty-jaas-${jetty.version}.jar
 

jetty-start/src/main/java/org/eclipse/jetty/start/Module.java

@@ -87,11 +87,21 @@ public class Module extends TextFile
 
     public void addChildEdge(Module child)
     {
+        if (childEdges.contains(child))
+        {
+            // already present, skip
+            return;
+        }
         this.childEdges.add(child);
     }
 
     public void addParentEdge(Module parent)
     {
+        if (parentEdges.contains(parent))
+        {
+            // already present, skip
+            return;
+        }
         this.parentEdges.add(parent);
     }
 
@@ -149,7 +159,7 @@ public class Module extends TextFile
     {
         return optionalParentNames;
     }
-    
+
     public Set<Module> getParentEdges()
     {
         return parentEdges;

jetty-start/src/main/java/org/eclipse/jetty/start/README.txt

@@ -9,11 +9,11 @@ Jetty start.jar provides a cross platform replacement for startup scripts.
 It makes use of executable JAR that builds the classpath and then executes
 jetty.
 
-To run with all the demo options:
+To run with the demo module:
 
-  java -jar start.jar OPTIONS=All
+  java -jar start.jar MODULES=demo
 
-To run with the default options:
+To run with the default modules:
 
   java -jar start.jar
 
@@ -31,15 +31,15 @@ To see the available options
 
 To run with JSP support (if available)
 
-  java -jar start.jar OPTIONS=Server,jsp
+  java -jar start.jar MODULES=jsp
 
 To run with JMX support
 
-  java -jar start.jar OPTIONS=Server,jmx etc/jetty-jmx.xml etc/jetty.xml
+  java -jar start.jar MODULES=jmx
 
 To run with JSP & JMX support
 
-    java -jar start.jar OPTIONS=Server,jsp,jmx etc/jetty-jmx.xml etc/jetty.xml
+    java -jar start.jar MODULES=jsp,jmx
 
 Note that JSP requires the jasper jars to be within $JETTY/lib/jsp  These 
 are currently not distributed with the eclipse release and must be

jetty-websocket/javax-websocket-server-impl/src/main/config/modules/websocket.mod

@@ -7,7 +7,7 @@ DEPEND=server
 DEPEND=annotations
 
 # WebSocket needs websocket jars (as defined in start.config)
-LIB=lib/websockets/*.jar
+LIB=lib/websocket/*.jar
 
 # WebSocket needs websocket configuration
 etc/jetty-websockets.xml