445823 - RequestLogHandler at end of HandlerCollection doesn't work
+ Adding more varieties of server side collection vs wrapper with error handlers + Adding servlet version of tests to demonstrate behavior in servlet context, when also using the mapped error handler
This commit is contained in:
Joakim Erdfelt
parent
e292b572f1
commit
e7b86b99cb
|
|
@ -24,6 +24,7 @@ import static org.junit.Assert.*;
|
|||
import java.io.IOException;
|
||||
import java.io.InputStream;
|
||||
import java.io.InputStreamReader;
|
||||
import java.io.PrintWriter;
|
||||
import java.io.StringWriter;
|
||||
import java.net.HttpURLConnection;
|
||||
import java.net.URI;
|
||||
|
|
@ -33,6 +34,7 @@ import java.util.List;
|
|||
import javax.servlet.AsyncContext;
|
||||
import javax.servlet.AsyncEvent;
|
||||
import javax.servlet.AsyncListener;
|
||||
import javax.servlet.RequestDispatcher;
|
||||
import javax.servlet.ServletException;
|
||||
import javax.servlet.http.HttpServletRequest;
|
||||
import javax.servlet.http.HttpServletResponse;
|
||||
|
|
@ -55,7 +57,13 @@ import org.junit.runners.Parameterized;
|
|||
import org.junit.runners.Parameterized.Parameter;
|
||||
import org.junit.runners.Parameterized.Parameters;
|
||||
|
||||
/**
|
||||
* Tests for RequestLogHandler behavior.
|
||||
* <p>
|
||||
* Tests different request handler behavior against different server+error configurations
|
||||
*/
|
||||
@RunWith(Parameterized.class)
|
||||
@Ignore
|
||||
public class RequestLogHandlerTest
|
||||
{
|
||||
private static final Logger LOG = Log.getLogger(RequestLogHandlerTest.class);
|
||||
|
|
@ -67,10 +75,10 @@ public class RequestLogHandlerTest
|
|||
@Override
|
||||
public void log(Request request, Response response)
|
||||
{
|
||||
captured.add(String.format("%s %s %s %03d",request.getMethod(),request.getUri().toString(),request.getProtocol(),response.getStatus()));
|
||||
captured.add(String.format("%s %s %s %03d",request.getMethod(),request.getRequestURI(),request.getProtocol(),response.getStatus()));
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
private static abstract class AbstractTestHandler extends AbstractHandler
|
||||
{
|
||||
@Override
|
||||
|
|
@ -90,17 +98,17 @@ public class RequestLogHandlerTest
|
|||
baseRequest.setHandled(true);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
private static class ResponseSendErrorHandler extends AbstractTestHandler
|
||||
{
|
||||
@Override
|
||||
public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException
|
||||
{
|
||||
response.sendError(500, "Whoops");
|
||||
response.sendError(500,"Whoops");
|
||||
baseRequest.setHandled(true);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
private static class ServletExceptionHandler extends AbstractTestHandler
|
||||
{
|
||||
@Override
|
||||
|
|
@ -109,7 +117,7 @@ public class RequestLogHandlerTest
|
|||
throw new ServletException("Whoops");
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
private static class IOExceptionHandler extends AbstractTestHandler
|
||||
{
|
||||
@Override
|
||||
|
|
@ -118,7 +126,7 @@ public class RequestLogHandlerTest
|
|||
throw new IOException("Whoops");
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
private static class RuntimeExceptionHandler extends AbstractTestHandler
|
||||
{
|
||||
@Override
|
||||
|
|
@ -127,7 +135,7 @@ public class RequestLogHandlerTest
|
|||
throw new RuntimeException("Whoops");
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
private static class AsyncOnTimeoutCompleteHandler extends AbstractTestHandler implements AsyncListener
|
||||
{
|
||||
@Override
|
||||
|
|
@ -160,7 +168,7 @@ public class RequestLogHandlerTest
|
|||
{
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
private static class AsyncOnTimeoutCompleteUnhandledHandler extends AbstractTestHandler implements AsyncListener
|
||||
{
|
||||
@Override
|
||||
|
|
@ -192,13 +200,13 @@ public class RequestLogHandlerTest
|
|||
{
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
private static class AsyncOnTimeoutDispatchHandler extends AbstractTestHandler implements AsyncListener
|
||||
{
|
||||
@Override
|
||||
public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException
|
||||
{
|
||||
if(request.getAttribute("deep") == null)
|
||||
if (request.getAttribute("deep") == null)
|
||||
{
|
||||
AsyncContext ac = request.startAsync();
|
||||
ac.setTimeout(1000);
|
||||
|
|
@ -229,7 +237,7 @@ public class RequestLogHandlerTest
|
|||
{
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
private static class AsyncOnStartIOExceptionHandler extends AbstractTestHandler implements AsyncListener
|
||||
{
|
||||
@Override
|
||||
|
|
@ -264,37 +272,108 @@ public class RequestLogHandlerTest
|
|||
{
|
||||
}
|
||||
}
|
||||
|
||||
@Parameters(name="{0}")
|
||||
|
||||
public static class OKErrorHandler extends ErrorHandler
|
||||
{
|
||||
@Override
|
||||
public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) throws IOException
|
||||
{
|
||||
if (baseRequest.isHandled() || response.isCommitted())
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
// collect error details
|
||||
String reason = (response instanceof Response)?((Response)response).getReason():null;
|
||||
int status = response.getStatus();
|
||||
|
||||
// intentionally set response status to OK (this is a test to see what is actually logged)
|
||||
response.setStatus(200);
|
||||
response.setContentType("text/plain");
|
||||
PrintWriter out = response.getWriter();
|
||||
out.printf("Error %d: %s%n",status,reason);
|
||||
baseRequest.setHandled(true);
|
||||
}
|
||||
}
|
||||
|
||||
public static class DispatchErrorHandler extends ErrorHandler
|
||||
{
|
||||
@Override
|
||||
public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) throws IOException
|
||||
{
|
||||
if (baseRequest.isHandled() || response.isCommitted())
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
RequestDispatcher dispatcher = request.getRequestDispatcher("/errorok/");
|
||||
assertThat("Dispatcher", dispatcher, notNullValue());
|
||||
|
||||
try
|
||||
{
|
||||
dispatcher.forward(request,response);
|
||||
}
|
||||
catch (ServletException e)
|
||||
{
|
||||
throw new IOException("Dispatch.forward failed",e);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
public static class AltErrorHandler extends ErrorHandler
|
||||
{
|
||||
@Override
|
||||
public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) throws IOException
|
||||
{
|
||||
if (baseRequest.isHandled() || response.isCommitted())
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
// collect error details
|
||||
String reason = (response instanceof Response)?((Response)response).getReason():null;
|
||||
int status = response.getStatus();
|
||||
|
||||
// intentionally set response status to OK (this is a test to see what is actually logged)
|
||||
response.setContentType("text/plain");
|
||||
PrintWriter out = response.getWriter();
|
||||
out.printf("Error %d: %s%n",status,reason);
|
||||
baseRequest.setHandled(true);
|
||||
}
|
||||
}
|
||||
|
||||
@Parameters(name = "{0}")
|
||||
public static List<Object[]> data()
|
||||
{
|
||||
List<Object[]> data = new ArrayList<>();
|
||||
|
||||
data.add(new Object[] { new HelloHandler(), "/test", "GET /test HTTP/1.1 200" });
|
||||
data.add(new Object[] { new AsyncOnTimeoutCompleteHandler(), "/test", "GET /test HTTP/1.1 200" });
|
||||
data.add(new Object[] { new AsyncOnTimeoutCompleteUnhandledHandler(), "/test", "GET /test HTTP/1.1 200" });
|
||||
data.add(new Object[] { new AsyncOnTimeoutDispatchHandler(), "/test", "GET /test HTTP/1.1 200" });
|
||||
|
||||
data.add(new Object[] { new AsyncOnStartIOExceptionHandler(), "/test", "GET /test HTTP/1.1 500" });
|
||||
data.add(new Object[] { new ResponseSendErrorHandler(), "/test", "GET /test HTTP/1.1 500" });
|
||||
data.add(new Object[] { new ServletExceptionHandler(), "/test", "GET /test HTTP/1.1 500" });
|
||||
data.add(new Object[] { new IOExceptionHandler(), "/test", "GET /test HTTP/1.1 500" });
|
||||
data.add(new Object[] { new RuntimeExceptionHandler(), "/test", "GET /test HTTP/1.1 500" });
|
||||
data.add(new Object[] { new HelloHandler(), "/test/", "GET /test/ HTTP/1.1 200" });
|
||||
data.add(new Object[] { new AsyncOnTimeoutCompleteHandler(), "/test/", "GET /test/ HTTP/1.1 200" });
|
||||
data.add(new Object[] { new AsyncOnTimeoutCompleteUnhandledHandler(), "/test/", "GET /test/ HTTP/1.1 200" });
|
||||
data.add(new Object[] { new AsyncOnTimeoutDispatchHandler(), "/test/", "GET /test/ HTTP/1.1 200" });
|
||||
|
||||
data.add(new Object[] { new AsyncOnStartIOExceptionHandler(), "/test/", "GET /test/ HTTP/1.1 500" });
|
||||
data.add(new Object[] { new ResponseSendErrorHandler(), "/test/", "GET /test/ HTTP/1.1 500" });
|
||||
data.add(new Object[] { new ServletExceptionHandler(), "/test/", "GET /test/ HTTP/1.1 500" });
|
||||
data.add(new Object[] { new IOExceptionHandler(), "/test/", "GET /test/ HTTP/1.1 500" });
|
||||
data.add(new Object[] { new RuntimeExceptionHandler(), "/test/", "GET /test/ HTTP/1.1 500" });
|
||||
|
||||
return data;
|
||||
}
|
||||
|
||||
@Parameter(0)
|
||||
public Handler testHandler;
|
||||
|
||||
|
||||
@Parameter(1)
|
||||
public String requestPath;
|
||||
|
||||
@Parameter(2)
|
||||
public String expectedLogEntry;
|
||||
|
||||
@Test(timeout=4000)
|
||||
@Ignore
|
||||
/**
|
||||
* Test a RequestLogHandler at the end of a HandlerCollection. all other configuration on server at defaults.
|
||||
*/
|
||||
@Test(timeout = 4000)
|
||||
public void testLogHandlerCollection() throws Exception
|
||||
{
|
||||
Server server = new Server();
|
||||
|
|
@ -353,8 +432,293 @@ public class RequestLogHandlerTest
|
|||
server.stop();
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* Test a RequestLogHandler at the end of a HandlerCollection and also with the default ErrorHandler as server bean in place.
|
||||
*/
|
||||
@Test(timeout = 4000)
|
||||
public void testLogHandlerCollection_ErrorHandler_ServerBean() throws Exception
|
||||
{
|
||||
Server server = new Server();
|
||||
ServerConnector connector = new ServerConnector(server);
|
||||
connector.setPort(0);
|
||||
server.setConnectors(new Connector[] { connector });
|
||||
|
||||
ErrorHandler errorHandler = new ErrorHandler();
|
||||
server.addBean(errorHandler);
|
||||
|
||||
CaptureLog captureLog = new CaptureLog();
|
||||
|
||||
RequestLogHandler requestLog = new RequestLogHandler();
|
||||
requestLog.setRequestLog(captureLog);
|
||||
|
||||
HandlerCollection handlers = new HandlerCollection();
|
||||
handlers.setHandlers(new Handler[] { testHandler, requestLog });
|
||||
server.setHandler(handlers);
|
||||
|
||||
try
|
||||
{
|
||||
server.start();
|
||||
|
||||
String host = connector.getHost();
|
||||
if (host == null)
|
||||
{
|
||||
host = "localhost";
|
||||
}
|
||||
int port = connector.getLocalPort();
|
||||
|
||||
URI serverUri = new URI("http",null,host,port,requestPath,null,null);
|
||||
|
||||
// Make call to test handler
|
||||
HttpURLConnection connection = (HttpURLConnection)serverUri.toURL().openConnection();
|
||||
try
|
||||
{
|
||||
connection.setAllowUserInteraction(false);
|
||||
|
||||
// log response status code
|
||||
int statusCode = connection.getResponseCode();
|
||||
LOG.debug("Response Status Code: {}",statusCode);
|
||||
|
||||
if (statusCode == 200)
|
||||
{
|
||||
// collect response message and log it
|
||||
String content = getResponseContent(connection);
|
||||
LOG.debug("Response Content: {}",content);
|
||||
}
|
||||
}
|
||||
finally
|
||||
{
|
||||
connection.disconnect();
|
||||
}
|
||||
|
||||
assertRequestLog(captureLog);
|
||||
}
|
||||
finally
|
||||
{
|
||||
server.stop();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Test a RequestLogHandler at the end of a HandlerCollection and also with the ErrorHandler in place.
|
||||
*/
|
||||
@Test(timeout=4000)
|
||||
public void testLogHandlerCollection_AltErrorHandler() throws Exception
|
||||
{
|
||||
Server server = new Server();
|
||||
ServerConnector connector = new ServerConnector(server);
|
||||
connector.setPort(0);
|
||||
server.setConnectors(new Connector[] { connector });
|
||||
|
||||
AltErrorHandler errorDispatcher = new AltErrorHandler();
|
||||
server.addBean(errorDispatcher);
|
||||
|
||||
ContextHandlerCollection contexts = new ContextHandlerCollection();
|
||||
ContextHandler errorContext = new ContextHandler("/errorpage");
|
||||
errorContext.setHandler(new AltErrorHandler());
|
||||
ContextHandler testContext = new ContextHandler("/test");
|
||||
testContext.setHandler(testHandler);
|
||||
contexts.addHandler(errorContext);
|
||||
contexts.addHandler(testContext);
|
||||
|
||||
RequestLogHandler requestLog = new RequestLogHandler();
|
||||
CaptureLog captureLog = new CaptureLog();
|
||||
requestLog.setRequestLog(captureLog);
|
||||
|
||||
HandlerCollection handlers = new HandlerCollection();
|
||||
handlers.setHandlers(new Handler[] { contexts, requestLog });
|
||||
server.setHandler(handlers);
|
||||
|
||||
try
|
||||
{
|
||||
server.start();
|
||||
|
||||
String host = connector.getHost();
|
||||
if (host == null)
|
||||
{
|
||||
host = "localhost";
|
||||
}
|
||||
int port = connector.getLocalPort();
|
||||
|
||||
URI serverUri = new URI("http",null,host,port,requestPath,null,null);
|
||||
|
||||
// Make call to test handler
|
||||
HttpURLConnection connection = (HttpURLConnection)serverUri.toURL().openConnection();
|
||||
try
|
||||
{
|
||||
connection.setAllowUserInteraction(false);
|
||||
|
||||
// log response status code
|
||||
int statusCode = connection.getResponseCode();
|
||||
LOG.debug("Response Status Code: {}",statusCode);
|
||||
|
||||
if (statusCode == 200)
|
||||
{
|
||||
// collect response message and log it
|
||||
String content = getResponseContent(connection);
|
||||
LOG.debug("Response Content: {}",content);
|
||||
}
|
||||
}
|
||||
finally
|
||||
{
|
||||
connection.disconnect();
|
||||
}
|
||||
|
||||
assertRequestLog(captureLog);
|
||||
}
|
||||
finally
|
||||
{
|
||||
server.stop();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Test a RequestLogHandler at the end of a HandlerCollection and also with the ErrorHandler in place.
|
||||
*/
|
||||
@Test(timeout=4000)
|
||||
public void testLogHandlerCollection_OKErrorHandler() throws Exception
|
||||
{
|
||||
Server server = new Server();
|
||||
ServerConnector connector = new ServerConnector(server);
|
||||
connector.setPort(0);
|
||||
server.setConnectors(new Connector[] { connector });
|
||||
|
||||
OKErrorHandler errorDispatcher = new OKErrorHandler();
|
||||
server.addBean(errorDispatcher);
|
||||
|
||||
ContextHandlerCollection contexts = new ContextHandlerCollection();
|
||||
ContextHandler errorContext = new ContextHandler("/errorpage");
|
||||
errorContext.setHandler(new AltErrorHandler());
|
||||
ContextHandler testContext = new ContextHandler("/test");
|
||||
testContext.setHandler(testHandler);
|
||||
contexts.addHandler(errorContext);
|
||||
contexts.addHandler(testContext);
|
||||
|
||||
RequestLogHandler requestLog = new RequestLogHandler();
|
||||
CaptureLog captureLog = new CaptureLog();
|
||||
requestLog.setRequestLog(captureLog);
|
||||
|
||||
HandlerCollection handlers = new HandlerCollection();
|
||||
handlers.setHandlers(new Handler[] { contexts, requestLog });
|
||||
server.setHandler(handlers);
|
||||
|
||||
try
|
||||
{
|
||||
server.start();
|
||||
|
||||
String host = connector.getHost();
|
||||
if (host == null)
|
||||
{
|
||||
host = "localhost";
|
||||
}
|
||||
int port = connector.getLocalPort();
|
||||
|
||||
URI serverUri = new URI("http",null,host,port,requestPath,null,null);
|
||||
|
||||
// Make call to test handler
|
||||
HttpURLConnection connection = (HttpURLConnection)serverUri.toURL().openConnection();
|
||||
try
|
||||
{
|
||||
connection.setAllowUserInteraction(false);
|
||||
|
||||
// log response status code
|
||||
int statusCode = connection.getResponseCode();
|
||||
LOG.debug("Response Status Code: {}",statusCode);
|
||||
|
||||
if (statusCode == 200)
|
||||
{
|
||||
// collect response message and log it
|
||||
String content = getResponseContent(connection);
|
||||
LOG.debug("Response Content: {}",content);
|
||||
}
|
||||
}
|
||||
finally
|
||||
{
|
||||
connection.disconnect();
|
||||
}
|
||||
|
||||
assertRequestLog(captureLog);
|
||||
}
|
||||
finally
|
||||
{
|
||||
server.stop();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Test a RequestLogHandler at the end of a HandlerCollection and also with the ErrorHandler in place.
|
||||
*/
|
||||
@Test(timeout=4000)
|
||||
public void testLogHandlerCollection_DispatchErrorHandler() throws Exception
|
||||
{
|
||||
Server server = new Server();
|
||||
ServerConnector connector = new ServerConnector(server);
|
||||
connector.setPort(0);
|
||||
server.setConnectors(new Connector[] { connector });
|
||||
|
||||
DispatchErrorHandler errorDispatcher = new DispatchErrorHandler();
|
||||
server.addBean(errorDispatcher);
|
||||
|
||||
ContextHandlerCollection contexts = new ContextHandlerCollection();
|
||||
ContextHandler errorContext = new ContextHandler("errorok");
|
||||
errorContext.setHandler(new OKErrorHandler());
|
||||
ContextHandler testContext = new ContextHandler("test");
|
||||
testContext.setHandler(testHandler);
|
||||
contexts.addHandler(errorContext);
|
||||
contexts.addHandler(testContext);
|
||||
|
||||
RequestLogHandler requestLog = new RequestLogHandler();
|
||||
CaptureLog captureLog = new CaptureLog();
|
||||
requestLog.setRequestLog(captureLog);
|
||||
|
||||
HandlerCollection handlers = new HandlerCollection();
|
||||
handlers.setHandlers(new Handler[] { contexts, requestLog });
|
||||
server.setHandler(handlers);
|
||||
|
||||
try
|
||||
{
|
||||
server.start();
|
||||
|
||||
String host = connector.getHost();
|
||||
if (host == null)
|
||||
{
|
||||
host = "localhost";
|
||||
}
|
||||
int port = connector.getLocalPort();
|
||||
|
||||
URI serverUri = new URI("http",null,host,port,requestPath,null,null);
|
||||
|
||||
// Make call to test handler
|
||||
HttpURLConnection connection = (HttpURLConnection)serverUri.toURL().openConnection();
|
||||
try
|
||||
{
|
||||
connection.setAllowUserInteraction(false);
|
||||
|
||||
// log response status code
|
||||
int statusCode = connection.getResponseCode();
|
||||
LOG.debug("Response Status Code: {}",statusCode);
|
||||
|
||||
if (statusCode == 200)
|
||||
{
|
||||
// collect response message and log it
|
||||
String content = getResponseContent(connection);
|
||||
LOG.debug("Response Content: {}",content);
|
||||
}
|
||||
}
|
||||
finally
|
||||
{
|
||||
connection.disconnect();
|
||||
}
|
||||
|
||||
assertRequestLog(captureLog);
|
||||
}
|
||||
finally
|
||||
{
|
||||
server.stop();
|
||||
}
|
||||
}
|
||||
|
||||
@Test(timeout = 4000)
|
||||
public void testLogHandlerWrapped() throws Exception
|
||||
{
|
||||
Server server = new Server();
|
||||
|
|
@ -366,7 +730,7 @@ public class RequestLogHandlerTest
|
|||
|
||||
RequestLogHandler requestLog = new RequestLogHandler();
|
||||
requestLog.setRequestLog(captureLog);
|
||||
|
||||
|
||||
requestLog.setHandler(testHandler);
|
||||
|
||||
server.setHandler(requestLog);
|
||||
|
|
@ -382,7 +746,7 @@ public class RequestLogHandlerTest
|
|||
}
|
||||
int port = connector.getLocalPort();
|
||||
|
||||
URI serverUri = new URI("http",null,host,port,"/test",null,null);
|
||||
URI serverUri = new URI("http",null,host,port,requestPath,null,null);
|
||||
|
||||
// Make call to test handler
|
||||
HttpURLConnection connection = (HttpURLConnection)serverUri.toURL().openConnection();
|
||||
|
|
|
|||
|
|
@ -0,0 +1,681 @@
|
|||
//
|
||||
// ========================================================================
|
||||
// Copyright (c) 1995-2014 Mort Bay Consulting Pty. Ltd.
|
||||
// ------------------------------------------------------------------------
|
||||
// All rights reserved. This program and the accompanying materials
|
||||
// are made available under the terms of the Eclipse Public License v1.0
|
||||
// and Apache License v2.0 which accompanies this distribution.
|
||||
//
|
||||
// The Eclipse Public License is available at
|
||||
// http://www.eclipse.org/legal/epl-v10.html
|
||||
//
|
||||
// The Apache License v2.0 is available at
|
||||
// http://www.opensource.org/licenses/apache2.0.php
|
||||
//
|
||||
// You may elect to redistribute this code under either of these licenses.
|
||||
// ========================================================================
|
||||
//
|
||||
|
||||
package org.eclipse.jetty.servlet;
|
||||
|
||||
import static org.hamcrest.Matchers.*;
|
||||
import static org.junit.Assert.*;
|
||||
|
||||
import java.io.IOException;
|
||||
import java.io.InputStream;
|
||||
import java.io.InputStreamReader;
|
||||
import java.io.PrintWriter;
|
||||
import java.io.StringWriter;
|
||||
import java.net.HttpURLConnection;
|
||||
import java.net.URI;
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
|
||||
import javax.servlet.AsyncContext;
|
||||
import javax.servlet.AsyncEvent;
|
||||
import javax.servlet.AsyncListener;
|
||||
import javax.servlet.Servlet;
|
||||
import javax.servlet.ServletException;
|
||||
import javax.servlet.http.HttpServlet;
|
||||
import javax.servlet.http.HttpServletRequest;
|
||||
import javax.servlet.http.HttpServletResponse;
|
||||
|
||||
import org.eclipse.jetty.server.Connector;
|
||||
import org.eclipse.jetty.server.Handler;
|
||||
import org.eclipse.jetty.server.Request;
|
||||
import org.eclipse.jetty.server.RequestLog;
|
||||
import org.eclipse.jetty.server.Response;
|
||||
import org.eclipse.jetty.server.Server;
|
||||
import org.eclipse.jetty.server.ServerConnector;
|
||||
import org.eclipse.jetty.server.handler.ContextHandlerCollection;
|
||||
import org.eclipse.jetty.server.handler.DefaultHandler;
|
||||
import org.eclipse.jetty.server.handler.ErrorHandler;
|
||||
import org.eclipse.jetty.server.handler.HandlerCollection;
|
||||
import org.eclipse.jetty.server.handler.RequestLogHandler;
|
||||
import org.eclipse.jetty.toolchain.test.IO;
|
||||
import org.eclipse.jetty.util.component.AbstractLifeCycle;
|
||||
import org.eclipse.jetty.util.log.Log;
|
||||
import org.eclipse.jetty.util.log.Logger;
|
||||
import org.junit.Ignore;
|
||||
import org.junit.Test;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.junit.runners.Parameterized;
|
||||
import org.junit.runners.Parameterized.Parameter;
|
||||
import org.junit.runners.Parameterized.Parameters;
|
||||
|
||||
/**
|
||||
* Servlet equivalent of the jetty-server's RequestLogHandlerTest, but with more ErrorHandler twists.
|
||||
*/
|
||||
@RunWith(Parameterized.class)
|
||||
@Ignore
|
||||
public class ServletRequestLogTest
|
||||
{
|
||||
private static final Logger LOG = Log.getLogger(ServletRequestLogTest.class);
|
||||
|
||||
public static class CaptureLog extends AbstractLifeCycle implements RequestLog
|
||||
{
|
||||
public List<String> captured = new ArrayList<>();
|
||||
|
||||
@Override
|
||||
public void log(Request request, Response response)
|
||||
{
|
||||
captured.add(String.format("%s %s %s %03d",request.getMethod(),request.getUri().toString(),request.getProtocol(),response.getStatus()));
|
||||
}
|
||||
}
|
||||
|
||||
@SuppressWarnings("serial")
|
||||
private static abstract class AbstractTestServlet extends HttpServlet
|
||||
{
|
||||
@Override
|
||||
public String toString()
|
||||
{
|
||||
return this.getClass().getSimpleName();
|
||||
}
|
||||
}
|
||||
|
||||
@SuppressWarnings("serial")
|
||||
private static class HelloServlet extends AbstractTestServlet
|
||||
{
|
||||
@Override
|
||||
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException
|
||||
{
|
||||
response.setContentType("text/plain");
|
||||
response.getWriter().print("Hello World");
|
||||
}
|
||||
}
|
||||
|
||||
@SuppressWarnings("serial")
|
||||
private static class ResponseSendErrorServlet extends AbstractTestServlet
|
||||
{
|
||||
@Override
|
||||
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException
|
||||
{
|
||||
response.sendError(500, "Whoops");
|
||||
}
|
||||
}
|
||||
|
||||
@SuppressWarnings("serial")
|
||||
private static class ServletExceptionServlet extends AbstractTestServlet
|
||||
{
|
||||
@Override
|
||||
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException
|
||||
{
|
||||
throw new ServletException("Whoops");
|
||||
}
|
||||
}
|
||||
|
||||
@SuppressWarnings("serial")
|
||||
private static class IOExceptionServlet extends AbstractTestServlet
|
||||
{
|
||||
@Override
|
||||
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException
|
||||
{
|
||||
throw new IOException("Whoops");
|
||||
}
|
||||
}
|
||||
|
||||
@SuppressWarnings("serial")
|
||||
private static class RuntimeExceptionServlet extends AbstractTestServlet
|
||||
{
|
||||
@Override
|
||||
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException
|
||||
{
|
||||
throw new RuntimeException("Whoops");
|
||||
}
|
||||
}
|
||||
|
||||
@SuppressWarnings("serial")
|
||||
private static class AsyncOnTimeoutCompleteServlet extends AbstractTestServlet implements AsyncListener
|
||||
{
|
||||
@Override
|
||||
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException
|
||||
{
|
||||
AsyncContext ac = request.startAsync();
|
||||
ac.setTimeout(1000);
|
||||
ac.addListener(this);
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onTimeout(AsyncEvent event) throws IOException
|
||||
{
|
||||
event.getAsyncContext().complete();
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onStartAsync(AsyncEvent event) throws IOException
|
||||
{
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onError(AsyncEvent event) throws IOException
|
||||
{
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onComplete(AsyncEvent event) throws IOException
|
||||
{
|
||||
}
|
||||
}
|
||||
|
||||
@SuppressWarnings("serial")
|
||||
private static class AsyncOnTimeoutDispatchServlet extends AbstractTestServlet implements AsyncListener
|
||||
{
|
||||
@Override
|
||||
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException
|
||||
{
|
||||
if(request.getAttribute("deep") == null)
|
||||
{
|
||||
AsyncContext ac = request.startAsync();
|
||||
ac.setTimeout(1000);
|
||||
ac.addListener(this);
|
||||
request.setAttribute("deep",true);
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onTimeout(AsyncEvent event) throws IOException
|
||||
{
|
||||
event.getAsyncContext().dispatch();
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onStartAsync(AsyncEvent event) throws IOException
|
||||
{
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onError(AsyncEvent event) throws IOException
|
||||
{
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onComplete(AsyncEvent event) throws IOException
|
||||
{
|
||||
}
|
||||
}
|
||||
|
||||
@SuppressWarnings("serial")
|
||||
private static class AsyncOnStartIOExceptionServlet extends AbstractTestServlet implements AsyncListener
|
||||
{
|
||||
@Override
|
||||
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException
|
||||
{
|
||||
AsyncContext ac = request.startAsync();
|
||||
ac.setTimeout(1000);
|
||||
ac.addListener(this);
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onTimeout(AsyncEvent event) throws IOException
|
||||
{
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onStartAsync(AsyncEvent event) throws IOException
|
||||
{
|
||||
event.getAsyncContext().complete();
|
||||
throw new IOException("Whoops");
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onError(AsyncEvent event) throws IOException
|
||||
{
|
||||
LOG.warn("onError() -> {}",event);
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onComplete(AsyncEvent event) throws IOException
|
||||
{
|
||||
}
|
||||
}
|
||||
|
||||
@SuppressWarnings("serial")
|
||||
public static class CustomErrorServlet extends HttpServlet
|
||||
{
|
||||
@Override
|
||||
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException
|
||||
{
|
||||
// collect error details
|
||||
String reason = (response instanceof Response)?((Response)response).getReason():null;
|
||||
int status = response.getStatus();
|
||||
|
||||
// intentionally set response status to OK (this is a test to see what is actually logged)
|
||||
response.setStatus(200);
|
||||
response.setContentType("text/plain");
|
||||
PrintWriter out = response.getWriter();
|
||||
out.printf("Error %d: %s%n",status,reason);
|
||||
}
|
||||
}
|
||||
|
||||
@Parameters(name="{0}")
|
||||
public static List<Object[]> data()
|
||||
{
|
||||
List<Object[]> data = new ArrayList<>();
|
||||
|
||||
data.add(new Object[] { new HelloServlet(), "/test/", "GET /test/ HTTP/1.1 200" });
|
||||
data.add(new Object[] { new AsyncOnTimeoutCompleteServlet(), "/test/", "GET /test/ HTTP/1.1 200" });
|
||||
data.add(new Object[] { new AsyncOnTimeoutDispatchServlet(), "/test/", "GET /test/ HTTP/1.1 200" });
|
||||
|
||||
data.add(new Object[] { new AsyncOnStartIOExceptionServlet(), "/test/", "GET /test/ HTTP/1.1 500" });
|
||||
data.add(new Object[] { new ResponseSendErrorServlet(), "/test/", "GET /test/ HTTP/1.1 500" });
|
||||
data.add(new Object[] { new ServletExceptionServlet(), "/test/", "GET /test/ HTTP/1.1 500" });
|
||||
data.add(new Object[] { new IOExceptionServlet(), "/test/", "GET /test/ HTTP/1.1 500" });
|
||||
data.add(new Object[] { new RuntimeExceptionServlet(), "/test/", "GET /test/ HTTP/1.1 500" });
|
||||
|
||||
return data;
|
||||
}
|
||||
|
||||
@Parameter(0)
|
||||
public Servlet testServlet;
|
||||
|
||||
@Parameter(1)
|
||||
public String requestPath;
|
||||
|
||||
@Parameter(2)
|
||||
public String expectedLogEntry;
|
||||
|
||||
/**
|
||||
* Test a RequestLogHandler at the end of a HandlerCollection.
|
||||
* This handler chain is setup to look like Jetty versions up to 9.2.
|
||||
* Default configuration.
|
||||
*/
|
||||
@Test(timeout=4000)
|
||||
public void testLogHandlerCollection() throws Exception
|
||||
{
|
||||
Server server = new Server();
|
||||
ServerConnector connector = new ServerConnector(server);
|
||||
connector.setPort(0);
|
||||
server.setConnectors(new Connector[] { connector });
|
||||
|
||||
// First the behavior as defined in etc/jetty.xml
|
||||
// id="Handlers"
|
||||
HandlerCollection handlers = new HandlerCollection();
|
||||
// id="Contexts"
|
||||
ContextHandlerCollection contexts = new ContextHandlerCollection();
|
||||
// id="DefaultHandler"
|
||||
DefaultHandler defaultHandler = new DefaultHandler();
|
||||
|
||||
handlers.setHandlers(new Handler[] { contexts, defaultHandler });
|
||||
server.setHandler(handlers);
|
||||
|
||||
// Next the behavior as defined by etc/jetty-requestlog.xml
|
||||
// the id="RequestLog"
|
||||
RequestLogHandler requestLog = new RequestLogHandler();
|
||||
CaptureLog captureLog = new CaptureLog();
|
||||
requestLog.setRequestLog(captureLog);
|
||||
|
||||
handlers.addHandler(requestLog);
|
||||
|
||||
// Lastly, the behavior as defined by deployment of a webapp
|
||||
// Add the Servlet Context
|
||||
ServletContextHandler app = new ServletContextHandler(ServletContextHandler.SESSIONS);
|
||||
app.setContextPath("/");
|
||||
contexts.addHandler(app);
|
||||
|
||||
// Add the test servlet
|
||||
ServletHolder testHolder = new ServletHolder(testServlet);
|
||||
app.addServlet(testHolder,"/test");
|
||||
|
||||
try
|
||||
{
|
||||
server.start();
|
||||
|
||||
String host = connector.getHost();
|
||||
if (host == null)
|
||||
{
|
||||
host = "localhost";
|
||||
}
|
||||
int port = connector.getLocalPort();
|
||||
|
||||
URI serverUri = new URI("http",null,host,port,requestPath,null,null);
|
||||
|
||||
// Make call to test handler
|
||||
HttpURLConnection connection = (HttpURLConnection)serverUri.toURL().openConnection();
|
||||
try
|
||||
{
|
||||
connection.setAllowUserInteraction(false);
|
||||
|
||||
// log response status code
|
||||
int statusCode = connection.getResponseCode();
|
||||
LOG.debug("Response Status Code: {}",statusCode);
|
||||
|
||||
if (statusCode == 200)
|
||||
{
|
||||
// collect response message and log it
|
||||
String content = getResponseContent(connection);
|
||||
LOG.debug("Response Content: {}",content);
|
||||
}
|
||||
}
|
||||
finally
|
||||
{
|
||||
connection.disconnect();
|
||||
}
|
||||
|
||||
assertRequestLog(captureLog);
|
||||
}
|
||||
finally
|
||||
{
|
||||
server.stop();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Test a RequestLogHandler at the end of a HandlerCollection.
|
||||
* and also with the default ErrorHandler as server bean in place.
|
||||
*/
|
||||
@Test(timeout=4000)
|
||||
public void testLogHandlerCollection_ErrorHandler_ServerBean() throws Exception
|
||||
{
|
||||
Server server = new Server();
|
||||
ServerConnector connector = new ServerConnector(server);
|
||||
connector.setPort(0);
|
||||
server.setConnectors(new Connector[] { connector });
|
||||
|
||||
ErrorHandler errorHandler = new ErrorHandler();
|
||||
server.addBean(errorHandler);
|
||||
|
||||
// First the behavior as defined in etc/jetty.xml
|
||||
// id="Handlers"
|
||||
HandlerCollection handlers = new HandlerCollection();
|
||||
// id="Contexts"
|
||||
ContextHandlerCollection contexts = new ContextHandlerCollection();
|
||||
// id="DefaultHandler"
|
||||
DefaultHandler defaultHandler = new DefaultHandler();
|
||||
|
||||
handlers.setHandlers(new Handler[] { contexts, defaultHandler });
|
||||
server.setHandler(handlers);
|
||||
|
||||
// Next the behavior as defined by etc/jetty-requestlog.xml
|
||||
// the id="RequestLog"
|
||||
RequestLogHandler requestLog = new RequestLogHandler();
|
||||
CaptureLog captureLog = new CaptureLog();
|
||||
requestLog.setRequestLog(captureLog);
|
||||
|
||||
handlers.addHandler(requestLog);
|
||||
|
||||
// Lastly, the behavior as defined by deployment of a webapp
|
||||
// Add the Servlet Context
|
||||
ServletContextHandler app = new ServletContextHandler(ServletContextHandler.SESSIONS);
|
||||
app.setContextPath("/");
|
||||
contexts.addHandler(app);
|
||||
|
||||
// Add the test servlet
|
||||
ServletHolder testHolder = new ServletHolder(testServlet);
|
||||
app.addServlet(testHolder,"/test");
|
||||
|
||||
try
|
||||
{
|
||||
server.start();
|
||||
|
||||
String host = connector.getHost();
|
||||
if (host == null)
|
||||
{
|
||||
host = "localhost";
|
||||
}
|
||||
int port = connector.getLocalPort();
|
||||
|
||||
URI serverUri = new URI("http",null,host,port,requestPath,null,null);
|
||||
|
||||
// Make call to test handler
|
||||
HttpURLConnection connection = (HttpURLConnection)serverUri.toURL().openConnection();
|
||||
try
|
||||
{
|
||||
connection.setAllowUserInteraction(false);
|
||||
|
||||
// log response status code
|
||||
int statusCode = connection.getResponseCode();
|
||||
LOG.debug("Response Status Code: {}",statusCode);
|
||||
|
||||
if (statusCode == 200)
|
||||
{
|
||||
// collect response message and log it
|
||||
String content = getResponseContent(connection);
|
||||
LOG.debug("Response Content: {}",content);
|
||||
}
|
||||
}
|
||||
finally
|
||||
{
|
||||
connection.disconnect();
|
||||
}
|
||||
|
||||
assertRequestLog(captureLog);
|
||||
}
|
||||
finally
|
||||
{
|
||||
server.stop();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Test a RequestLogHandler at the end of a HandlerCollection
|
||||
* using servlet specific error page mapping.
|
||||
*/
|
||||
@Test(timeout=4000)
|
||||
public void testLogHandlerCollection_SimpleErrorPageMapping() throws Exception
|
||||
{
|
||||
Server server = new Server();
|
||||
ServerConnector connector = new ServerConnector(server);
|
||||
connector.setPort(0);
|
||||
server.setConnectors(new Connector[] { connector });
|
||||
|
||||
// First the behavior as defined in etc/jetty.xml
|
||||
// id="Handlers"
|
||||
HandlerCollection handlers = new HandlerCollection();
|
||||
// id="Contexts"
|
||||
ContextHandlerCollection contexts = new ContextHandlerCollection();
|
||||
// id="DefaultHandler"
|
||||
DefaultHandler defaultHandler = new DefaultHandler();
|
||||
|
||||
handlers.setHandlers(new Handler[] { contexts, defaultHandler });
|
||||
server.setHandler(handlers);
|
||||
|
||||
// Next the behavior as defined by etc/jetty-requestlog.xml
|
||||
// the id="RequestLog"
|
||||
RequestLogHandler requestLog = new RequestLogHandler();
|
||||
CaptureLog captureLog = new CaptureLog();
|
||||
requestLog.setRequestLog(captureLog);
|
||||
|
||||
handlers.addHandler(requestLog);
|
||||
|
||||
// Lastly, the behavior as defined by deployment of a webapp
|
||||
// Add the Servlet Context
|
||||
ServletContextHandler app = new ServletContextHandler(ServletContextHandler.SESSIONS);
|
||||
app.setContextPath("/");
|
||||
contexts.addHandler(app);
|
||||
|
||||
// Add the test servlet
|
||||
ServletHolder testHolder = new ServletHolder(testServlet);
|
||||
app.addServlet(testHolder,"/test");
|
||||
app.addServlet(CustomErrorServlet.class,"/errorpage");
|
||||
|
||||
// Add error page mapping
|
||||
ErrorPageErrorHandler errorMapper = new ErrorPageErrorHandler();
|
||||
errorMapper.addErrorPage(500,"/errorpage");
|
||||
app.setErrorHandler(errorMapper);
|
||||
|
||||
try
|
||||
{
|
||||
server.start();
|
||||
|
||||
String host = connector.getHost();
|
||||
if (host == null)
|
||||
{
|
||||
host = "localhost";
|
||||
}
|
||||
int port = connector.getLocalPort();
|
||||
|
||||
URI serverUri = new URI("http",null,host,port,requestPath,null,null);
|
||||
|
||||
// Make call to test handler
|
||||
HttpURLConnection connection = (HttpURLConnection)serverUri.toURL().openConnection();
|
||||
try
|
||||
{
|
||||
connection.setAllowUserInteraction(false);
|
||||
|
||||
// log response status code
|
||||
int statusCode = connection.getResponseCode();
|
||||
LOG.debug("Response Status Code: {}",statusCode);
|
||||
|
||||
if (statusCode == 200)
|
||||
{
|
||||
// collect response message and log it
|
||||
String content = getResponseContent(connection);
|
||||
LOG.debug("Response Content: {}",content);
|
||||
}
|
||||
}
|
||||
finally
|
||||
{
|
||||
connection.disconnect();
|
||||
}
|
||||
|
||||
assertRequestLog(captureLog);
|
||||
}
|
||||
finally
|
||||
{
|
||||
server.stop();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Test an alternate (proposed) setup for using RequestLogHandler in a wrapped style
|
||||
*/
|
||||
@Test(timeout=4000)
|
||||
public void testLogHandlerWrapped() throws Exception
|
||||
{
|
||||
Server server = new Server();
|
||||
ServerConnector connector = new ServerConnector(server);
|
||||
connector.setPort(0);
|
||||
server.setConnectors(new Connector[] { connector });
|
||||
|
||||
// First the behavior as defined in etc/jetty.xml (as is)
|
||||
// id="Handlers"
|
||||
HandlerCollection handlers = new HandlerCollection();
|
||||
// id="Contexts"
|
||||
ContextHandlerCollection contexts = new ContextHandlerCollection();
|
||||
// id="DefaultHandler"
|
||||
DefaultHandler defaultHandler = new DefaultHandler();
|
||||
|
||||
handlers.setHandlers(new Handler[] { contexts, defaultHandler });
|
||||
server.setHandler(handlers);
|
||||
|
||||
// Next the proposed behavioral change to etc/jetty-requestlog.xml
|
||||
// the id="RequestLog"
|
||||
RequestLogHandler requestLog = new RequestLogHandler();
|
||||
CaptureLog captureLog = new CaptureLog();
|
||||
requestLog.setRequestLog(captureLog);
|
||||
|
||||
Handler origServerHandler = server.getHandler();
|
||||
requestLog.setHandler(origServerHandler);
|
||||
server.setHandler(requestLog);
|
||||
|
||||
// Lastly, the behavior as defined by deployment of a webapp
|
||||
// Add the Servlet Context
|
||||
ServletContextHandler app = new ServletContextHandler(ServletContextHandler.SESSIONS);
|
||||
app.setContextPath("/");
|
||||
contexts.addHandler(app);
|
||||
|
||||
// Add the test servlet
|
||||
ServletHolder testHolder = new ServletHolder(testServlet);
|
||||
app.addServlet(testHolder,"/test");
|
||||
app.addServlet(CustomErrorServlet.class,"/errorpage");
|
||||
|
||||
// Add error page mapping
|
||||
ErrorPageErrorHandler errorMapper = new ErrorPageErrorHandler();
|
||||
errorMapper.addErrorPage(500,"/errorpage");
|
||||
app.setErrorHandler(errorMapper);
|
||||
|
||||
try
|
||||
{
|
||||
server.start();
|
||||
|
||||
String host = connector.getHost();
|
||||
if (host == null)
|
||||
{
|
||||
host = "localhost";
|
||||
}
|
||||
int port = connector.getLocalPort();
|
||||
|
||||
URI serverUri = new URI("http",null,host,port,"/test",null,null);
|
||||
|
||||
// Make call to test handler
|
||||
HttpURLConnection connection = (HttpURLConnection)serverUri.toURL().openConnection();
|
||||
try
|
||||
{
|
||||
connection.setAllowUserInteraction(false);
|
||||
|
||||
// log response status code
|
||||
int statusCode = connection.getResponseCode();
|
||||
LOG.info("Response Status Code: {}",statusCode);
|
||||
|
||||
if (statusCode == 200)
|
||||
{
|
||||
// collect response message and log it
|
||||
String content = getResponseContent(connection);
|
||||
LOG.info("Response Content: {}",content);
|
||||
}
|
||||
}
|
||||
finally
|
||||
{
|
||||
connection.disconnect();
|
||||
}
|
||||
|
||||
assertRequestLog(captureLog);
|
||||
}
|
||||
finally
|
||||
{
|
||||
server.stop();
|
||||
}
|
||||
}
|
||||
|
||||
private void assertRequestLog(CaptureLog captureLog)
|
||||
{
|
||||
int captureCount = captureLog.captured.size();
|
||||
|
||||
if (captureCount != 1)
|
||||
{
|
||||
LOG.warn("Capture Log size is {}, expected to be 1",captureCount);
|
||||
if (captureCount > 1)
|
||||
{
|
||||
for (int i = 0; i < captureCount; i++)
|
||||
{
|
||||
LOG.warn("[{}] {}",i,captureLog.captured.get(i));
|
||||
}
|
||||
}
|
||||
assertThat("Capture Log Entry Count",captureLog.captured.size(),is(1));
|
||||
}
|
||||
|
||||
String actual = captureLog.captured.get(0);
|
||||
assertThat("Capture Log",actual,is(expectedLogEntry));
|
||||
}
|
||||
|
||||
private String getResponseContent(HttpURLConnection connection) throws IOException
|
||||
{
|
||||
try (InputStream in = connection.getInputStream(); InputStreamReader reader = new InputStreamReader(in))
|
||||
{
|
||||
StringWriter writer = new StringWriter();
|
||||
IO.copy(reader,writer);
|
||||
return writer.toString();
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
Loading…
Reference in New Issue