Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue #5365 ISE not NPE if fail to create session. (#5370) 

If SessionHandler.newHttpSession(Request) fails to create a session
it returns null. Request.getSession(true) cannot throw a checked
exception, nor can it return null, so we should throw ISE.

Signed-off-by: Jan Bartel <janb@webtide.com>
This commit is contained in:
Jan Bartel 2020-09-30 16:51:54 +02:00 committed by GitHub
parent c7e52eeecb
commit eb02009f87
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
jetty-server/src/main/java/org/eclipse/jetty/server/Request.java
View File

@ -1623,6 +1623,9 @@ public class Request implements HttpServletRequest
throw new IllegalStateException("No SessionManager"); throw new IllegalStateException("No SessionManager");
_session = _sessionHandler.newHttpSession(this); _session = _sessionHandler.newHttpSession(this);
if (_session == null)
throw new IllegalStateException("Create session failed");
HttpCookie cookie = _sessionHandler.getSessionCookie(_session, getContextPath(), isSecure()); HttpCookie cookie = _sessionHandler.getSessionCookie(_session, getContextPath(), isSecure());
if (cookie != null) if (cookie != null)
_channel.getResponse().replaceCookie(cookie); _channel.getResponse().replaceCookie(cookie);