Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4180 from eclipse/jetty-9.4.x-4179-SendCallback-gc 

Issue #4179 SendCallback GC
This commit is contained in:
Simone Bordet 2019-10-10 12:45:30 +02:00 committed by GitHub
parent cd57af4caf faac5d7f04
commit ec56739d3c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnection.java
View File

@ -848,19 +848,22 @@ public class HttpConnection extends AbstractConnection implements Runnable, Http
} }
} }
private void releaseHeader() private Callback release()
{ {
ByteBuffer h = _header; Callback complete = _callback;
_callback = null;
_info = null;
_content = null;
if (_header != null)
_bufferPool.release(_header);
_header = null; _header = null;
if (h != null) return complete;
_bufferPool.release(h);
} }
@Override @Override
protected void onCompleteSuccess() protected void onCompleteSuccess()
{ {
releaseHeader(); release().succeeded();
_callback.succeeded();
if (_shutdownOut) if (_shutdownOut)
getEndPoint().shutdownOutput(); getEndPoint().shutdownOutput();
} }
@ -868,8 +871,7 @@ public class HttpConnection extends AbstractConnection implements Runnable, Http
@Override @Override
public void onCompleteFailure(final Throwable x) public void onCompleteFailure(final Throwable x)
{ {
releaseHeader(); failedCallback(release(), x);
failedCallback(_callback, x);
if (_shutdownOut) if (_shutdownOut)
getEndPoint().shutdownOutput(); getEndPoint().shutdownOutput();
} }