From f0c2fd24741dc7d10ee2c8402937c9060dbdcb1c Mon Sep 17 00:00:00 2001
From: Simone Bordet <simone.bordet@gmail.com>
Date: Mon, 4 Jun 2012 15:39:01 +0200
Subject: [PATCH] Improved error reporting in case of a write failure.

---
 .../eclipse/jetty/spdy/StandardSession.java   | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardSession.java b/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardSession.java
index bfcbc1e0a09..5f384dc058c 100644
--- a/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardSession.java
+++ b/jetty-spdy/spdy-core/src/main/java/org/eclipse/jetty/spdy/StandardSession.java
@@ -97,7 +97,7 @@ public class StandardSession implements ISession, Parser.Listener, Handler<Stand
     private final AtomicInteger lastStreamId = new AtomicInteger();
     private final FlowControlStrategy flowControlStrategy;
     private boolean flushing;
-    private boolean failed = false;
+    private Throwable failure;
 
     public StandardSession(short version, ByteBufferPool bufferPool, Executor threadPool, ScheduledExecutorService scheduler,
             Controller<FrameBytes> controller, IdleListener idleListener, int initialStreamId, SessionFrameListener listener,
@@ -870,11 +870,11 @@ public class StandardSession implements ISession, Parser.Listener, Handler<Stand
 
     private void append(FrameBytes frameBytes)
     {
-        boolean fail;
+        Throwable failure;
         synchronized (queue)
         {
-            fail = failed;
-            if (!fail)
+            failure = this.failure;
+            if (failure == null)
             {
                 int index = queue.size();
                 while (index > 0)
@@ -888,17 +888,17 @@ public class StandardSession implements ISession, Parser.Listener, Handler<Stand
             }
         }
 
-        if (fail)
-            frameBytes.fail(new SPDYException("Session failed"));
+        if (failure != null)
+            frameBytes.fail(new SPDYException(failure));
     }
 
     private void prepend(FrameBytes frameBytes)
     {
-        boolean fail;
+        Throwable failure;
         synchronized (queue)
         {
-            fail = failed;
-            if (!fail)
+            failure = this.failure;
+            if (failure == null)
             {
                 int index = 0;
                 while (index < queue.size())
@@ -912,8 +912,8 @@ public class StandardSession implements ISession, Parser.Listener, Handler<Stand
             }
         }
 
-        if (fail)
-            frameBytes.fail(new SPDYException("Session failed"));
+        if (failure != null)
+            frameBytes.fail(new SPDYException(failure));
     }
 
     @Override
@@ -935,7 +935,7 @@ public class StandardSession implements ISession, Parser.Listener, Handler<Stand
 
         synchronized (queue)
         {
-            failed = true;
+            failure = x;
             String logMessage = String.format("Failed write of %s, failing all %d frame(s) in queue",frameBytes,queue.size());
             logger.debug(logMessage,x);
             frameBytesToFail.addAll(queue);