400738 - ResourceHandler doesn't support range requests

+ Adding testcase to replicate issue.
2013-02-13 14:27:26 -07:00 · 2013-02-13 14:27:26 -07:00 · f15d4c0376
parent 6d0f233c80
commit f15d4c0376
1 changed files with 112 additions and 0 deletions
--- a/jetty-server/src/test/java/org/eclipse/jetty/server/handler/ResourceHandlerRangeTest.java
+++ b/jetty-server/src/test/java/org/eclipse/jetty/server/handler/ResourceHandlerRangeTest.java
@ -0,0 +1,112 @@
+//
+//  ========================================================================
+//  Copyright (c) 1995-2013 Mort Bay Consulting Pty. Ltd.
+//  ------------------------------------------------------------------------
+//  All rights reserved. This program and the accompanying materials
+//  are made available under the terms of the Eclipse Public License v1.0
+//  and Apache License v2.0 which accompanies this distribution.
+//
+//      The Eclipse Public License is available at
+//      http://www.eclipse.org/legal/epl-v10.html
+//
+//      The Apache License v2.0 is available at
+//      http://www.opensource.org/licenses/apache2.0.php
+//
+//  You may elect to redistribute this code under either of these licenses.
+//  ========================================================================
+//
+
+package org.eclipse.jetty.server.handler;
+
+import static org.hamcrest.Matchers.*;
+
+import java.io.File;
+import java.io.FileWriter;
+import java.io.InputStream;
+import java.net.HttpURLConnection;
+import java.net.URI;
+
+import org.eclipse.jetty.server.Server;
+import org.eclipse.jetty.server.ServerConnector;
+import org.eclipse.jetty.toolchain.test.FS;
+import org.eclipse.jetty.toolchain.test.MavenTestingUtils;
+import org.eclipse.jetty.util.IO;
+import org.eclipse.jetty.util.resource.Resource;
+import org.junit.AfterClass;
+import org.junit.Assert;
+import org.junit.BeforeClass;
+import org.junit.Ignore;
+import org.junit.Test;
+
+@Ignore("Unfixed range bug")
+public class ResourceHandlerRangeTest
+{
+    private static Server server;
+    private static URI serverUri;
+
+    @BeforeClass
+    public static void startServer() throws Exception
+    {
+        server = new Server();
+        ServerConnector connector = new ServerConnector(server);
+        connector.setPort(0);
+        server.addConnector(connector);
+
+        ContextHandlerCollection contexts = new ContextHandlerCollection();
+
+        File dir = MavenTestingUtils.getTargetTestingDir(ResourceHandlerRangeTest.class.getSimpleName());
+        FS.ensureEmpty(dir);
+        File rangeFile = new File(dir,"range.txt");
+        try (FileWriter writer = new FileWriter(rangeFile))
+        {
+            writer.append("0123456789");
+            writer.flush();
+        }
+
+        ContextHandler contextHandler = new ContextHandler();
+        ResourceHandler contentResourceHandler = new ResourceHandler();
+        contextHandler.setBaseResource(Resource.newResource(dir.getAbsolutePath()));
+        contextHandler.setHandler(contentResourceHandler);
+        contextHandler.setContextPath("/");
+
+        contexts.addHandler(contextHandler);
+
+        server.setHandler(contexts);
+        server.start();
+
+        String host = connector.getHost();
+        if (host == null)
+        {
+            host = "localhost";
+        }
+        int port = connector.getLocalPort();
+        serverUri = new URI(String.format("http://%s:%d/",host,port));
+    }
+
+    @AfterClass
+    public static void stopServer() throws Exception
+    {
+        server.stop();
+    }
+
+    @Test
+    public void testGetRange() throws Exception
+    {
+        URI uri = serverUri.resolve("range.txt");
+
+        HttpURLConnection uconn = (HttpURLConnection)uri.toURL().openConnection();
+        uconn.setRequestMethod("GET");
+        uconn.addRequestProperty("Range","bytes=" + 5 + "-");
+
+        int contentLength = Integer.parseInt(uconn.getHeaderField("Content-Length"));
+
+        String response;
+        try (InputStream is = uconn.getInputStream())
+        {
+            response = IO.toString(is);
+        }
+
+        Assert.assertThat("Content Length",contentLength,is(5));
+        Assert.assertThat("Response Content",response,is("56789"));
+    }
+}