Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue #2662 - Unnecessary boxing conversions 

Signed-off-by: Matthias Perktold <tias251@gmail.com>
This commit is contained in:
Matthias Perktold 2018-06-13 16:20:12 +02:00
parent 6b7f4c91db
commit f901efc413
30 changed files with 50 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
jetty-annotations/src/main/java/org/eclipse/jetty/annotations/AnnotationConfiguration.java
View File

@ -426,7 +426,7 @@ public class AnnotationConfiguration extends AbstractConfiguration
int javaPlatform = 0;
Object target = context.getAttribute(JavaVersion.JAVA_TARGET_PLATFORM);
if (target!=null)
javaPlatform = Integer.valueOf(target.toString());
javaPlatform = Integer.parseInt(target.toString());
AnnotationParser parser = createAnnotationParser(javaPlatform);
_parserTasks = new ArrayList<ParserTask>();
@ -539,7 +539,7 @@ public class AnnotationConfiguration extends AbstractConfiguration
return ((Boolean)o).booleanValue();
}
//try system property to see if we should use multithreading
return Boolean.valueOf(System.getProperty(MULTI_THREADED, Boolean.toString(DEFAULT_MULTI_THREADED)));
return Boolean.parseBoolean(System.getProperty(MULTI_THREADED, Boolean.toString(DEFAULT_MULTI_THREADED)));
}

2
jetty-hazelcast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStore.java
View File

@ -204,7 +204,7 @@ public class HazelcastSessionDataStore
if (sd.getExpiry() <= 0)
return true; //never expires
else
return (Boolean.valueOf(sd.getExpiry() > System.currentTimeMillis())); //not expired yet
return sd.getExpiry() > System.currentTimeMillis(); //not expired yet
}
public String getCacheKey( String id )

8
jetty-http/src/main/java/org/eclipse/jetty/http/HttpField.java
View File

@ -72,12 +72,12 @@ public class HttpField
public int getIntValue()
{
return Integer.valueOf(_value);
return Integer.parseInt(_value);
}
public long getLongValue()
{
return Long.valueOf(_value);
return Long.parseLong(_value);
}
public String[] getValues()
@ -348,7 +348,7 @@ public class HttpField
public IntValueHttpField(HttpHeader header, String name, String value)
{
this(header,name,value,Integer.valueOf(value));
this(header,name,value,Integer.parseInt(value));
}
public IntValueHttpField(HttpHeader header, String name, int intValue)
@ -386,7 +386,7 @@ public class HttpField
public LongValueHttpField(HttpHeader header, String name, String value)
{
this(header,name,value,Long.valueOf(value));
this(header,name,value,Long.parseLong(value));
}
public LongValueHttpField(HttpHeader header, String name, long value)

2
jetty-http2/http2-client/src/test/java/org/eclipse/jetty/http2/client/ProxyTest.java
View File

@ -93,7 +93,7 @@ public class ProxyTest
configuration.setSendServerVersion(false);
String value = initParams.get("outputBufferSize");
if (value != null)
configuration.setOutputBufferSize(Integer.valueOf(value));
configuration.setOutputBufferSize(Integer.parseInt(value));
proxyConnector = new ServerConnector(proxy, new HTTP2ServerConnectionFactory(configuration));
proxy.addConnector(proxyConnector);

9
jetty-infinispan/src/main/java/org/eclipse/jetty/session/infinispan/InfinispanSessionDataStore.java
View File

@ -22,6 +22,7 @@ package org.eclipse.jetty.session.infinispan;
import java.util.HashSet;
import java.util.Set;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference;
import org.eclipse.jetty.server.session.AbstractSessionDataStore;
@ -258,7 +259,7 @@ public class InfinispanSessionDataStore extends AbstractSessionDataStore
{
// TODO find a better way to do this that does not pull into memory the
// whole session object
final AtomicReference<Boolean> reference = new AtomicReference<>();
final AtomicBoolean reference = new AtomicBoolean();
final AtomicReference<Exception> exception = new AtomicReference<>();
Runnable load = new Runnable()
@ -271,14 +272,14 @@ public class InfinispanSessionDataStore extends AbstractSessionDataStore
SessionData sd = load(id);
if (sd == null)
{
reference.set(Boolean.FALSE);
reference.set(false);
return;
}
if (sd.getExpiry() <= 0)
reference.set(Boolean.TRUE); //never expires
reference.set(true); //never expires
else
reference.set(Boolean.valueOf(sd.getExpiry() > System.currentTimeMillis())); //not expired yet
reference.set(sd.getExpiry() > System.currentTimeMillis()); //not expired yet
}
catch (Exception e)
{

2
jetty-jaspi/src/main/java/org/eclipse/jetty/security/jaspi/modules/BaseAuthModule.java
View File

@ -112,7 +112,7 @@ public class BaseAuthModule implements ServerAuthModule, ServerAuthContext
{
String mandatory = (String) messageInfo.getMap().get(JaspiMessageInfo.MANDATORY_KEY);
if (mandatory == null) return false;
return Boolean.valueOf(mandatory);
return Boolean.parseBoolean(mandatory);
}
protected boolean login(Subject clientSubject, String credentials,

2
jetty-proxy/src/test/java/org/eclipse/jetty/proxy/AsyncMiddleManServletTest.java
View File

@ -131,7 +131,7 @@ public class AsyncMiddleManServletTest
configuration.setSendServerVersion(false);
String value = initParams.get("outputBufferSize");
if (value != null)
configuration.setOutputBufferSize(Integer.valueOf(value));
configuration.setOutputBufferSize(Integer.parseInt(value));
proxyConnector = new ServerConnector(proxy, new HttpConnectionFactory(configuration));
proxy.addConnector(proxyConnector);

2
jetty-proxy/src/test/java/org/eclipse/jetty/proxy/ProxyServletTest.java
View File

@ -160,7 +160,7 @@ public class ProxyServletTest
configuration.setSendServerVersion(false);
String value = initParams.get("outputBufferSize");
if (value != null)
configuration.setOutputBufferSize(Integer.valueOf(value));
configuration.setOutputBufferSize(Integer.parseInt(value));
proxyConnector = new ServerConnector(proxy, new HttpConnectionFactory(configuration));
proxy.addConnector(proxyConnector);

4
jetty-security/src/main/java/org/eclipse/jetty/security/authentication/DigestAuthenticator.java
View File

@ -72,10 +72,10 @@ public class DigestAuthenticator extends LoginAuthenticator
String mna = configuration.getInitParameter("maxNonceAge");
if (mna != null)
setMaxNonceAge(Long.valueOf(mna));
setMaxNonceAge(Long.parseLong(mna));
String mnc = configuration.getInitParameter("maxNonceCount");
if (mnc != null)
setMaxNonceCount(Integer.valueOf(mnc));
setMaxNonceCount(Integer.parseInt(mnc));
}
public int getMaxNonceCount()

2
jetty-security/src/main/java/org/eclipse/jetty/security/authentication/FormAuthenticator.java
View File

@ -136,7 +136,7 @@ public class FormAuthenticator extends LoginAuthenticator
if (error!=null)
setErrorPage(error);
String dispatch=configuration.getInitParameter(FormAuthenticator.__FORM_DISPATCH);
_dispatch = dispatch==null?_dispatch:Boolean.valueOf(dispatch);
_dispatch = dispatch==null?_dispatch:Boolean.parseBoolean(dispatch);
}
/* ------------------------------------------------------------ */

4
jetty-server/src/main/java/org/eclipse/jetty/server/Request.java
View File

@ -515,7 +515,7 @@ public class Request implements HttpServletRequest
}
else if (obj instanceof String)
{
maxFormContentSize = Integer.valueOf((String)obj);
maxFormContentSize = Integer.parseInt((String)obj);
}
}
@ -531,7 +531,7 @@ public class Request implements HttpServletRequest
}
else if (obj instanceof String)
{
maxFormKeys = Integer.valueOf((String)obj);
maxFormKeys = Integer.parseInt((String)obj);
}
}

2
jetty-server/src/main/java/org/eclipse/jetty/server/handler/AbstractHandler.java
View File

@ -93,7 +93,7 @@ public abstract class AbstractHandler extends ContainerLifeCycle implements Hand
protected void doError(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException
{
Object o = request.getAttribute(RequestDispatcher.ERROR_STATUS_CODE);
int code = (o instanceof Integer)?((Integer)o).intValue():(o!=null?Integer.valueOf(o.toString()):500);
int code = (o instanceof Integer)?((Integer)o).intValue():(o!=null?Integer.parseInt(o.toString()):500);
o = request.getAttribute(RequestDispatcher.ERROR_MESSAGE);
String reason = o!=null?o.toString():null;

2
jetty-server/src/test/java/org/eclipse/jetty/server/AsyncRequestReadTest.java
View File

@ -354,7 +354,7 @@ public class AsyncRequestReadTest
BufferedReader in = request.getReader();
PrintWriter out =httpResponse.getWriter();
int read=Integer.valueOf(request.getParameter("read"));
int read=Integer.parseInt(request.getParameter("read"));
// System.err.println("read="+read);
for (int i=read;i-->0;)
{

6
jetty-server/src/test/java/org/eclipse/jetty/server/DumpHandler.java
View File

@ -63,10 +63,10 @@ public class DumpHandler extends AbstractHandler.ErrorDispatchHandler
if (!isStarted())
return;
if (Boolean.valueOf(request.getParameter("flush")))
if (Boolean.parseBoolean(request.getParameter("flush")))
response.flushBuffer();
if (Boolean.valueOf(request.getParameter("empty")))
if (Boolean.parseBoolean(request.getParameter("empty")))
{
baseRequest.setHandled(true);
response.setStatus(200);
@ -230,7 +230,7 @@ public class DumpHandler extends AbstractHandler.ErrorDispatchHandler
writer.flush();
// commit now
if (!Boolean.valueOf(request.getParameter("no-content-length")))
if (!Boolean.parseBoolean(request.getParameter("no-content-length")))
response.setContentLength(buf.size()+1000);
response.addHeader("Before-Flush",response.isCommitted()?"Committed???":"Not Committed");
buf.writeTo(out);

2
jetty-server/src/test/java/org/eclipse/jetty/server/ExtendedServerTest.java
View File

@ -147,7 +147,7 @@ public class ExtendedServerTest extends HttpServerTestBase
String s=response.substring(response.indexOf("DispatchedAt=")+13);
s=s.substring(0,s.indexOf('\n'));
long dispatched=Long.valueOf(s);
long dispatched=Long.parseLong(s);
Assert.assertThat(dispatched, Matchers.greaterThanOrEqualTo(start));
Assert.assertThat(dispatched, Matchers.lessThan(end));

4
jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java
View File

@ -910,7 +910,7 @@ public abstract class HttpServerTestBase extends HttpServerTestFixture
// read and check the times are < 999ms
String[] times = in.readLine().split(",");
for (String t : times)
Assert.assertTrue(Integer.valueOf(t) < 999);
Assert.assertTrue(Integer.parseInt(t) < 999);
// read the EOF chunk
@ -940,7 +940,7 @@ public abstract class HttpServerTestBase extends HttpServerTestFixture
// read and check the times are < 999ms
times = in.readLine().split(",");
for (String t : times)
Assert.assertTrue(t, Integer.valueOf(t) < 999);
Assert.assertTrue(t, Integer.parseInt(t) < 999);
// check close
Assert.assertTrue(in.readLine() == null);

2
jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SSLEngineTest.java
View File

@ -369,7 +369,7 @@ public class SSLEngineTest
if (request.getParameter("dump")!=null)
{
ServletOutputStream out=response.getOutputStream();
byte[] buf = new byte[Integer.valueOf(request.getParameter("dump"))];
byte[] buf = new byte[Integer.parseInt(request.getParameter("dump"))];
// System.err.println("DUMP "+buf.length);
for (int i=0;i<buf.length;i++)
buf[i]=(byte)('0'+(i%10));

4
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/StatisticsServlet.java
View File

@ -104,7 +104,7 @@ public class StatisticsServlet extends HttpServlet
}
}
if (Boolean.valueOf( req.getParameter("statsReset")))
if (Boolean.parseBoolean( req.getParameter("statsReset")))
{
_statsHandler.statsReset();
return;
@ -114,7 +114,7 @@ public class StatisticsServlet extends HttpServlet
if (wantXml == null)
wantXml = req.getParameter("XML");
if (Boolean.valueOf(wantXml))
if (Boolean.parseBoolean(wantXml))
{
sendXmlResponse(resp);
}

6
jetty-servlet/src/test/java/org/eclipse/jetty/servlet/AsyncContextTest.java
View File

@ -651,15 +651,15 @@ public class AsyncContextTest
{
request.startAsync(request, response);
if (Boolean.valueOf(request.getParameter("dispatch")))
if (Boolean.parseBoolean(request.getParameter("dispatch")))
{
request.getAsyncContext().dispatch();
}
if (Boolean.valueOf(request.getParameter("complete")))
if (Boolean.parseBoolean(request.getParameter("complete")))
{
response.getOutputStream().write("completeBeforeThrow".getBytes());
if (Boolean.valueOf(request.getParameter("flush")))
if (Boolean.parseBoolean(request.getParameter("flush")))
response.flushBuffer();
request.getAsyncContext().complete();
}

2
jetty-servlet/src/test/java/org/eclipse/jetty/servlet/AsyncServletIOTest.java
View File

@ -481,7 +481,7 @@ public class AsyncServletIOTest
while (writes!=null && _w< writes.length)
{
int write=Integer.valueOf(writes[_w++]);
int write=Integer.parseInt(writes[_w++]);
if (write==0)
out.flush();

2
jetty-servlets/src/main/java/org/eclipse/jetty/servlets/DoSFilter.java
View File

@ -737,7 +737,7 @@ public class DoSFilter implements Filter
byte[] result = new byte[16];
for (int i = 0; i < result.length; i += 2)
{
int word = Integer.valueOf(ipv6Matcher.group(i / 2 + 1), 16);
int word = Integer.parseInt(ipv6Matcher.group(i / 2 + 1), 16);
result[i] = (byte)((word & 0xFF00) >>> 8);
result[i + 1] = (byte)(word & 0xFF);
}

2
jetty-servlets/src/main/java/org/eclipse/jetty/servlets/PushSessionCacheFilter.java
View File

@ -54,7 +54,7 @@ public class PushSessionCacheFilter implements Filter
public void init(FilterConfig config) throws ServletException
{
if (config.getInitParameter("associateDelay") != null)
_associateDelay = Long.valueOf(config.getInitParameter("associateDelay"));
_associateDelay = Long.parseLong(config.getInitParameter("associateDelay"));
// Add a listener that is used to collect information about associated resource,
// etags and modified dates

2
jetty-start/src/main/java/org/eclipse/jetty/start/BaseBuilder.java
View File

@ -246,7 +246,7 @@ public class BaseBuilder
files.addAll(startArgs.getFiles());
if (!files.isEmpty() && processFileResources(files))
modified.set(Boolean.TRUE);
modified.set(true);
return modified.get();
}

2
jetty-start/src/main/java/org/eclipse/jetty/start/fileinits/TestFileInitializer.java
View File

@ -59,6 +59,6 @@ public class TestFileInitializer extends FileInitializer
}
StartLog.log("TESTING MODE","Skipping download of " + uri);
return Boolean.TRUE;
return true;
}
}

2
jetty-util/src/main/java/org/eclipse/jetty/util/IPAddressMap.java
View File

@ -281,7 +281,7 @@ public class IPAddressMap<TYPE> extends HashMap<String, TYPE>
{
if (part.indexOf('-') < 0)
{
Integer value = Integer.valueOf(part);
int value = Integer.parseInt(part);
_mask.set(value);
}
else

2
jetty-util/src/main/java/org/eclipse/jetty/util/MultiReleaseJarFile.java
View File

@ -75,7 +75,7 @@ public class MultiReleaseJarFile implements Closeable
if (manifest==null)
multiRelease = false;
else
multiRelease = Boolean.valueOf(String.valueOf(manifest.getMainAttributes().getValue("Multi-Release")));
multiRelease = Boolean.parseBoolean(String.valueOf(manifest.getMainAttributes().getValue("Multi-Release")));
Map<String,VersionedJarEntry> map = new TreeMap<>();
jarFile.stream()

2
jetty-util/src/main/java/org/eclipse/jetty/util/log/Log.java
View File

@ -208,7 +208,7 @@ public class Log
log_class = StdErrLog.class;
LOG = new StdErrLog();
Boolean announce = Boolean.parseBoolean(__props.getProperty("org.eclipse.jetty.util.log.announce", "true"));
boolean announce = Boolean.parseBoolean(__props.getProperty("org.eclipse.jetty.util.log.announce", "true"));
if(announce)
{
LOG.debug("Logging to {} via {}", LOG, log_class.getName());

2
jetty-util/src/test/java/org/eclipse/jetty/util/thread/strategy/jmh/TestConnection.java
View File

@ -76,7 +76,7 @@ public class TestConnection implements Producer
{
_request = request;
_futureResult = futureResult;
_blocking = Boolean.valueOf(request.get("blocking"));
_blocking = Boolean.parseBoolean(request.get("blocking"));
}
@Override

10
jetty-webapp/src/main/java/org/eclipse/jetty/webapp/StandardDescriptorProcessor.java
View File

@ -476,7 +476,7 @@ public class StandardDescriptorProcessor extends IterativeDescriptorProcessor
String async=node.getString("async-supported",false,true);
if (async!=null)
{
boolean val = async.length()==0||Boolean.valueOf(async);
boolean val = async.length()==0||Boolean.parseBoolean(async);
switch (context.getMetaData().getOrigin(name+".servlet.async-supported"))
{
case NotSet:
@ -513,7 +513,7 @@ public class StandardDescriptorProcessor extends IterativeDescriptorProcessor
String enabled = node.getString("enabled", false, true);
if (enabled!=null)
{
boolean is_enabled = enabled.length()==0||Boolean.valueOf(enabled);
boolean is_enabled = enabled.length()==0||Boolean.parseBoolean(enabled);
switch (context.getMetaData().getOrigin(name+".servlet.enabled"))
{
case NotSet:
@ -1119,7 +1119,7 @@ public class StandardDescriptorProcessor extends IterativeDescriptorProcessor
error = ErrorPageErrorHandler.GLOBAL_ERROR_PAGE;
}
else
code=Integer.valueOf(error);
code=Integer.parseInt(error);
String location = node.getString("location", false, true);
if (!location.startsWith("/"))
@ -1814,10 +1814,10 @@ public class StandardDescriptorProcessor extends IterativeDescriptorProcessor
String async=node.getString("async-supported",false,true);
if (async!=null)
holder.setAsyncSupported(async.length()==0||Boolean.valueOf(async));
holder.setAsyncSupported(async.length()==0||Boolean.parseBoolean(async));
if (async!=null)
{
boolean val = async.length()==0||Boolean.valueOf(async);
boolean val = async.length()==0||Boolean.parseBoolean(async);
switch (context.getMetaData().getOrigin(name+".filter.async-supported"))
{
case NotSet:

2
jetty-websocket/websocket-api/src/main/java/org/eclipse/jetty/websocket/api/extensions/ExtensionConfig.java
View File

@ -170,7 +170,7 @@ public class ExtensionConfig
{
return defValue;
}
return Integer.valueOf(val);
return Integer.parseInt(val);
}
public final String getParameter(String key, String defValue)