Commit Graph

30307 Commits

Author SHA1 Message Date
Ludovic Orban e8a258baba
#12327 Fix flaky assertions
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2024-09-30 13:33:32 +02:00
Simone Bordet 3b1f38e592
Merged branch 'jetty-12.0.x' into 'jetty-12.1.x'.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-20 16:00:12 +02:00
Simone Bordet 115ee1cf39
Fixes #12289 - Improve ConcurrentPool concurrency. (#12290)
A call to `sweep()`, although protected by the lock for concurrent calls to `reserve()`, may be concurrent with `remove(Entry)`.

`remove(Entry)` in turn calls `entries.remove(Object)`, so that the concurrent iteration in `sweep()` over `entries` fails with an `ArrayIndexOutOfBoundsException`.

Now using the bulk `entries.removeIf(Predicate)` method in `sweep()`, so that sweeping is atomic with respect to `entries.remove(Object)`.

Fixed other occurrences of manual iteration over CopyOnWriteArrayList that may be concurrent with removals.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-20 15:50:39 +02:00
Simone Bordet 838b97d5d2
Merged branch 'jetty-12.0.x' into 'jetty-12.1.x'.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-20 15:43:50 +02:00
Simone Bordet 9c342637cc Fixed #12284 - Excessive heap consumption by SSLSessionImpl by Jetty Server with TLS 1.3 and long-lived client.
Now `SslSessionData` is stored as a field, rather than in the `SSLSession` as an attribute.
This implies a little more cost to create the `SslSessionData` per connection rather than per `SSLSession`, but it should be negligible.

Now `SslSessionData` cannot be retrieved as a `SSLSession` attribute, but we have explicit APIs to retrieve it, so it should not be a problem.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-20 16:41:15 +03:00
gregw acb30ab98a Merge branch 'jetty-12.0.x' into jetty-12.1.x 2024-09-19 09:41:12 +10:00
Jan Bartel 6f83639d32
Issue #12279 ensure handlers added correctly for maven plugin (#12282)
* Issue #12279 ensure handlers added correctly for maven plugin
2024-09-19 09:38:08 +10:00
Jan Bartel 41333a7712
Issue #12255 Dump CookieConfig (#12257) 2024-09-18 06:57:30 -05:00
gregw a6125e40f0 Merge remote-tracking branch 'origin/jetty-12.0.x' into jetty-12.1.x 2024-09-18 07:17:52 +10:00
Greg Wilkins dc43f3d498
Optimize request buffer release #12239 (#12240)
Release request buffer before handling when there is no content

---------

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-18 07:11:32 +10:00
Olivier Lamy db1c878cbc
Merge pull request #12280 from jetty/jetty-12.1.x-test-distribution-cleanup
Jetty 12.1.x test distribution cleanup merge
2024-09-17 20:50:01 +10:00
Olivier Lamy a9513c0ae8
log to search for restart can be different depending on eexx
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-17 20:12:43 +10:00
Olivier Lamy 4a0ee278c1
fix logging
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-17 19:54:56 +10:00
Olivier Lamy fb8e237dca
need this dependency
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-17 19:08:41 +10:00
Olivier Lamy b89f767be6
needed dependencies
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-17 18:38:48 +10:00
Olivier Lamy 0c31ab7ca6
checkstyle
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-17 18:24:53 +10:00
Olivier Lamy efcddd330a
checkstyle
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-17 18:22:25 +10:00
Olivier Lamy b152630eb6
spotless
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-17 17:50:46 +10:00
Olivier Lamy ac18df08af
restore jetty-test-common as it is used in multiple places
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-17 16:55:16 +10:00
Olivier Lamy 6f69383188
fix merge
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-17 16:20:31 +10:00
Olivier Lamy dd172f58db
Merge branch 'jetty-12.0.x' into jetty-12.1.x 2024-09-17 16:08:57 +10:00
Olivier Lamy e52bd7a9c7
Jetty 12.0.x Simplify tests with OpenId by using an exising openid provider and avoid extra not necessary maven modules (#12274)
* use keycloak as openid provider for testing
* merge all test-distribution into a single one

---------

Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-17 15:08:49 +10:00
Simone Bordet 9eaedb04be
Merged branch 'jetty-12.0.x' into 'jetty-12.1.x'.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-16 10:05:16 +02:00
Simone Bordet 8c943c4bfb Issue #12256 - Configuring Virtual Thread executor in Jetty Http client makes my Spring Boot app freeze
* Defaulted the number of selectors to 1 in HttpClientTransportOverHTTP, to align with ClientConnector.
* Improved virtual thread documentation.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-16 11:01:06 +03:00
Ludovic Orban 76962e966a
Merge remote-tracking branch 'origin/jetty-12.0.x' into jetty-12.1.x 2024-09-16 09:32:11 +02:00
Ludovic Orban ceee65a7e5 #12268 do not rely on time
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2024-09-16 09:11:54 +02:00
Ludovic Orban 2018c439b6 #12268 reset _iterate flag when another processing is scheduled
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2024-09-16 09:11:54 +02:00
Jan Bartel 5105afafa4
Issue #12241 Restore SameSite config as session cookie comment. (#12263)
* Issue #12241 Restore SameSite config as session cookie comment in ee8/9.
2024-09-16 08:48:06 +10:00
Olivier Lamy 0553fe3030
fix cache url
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-12 09:44:37 +10:00
Olivier Lamy 764805d176
Merge branch 'jetty-12.0.x' into jetty-12.1.x 2024-09-12 09:40:49 +10:00
Olivier Lamy daa4923779
Jetty 12.0.x Use cache stored in nexus to avoid having to maintain a separate nginx pod which consume cpu and memory (#12258)
* use nexus remote cache rather than home made container

---------

Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-12 07:08:44 +10:00
Joakim Erdfelt 044a3be744
Merge pull request #12245 from jetty/release/12.0.13
Merge back release 12.0.13
2024-09-11 09:45:12 -05:00
Simone Bordet 3d8a62d3b3
Merged branch 'jetty-12.0.x' into 'jetty-12.1.x'.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-10 11:09:32 +02:00
Simone Bordet 24f0ac28ad Fixes #11327 - Flaky test ServletTest.testSimpleIdleRead().
Just improving the test code.
The flakyness was likely fixed by the work in #12216 and #12237.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-10 12:03:02 +03:00
Olivier Lamy f2d044b02b
do not always execute this
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-10 17:57:01 +10:00
Olivier Lamy 13c8ba4f63
force running test-jar when using the cache
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-10 09:11:59 +10:00
Olivier Lamy b54ba94a82
add direct dependency
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-10 09:03:19 +10:00
Simone Bordet 4b40aa7116
Merged branch 'jetty-12.0.x' into 'jetty-12.1.x'.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-09 17:38:00 +02:00
Simone Bordet fa0502db54
Fixes #12249 - HTTP/2 responses with Content-Length may have no content. (#12250)
Fixed HttpReceiverOverHTTP2.read() to return a failed chunk if the stream has been reset.
This closes the window where a RST_STREAM frame may be received, drain the DATA frames in HTTP2Stream, and the application reading exactly at that point.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-09 17:20:17 +02:00
Olivier Lamy d5130f1f44
remove useless option
Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-07 08:59:50 +10:00
Simone Bordet 2e4ecdaa9c
Merged branch 'jetty-12.0.x' into 'jetty-12.1.x'.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-06 12:00:00 +02:00
Simone Bordet 5bff971fb0
Fixed flaky test EventsHandlerTest.testEventsOfNoopHandler().
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-06 11:58:45 +02:00
gregw fda0408e38 Merge remote-tracking branch 'origin/jetty-12.0.x' into jetty-12.1.x
# Conflicts:
#	jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpConnection.java
2024-09-06 14:18:20 +10:00
Simone Bordet 6887435773
Fixes #12227 - Improve HttpConnection buffer recycling. (#12237)
In this PR, the responsibility to release the buffers is in 2 methods: onFillable() (called when network data is available, and to process the next request) and parseAndFillForContent() (called from Request.read()).

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Co-authored-by: gregw <gregw@webtide.com>
2024-09-06 14:11:29 +10:00
Olivier Lamy f0a1db100f
Jetty 12.0.x Add jdk23 build (fix javadoc breaking with 23) (#12238)
* add jdk23 build
* make jdk23 happy with javadoc
---------

Signed-off-by: Olivier Lamy <olamy@apache.org>
2024-09-06 10:57:42 +10:00
Lachlan Roberts cc5fea5c3a
Changes from #12236 for EE11
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
2024-09-06 00:04:12 +10:00
Lachlan Roberts d59257e2ec
fix incorrect package name in documentation
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
2024-09-05 23:50:43 +10:00
Lachlan Roberts 0dc9ae7356
Merge PR #12208 to EE11
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
2024-09-05 23:49:33 +10:00
Lachlan Roberts a5727d8e27
Merge remote-tracking branch 'origin/jetty-12.0.x' into jetty-12.1.x 2024-09-05 23:32:29 +10:00
Simone Bordet c2519bbf48 Fixes #11581 - Flaky WebSocketOverHTTP2Test.testWebSocketOverDynamicHTTP2()
Marked the test as flaky, actual resolution needs resolving #12235.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2024-09-05 13:16:23 +03:00