Eclipse
/
jetty.project
mirror of https://github.com/jetty/jetty.project.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
18,928 Commits 68 Branches 465 Tags 359 MiB
Commit Graph

43 Commits

Author SHA1 Message Date
Lachlan Roberts 9cb93432b3 Issue #6205 - Fix serialization issues in OpenIdAuthenticator 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2021-05-12 17:06:38 +02:00
Lachlan 2e7f5ebd2b Issue #6205 - Fix issues with OpenID redirecting to wrong URI (#6211) 
Use the OpenID state param to map to the redirect URI.
 2021-05-12 16:50:42 +02:00
Joakim Erdfelt 5dd987779c
Adding `WhitespaceAfter` checkstyle rule. 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
 2021-02-15 12:48:24 -06:00
Joakim Erdfelt 176e29e408
Happy New Year 2021 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
 2021-01-21 12:31:00 -06:00
Greg Wilkins 14f94f738d
Issue #5605 unconsumed input on sendError (#5637) 
* Issue #5605 unconsumed input on sendError

Add Connection:close if content can't be consumed during a sendError. Processed after the request has returned to the container.

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Update from review

 + Add close on all uncommitted requests when content cannot be consumed.

* Update from review

 + fixed comment
 + space comma

* Only consume input in COMPLETE if response is >=200 (ie not an upgrade or similar)

* Updated to be less adventurous

I do not think it was valid to always consumeAll in COMPLETE as this could break upgrades with both 101s and 200s
Instead I have reverted to having this consumeAll logic only:
 + in sendError once control has passed back to the container and we are about to generate an error page.
 + in front of all the sendRedirection that we do without calling the application first.

Extra tests also added

* Updated to be less adventurous

reverted test

* Testcase for odd sendError(400) issue.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Fix for odd sendError(400) issue.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

* Testcase for odd sendError(400) issue.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Always try to consumeAll on all requests

* Refinements after testing in 10

* Refinements after testing in 10

Fixed test

* Fixed comment from review

* Updates from review

+ added redirect methods that consumeAll
+ ensureContentConsumedOrConnectionClose renamed to ensureConsumeAllOrNotPersistent
+ ensureConsumeAllOrNotPersistent now handles HTTP/1.0 and HTTP/1.1 differently

* better consumeAll implementation

* update from review

 + better javadoc
 + filter out keep-alive
 + added more tests

* update from review

 + better javadoc

* update from review

 + fixed form redirection test for http 1.0 and 1.1

* update from review

 + HttpGenerator removes keep-alive if close present
 + Use isRedirection

Co-authored-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
 2020-11-18 10:40:05 +01:00
Lachlan Roberts 5f2c96dc58 use the OpenID Token expiry time for the initial authentication only, and not for expiry of the session. 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2020-07-27 10:02:38 +10:00
Lachlan Roberts e03c740ee8 Issue #5064 - the OpenIdCredentials should be serializable 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2020-07-21 09:48:30 +10:00
Lachlan Roberts de1b6745c5 the DO NOT EDIT comment in .mod files should start with '#' 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2020-07-15 16:47:22 +10:00
Lachlan Roberts 0de5976651 Issue 4235 - changes from review 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2020-04-14 21:34:26 +10:00
Lachlan Roberts 4bc32e314b Issue #4235 - communicate reason of OpenID auth failure to error page 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2020-03-24 21:36:41 +11:00
Joakim Erdfelt 8c65309963
Addressing Checkstyle violations in src/test/java 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
 2020-01-14 12:33:34 -06:00
Simone Bordet 923ec38adf Merged branch 'jetty-9.3.x' into 'jetty-9.4.x'. 2020-01-07 16:51:25 +01:00
Greg Wilkins 0d4e07ea1e fix OpenIdAuthenticationTest for windows build 
Signed-off-by: Greg Wilkins <gregw@webtide.com>
 2020-01-04 13:31:06 +11:00
olivier lamy e1371a1c13 happy new year 
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
 2020-01-02 21:54:05 +01:00
Lachlan cff6bb444a
Issue #4128 - test the decoding of OpenId Credentials (#4166) 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-11-20 14:23:19 +11:00
Lachlan Roberts 4e43258785 Issue #4236 - move redirect code to utility method 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-11-13 17:19:09 +11:00
Lachlan 7b9f7ab37e
Merge pull request #4207 from eclipse/jetty-9.4.x-4189-OpenIdHttpClient 
Issue #4138 - use HttpClient for OpenID Authentication
 2019-11-11 13:52:41 +11:00
Lachlan Roberts 39aac30137 Issue #4138 - Changes from review 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-11-11 13:51:48 +11:00
Lachlan 18e7ee5940
Issue #4237 - allow openid module to be configured without context xml (#4244) 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-11-07 10:53:25 +11:00
Lachlan a9e543c1c0
Issue #4227 - do not use encodeRedirectURL for openid redirects (#4233) 
* Issue #4227 - do not use encodeRedirectURL for openid redirects

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>

* changes from review

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-10-22 22:47:29 +11:00
Lachlan Roberts ed74a459a7 Issue #4138 - only warn if metadata issuer is not consistent with config 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-10-18 10:31:50 +11:00
Lachlan Roberts 337b6c1439 Issue #4138 - Changes from review 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-10-17 15:59:21 +11:00
Lachlan Roberts 039fb38070 Issue #4138 - use HttpClient for OpenID Authentication 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-10-16 16:26:21 +11:00
Travis Spencer 46d3a371cf Use HttpClient instead of HttpURLConnection 
Signed-off-by: Travis Spencer <travis@curity.io>
 2019-10-15 08:50:33 +02:00
Travis Spencer 1d5ceee267 Issue #4132 Allow token and authorization endpoints to be configured 
Signed-off-by: Travis Spencer <travis@curity.io>
 2019-10-08 01:04:34 +02:00
Lachlan 6e698df4d3
Merge pull request #4135 from travisspencer/4134-fix-aud 
Issue #4134 - Validate audience (aud) claim as list or string, not just string
 2019-10-08 09:28:22 +11:00
Lachlan acf4eeff65
Merge pull request #4129 from travisspencer/fix-4128 
Issue #4128 - Add missing padding and use URL decoder
 2019-10-08 09:17:12 +11:00
Travis Spencer 1c6202658e Validate aud claim as list or string, not just string 
Signed-off-by: Travis Spencer <travis@curity.io>
 2019-10-06 18:00:32 +02:00
Travis Spencer 8b37a8f7fe Issue #4128 - Add missing padding and use URL decoder 
Signed-off-by: Travis Spencer <travis@curity.io>
 2019-10-05 18:06:26 +02:00
Travis Spencer 201264d17b Don't add scopes if none are provided 
Signed-off-by: Travis Spencer <travis@curity.io>
 2019-09-28 18:05:48 +02:00
Lachlan Roberts 42f1214796 fix OpenID module after rename of authenticateNewUsers 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-09-17 10:54:22 +10:00
Simone Bordet b3912d54fe Fixes #137 - Support OAuth. 
Review and code cleanups.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
 2019-09-13 22:01:57 +02:00
Lachlan Roberts eb1c77daf4 remove empty lines 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-09-12 10:22:15 +10:00
Lachlan Roberts fbd1ba0c09 add missing licence header 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-09-11 13:00:22 +10:00
Lachlan Roberts 85cdc0d6c4 Reworked OpenId demo into test using a local test OpenIdProvider 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-09-11 12:14:47 +10:00
Lachlan Roberts c67ac736df implement serializable for auth in cluster 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-09-10 10:21:38 +10:00
Lachlan Roberts 9134def345 OpenIdAuthenticator javadoc update 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-09-09 17:34:39 +10:00
Lachlan Roberts dc26739502 changes from review 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-09-09 16:58:36 +10:00
Lachlan Roberts be69598a48 add javadoc 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-09-09 14:57:35 +10:00
Lachlan Roberts 2770afb280 fix claim validation 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-09-06 16:03:22 +10:00
Lachlan Roberts f592e63711 add configuration to authenticate new users with a base LoginService 
improved comments

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-08-30 14:33:41 +10:00
Lachlan Roberts 19369636e3 add additional validation, renaming and cleanups 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-08-29 17:47:37 +10:00
Lachlan Roberts d33b96f411 add OpenId module to support OpenId Connect authentication 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
 2019-08-29 08:03:11 +10:00