Commit Graph

100 Commits

Author SHA1 Message Date
Joakim Erdfelt a9c596e3d7
Updating various old/moved URL references found across project (`jetty-10.0.x`) (#10098)
* Now that the migration of `https://eclipse.org/jetty/` to `https://eclipse.dev/jetty/` has occurred, it is time to review the URI use in our project

+ Updated URLs in poms
+ Added more URIs to XmlConfiguration
+ Updated URLs in module files
+ Updated URLs in documentation
+ Updated URLs in HTML
+ Correcting bad double-scheme URLs (eg: `http://https://www.eclipse...`)
+ Updating text in *.mod files
+ Removing `/current/` from path `/jetty/documentation/current/`
+ Fixing mailing list URL

---------

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2023-07-14 12:38:45 -05:00
Lachlan 24b7d06fd5
Issue #9464 - Add optional configuration to log user out after OpenID idToken expires. (Jetty-10) (#9528)
* improvements to logout from the OpenIdLoginService validate
* respect idToken expiry for lifetime of login
* fix checkstyle error
* Add respectIdTokenExpiry configuration
* changes from review
* rename respectIdTokenExpiry to logoutWhenIdTokenIsExpired
* changes from review

---------

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2023-04-11 12:20:16 +10:00
gregw 7a7d69a69f Happy no year
Remove modification date from copyright notice and instead just have the
project inception year.

Signed-off-by: gregw <gregw@webtide.com>
2023-02-15 15:22:32 +11:00
Lachlan Roberts c60f38f387 Issue #8330 - fix persistence of sessions in OpenID
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-11-01 12:01:24 +11:00
Lachlan Roberts 41d4a3263c add test to replicate issue with OpenId Session serialization
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-11-01 12:01:23 +11:00
Lachlan Roberts c38b3261f4 Issue #8216 - fix broken test OpenIdAuthenticationTest
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-07-13 15:28:21 +10:00
Lachlan Roberts 6de385eac8 Issue #8216 - change logic on when to redirect
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-07-13 13:37:12 +10:00
Lachlan Roberts 90fe5621f9 Issue #8216 - improve testing for end_session_endpoint
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-07-12 15:17:08 +10:00
Lachlan Roberts 26732c90a0 Issue #8216 - Use HttpServletRequest.logout() for openid end_session_endpoint redirect
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-07-12 12:40:45 +10:00
Lachlan Roberts 92cf466801 Merge commit '5282ca37ef7a81789b3c1d0a41854259898bce96' into jetty-10.0.x-8216-openid-logout 2022-07-12 11:52:09 +10:00
Lachlan Roberts ec14acb322 Issue #8216 - changes from review
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-07-04 13:44:56 +10:00
Lachlan Roberts 057519f985 Issue #8216 - changes from review
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-07-04 13:31:20 +10:00
Lachlan Roberts 2613917668 Issue #8216 - changes from review
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-07-04 11:53:46 +10:00
keller-j 5282ca37ef Issue #8216 - provide logout for OpenID via OpenidAuthenticator
Signed-off-by: Johannes Keller <keller.johannes95@gmail.com>
2022-06-29 18:01:00 +02:00
Lachlan Roberts b2aa22fd8f Issue #8216 - make processing of metadata in OpenIdConfiguration extensible
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-06-29 18:24:51 +10:00
Lachlan Roberts 5fe999caa2 Issue #7545 - changes from review
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-02-08 15:59:23 +11:00
Lachlan Roberts e1d149f84c Issue #7545 - add name annotations for args in OpenIdConfiguration constructor
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2022-02-08 15:28:54 +11:00
Joakim Erdfelt cb127793e5
Happy New Year 2022 (#7459)
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2022-01-27 10:42:30 -06:00
Lachlan Roberts 2a5197216d Issue #7042 - remove init param to set authenticateNewUsers per webapp
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-11-10 18:19:51 +11:00
Lachlan Roberts 2a3c65c164 Issue #7042 - if only 1 OpenIdConfig available select it regardless of realm name
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-11-10 18:16:22 +11:00
Lachlan Roberts f12d6f5b6c Issue #7042 - Changes from review
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-11-10 10:22:50 +11:00
Lachlan Roberts deb4e203a4 Issue #7042 - add name arguments to jetty-openid.xml
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-11-05 10:45:15 +11:00
Lachlan Roberts b8af57153a Issue #7042 - Allow OpenIdConfiguration to be selected based on realm name.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-10-26 09:54:00 +11:00
Simone Bordet 0412bdc3d9 Fixes #6938 - module-info.java file do not use the canonical order for the elements
Changed order of entries in module-info.java to be canonical

(cherry picked from commit 02691171d5)
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-10-01 09:25:55 +02:00
Lachlan c150ce6859
Merge pull request #6621 from eclipse/jetty-10.0.x-6617-openidBasicAuth
Issue #6617 - add support for the client_secret_basic authentication method
2021-08-19 16:19:15 +10:00
Lachlan Roberts 50798ff504 Issue #6617 - change jetty property name to jetty.openid.authMethod
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-08-18 10:43:50 +10:00
Lachlan Roberts af316e58ff Issue #6618 - Use a new OpenIdCredentials constructor instead of static method.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-08-17 13:31:49 +10:00
Lachlan Roberts b0503091c2 Use correct auth method string in OpenIdConfiguration default constructor
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-08-17 09:24:02 +10:00
Lachlan Roberts b91c3fdbb0 Issue #6617 - add support for the client_secret_basic authentication method
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-08-16 15:43:19 +10:00
Lachlan Roberts 9af67f8bff Issue #6618 - azp claim should not be required for single value aud array
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-08-16 10:45:26 +10:00
Lachlan Roberts 8fee07aca8 Issue #6205 - Fix serialization issues in OpenIdAuthenticator
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-05-12 17:10:22 +02:00
Lachlan e9f260f4c3
Issue #6205 - Fix issues with OpenID redirecting to wrong URI (#6211)
Use the OpenID state param to map to the redirect URI.
2021-05-10 15:19:07 +10:00
Joakim Erdfelt d6ec96fe1b
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x 2021-02-15 14:18:08 -06:00
Joakim Erdfelt 5dd987779c
Adding `WhitespaceAfter` checkstyle rule.
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-02-15 12:48:24 -06:00
Joakim Erdfelt e81c847998
Happy New Year 2021 (Jetty 10 edition)
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-01-21 15:05:57 -06:00
Joakim Erdfelt 176e29e408
Happy New Year 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-01-21 12:31:00 -06:00
Joakim Erdfelt f0badc5c5e
Issue #5784 - Fixing source header text: EPL-2.0 OR Apache-2.0
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-12-10 16:04:50 -06:00
gregw f37ad023a8 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x
Signed-off-by: gregw <gregw@webtide.com>
2020-11-18 11:20:48 +01:00
Greg Wilkins 14f94f738d
Issue #5605 unconsumed input on sendError (#5637)
* Issue #5605 unconsumed input on sendError

Add Connection:close if content can't be consumed during a sendError. Processed after the request has returned to the container.

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Update from review

 + Add close on all uncommitted requests when content cannot be consumed.

* Update from review

 + fixed comment
 + space comma

* Only consume input in COMPLETE if response is >=200 (ie not an upgrade or similar)

* Updated to be less adventurous

I do not think it was valid to always consumeAll in COMPLETE as this could break upgrades with both 101s and 200s
Instead I have reverted to having this consumeAll logic only:
 + in sendError once control has passed back to the container and we are about to generate an error page.
 + in front of all the sendRedirection that we do without calling the application first.

Extra tests also added

* Updated to be less adventurous

reverted test

* Testcase for odd sendError(400) issue.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Fix for odd sendError(400) issue.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

* Testcase for odd sendError(400) issue.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Always try to consumeAll on all requests

* Refinements after testing in 10

* Refinements after testing in 10

Fixed test

* Fixed comment from review

* Updates from review

+ added redirect methods that consumeAll
+ ensureContentConsumedOrConnectionClose renamed to ensureConsumeAllOrNotPersistent
+ ensureConsumeAllOrNotPersistent now handles HTTP/1.0 and HTTP/1.1 differently

* better consumeAll implementation

* update from review

 + better javadoc
 + filter out keep-alive
 + added more tests

* update from review

 + better javadoc

* update from review

 + fixed form redirection test for http 1.0 and 1.1

* update from review

 + HttpGenerator removes keep-alive if close present
 + Use isRedirection

Co-authored-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-18 10:40:05 +01:00
Lachlan Roberts bcc859fcf6 Issue #5321 - add some missing module-info.java files
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-09-24 15:09:38 +10:00
Chris Walker 70c8822eef
Updated module descriptions for consistency. Resolves #5313 2020-09-23 13:10:47 -05:00
Greg Wilkins 780e1207c7
Issue #5254 List/Show modules (#5257)
* Issue #5254 List/Show modules

 * simplified --list-modules output
 * added --show-module

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* improve module descriptions

Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-09-14 18:07:16 +02:00
Lachlan Roberts 7ea35d78c5 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x 2020-07-28 13:39:50 +10:00
Lachlan Roberts 5f2c96dc58 use the OpenID Token expiry time for the initial authentication only, and not for expiry of the session.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-07-27 10:02:38 +10:00
Lachlan Roberts f1b4bdbbf2 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-07-23 17:17:53 +10:00
Lachlan Roberts e03c740ee8 Issue #5064 - the OpenIdCredentials should be serializable
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-07-21 09:48:30 +10:00
Lachlan Roberts c09e4d6f86 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-07-16 08:46:29 +10:00
Lachlan Roberts de1b6745c5 the DO NOT EDIT comment in .mod files should start with '#'
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-07-15 16:47:22 +10:00
Greg Wilkins fb6a445639
Issue #4741 No Servlet Path (#4898)
* Issue #4741 HttpServletMapping

This completes the refactoring started in #4851, using
the HttpServletMapping field to avoid having the servletPath field
in the Request and instead have a pathInContext field.

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4741 HttpServletMapping

reverted ResourceService changes

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4741 HttpServletMapping

fixed gzip handler

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4741 HttpServletMapping

Fixed several TODOs left in the code
removed _contextPath field and used an attributes lookup for include
replaced setContextPaths with setContext

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4741 HttpServletMapping

Used the same pattern from the contextPath changes for servletPath and pathInfo.   Now the servletPathMapping is always set on the request and only if the dispatch is an include do the effected methods look deeper for the source values.

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4741 HttpServletMapping

Improved javadoc

Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-05-28 12:17:22 +02:00
Greg Wilkins 6694f94cd5 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-04-15 18:50:19 +02:00