26169491c9
Issue #3655 simplifications of Cookie handling
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 23:10:12 +02:00
2de5456790
Issue #3655 - Fixing javadoc
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-05-22 23:10:12 +02:00
5d267963a3
Issue #3655 - Cookie generation now complies with RFC6265 spaces
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-05-22 23:10:12 +02:00
fd542c2856
Merge pull request #3591 from eclipse/jetty-9.4.x-3550-QueuedThreadPool-cleanup
...
Jetty 9.4.x 3550 queued thread pool cleanup
2019-05-22 18:18:49 +02:00
b70d22fee8
Issue #3550 - QueuedThreadPool cleanup.
...
Improved code formatting.
Removed unnecessary code in doStop().
Now explicitly checking whether idleTimeout > 0 before shrinking.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-05-22 18:17:44 +02:00
2ba0c7bb79
Issue #3681
...
cacheContent type and avoid unnecessary character encoding calculations
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 14:12:52 +02:00
70311fe987
Issue #3681
...
minor cleanups
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 14:02:38 +02:00
4ac511ba13
Issue #3681
...
minor cleanups
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 13:00:48 +02:00
8578e684d8
Issue #3681
...
Even more benchmark variations
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 11:13:08 +02:00
2256c532be
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 10:30:25 +02:00
ab8670370f
Issue #3681
...
More benchmark variations
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 09:28:55 +02:00
52cc4f6c22
Issue #83 - reworked SessionTrackingTest to fix intermittent failures
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-22 17:16:52 +10:00
2d358cd4b3
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-3681-HttpFieldsOptimize
2019-05-22 08:30:00 +02:00
f4990dd0f5
prefer the field and variable name of coreSession instead of session
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-22 08:29:05 +02:00
491ff5eb93
rename WebSocketChannel to WebSocketCoreSession
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-22 08:29:05 +02:00
1e84a04682
Removed blank
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-22 08:27:53 +02:00
e8f11d3c7e
Added small performance improvements
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-22 08:27:53 +02:00
f07e59554b
Issue #3681
...
remove HttpFields instrumentation
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-21 15:26:52 +02:00
b0985c4ad4
Issue #3681
...
added iteration test to benchmark
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-21 15:06:16 +02:00
fd183af1cc
Issue #3681
...
instrumented HttpFields
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-21 14:26:01 +02:00
1458854d24
Issue #3681
...
Use LinkedHashMap<List<Pair>>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-21 13:59:52 +02:00
2831bfb159
Issue #3681
...
Better default HttpFields size with TODOs to tune.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-21 12:40:40 +02:00
5f1a8696b1
Issue #3681
...
Benchmark possible HttpFields lookup mechanisms
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-21 12:39:28 +02:00
5f62e0f2db
store shared websocket components as attributes and not beans
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-21 18:56:53 +10:00
e31009cb06
WebSocketCoreClient no longer stores configuration and can be shared
...
configuration moved to ClientUpgradeRequest
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-21 11:33:06 +10:00
a2465234c6
Merged branch 'jetty-9.4.x' into 'jetty-10.0.x'.
2019-05-20 11:04:24 +02:00
3af45f4c89
Merge pull request #3665 from eclipse/jetty-9.4.x-3663-remove-deps-in-wsclient-with-httpclient
...
Issue #3663 - Remove @Deprecation's from WebSocketClient
2019-05-20 10:55:43 +02:00
6e52c8cb61
Merge pull request #3632 from eclipse/jetty-9.4.x-3605-http2_client_channel_recycle
...
Fixes #3605 - IdleTimeout with Jetty HTTP/2 and InputStreamResponseListener
2019-05-20 10:38:01 +02:00
b0bc9c9200
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x
2019-05-17 16:47:45 +02:00
671d1cb2b8
Issue #3653 Ensure custom SecurityManager.checkPermission is used. ( #3654 )
...
* Issue #3653 Ensure custom SecurityManager.checkPermission is used.
2019-05-17 16:28:42 +02:00
2b227f121e
Issue #3550
...
I have modified the JMH benchmark to look at latency (by measuring throughput) for executing a job with low, medium and high concurrency. It looks like the JREs threadpool is not so bad in some load ranges, but once things get busy we are still a bit better. No significant difference is seen between previous QTP impl and the one in this PR.
```
Benchmark (size) (type) Mode Cnt Score Error Units
ThreadPoolBenchmark.testFew 200 ETP thrpt 3 129113.271 ± 10821.235 ops/s
ThreadPoolBenchmark.testFew 200 QTP thrpt 3 122970.794 ± 8702.327 ops/s
ThreadPoolBenchmark.testFew 200 QTP+ thrpt 3 121408.662 ± 12420.318 ops/s
ThreadPoolBenchmark.testSome 200 ETP thrpt 3 277400.574 ± 34433.710 ops/s
ThreadPoolBenchmark.testSome 200 QTP thrpt 3 244056.673 ± 60118.319 ops/s
ThreadPoolBenchmark.testSome 200 QTP+ thrpt 3 240686.913 ± 43104.941 ops/s
ThreadPoolBenchmark.testMany 200 ETP thrpt 3 679336.308 ± 157389.044 ops/s
ThreadPoolBenchmark.testMany 200 QTP thrpt 3 704502.083 ± 15624.325 ops/s
ThreadPoolBenchmark.testMany 200 QTP+ thrpt 3 708220.737 ± 3254.264 ops/s
```
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-17 15:35:18 +02:00
5760795f96
Corrected license header information
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-17 14:26:58 +02:00
d4ffef3de7
Added tests for UpgradeResponseAdapter
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-17 14:26:58 +02:00
d10f678e4c
Added tests for DateParser
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-17 14:26:58 +02:00
8b4e6a34ac
Added tests for HttpScheme
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-17 14:26:58 +02:00
646f9aa822
Added tests for NamedLiteral
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-17 14:26:58 +02:00
0b41386c0d
don't allow custom CoreClients to be supplied to JavaxClientContainer
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-17 16:54:09 +10:00
0eb90e41d1
Issue #3663 - Remove @Deprecation's from WebSocketClient
...
+ Those methods and constructors that had @Deprecation assigned
that urged the use of HttpClient directly are no longer
annotated as deprecated because of legitimate possibility of
a valid LinkageError
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-05-16 09:48:28 -05:00
4f90eb6533
Added Unit Tests to increase code coverage.
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-16 08:25:34 +02:00
c40a303e2c
allow live configuration of maxMessageSizes on JettyWebSocketSession
...
and set the configuration on supplied CoreClient to the Javax client container
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-16 15:50:20 +10:00
a115e92029
move maxMessageSize configuration from javax framehandler to session
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-16 15:43:38 +10:00
455cc3d2e2
improvements to the jetty-websocket configuration testing
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-16 15:43:22 +10:00
c68a1b6066
fix the websocket configuration problems shown by ClientConfigTest
...
correctly detect when a message has exceeded the max size in the sink
forward changes to the input buffer size to the connection in WSChannel
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-16 15:38:33 +10:00
7019c18117
refactor of javax WebSocketContainer configuration
...
the client and server subclasses of JavaxWebSocketContainer now
share a common configuration instance which is used as the default
configuration for both server and client endpoints
to do this a setter was added for the configuration on the CoreClient
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-16 15:38:12 +10:00
7ba77c0be4
add tests for jetty-websocket client configuration
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-16 15:37:46 +10:00
f0e4102896
Merge pull request #3657 from TheRealHaui/small-minor-performance-improvements
...
Using `isEmpty()` instead of testing size/length.
2019-05-15 21:29:07 +02:00
53c9a8c35a
Small minor performance improvements
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-15 20:23:45 +02:00
665b1929e0
Small minor performance improvements
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-15 20:17:33 +02:00
7e5dcda708
force websocket idle timeout default to be set on endpoint
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-15 12:39:04 +02:00
2782344d4c
revert ConfigurationCustomizer change from #3374
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-05-15 12:39:04 +02:00
Greg Wilkins
Joakim Erdfelt
Simone Bordet
Lachlan Roberts
Michael Hausegger
Jan Bartel