Lachlan
3651acc5c9
Merge pull request #3707 from lachlan-roberts/jetty-9.4.x-3683-multipart
...
Issue #3683 - ensure multipart files are still cleaned up if error occurs
2019-06-06 07:38:32 +10:00
Jan Bartel
bc3c650822
Issue #3729 Ensure java:comp/env creation threadsafe.
...
Also fixed and added some tests for locking of java:comp/env
Signed-off-by: Jan Bartel <janb@webtide.com>
2019-06-05 12:19:33 +02:00
Greg Wilkins
4db934a809
Issue #3729 concurrent JNDI access
...
+ made locking deep
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-06-05 12:00:32 +02:00
Greg Wilkins
7484651941
Issue #3729 concurrent JNDI access
...
+ concurrent map for the NamingContext bindings
+ refactored duplicate code into common methods
+ simplified deepBindSupport
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-06-04 19:32:53 +02:00
Simone Bordet
b96b4bfffe
Merge pull request #3714 from eclipse/jetty-9.4.x-3713-warn_deprecations_in_xml
...
#3713 - Emit warning when invoking deprecated method in Jetty XML.
2019-06-04 15:42:22 +02:00
Simone Bordet
2688ed55e5
Issue #3713 - Emit warning when invoking deprecated method in Jetty XML.
...
Added warnings for deprecated field get/set.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-06-04 10:24:13 +02:00
Lachlan
ac8303c45e
Merge pull request #3637 from lachlan-roberts/jetty-9.4.x-3498-websocket-suspend
...
Issue #3498 - jetty 9.4 websocket suspend for incoming frames
2019-06-04 13:42:24 +10:00
Lachlan Roberts
e75ca325fd
Issue #3683 - close part if failure occurs in MultiPartFormInputStream
...
parameterize MultiPartServletTest over compliance modes
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-06-04 12:03:24 +10:00
Lachlan Roberts
17b8eb8401
Issue #3683 - ensure multipart files are still cleaned up after errors
...
- do not parse MultiParts in constructor so the attribute can be set
- deleteParts in MultiPartFormInputStream from _parts MultiMap
- only add the MultiPartCleanerListener once per context
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-06-04 11:19:42 +10:00
Lachlan Roberts
970b030c4a
Issue #3683 - test multipart tmp files are deleted if error occurs
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-06-04 11:09:55 +10:00
Joakim Erdfelt
a6b2bd86ef
Issue #3698 - Changes based on review from @sbordet
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-06-03 15:52:41 -05:00
Joakim Erdfelt
54888d2541
Issue #3698 - Reworking WebSocket SCI's to be more flexible in embedded
...
+ Added new SCIOnStartupListener that allows for manual wiring up
of ServletContainerInitializers (with no bytecode scanning)
in embedded jetty usages
+ Introduced .initialized(context) and .configure(context) to both of
the websocket SCIs
+ Moved ClientConnectTest to jetty-websocket-tests
+ Moved WebSocketClientTest to jetty-websocket-tests
+ Made moved tests not use BlockheadServer
+ Made moved tests use new .configure(context, lambda) methods
+ Also allowing javax.websocket.server SCI implementation to
add ContextDestroyListener during the execution of another
ServletContextListener.
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-06-03 13:31:06 -05:00
Simone Bordet
5ebd6d4ad2
Merge pull request #3682 from eclipse/jetty-9.4.x-3681-HttpFieldsOptimize
...
Jetty 9.4.x 3681 http fields optimize
2019-06-03 16:51:58 +02:00
Simone Bordet
4058abd7c7
Issue #3713 - Emit warning when invoking deprecated method in Jetty XML.
...
Improved test case to test for log lines with deprecation warnings.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-06-03 16:08:33 +02:00
Simone Bordet
8dc9f745ff
Issue #3713 - Emit warning when invoking deprecated method in Jetty XML.
...
Fixed return value from varargs methods.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-06-03 16:07:45 +02:00
Jan Bartel
dec10044e0
Jetty 9.4.x 3722 session destroy listeners ( #3723 )
...
* Issue #3722 Use webapp classloader for HttpSessionListener.sessionDestroyed calls
2019-06-03 10:27:38 +02:00
Joakim Erdfelt
4e00f88946
Issue #3715 - Improve Log condensePackageString() performance
...
+ Removed regex usage
+ More unit tests
+ Adding jmh test for improvements (see PR #3716 for published results
of old vs new implementation)
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-05-31 10:57:38 -05:00
Joakim Erdfelt
ad3be199e8
Disabling broken slack notifications
2019-05-31 10:43:56 -05:00
Greg Wilkins
39be07871b
Issue #3681
...
updates from review
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-31 13:17:25 +02:00
Greg Wilkins
4d60260cd3
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-3681-HttpFieldsOptimize
2019-05-31 13:04:12 +02:00
olivier lamy
bea7806c77
single line notification
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-05-31 19:47:56 +10:00
Olivier Lamy
62fed86430
slack notification only for main branches ( #3717 )
...
* slack notification only for main branches
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-05-31 14:24:13 +10:00
Simone Bordet
fe94da9e46
Issue #3713 - Emit warning when invoking deprecated method in Jetty XML.
...
Added warnings for invocation of deprecated constructors and methods.
Moved methods exclusively used by XmlConfiguration from TypeUtil.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-05-30 22:27:27 +02:00
Simone Bordet
4bc4a60e8d
Code cleanup and reformatting.
...
Javadocs.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-05-30 19:22:37 +02:00
Simone Bordet
eb837293ad
Replaced usage of deprecated "replacement" with "location".
...
Code cleanup & formatting.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-05-30 14:39:28 +02:00
olivier lamy
d6dbf7cae0
this when is not working
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-05-30 21:34:10 +10:00
olivier lamy
5def2dff97
slack notif only for main branches
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-05-30 20:34:42 +10:00
Olivier Lamy
4184e15121
add slack notif when failure or unstable ( #3693 )
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-05-30 20:15:29 +10:00
Miron Balcerzak
4c11f245c9
Fixes #3332 jetty-maven-plugin - transitive deps in single war project ( #3349 )
...
* Issue #3332 jetty-maven-plugin - transitive deps in single war project
Signed-off-by: Miron Balcerzak <mironbalcerzak@gmail.com>
* Issue #3332 jetty-maven-plugin - code review fixes
Signed-off-by: Miron Balcerzak <mironbalcerzak@gmail.com>
* Issue #3332 jetty-maven-plugin - code review fixes
Signed-off-by: Miron Balcerzak <mironbalcerzak@gmail.com>
2019-05-30 20:12:47 +10:00
olivier lamy
c5d854b3fc
those artifacts are needed to build distribution so it must be declared as a dependency other can fail when using -pl option
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-05-30 18:30:03 +10:00
Simone Bordet
ae151583b0
Merge pull request #3710 from TheRealHaui/add-Unit-Tests-five
...
Add unit tests for websocket.
2019-05-29 21:09:41 +02:00
Michael Hausegger
fdcbb214f8
Added tests for decoders
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-29 17:43:19 +02:00
Greg Wilkins
0c61ec3e4d
Fix idle race by allowing idle count to go negative ( #3694 )
...
* Fix idle race by allowing idle count to go negative
* Fixed flakey dump test
* don't exit Runner on exceptions
* cleanup after pair programming with sbordet
* longer benchmark runs
* optimized by removing need to check isRunning
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Code reformatting.
* Fixed stop logic.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-05-29 17:24:01 +02:00
Michael Hausegger
564ac4a2d3
Added Unit Tests for ReflectUtil.
...
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-29 17:09:45 +02:00
Jan Bartel
8548a49200
Issue #3680 Remove config-only infinispan artifacts from bom. ( #3688 )
...
Signed-off-by: Jan Bartel <janb@webtide.com>
2019-05-28 13:42:10 +02:00
Jan Bartel
73b417a116
Issue #3690 Upgrade to asm 7.1 ( #3691 )
...
Signed-off-by: Jan Bartel <janb@webtide.com>
2019-05-28 13:39:14 +02:00
Greg Wilkins
cf9c238721
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-3681-HttpFieldsOptimize
2019-05-26 16:18:13 +02:00
Michael Hausegger
a3b755858d
Added additional Unit Tests to increase code coverage ( #3692 )
...
* Added additional Unit Tests to increase code coverage
Signed-off-by: Michael Hausegger <hausegger.michael@googlemail.com>
2019-05-24 16:24:40 +10:00
Greg Wilkins
53dc425bde
Issue #3681
...
updates from review
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-23 12:33:35 +02:00
Olivier Lamy
0ebc0fa9ce
Issue #3659 jmh tests are creating to many tmp files and never cleaned ( #3650 )
...
* cleanup tmp files created by jmh tests
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-05-23 14:12:44 +10:00
Olivier Lamy
f2c59a3cb7
add convenient StringUtil isEmpty method ( #3687 )
...
* add StringUtil.isEmpty
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-05-23 09:01:36 +10:00
Greg Wilkins
4dc004cf96
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-3681-HttpFieldsOptimize
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 23:26:48 +02:00
Greg Wilkins
0bf138f034
removed unused lines
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 23:10:12 +02:00
Greg Wilkins
065581edd9
cleanups
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 23:10:12 +02:00
Greg Wilkins
26169491c9
Issue #3655 simplifications of Cookie handling
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 23:10:12 +02:00
Joakim Erdfelt
2de5456790
Issue #3655 - Fixing javadoc
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-05-22 23:10:12 +02:00
Joakim Erdfelt
5d267963a3
Issue #3655 - Cookie generation now complies with RFC6265 spaces
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-05-22 23:10:12 +02:00
Simone Bordet
fd542c2856
Merge pull request #3591 from eclipse/jetty-9.4.x-3550-QueuedThreadPool-cleanup
...
Jetty 9.4.x 3550 queued thread pool cleanup
2019-05-22 18:18:49 +02:00
Simone Bordet
b70d22fee8
Issue #3550 - QueuedThreadPool cleanup.
...
Improved code formatting.
Removed unnecessary code in doStop().
Now explicitly checking whether idleTimeout > 0 before shrinking.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-05-22 18:17:44 +02:00
Greg Wilkins
2ba0c7bb79
Issue #3681
...
cacheContent type and avoid unnecessary character encoding calculations
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-05-22 14:12:52 +02:00