Commit Graph

15952 Commits

Author SHA1 Message Date
Lachlan a75fb6be17
Issue #321 - DeadCode JaspiAuthenticatorFactory.findServerName Server param not used
changes from review
2018-08-09 14:19:04 +10:00
lachan-roberts e285bc52c4 Issue #321 - DeadCode JaspiAuthenticatorFactory.findServerName Server param not used
added back a deprecated findServerName method with the previous signature which calls the new method

Signed-off-by: lachan-roberts <lachlan@webtide.com>
2018-08-08 11:06:00 +10:00
Lachlan Roberts 3029f30d2b Issue #321 - DeadCode JaspiAuthenticatorFactory.findServerName Server param not used
removed the subject parameter and instead get the subject from findServiceSubject(server)
contextPath String was not being used

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-08-07 13:37:09 +10:00
Jan Bartel 88d1ead25b
Issue #2754 Only instantiate listener if it will be used (#2763)
Signed-off-by: Jan Bartel <janb@webtide.com>
2018-08-07 12:23:09 +10:00
Greg Wilkins 9dd2369a53
Merge pull request #2752 from lachlan-roberts/jetty-9.4.x-2739-AuthenticationProtocolHandler
Issue #2739 - AuthenticationProtocolHandler Multiple Challenge Pattern
2018-08-07 10:45:43 +10:00
Simone Bordet 8eb11a56c8 Merged branch 'jetty-9.3.x' into 'jetty-9.4.x'. 2018-08-06 15:00:16 +02:00
Simone Bordet 289dc935f1 Merged branch 'jetty-9.2.x' into 'jetty-9.3.x'. 2018-08-06 12:55:09 +02:00
Simone Bordet da9c5fcae2 Fixes #2777 - Workaround for Conscrypt's ssl == null.
Isolated SSLEngine method calls and wrapped them into try/catch
blocks to ignore the NullPointerException thrown by Conscrypt.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-08-06 12:41:44 +02:00
lachan-roberts a60a8b8678 Issue #2739 - AuthenticationProtocolHandler Multiple Challenge Pattern
add header info's upfront and mutate the param map instead of adding them lazily

Signed-off-by: lachan-roberts <lachlan@webtide.com>
2018-08-06 17:39:26 +10:00
lachan-roberts f735c0427f Issue #2739 - AuthenticationProtocolHandler Multiple Challenge Pattern
process the param value with QuotedCSV.unquote()

Signed-off-by: lachan-roberts <lachlan@webtide.com>
2018-08-06 17:30:47 +10:00
lachan-roberts 96f5773e4f Issue #2739 - AuthenticationProtocolHandler Multiple Challenge Pattern
Increased complexity of regex in order to use only one regex pattern and reworked state machine into simple for loop

Signed-off-by: lachan-roberts <lachlan@webtide.com>
2018-08-06 11:42:52 +10:00
Olivier Lamy f4a0bfbdd8
Issue #2746 jmh module (#2750)
#2746 move jmh classes to a dedicated jmh module

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-08-04 14:08:13 +10:00
Joakim Erdfelt d36da55626
Merge pull request #2770 from eclipse/jetty-9.4.x-issue-2768-websocket-session-userproperties-null
Issue #2768 - JSR356 Session.getUserProperties() is null during @OnOpen
2018-08-03 08:16:10 -05:00
Simone Bordet 5cf256f3fd
Merge pull request #2766 from DavidShepherdson/Issue-#2762
Issue #2762: Fixed typo when checking JETTY_START_TIMEOUT.
2018-08-03 12:14:38 +02:00
Joakim Erdfelt 586484850f Issue #2768 - JSR356 Session.getUserProperties() is null during @OnOpen
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2018-08-02 09:16:34 -05:00
Joakim Erdfelt d37b506cb1 Adding mod & adoc to gitattributes 2018-08-02 08:57:58 -05:00
David Shepherdson b6bc2bea7a Issue #2762: Fixed typo when checking JETTY_START_TIMEOUT.
Signed-off-by: David Shepherdson <david@shepherdson.name>
2018-08-02 21:51:27 +10:00
Simone Bordet b561ee2734 Issue #2755 - ManagedSelector 100% CPU spin.
Now checking for thread interrupted only when select() reports 0 selected.
This will avoid the check in case of legit I/O wakeups.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-08-02 13:13:54 +02:00
Greg Wilkins 2cc90c2be5 Less verbose testing
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-08-02 16:41:06 +10:00
Joakim Erdfelt 321b4b4f7a Updating VERSION.txt 2018-08-01 12:26:58 -05:00
Simone Bordet 72c3feb7b9
Merge pull request #2758 from eclipse/jetty-9.4.x-2757-http2_network_buffer_release
Issue #2757 - Possible double release of HTTP/2 ByteBuffers.
2018-08-01 19:12:04 +02:00
Simone Bordet 34188fdaa8
Merge pull request #2756 from eclipse/jetty-9.4.x-2755-managed_selector_spin
Issue #2755 - Managed Selector 100% CPU Spin
2018-08-01 19:11:01 +02:00
Simone Bordet 8c296e7d52 Issue #2757 - Possible double release of HTTP/2 ByteBuffers.
Clarified the NetworkBuffer API semantic so that the code is now simpler.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-08-01 18:24:42 +02:00
Simone Bordet 0a336230ef Issue #2755 - ManagedSelector 100% CPU spin.
Avoid race between doStart() and doStop() by waiting in doStart()
for _started=true.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-08-01 17:25:46 +02:00
Simone Bordet a090741a60 Issue #2755 - ManagedSelector 100% CPU spin.
Added check for thread interrupted.
If interrupted and ManagedSelector is not running, bail out.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-08-01 16:57:08 +02:00
lachan-roberts 58f2b8f360 Issue #2739 - AuthenticationProtocolHandler Multiple Challenge Pattern
Splitting elements into list using QuotedCSV and processing with state machine instead of using regex to split into multiple challenges.

Signed-off-by: lachan-roberts <lachlan@webtide.com>
2018-07-31 19:26:10 +10:00
Olivier Lamy 0ba1d9b5a5
Issue #307 datecache contention (#2725)
* use DateTimeFormatter which is threadsafe so no need of synchronized block  #307

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-07-26 20:46:50 +10:00
Simone Bordet af880f119a
Merge pull request #2736 from eclipse/jetty-9.4.x-2679-h2spec_compliance
Jetty 9.4.x 2679 h2spec compliance
2018-07-21 17:26:14 +02:00
Simone Bordet 9a22dd820a Issue #2679 - h2spec compliance.
Integrated h2spec execution in the Maven build.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-07-21 15:55:43 +02:00
Simone Bordet 5e9a45eca1
Merge pull request #2742 from lachlan-roberts/jetty-9.4.x-2679-h2spec_compliance
Issue #2679 - h2spec compliance Huffman encoding
2018-07-21 14:16:48 +02:00
lachan-roberts b5e607068f Issue #2679 - HTTP/2 Spec Compliance
now handling padding over 7 bits with Exception
throwing CompressionExceptions instead of StreamExceptions
fixed issue with non terminal encoded strings

Signed-off-by: lachan-roberts <lachlan@webtide.com>
2018-07-21 22:10:12 +10:00
Simone Bordet 4b0becbbe0 Issue #2679 - h2spec compliance.
Fixed content-length compliance.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-07-21 12:52:44 +02:00
Simone Bordet 4ace2e4d8d Issue #2679 - h2spec compliance.
Integrated HPACK modifications to comply with the specification.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-07-21 11:42:31 +02:00
Lachlan Roberts da213d5876 Issue #2679 - HTTP/2 Spec Compliance
Now throwing exceptions for incorrect padding and EOS in content in Huffman.decode()

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-07-21 11:32:34 +10:00
Greg Wilkins cd0cf3d11f Issue #2706 - minor cleanup
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-07-20 16:03:27 +02:00
Greg Wilkins d6b7f8d71f
Merge pull request #2729 from lachlan-roberts/jetty-9.4.x-2706-ResourceService
Issue #2706 - Resource Service Incorrectly Returning 404
2018-07-20 15:29:09 +02:00
Lachlan Roberts a72fe7e3c7 Issue #2679 - HTTP/2 Spec Compliance
Added tests for the problems with the Huffman encoding

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-07-20 22:40:05 +10:00
Lachlan Roberts 8444681880 Issue #2706 - Resource Service Incorrectly Returning 404
changes from review

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-07-20 21:30:00 +10:00
Greg Wilkins cf3681ef56
Issue #1688 Encoded form content (#2733)
* Issue #1688 Encoded form content

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* fixes from review

Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-07-20 09:30:36 +02:00
Lachlan Roberts 0f3f77761f Issue #2706 - Resource Service Incorrectly Returning 404
Replaced the response.isCommitted() check with a boolean returned from _resourceService.doGet().
This means the response does not need to be committed for the check to work correctly.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-07-20 11:01:56 +10:00
Greg Wilkins 5e85ee851f
Merge pull request #2738 from lachlan-roberts/jetty-9.4.x-2737-AuthenicationProtocolHandler-ParamPattern
Issue #2737 - Allow "=" characters in the AuthenticationProtocolHandler PARAM_PATTERN
2018-07-19 17:19:48 +02:00
Greg Wilkins 0da9225056 dynamic table resize
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-07-19 13:49:40 +02:00
Lachlan Roberts 1373e90e32 Issue #2737 - Allow "=" characters in the AuthenticationProtocolHandler PARAM_PATTERN
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-07-19 21:26:59 +10:00
Greg Wilkins 971ca22367 8.1.2.3
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-07-19 12:50:54 +02:00
Greg Wilkins fa46013cf7 8.1.2.2
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-07-19 12:24:24 +02:00
Simone Bordet 0f4a1744f0 Merged branch 'jetty-9.4.x-2695-hpack-compliance' into 'jetty-9.4.x-2679-h2spec_compliance'. 2018-07-19 11:17:49 +02:00
Simone Bordet 4a65b44f6e Merged branch 'jetty-9.4.x' into 'jetty-9.4.x-2679-h2spec_compliance'. 2018-07-19 11:16:01 +02:00
Lachlan Roberts 648554ad5c Issue #2706 - Resource Service Incorrectly Returning 404
Removed response.flushBuffer() after writing to fix DefaultServletTest.testFiltered()

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-07-19 12:46:18 +10:00
Joakim Erdfelt d96aee4498
Merge pull request #2624 from eclipse/jetty-9.4.x-issue-1905-deprecate-jetty-runner
Issue #1905 - Deprecate jetty-runner
2018-07-18 15:28:11 -05:00
Simone Bordet a2af1a6c17
Merge pull request #2731 from eclipse/jetty-9.4.x-2730-limit_concurrent_pushes
Fixes #2730 - Limit concurrent HTTP/2 pushed resources.
2018-07-18 18:04:20 +02:00