Commit Graph

9650 Commits

Author SHA1 Message Date
Joakim Erdfelt ce48e7094d [FindBugs] Use java.utils.Arrays.hashCode
The method hashCode() of an raw array ignores the length and contents of the array
which yields equal hashCodes for arrays containing different items or varying in length.

This avoids unnecessarily returning equal hashCodes when the objects are actually different.
2014-07-17 08:17:18 +10:00
Joakim Erdfelt 347075ed2d [FindBugs] Possible Null Pointer Dereferences by values passed from caller 2014-07-17 08:16:57 +10:00
Joakim Erdfelt 1d0c370152 [FindBugs] Possible Null Pointer Dereferences by values passed from caller 2014-07-17 08:16:41 +10:00
Joakim Erdfelt a3c363832b [FindBugs] complaints about non-Boolean object used in %b format parameter 2014-07-17 08:14:55 +10:00
Greg Wilkins 409389ba6e 439652 GzipHandler super.doStart 2014-07-16 16:45:02 +10:00
Greg Wilkins 5f033b48d5 438204 leave IPv6 addresses [] wrapped in getServerName 2014-07-16 16:39:02 +10:00
Jan Bartel 50f11bea09 439663 Allow mappings to be declared before servlet/filter 2014-07-16 15:53:07 +10:00
Joakim Erdfelt dd5cdab54c 439540 - setReuseAddress() in ServerConnector.java is not coded properly
+ Adding unit test to confirm existing behavior of
  ServerConnector.setReuseAddress(boolean) and ServerConnector.open()
2014-07-15 17:02:51 -07:00
Simone Bordet 745f757552 Guarded calls to LOG.debug() with if (LOG.isDebugEnabled()) to reduce allocation of varargs Object[]. 2014-07-15 18:49:14 +02:00
Jesse McConnell 406eba7e26 testing autopush 2014-07-14 11:16:35 -05:00
Jan Bartel 28998e4913 439399 Scan tlds for apache jasper standard taglib with jetty-maven-plugin 2014-07-11 17:38:31 +10:00
Jan Bartel 5f77a0ef72 439394 load-on-startup with value 0 not preserved for quickstart 2014-07-11 16:25:32 +10:00
Jan Bartel d5c210f1c3 439390 Ensure jsp scratchdir is created same way for quickstart and non-quickstart 2014-07-11 16:06:40 +10:00
Jan Bartel 644eccab8b 439387 Ensure empty servlet-class never generated for quickstart 2014-07-11 14:16:24 +10:00
Jan Bartel c674c41003 438895 Add mvn jetty:effective-web-xml goal 2014-07-10 17:29:03 +10:00
Jan Bartel b13859c641 Fix javadoc for jetty:run mojo to point to correct documentation. 2014-07-10 17:29:03 +10:00
Greg Wilkins 55ca09a00e 438190 findbug improvements 2014-07-10 14:41:32 +10:00
Joakim Erdfelt 0c7de2e5bd 438331 - AbstractLogger.debug(String,long) infinite loop
+ Breaking infinit loop
2014-07-09 08:54:10 -07:00
Jan Bartel 5969638e69 439201 GzipFilter and AsyncGzipFilter should strip charset from Content-Type before making exclusion comparison in doFilter 2014-07-09 18:01:07 +10:00
Jan Bartel 10da0e1015 439194 Refactor mvn jetty:run-forked so that it is configurable the same as the other jetty:run-X goals 2014-07-09 15:07:39 +10:00
Greg Wilkins 0f70f28839 avoid race test failures 2014-07-03 15:10:48 +10:00
Greg Wilkins 7fbf521d4e 438204 correctly wrap IPv6 hostnames in URIs generated by jetty 2014-07-03 10:11:16 +10:00
Greg Wilkins 78b03c5b8e More debug for intermittent failures 2014-07-02 16:01:00 +10:00
Greg Wilkins 228600caf5 fixed race in HttpReceiverOverHTTPTest 2014-07-02 15:08:06 +10:00
Jan Bartel 839485797b 437419 Allow scanning of META-INF for resources,fragments,tlds for unpacked jars 2014-07-01 10:40:58 +10:00
Greg Wilkins 0751256559 438434 ResourceHandler checks aliases 2014-06-27 21:46:59 +02:00
Greg Wilkins a8964979b9 updated AliasConstraintTest to expected results 2014-06-27 21:02:07 +02:00
Greg Wilkins 9b764ef3fa 435322 Fixed Iterating Callback close 2014-06-27 20:43:12 +02:00
Joakim Erdfelt a68bf9139b Adding AliasedConstraintTest for working out alias logic 2014-06-26 16:11:05 -07:00
Joakim Erdfelt 6faf94e4c1 437462 - consistent test failure in jetty-start under windows
+ Fixing up logic to be more lenient for case insensitive nature of
  microsoft windows (it was tripping up over C:\ vs c:\ difference)
2014-06-26 15:29:05 -07:00
Joakim Erdfelt d49ecdf1d6 Minor tweak for windows testcase expecting IllegalArgumentException 2014-06-26 09:14:04 -07:00
Simone Bordet 17895f8256 438079 - Review garbage creation in 9.2.x series. 2014-06-26 13:16:08 +02:00
Simone Bordet 299d390dae Removed unnecessary reset of fields from onCompleteSuccess() and
onCompleteFailure().
They are not needed because these are methods that move the
IteratingCallback in a final state, so it won't be used anymore. And
if it is reset(), then those fields are already properly reset there.
2014-06-26 10:48:38 +02:00
Simone Bordet 4af586770e Cannot throw exceptions from reset(), must fail the callback instead. 2014-06-26 10:46:43 +02:00
Simone Bordet 2e57fb6fad Removed unnecessary volatile declaration.
Calls to reset() are always followed by iterate() that provides a memory barrier by changing its state, which is an AtomicReference.
2014-06-26 10:45:00 +02:00
Simone Bordet f2f19ee3ba Improved changes introduced by a746d78. 2014-06-26 10:08:13 +02:00
Simone Bordet 02271b29f5 Removed Action.FAILED, since it was never used and cluttered the
implementation. Subclasses should just either throw an exception or
directly call failed(Throwable).
2014-06-26 09:41:15 +02:00
Joakim Erdfelt 39079d4e84 Tweaking for windows test conditions 2014-06-25 15:29:18 -07:00
Joakim Erdfelt 728127dbb8 Marking surefie runMode to hopefully trigger more order dependent test failures 2014-06-25 15:29:18 -07:00
Greg Wilkins a746d78951 438079 435322 Fixed Iterating Callback fail handling and removed per send instance 2014-06-25 19:20:03 +02:00
Joakim Erdfelt 45a0690ba7 More PathResource updates.
+ Fixing up PathResource.list() per recommendations by @ash2k (on github)
+ Adding PathResource.getAlias() to conform to expectations
2014-06-25 10:07:41 -07:00
Simone Bordet 7b7c592fc8 Improved logging. 2014-06-25 17:26:04 +02:00
Joakim Erdfelt bad3165d8a Fixing jdk 8 test failure 2014-06-25 08:24:24 -07:00
Joakim Erdfelt 2a943887b6 437800 - URLs with single quote and spaces return 404
+ Expanded FileResourceTest
+ Added PathResource + PathResourceTest to show java.nio.file
  alternative approach (currently POC)
2014-06-25 06:53:22 -07:00
Simone Bordet 3ff4195dbc Guarded calls to LOG.debug() with if (LOG.isDebugEnabled()) to reduce allocation of varargs Object[]. 2014-06-25 12:26:45 +02:00
Greg Wilkins 28ad689bcb 437996 avoid async status race by not setting 200 on handled 2014-06-24 12:27:03 +02:00
Greg Wilkins 31ce7cabda 437800 Improved alias handling of different encodings 2014-06-24 11:32:56 +02:00
Jan Bartel fead772b64 437706 ServletTester calls LocalConnector method with hardcoded timeout 2014-06-24 10:43:15 +02:00
Joakim Erdfelt d92f6c6fd3 437395 - Start / Properties in template sections should be default applied for enabled modules
+ Fixing typo in enableModule()
+ Fixing concurrent modification exception during walk of parents in
  enableModule()
2014-06-19 10:18:51 -07:00
Simone Bordet 1fadf41464 Added ALPN debug configuration. 2014-06-19 16:59:02 +02:00