c40b955e09
Issue #5022 Filter Cache cleanup ( #5271 )
...
* Issue #5022 Filter Cache cleanup
Issue #5022 Filter Cache cleanup:
+ Fixed many compiler warnings
+ removed old LazyList leftovers
+ Don't create holder string for source unless required
+ Only have a single type of chain, so it can be wrapped regardless of cache
+ Reverse mappings lists to make filter chain creation easier
+ build chain directly rather than build a list then a chain
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* added comment to explain ordering
Signed-off-by: gregw <gregw@webtide.com>
* More cleanups
* fixed toString format
turn off debug in OSGI test
2020-10-05 13:29:11 +02:00
85e257fc98
Updating to version 9.4.33-SNAPSHOT
2020-09-30 11:53:09 -05:00
de97d26f7b
Updating to version 9.4.32.v20200930
2020-09-30 11:03:24 -05:00
eb02009f87
Issue #5365 ISE not NPE if fail to create session. ( #5370 )
...
If SessionHandler.newHttpSession(Request) fails to create a session
it returns null. Request.getSession(true) cannot throw a checked
exception, nor can it return null, so we should throw ISE.
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-09-30 16:51:54 +02:00
3423375a97
Issue #5357 - Updating to https://eclipse.org/ ( #5358 )
...
* Issue #5357 - Updating to https://eclipse.org/
- Removing redundant <url> refs in pom.xml
- Correcting bad indenting from merge
- Correcting mailing list references
- Correcting bugs.eclipse.org references
- Correcting text file references
- Correcting html references
- Correcting further references
- Correcting download.eclipse.org reference
- Adding test for demo-base /proxy/current/
- Ensuring jetty-client is included in javadoc-proxy.war/WEB-INF/lib
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-29 11:02:32 -05:00
7e627359b3
Merge pull request #5276 from eclipse/jetty-9.4.x-IncludeExcludeConnectionStatistics
...
update documentation for statistics collection
2020-09-25 15:20:04 +10:00
8fe32ce217
Merge pull request #5251 from eclipse/jetty-9.4.x-5247-forwarded-header-priority
...
Issue #5247 ForwardedRequestCustomizer authority order rework
2020-09-23 16:14:50 -05:00
ebfdf8fc1b
Issue #5247 - Updates from review by greg
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-21 10:34:28 -05:00
6cf6b78a16
Issue #5246 - Adding DeflaterPool to GzipHandler.dump
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-17 10:27:15 -05:00
290c98e9b1
Issue #5285 - Making Content-Encoding for form content consistent
...
+ Fixing unit test expectations
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-16 15:48:03 -05:00
844f134d21
Issue #5285 - Using Status code 415 Unsupported Media Type instead.
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-16 15:39:43 -05:00
bd589de512
Issue #5268 Change WARN to DEBUG for NullSessionCache eviction setter. ( #5270 )
...
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-09-16 11:27:07 +02:00
fbaabf5c8f
update documentation for statistics collection
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-09-16 15:48:27 +10:00
59b85b6288
Issue #5247 - Updating Javadoc on ForwardedRequestCustomizer
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-11 11:58:04 -05:00
a2233ce233
Issue #5247 - Introduce ForwardedRequestCustomizer.Priority enum
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-11 11:17:31 -05:00
ac42cbd143
Issue #5247 - Improve testing of ForwardedRequestCustomizer
...
+ Merge ProxyPass tests from CheckReverseProxyHeadersTest into
ForwardedRequestCustomizerTest
+ Deleted CheckReverseProxyHeadersTest.java
+ Add more tests for ForcedHost configuration
+ Updated ForwardedRequestCustomizer to conform to expectations
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-11 11:11:09 -05:00
4280303046
Issue #5247 - Document ForwardedRequestCustomizer authority search order
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-09 15:20:21 -05:00
f74cada660
Issue #5247 - Priority based ForwardedRequestCustomizer
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-09 14:56:33 -05:00
165e59b3e2
Merge pull request #5226 from eclipse/jetty-9.4.x-5224-xforwarded-multiple-ports
...
Issue #5224 X-Forwarded-Host support for port
2020-09-09 11:37:33 -05:00
2896ed31d6
Issue #5224 - Updating ForwardedRequestCustomizerTest expectations
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-08 12:34:53 -05:00
56b1d17d79
Issue #5233 - correcting NCSARequestLogTest expectation on unsupported version
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-08 05:59:41 -05:00
b2e0f69ea8
Issue #5233 - Bad/Unsupported HTTP version should return 505 not 400.
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-04 12:23:11 -05:00
5fef14019a
Merge pull request #5215 from eclipse/jetty-9.4.x-5214-head-huge-static
...
Issue #5214 - Servlet HEAD doesn't support content-length over Integer.MAX_VALUE
2020-09-02 12:54:38 -05:00
e2134b13d7
Issue #5224 - X-Forwarded-Host support for port
...
+ More test cases
+ Allowing X-Forwarded-Host to parse port (if present properly)
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-02 10:27:33 -05:00
e4ca153364
Issue #5224 - Test to replicate reported issue
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-09-02 09:34:16 -05:00
ef0c752476
Issue #4888 Ensure HttpSessionListener can access session via ( #5220 )
...
Issue #4888 Ensure HttpSessionListener can call Request.getSession
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-09-02 11:53:23 +02:00
a6b7f73019
Merge branch 'jetty-9.4.x-5214-head-huge-static' of https://github.com/eclipse/jetty.project into jetty-9.4.x-5214-head-huge-static
2020-08-31 18:22:10 +02:00
9e326fe520
+ improved sentinels values for content-length
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-08-31 18:19:11 +02:00
9128fc48e4
Cleanup dead code in ResourceService
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-08-31 11:16:22 -05:00
dcb06d3c35
Issue #5214 - Use known content_length when in HEAD mode
...
+ Adding DefaultServlet.doHead() to avoid servlet wrapping
+ Making ResourceService HEAD aware
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-08-31 11:03:49 -05:00
eba360f662
Issue #5214 - Use known content_length when in bypass write
...
+ In the case of HEAD, the servlet-api response is a wrapper
of javax.servlet.http.HttpServlet$NoBodyResponse
We know the content_length, use it.
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-08-31 09:43:04 -05:00
001def4905
Merge pull request #5175 from eclipse/jetty-9.4.x-5105-StatisticsHandler
...
Issue #5105 - StatisticsHandler Graceful Shutdown of Async Requests
2020-08-28 11:54:45 +10:00
a9c90d3309
Issue #5105 - change asyncGraceful to gracefulShutdownWaitsForRequests
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-08-27 08:59:13 +10:00
8edb7682cd
DebugHandler should use isAsyncStarted() instead of isSuspended()
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-08-25 10:40:09 +10:00
2d5da1fa35
StatisticsHandler should still return 503 responses on shutdown
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-08-25 10:34:59 +10:00
8faa71818f
change addToAllConnectors method to addBeanToAllConnectors
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-08-25 10:22:18 +10:00
c0268c590f
change name of waitForSuspendedRequestsOnShutdown to asyncGraceful
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-08-24 16:19:59 +10:00
623d1be7c7
Change the way ConnectorStatistics is added to the Servers Connectors
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-08-21 15:45:58 +10:00
70a679f5f4
reorder some CustomRequestLog methods to be same as jetty-10
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-08-21 10:29:22 +10:00
12381e9cf5
cleanup various warnings and TODOs in CustomRequestLog
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-08-20 12:02:00 +10:00
0fae221afa
Issue #5105 - fix GracefulStopTest expectations from 503s to 404s
...
StatisticsHandler no longer gives 503 responses after shutdown.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-08-20 07:27:12 +10:00
a65f00156d
Issue #5105 - add optional configuration to not wait for suspended requests in StatisticsHandler
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-08-20 07:27:12 +10:00
32358b1b77
Issue #5105 - fix StatisticsHandler bug with async dispatched requests
...
If the request is async dispatched, the check state.isSuspended() is not
correct to determine if the request was async or not. The check
state.isAsyncStarted() should be used instead.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-08-20 07:27:12 +10:00
a46ed5b5f0
Also manage graceful shutdown of already started async requests
...
Signed-off-by: Thomas Draebing <thomas.draebing@sap.com>
2020-08-19 09:59:21 +02:00
7b3dccc1bf
Issue #5104 - AbstractProxyServlet include incorrect protocol version in Via header when accessed over H2.
...
Added HttpFields.computeField() for HttpHeader too and updated usages.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-08-13 11:50:43 +02:00
79d340fdb6
Fixes #5104 - AbstractProxyServlet include incorrect protocol version in Via header when accessed over H2.
...
* Introduced HttpFields.computeField() to put/append header values.
* Reworked AbstractProxyServlet.addViaHeader().
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-08-13 00:08:52 +02:00
dd4c1dbac0
Merged branch 'jetty-9.4.x' into 'jetty-9.4.x-5079-ipv6_brackets'.
2020-08-08 23:21:14 +02:00
dcf867cd2b
Issue #3916 - Improve multi range response Content-Length calc
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-08-08 11:34:25 -05:00
2206b3edae
Issue #3916 - Fixing broken Content-Length evaluation
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-08-08 07:18:02 -05:00
d53d9d8a1d
Fixes #5079 - :authority header for IPv6 address not having square brackets.
...
On the client:
* Origin.Address.host is passed through HostPort.normalizeHost(),
so that if it is IPv6 is bracketed.
Now the ipv6 address passed to an `HttClient` request is bracketed.
* HttpRequest was de-bracketing the host, but now it does not anymore.
On the server:
* Request.getLocalAddr(), getLocalName(), getRemoteAddr(),
getRemoteHost(), getServerName(), when dealing with an IPv6 address,
return it bracketed.
The reason to return bracketed IPv6 also from *Addr() methods is that
if it is used with InetAddress/InetSocketAddress it still works, but
often it is interpreted as a URI host so brackets are necessary.
* DoSFilter was blindly bracketing - now it does not.
Added a number of test cases, and fixed those that expected
non-bracketed IPv6.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-08-07 15:53:19 +02:00
Greg Wilkins
Joakim Erdfelt
Jan Bartel
Lachlan
Thomas Draebing
Simone Bordet