Commit Graph

21046 Commits

Author SHA1 Message Date
Lachlan Roberts 66ef0ebc03 Issue #4903 - do ServerEndpointConfig validation check before started
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-06-11 19:20:49 +10:00
olivier lamy c48aee0a54 maven war plugin 3.3.0
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-06-11 10:08:41 +10:00
Lachlan Roberts f41f601e19 Issue #4903 - fix validation on custom Configurator annotated endpoint
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-06-11 09:58:49 +10:00
Joakim Erdfelt b22e306796
Issue #4903 - Improved behavior for Custom ServerEndpointConfig.Configurator
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-06-10 17:03:26 -05:00
Jan Bartel cb09abe873
Issue #4920 Restore ability to invalidate sessions on shutdown (#4933)
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-06-10 18:40:19 +02:00
Joakim Erdfelt 9bfc168329
Issue #4903 - Improved behavior for Custom ServerEndpointConfig.Configurator
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-06-10 11:01:30 -05:00
olivier lamy cbda92ab8c add olamy key
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-06-10 16:20:58 +10:00
Lachlan 122cbe28ed
Merge pull request #4952 from eclipse/jetty-10.0.x-websocketJpmsWarnings
fix websocket JPMS warnings and build issues
2020-06-10 08:37:17 +10:00
Simone Bordet 207336338e Merged branch 'jetty-9.4.x' into 'jetty-10.0.x'. 2020-06-09 17:08:31 +02:00
Simone Bordet 1d16310bd2
Merge pull request #4953 from lorban/jetty-9.4.x-4855-h2spec-8-1-2-6-failure
Fix h2spec 8.1.2.6 test failure
2020-06-09 17:07:22 +02:00
Ludovic Orban 714a9204b3 #4855 fix race condition that can sometimes make H2 stream send an improper reset with cancel error code instead of protocol error code when the client sends more data than the content-length header specifies
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-06-09 16:59:49 +02:00
Lachlan Roberts 5fc90cc6db fix websocket JPMS warnings and build issues
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-06-10 00:36:49 +10:00
Simone Bordet dd6cd4b881 Merged branch 'jetty-9.4.x' into 'jetty-10.0.x'. 2020-06-09 16:11:53 +02:00
Simone Bordet 56bda1b3ae
Jetty 9.4.x 4855 h2spec failures (#4946)
* Fixes #4855 - Occasional h2spec failures on CI

In case of bad usage of the HTTP/2 API, we don't want to close()
the stream but just fail the callback, because the stream
may be performing actions triggered by a legit API usage.

In case of a call to `AsyncListener.onError()`, applications may decide to call
AsyncContext.complete() and that would be a correct usage of the Servlet API.
This case was not well handled and was wrongly producing a WARN log with an
`IllegalStateException`.

Completely rewritten `HttpTransportOverHTTP2.TransportCallback`.
The rewrite handles correctly asynchronous failures that now are executed
sequentially (and not concurrently) with writes.
If a write is in progress, the failure will just change the state and at the
end of the write a check on the state will determine what actions to take.

A session failure is now handled in HTTP2Session by first failing all the
streams - which notifies the Stream.Listeners - and then failing the session
- which notifies the Session.Listener.
The stream failures are executed concurrently by dispatching each one to a
different thread; this means that the stream failure callbacks are executed
concurrently (likely sending RST_STREAM frames).
The session failure callback is completed only when all the stream failure
callbacks have completed, to ensure that a GOAWAY frame is processed after
all the RST_STREAM frames.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-06-09 13:15:05 +02:00
Ludovic Orban eb6db0db66
#4855 disable racy h2spec test (#4950)
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-06-09 09:48:15 +02:00
olivier lamy c80f841798 fix license header
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-06-07 21:32:34 +10:00
olivier lamy 004cdc9c0b fix merge of what-version.adoc
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-06-07 20:55:28 +10:00
olivier lamy 2f570db004 fix bad merge
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-06-07 10:06:01 +10:00
olivier lamy fdc4cabc6b fix bad merge
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-06-07 09:48:43 +10:00
olivier lamy 593d3e9aa6 remove duplicate dependency
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-06-07 09:31:44 +10:00
olivier lamy 2413f551f1 Merge branch 'jetty-9.4.x' into jetty-10.0.x 2020-06-07 09:30:54 +10:00
Chris Walker 7c1d290d89
Added Jetty 11 to version matrix 2020-06-06 13:42:29 -05:00
Joakim Erdfelt eac4187a29
Merge pull request #4940 from eclipse/jetty-9.4.x-4939-accept_queue_size_docs
Fixes #4939 - acceptorQueueSize [sic]
2020-06-04 14:01:54 -05:00
Joakim Erdfelt c75f1b3888
Adding note to Example code about it not being secure
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-06-04 12:00:48 -05:00
Simone Bordet 029470c5dc Fixes #4939 - acceptorQueueSize [sic]
acceptorQueueSize -> acceptQueueSize.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-06-04 18:31:40 +02:00
Simone Bordet 9c6ffae77b Merged branch 'jetty-9.4.x' into 'jetty-10.0.x'. 2020-06-04 11:51:34 +02:00
Simone Bordet b904a5cc85 Do not assume the ByteBuffer has a backing byte array.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-06-04 11:49:42 +02:00
olivier lamy 57d4714a08 remove test
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-06-04 14:35:48 +10:00
olivier lamy 1aaf22cdc1 temporary debug
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-06-04 13:30:16 +10:00
Lachlan Roberts 86ea115e1f Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x 2020-06-04 09:27:43 +10:00
Lachlan Roberts 38f56f5973 make some test methods public to fix build
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-06-04 09:26:35 +10:00
Joakim Erdfelt 426795660f
Cleaning up double-merge final issues.
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-06-03 16:14:32 -05:00
Joakim Erdfelt 90c1fc668c
Merge branch 'jetty-10.0.x' of github.com:eclipse/jetty.project into jetty-10.0.x 2020-06-03 16:10:51 -05:00
Joakim Erdfelt 0cce039e7c
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x 2020-06-03 16:10:41 -05:00
Greg Wilkins 0f48708922 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-06-03 23:01:52 +02:00
Greg Wilkins ff8ae56fa9
Issue #4936 response buffer corruption (#4937)
* Issue #4936 - Adding LargeHeaderTest to replicate issue

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Issue #4936 - Updating LargeHeaderTest to use ServerConnector

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Issue #4936 - Fail LargeHeaderTest if client detects issues.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Issue #4936 large response header buffer corruption

If the response buffer is too large, the header buffer was released
but not nulled, then an exception thrown, which again released the
not nulled buffer.  The buffer thus ends up in the buffer pool twice!

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4936 large response header buffer corruption

removed old comment

Signed-off-by: Greg Wilkins <gregw@webtide.com>

Co-authored-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-06-03 22:54:12 +02:00
Joakim Erdfelt 2834f93447
Merge pull request #4935 from lorban/jetty-9.4.x-4877-fix-PathMappings-get
#4877 fix PathSpec long-standing bugs and shortcomings
2020-06-03 11:46:38 -05:00
Ludovic Orban e43c98f08d Signed-off-by: Ludovic Orban <lorban@bitronix.be> 2020-06-03 17:58:01 +02:00
Ludovic Orban 6c62157865 Signed-off-by: Ludovic Orban <lorban@bitronix.be> 2020-06-03 16:30:26 +02:00
Jan Bartel 5d328ba928 Suppress debug stacktrace for TestFileSessions.testSweep
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-06-03 10:26:13 +02:00
Jan Bartel 7d8f543fc1 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x 2020-06-03 10:11:43 +02:00
Jan Bartel 74a2ce7a42
Issue #4826 Upgrade to apache jsp 8.5.54 (#4932)
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-06-03 10:04:55 +02:00
Lachlan Roberts 286ee6868a Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x 2020-06-03 12:36:10 +10:00
Lachlan f671cf6512
Merge pull request #4884 from lorban/jetty-9.4.x-4877-pathSpec
Refactor PathSpec and fix javax.websocket URI Template matching
2020-06-03 11:50:09 +10:00
Simone Bordet 5308adab60 Merged branch 'jetty-9.4.x' into 'jetty-10.0.x'. 2020-06-01 22:02:59 +02:00
Simone Bordet 88a139628f
Merge pull request #4930 from eclipse/jetty-9.4.x-4929-request_cookies_not_sent_when_cookiestore_empty
Fixes #4929 - HttpClient: HttpCookieStore.Empty prevents sending cook…
2020-06-01 21:55:56 +02:00
Simone Bordet b8b88b238e Merged branch 'jetty-9.4.x' into 'jetty-10.0.x'. 2020-06-01 17:24:36 +02:00
Simone Bordet 4277759a85 Fixes #4904 - WebsocketClient creates more connections than needed.
After merge fixes.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-06-01 17:19:31 +02:00
Simone Bordet 46c62d48d2 Fixes #4929 - HttpClient: HttpCookieStore.Empty prevents sending cookies.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-06-01 17:02:28 +02:00
Joakim Erdfelt 41440b6c2c
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x 2020-06-01 09:40:43 -05:00