15764 Commits

Author SHA1 Message Date
Konstantin Lutovich
25888f0d83 Fix NPE in PreEncodedHttpField constructor (#2488)
Which might happen when given `HttpHeader` is null. It might be null
when most generic constructor `#PreEncodedHttpField(HttpHeader, String, String)`
is invoked with a null argument or when `#PreEncodedHttpField(String, String)`
constructor is used. Later is valuable for custom headers. NPE happens
because of an attempt to call `HttpHeader#asString()` on a null argument.

This commit fixes the problem by making encoders use specified header
name, instead of trying to retrieve it from the `HttpHeader` object.

Signed-off-by: lutovich <konstantin.lutovich@neo4j.com>
2018-04-26 08:35:24 +10:00
Simone Bordet
ed51c4a9e6
Merge pull request #2449 from lachlan-roberts/jetty-9.4.x-1555-wwwAuthenticate-Parsing
Fixes #1555 AuthenticationProtocolHandler unable to parse Digest WWW Header.
2018-04-26 00:02:54 +02:00
Joakim Erdfelt
0ea704a29a Fixing merge issue 2018-04-25 16:30:47 -05:00
Olivier Lamy
47586c5449
Fix typo (#2480)
* fix typo for #2403

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>

* default url to download artifacts must be https per default #2472

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>

* use dot rather than dashes

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>

* use central.maven.org as default

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-26 06:20:01 +10:00
Simone Bordet
0a4d62c91d
Issue #2468 - EWYK concurrent produce (#2477)
Fixes #2468 - EWYK concurrent production.

Fixed the case when a task throws an exception, which causes
the thread that ran the task to continue production, even
when it should not.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-04-25 17:59:58 +02:00
Simone Bordet
c4e1e8f454 Moved method onFlushed() to ISession.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-04-25 15:11:24 +02:00
Olivier Lamy
d64d0348b7
test some Jenkinsfile changes (#2471)
* maven 3.5

* add surefire timeout to avoid build stuck
2018-04-25 19:29:21 +10:00
Lachlan Roberts
04ae33c4ac Switched getHeaderInfo from recursion to iteration.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-04-25 16:09:55 +10:00
Assim Deodia
eeeffed73a AsyncMiddleManServlet.Transparent class wrongly extends ProxyServlet
`AsyncMiddleManServlet.Transparent` class should extend `AsyncMiddleManServlet`
so the consumers can override the `newServerResponseContentTransformer` &
`newServerResponseContentTransformer` to provide their own ContentTransformer.

The way it is structured right now makes it impossible to use
`AsyncMiddleManServlet.Transparent` servlet as a middle man servlet.

Signed-off-by: Assim Deodia <assim.deodia@gmail.com>
2018-04-24 18:12:00 -07:00
Olivier Lamy
fbbf5d2d2d
allow --add-to-start to specify maven repository location #2403 (#2473)
* allow --add-to-start to specify maven repository location #2403

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-25 10:57:45 +10:00
Joakim Erdfelt
1c0bbae9cc Issue #2376 - Applying recommended scope changes 2018-04-24 16:30:01 -05:00
Simone Bordet
525579a395
Merge pull request #2475 from eclipse/jetty-9.4.x-2474-http2_client_invalid_server
Issue #2474 - HTTP/2 client not handling invalid servers correctly.
2018-04-24 10:44:27 +02:00
Lachlan Roberts
7adad0bdc6 Merge remote-tracking branch 'origin/jetty-9.4.x-1555-wwwAuthenticate-Parsing' into jetty-9.4.x-1555-wwwAuthenticate-Parsing 2018-04-24 11:28:44 +10:00
Lachlan Roberts
fc5c438d72 Changes after review 1
Changed the base64 pattern to only accept token68 pattern from rfc7235#appendix-C
Add limit to recusion depth of multiple challange matching to stop any vulnerablilties related to malicious server overflowing client stack
Regex no longer allows trailing whitespace

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-04-24 11:16:31 +10:00
Simone Bordet
d7dac7ea1d Issue #2474 - HTTP/2 client not handling invalid servers correctly.
Fixed by start reading from the server after the session
promise has been notified, which may send the first request.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-04-23 20:04:25 +02:00
Olivier Lamy
571232d4ce
change thread number to test on the build platform 2018-04-22 09:47:28 +10:00
olivier lamy
e504085b57 grhhh I missed to get rid of this one...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-21 16:55:18 +10:00
olivier lamy
7912a55dec use variable for this reused value
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-21 10:39:18 +10:00
Simone Bordet
fa5a1d3be4 Fixes #2453 - RawHTTP2ProxyTest.testRawHTTP2Proxy failure on CI.
onData() implementations must copy the data
bytes if they do not consume them locally.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-04-20 18:15:53 +02:00
olivier lamy
1574ea1780 reduce pmd plugin noise
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-20 21:25:13 +10:00
Olivier Lamy
2abc5928b0
Merge pull request #2467 from olamy/bugfix/hazelcast_testClusteredScavenge_2440
no need to create different map per test as we clear it
2018-04-20 19:51:51 +10:00
olivier lamy
781cf076f7 compact syntax :-)
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-20 18:59:12 +10:00
olivier lamy
b90f6de54e no need to create different map per test as we clear it
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-20 18:59:12 +10:00
Olivier Lamy
5758fb52c0
Merge pull request #2469 from olamy/feature/build_local_repo_test
test new local repository for CI and use PMD cache
2018-04-20 18:54:10 +10:00
Simone Bordet
6e2cd06c89 Merged branch 'jetty-9.3.x' into 'jetty-9.4.x'. 2018-04-20 10:31:39 +02:00
Simone Bordet
8323417622 Merged branch 'jetty-9.2.x' into 'jetty-9.3.x'. 2018-04-20 10:27:14 +02:00
Simone Bordet
d7ce334f8f Updated ALPN version for JDK 8u171 and 8u172.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-04-20 10:16:50 +02:00
olivier lamy
b261c11920 use a variable for maven tool and use same directory as now local repo is relative
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-20 17:48:08 +10:00
olivier lamy
06b04e9cda enable cache for pmd plugin
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-20 16:53:29 +10:00
olivier lamy
43e030b568 using the same for all invocation will work better...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-20 16:50:30 +10:00
olivier lamy
c910b0e6d5 test new local repository
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-20 16:40:05 +10:00
olivier lamy
791d4c7d2c Revert "use an other local repository to try having install plugin stuck..."
This reverts commit ef17962f510f5545d52b90eb61bcc9272640ea44.
2018-04-20 16:38:52 +10:00
olivier lamy
ef17962f51 use an other local repository to try having install plugin stuck...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-20 16:32:14 +10:00
Greg Wilkins
67ebdea11b Directly set warnAt to minThreads #2464
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-04-20 08:12:34 +10:00
Greg Wilkins
11854f502c Directly set warnAt to minThreads #2464
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-04-20 08:10:20 +10:00
Olivier Lamy
9c1cd15e6f
Merge pull request #2462 from olamy/no_sources_jar_for_test_modules
[WIP] no need of sources jar for test jars will save some io...
2018-04-19 18:16:41 +10:00
Olivier Lamy
c7e78ae896
update logging versions #2461 (#2465)
* update logging versions #2461

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-19 15:45:11 +10:00
Greg Wilkins
6d0ff04dab Directly set warnAt to minThreads #2464
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-04-19 15:38:22 +10:00
olivier lamy
d84cac1be7 no need of sources jar for test jars will save some io...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-19 10:27:18 +10:00
olivier lamy
237d6280c3 upgrade pmd plugin
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-19 09:42:01 +10:00
olivier lamy
9dd72454da upgrade jar plugin
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-19 09:42:01 +10:00
olivier lamy
c8bb36330a upgrade dependency plugin
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-19 09:42:01 +10:00
olivier lamy
d68e9ea23c upgrade compiler plugin
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-19 09:42:01 +10:00
olivier lamy
01c08133de upgrade install plugin 2.5.2
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-19 09:42:01 +10:00
Simone Bordet
50c44f2297 Fixes #2454 - Avoid sending empty DATA frame in case of HTTP/2 trailers.
Updated the logic to avoid sending an empty data frame
when only sending the trailers in HttpTransportOverHTTP2.send().

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-04-18 14:19:58 +02:00
Lachlan
adb844de64
Merge branch 'jetty-9.4.x' into jetty-9.4.x-1555-wwwAuthenticate-Parsing 2018-04-18 16:06:02 +10:00
Lachlan Roberts
5a1325949e Changes to allow for other formats specified in RFC7235
- Multiple challanges in the same header can now be parsed successfully.
    - Will now allow a base64 value after the auth-scheme instead of parameters. Which can be used for the Negotiate auth-scheme.
    - Added more in depth testing for tricky cases.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-04-18 16:02:33 +10:00
Jan Bartel
0e88849a68
Issue #2164 Make osgi.serviceloader mostly optional (#2408)
Signed-off-by: Jan Bartel <janb@webtide.com>
2018-04-18 14:48:53 +10:00
Simone Bordet
fac93fa7f8 Fixes #2451 - Review ReservedThreadExecutor.getAvailable().
Fixed by having getAvailable() returning _stack.size().

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-04-17 16:30:06 +02:00
Olivier Lamy
f36eba4577
class.newInstance is deprecated #2435 (#2437)
* Class.newInstance() is deprecated in Java 9+ #2435

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-04-17 19:07:20 +10:00