042de2ec9f
461452 Double release of buffer by HttpReceiverOverHTTP
...
Updated HttpParse to always return from parseNext when messageComplete is called. This allows it to notice reentrant state changes
and removes the need for HttpReceiverOverHTTP.methodComplete to return true, thus avoiding the race.
2015-03-05 15:26:19 +11:00
418a60bbd0
461452 Double release of buffer by HttpReceiverOverHTTP
...
Updated comments to better describe the race to double release the buffer
2015-03-05 12:15:31 +11:00
8cbab09527
461452 Double release of buffer by HttpReceiverOverHTTP
...
This commit is just a tidy up of the code to reduce the size of the race causing this problem. It is not a fix.
2015-03-05 11:05:35 +11:00
40ad8dc608
Notifying the "failure" event for request and response when the failure
...
is detected during the processing of another event.
2015-03-04 01:01:09 +01:00
66df49bb4c
Clarified test code.
2015-03-02 09:57:42 +01:00
ec2fcb6648
Made tests more stable by consuming the content on the server.
...
When the content was not consumed, it was possible that the response
arrived to the client before it was able to send the whole request
content.
In some cases/tests this would cause the request to fail, thereby
failing the test as well.
2015-02-27 11:06:57 +01:00
b86ab56cfc
Fixed test.
2015-02-27 10:26:24 +01:00
27beeff164
Merged branch 'jetty-9.2.x' into 'master'.
2015-02-27 09:56:32 +01:00
da80498c56
Improved logging.
2015-02-26 23:38:27 +01:00
bbc2d0c29d
Simplified abort logic.
2015-02-26 23:26:24 +01:00
31a0b36f3c
Improved logging and toString() implementations.
2015-02-26 23:26:24 +01:00
008b03ac78
460905 - Make sure TimeoutCompleteListener is cancelled if the request cannot be sent.
2015-02-26 12:25:42 +01:00
d5a6ad2345
460905 - Make sure TimeoutCompleteListener is cancelled if the request cannot be sent.
2015-02-26 10:56:19 +01:00
165ae8f238
Improved LocalConnector
2015-02-26 20:13:45 +11:00
1659d83978
[maven-release-plugin] prepare for next development iteration
2015-02-24 10:38:33 -06:00
dc0c3f4c52
[maven-release-plugin] prepare release jetty-9.2.9.v20150224
2015-02-24 10:38:28 -06:00
d9255d02d8
Fixed test.
2015-02-24 13:08:21 +01:00
c52ba39722
Preventing NPE in case the exchange is failed in the middle of
...
sending content.
2015-02-24 13:01:11 +01:00
58ea526b56
Notifying client connection's promise from onOpen().
...
The client connection's promise was succeeded in the context of a
call to SelectorManager.newConnection().
This was wrong, since succeeding the promise may trigger the send
of a request *before* the connection is actually linked to the
endPoint and opened.
This change moves the succeeding of the client connection's promise
to the connection onOpen() method.
2015-02-20 18:23:31 +01:00
a01d85f0d9
Merged branch 'jetty-9.2.x' into 'master'.
2015-02-20 16:08:18 +01:00
71f6527cae
Removed extra dispatches from HTTP client code.
2015-02-20 16:02:54 +01:00
b69b8dfe50
460443 - Race condition releasing the response buffer.
...
Fixed by making sure that the response buffer is released at the
appropriate times.
2015-02-20 16:00:42 +01:00
ddde0db339
Added test to check that a 100 Continue response and a normal response,
...
when read in a single read by the client, are processed correctly.
2015-02-20 16:00:42 +01:00
ce5db2ca55
[maven-release-plugin] prepare for next development iteration
2015-02-17 16:02:22 -06:00
26b7597928
[maven-release-plugin] prepare release jetty-9.2.8.v20150217
2015-02-17 16:02:16 -06:00
28b9a0927c
Merged branch 'jetty-9.2.x' into 'master'.
2015-02-15 20:51:49 +01:00
ffa32dfae7
459963 - Failure writing content of a committed request leaks connections.
...
Fixed by making the logic in HttpSender fail and complete the response
in case of request failure, without taking in consideration whether
the request was committed or aborted.
2015-02-15 20:42:55 +01:00
cf022de2fd
Removed unused @Slow annotations.
2015-02-15 20:41:36 +01:00
8f0a874163
Removed unnecessary hiding of stack traces.
2015-02-15 20:40:50 +01:00
ed1cbc0631
Improved logging.
2015-02-15 20:39:01 +01:00
0f7ee8d607
Merge remote-tracking branch 'origin/jetty-9.2.x'
...
Conflicts:
jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java
jetty-http/src/main/java/org/eclipse/jetty/http/HttpVersion.java
jetty-io/src/main/java/org/eclipse/jetty/io/EndPoint.java
jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnection.java
2015-02-13 11:45:56 +11:00
2b2a70a93a
459845 Support upgrade
...
Added the concept of UpgradeFrom and UpgradeTo connections that support
transferring a buffer with content before opening new connection.
Aded EndPoint.update method as utility
2015-02-13 11:41:18 +11:00
be860741d5
459655 - Remove SPDY and NPN.
...
Cleanup of javadocs, comments, XML and other text files.
2015-02-11 16:18:07 +01:00
7dffe4f082
459542 - AsyncMiddleManServlet race condition on first download content.
...
Fixed the race condition by submitting a zero length buffer to write
from onWritePossible() which will succeed the callback without
causing races.
2015-02-10 13:16:41 +01:00
12e2f9e6c8
459542 - AsyncMiddleManServlet race condition on first download content.
...
Fixed the race condition by submitting a zero length buffer to write
from onWritePossible() which will succeed the callback without
causing races.
2015-02-10 13:10:57 +01:00
cb5541b58e
Merged branch 'jetty-9.2.x' into 'master'.
2015-02-09 17:39:16 +01:00
f974c74329
Implemented HTTP2Client connect timeout.
2015-02-09 16:22:21 +01:00
2a749dc0ea
Fail the callback in case we cannot activate a newly created connection.
2015-02-09 12:11:18 +01:00
96132dbe45
Merged branch 'jetty-9.2.x' into 'master'.
2015-02-09 08:56:03 +01:00
43f14997d8
Improved toString() methods for better reporting during dump().
2015-02-09 08:54:52 +01:00
99da9ce98e
Merged branch 'jetty-9.2.x' into 'master'.
2015-02-06 21:45:22 +01:00
ee16dfd066
Added test to verify the complete event is not fired until the
...
content is consumed.
2015-02-06 21:42:07 +01:00
12eaedd96b
Refactored HttpDestination to allow customization of the request enqueuing.
...
Subclasses may override enqueue() and provide a different algorihtm.
2015-02-06 21:42:07 +01:00
961a90d16c
Merged branch 'jetty-9.2.x' into 'master'.
2015-01-29 14:11:21 +01:00
e03cd5e286
451092 - Connector will fail if HeaderListener return false.
...
Not a bug, but wrote one more test and clarified Javadocs.
2015-01-29 11:44:11 +01:00
af312dbca0
Fixed case where a trying to send a request was causing an IllegalStateException.
...
It is always possible that a request is aborted by the client code
while being sent, so we should just return rather than throwing.
2015-01-29 11:13:39 +01:00
b6e4852179
Improved dump() output.
2015-01-29 11:13:39 +01:00
88ed996295
Improved toString().
2015-01-29 11:13:39 +01:00
a52703cba9
458527 - Implement an async proxy servlet that can perform content transformations.
2015-01-27 15:29:47 +01:00
aa22842c20
[maven-release-plugin] prepare for next development iteration
2015-01-16 17:48:29 -06:00
8c58a9abc4
[maven-release-plugin] prepare release jetty-9.2.7.v20150116
2015-01-16 17:48:23 -06:00
81bb8411d1
[maven-release-plugin] prepare for next development iteration
2015-01-16 12:06:36 -06:00
7865f88b81
[maven-release-plugin] prepare release jetty-9.2.7.v20150116
2015-01-16 12:06:30 -06:00
db991355a2
[maven-release-plugin] prepare for next development iteration
2015-01-16 10:41:45 -06:00
6930abb8d3
[maven-release-plugin] prepare release jetty-9.2.7.v20140116
2015-01-16 10:41:39 -06:00
9225b124a4
[maven-release-plugin] prepare for next development iteration
2015-01-16 08:21:35 -06:00
ebd563e64d
[maven-release-plugin] prepare release 9.2.7.v20140116
2015-01-16 08:21:29 -06:00
6861da11b9
457130 - HTTPS request with IP host and HTTP proxy throws IllegalArgumentException.
...
Fixed handling of cookies in case of null URI.
2015-01-09 16:08:41 +01:00
c7d9c5c951
457130 - HTTPS request with IP host and HTTP proxy throws IllegalArgumentException.
...
Fixed handling of cookies in case of null URI.
2015-01-09 16:07:41 +01:00
86c2d01e80
Merged branch 'jetty-9.2.x' into 'master'.
2015-01-09 12:59:17 +01:00
fd13361132
Fixed test assumption.
2015-01-09 12:58:14 +01:00
8a27385bc3
Merged branch 'jetty-9.2.x' into 'master'.
2015-01-09 12:51:13 +01:00
bb2872b789
Fixed test assumption.
2015-01-09 12:46:56 +01:00
adae3193d8
457130 - HTTPS request with IP host and HTTP proxy throws IllegalArgumentException.
...
Fixed by handling the case of non-URI request target.
2015-01-09 11:49:13 +01:00
7e7dd40f0a
Happy New Year 2015 (merge from master)
2015-01-08 09:14:13 -07:00
0c21d7c78b
Merged branch 'jetty-9.2.x' into 'master'.
2015-01-08 16:57:45 +01:00
51aafc78a4
457032 - Request sent from a failed CompleteListener due to connect timeout is failed immediately.
...
Fixed by copying the exchange queue and failing only the exchanges
that are present in the copy.
2015-01-08 16:56:59 +01:00
a3201a3c81
Happy New Year 2015
2015-01-07 17:06:59 -07:00
6a0668b7a1
Happy New Year 2015
2015-01-07 17:03:30 -07:00
a85a74bbdc
Reworked buffer releasing to ensure that it is always executed before
...
fillInterested() is called.
This is needed to avoid race conditions where fillInterested()
triggers a new thread entering onFillable() and acquiring a new buffer
while the previous thread is releasing the previous buffer.
2015-01-02 18:22:39 +01:00
cc216eb8ee
fixed client proxy test
2015-01-02 15:38:12 +01:00
e1e57924dc
fixed client test for new lazy consumeAll behaviour
2015-01-02 15:36:34 +01:00
dcd9182f87
fixed client test for new lazy consumeAll behaviour
2015-01-02 15:31:34 +01:00
a4d2895400
removed unneeded execute for SslConnection onFillable
2015-01-02 15:24:14 +01:00
3af9b145a3
Deprecated the AbstractConnection dispatchIO mechanism
2015-01-01 16:18:13 +01:00
5f2a7fdfce
fixed http client respond before consumed test.
...
The server now is a bit lazier if the handler has not consumed content. It will not block to consume and gives up and closes the connection instead.
2014-12-31 11:48:23 +01:00
9cff4a57e7
Merged branch 'master' into 'jetty-9.3-ewyk'.
2014-12-22 21:34:10 +01:00
e8c88cfd9c
Merged branch 'jetty-9.2.x' into 'master'.
2014-12-22 21:32:09 +01:00
c944b06a61
New tests testing request retry.
2014-12-22 21:27:59 +01:00
3b34423b17
EWYK SelectorManager
2014-12-18 17:06:32 +01:00
cdd2b0a9d2
refacted SelectorManager to have a ManagedSelector
2014-12-17 16:29:24 +01:00
28fb3e45d0
453636 Improved spin detection on test
2014-12-10 10:16:16 +01:00
bc22ba72dc
[maven-release-plugin] prepare for next development iteration
2014-12-05 16:45:12 +01:00
1cc075cf98
[maven-release-plugin] prepare release jetty-9.2.6.v20141205
2014-12-05 16:45:01 +01:00
127b48c932
[maven-release-plugin] prepare for next development iteration
2014-12-03 09:00:57 -06:00
028f4b9610
[maven-release-plugin] prepare release jetty-9.2.6.v20141203
2014-12-03 09:00:46 -06:00
1263d1f3c8
[maven-release-plugin] prepare for next development iteration
2014-12-03 08:26:47 -06:00
5c7f706496
[maven-release-plugin] prepare release jetty-9.2.6.v20141203
2014-12-03 08:26:35 -06:00
09846e324d
[maven-release-plugin] prepare for next development iteration
2014-11-12 17:13:19 -06:00
97d2bd95a6
[maven-release-plugin] prepare release jetty-9.2.5.v20141112
2014-11-12 17:13:14 -06:00
5d0595cabd
[maven-release-plugin] prepare for next development iteration
2014-11-03 13:46:58 -06:00
772ff0bfd4
[maven-release-plugin] prepare release jetty-9.2.4.v20141103
2014-11-03 13:46:52 -06:00
64597b318c
Merged branch 'jetty-9.2.x' into 'master'.
2014-11-03 17:25:37 +01:00
9c64fb73e4
449603 - OutputStreamContentProvider hangs when host is not available.
...
Fixed by having HttpRequest.abort() to fail the ContentProvider.
In this way, the ContentProvider knows, even before being used to
send the request content, that the request has failed, and may
forward the failure to the client code.
2014-11-03 16:50:59 +01:00
cbd7b75e10
Removed unused code.
2014-11-03 10:55:13 +01:00
1c4a08b35b
[maven-release-plugin] prepare for next development iteration
2014-10-31 09:58:16 -05:00
a4ff7bf841
[maven-release-plugin] prepare release jetty-9.2.4.v20141031
2014-10-31 09:58:10 -05:00
e1b73a64eb
[maven-release-plugin] prepare for next development iteration
2014-10-30 11:28:41 -05:00
5770cc1179
[maven-release-plugin] prepare release jetty-9.2.4.v20141030
2014-10-30 11:28:35 -05:00
58eb6740ec
[maven-release-plugin] prepare for next development iteration
2014-10-28 14:20:30 -05:00
19a44846cf
[maven-release-plugin] prepare release jetty-9.2.4.v20141028
2014-10-28 14:20:24 -05:00
31e448ffd6
Removed duplication of HttpGenerator$Info vs http.MetaData
...
Use MetaData throughout code base
2014-10-24 15:51:20 +11:00
360fce58be
Merged branch 'jetty-9.2.x' into 'master'.
2014-10-23 12:54:07 +02:00
fac197f868
Clarified semantic of Request.header().
2014-10-23 12:53:37 +02:00
9cb21d1377
Merged branch 'jetty-9.2.x' into 'master'.
2014-10-23 12:42:00 +02:00
f7baf9923f
Fixed issue caused by the fix to #447746 : user agent header must not
...
be added, but overwritten.
2014-10-23 12:41:16 +02:00
65832dfae3
Merged branch 'jetty-9.2.x' into 'master'.
2014-10-23 11:47:02 +02:00
84b38aba15
447746 - HttpClient is always going to send User-Agent header even though I do not want it to.
2014-10-23 11:46:18 +02:00
0eade706a6
Removed Thread.dumpStack() calls used for debugging.
2014-10-22 18:10:25 +02:00
6268421dd0
Merged branch 'jetty-9.2.x' into 'master'.
2014-10-16 18:05:12 +02:00
f2eaa963f8
Removed debugging statements.
2014-10-16 17:42:32 +02:00
e7d830c26e
Merged branch 'jetty-9.2.x' into 'master'.
2014-10-13 16:57:52 +02:00
2dba2ea2c2
Improved exception reporting.
2014-10-13 16:55:59 +02:00
6ed0170913
Removed call to Thread.dumpStack().
2014-09-26 11:34:26 +02:00
8d2efaf7eb
445167 - Allow configuration of dispatch after select.
...
Introduced parameter "dispatchIO" in the relevant factories so that
they can be configured by users and connections will be created
taking into account this parameter.
For less configurable connection factories, this parameter is
currently hardcoded to either true or false depending on the case.
For example, ALPN and NPN connections have it to false, since they
don't do any blocking operation in onFillable().
2014-09-26 10:13:16 +02:00
a8b461fe91
Cosmetics: removed unused imports, cleaned up source code, improved javadocs.
2014-09-26 10:13:16 +02:00
f1678124dc
444764 - HttpClient notifies callbacks for last chunk of content twice.
...
Fixed by filtering out notification of the callbacks in case the
HttpContent is already consumed.
2014-09-23 11:33:44 +02:00
1cd367ae7c
444764 - HttpClient notifies callbacks for last chunk of content twice.
...
Fixed by filtering out notification of the callbacks in case the
HttpContent is already consumed.
2014-09-22 18:16:49 +02:00
48510bc71a
444214 - Socks4Proxy fails when reading less than 8 bytes.
2014-09-16 21:37:51 +02:00
f93c1cf593
444214 - Socks4Proxy fails when reading less than 8 bytes.
2014-09-16 21:20:45 +02:00
1878b344c7
Added SOCKS 4 tests.
2014-09-16 14:24:45 +02:00
2481be42fe
Adding timeouts for problematic test case
2014-09-11 10:47:43 -07:00
9249ebb6ef
Using 9.2.4-SNAPSHOT for branch
2014-09-11 06:10:44 -07:00
9bfeb2221f
[maven-release-plugin] prepare release jetty-9.2.3.v20140905
2014-09-05 09:19:23 -05:00
ee3ab1f8ea
Merged branch 'master' into 'jetty-http2'.
2014-09-01 11:57:09 +02:00
9dbd2cd9d8
442950 - Embedded Jetty client requests to localhost hangs with high cpu usage (NIO OP_CONNECT Solaris/Sparc).
...
Now checking the return value of SocketChannel.connect() to determine
whether to register the channel (true) or finish the connect (false).
2014-09-01 11:28:59 +02:00
23eba39748
Merge remote-tracking branch 'origin/master' into jetty-http2
2014-08-21 16:39:45 +10:00
7584488702
javadoc
2014-08-21 09:43:35 +10:00
1c71040eca
moved config plugin to profile
2014-08-15 19:53:52 +10:00
b47f9ef605
cleaned up OSGi manifest creation
2014-08-15 19:35:49 +10:00
3ace246cff
Catching Throwable instead of Exception.
2014-08-08 18:16:56 +02:00
eaf374fa58
refactored Dispatcher for new HttpURI
2014-07-25 17:28:35 +10:00
cb42ef2167
[maven-release-plugin] prepare for next development iteration
2014-07-23 11:18:01 -07:00
dc62cb5ac7
[maven-release-plugin] prepare release jetty-9.2.2.v20140723
2014-07-23 11:17:55 -07:00
fa3d7d0f7e
Merge remote-tracking branch 'origin/master' into jetty-http2
...
Conflicts:
jetty-servlet/src/test/java/org/eclipse/jetty/servlet/AsyncContextDispatchWithQueryStrings.java
2014-07-23 16:53:13 +10:00
3a6879d3e8
expanded tabs in indents
2014-07-23 16:49:05 +10:00
467773dbdf
Merged branch 'master' into 'jetty-http2'.
2014-07-22 21:14:46 +02:00
dd914db3cf
Reorganized GZIP tests.
2014-07-22 20:55:18 +02:00
52172fb3c4
440038 - Content decoding may fail.
...
Properly looping around the decoding step to ensure that the encoded
content is fully consumed.
2014-07-21 19:21:44 +02:00
816b85ea4d
439895 - No event callback should be invoked after the "failure" callback.
...
Fixed HttpSender and HttpReceiver to use a non-blocking collaborative
mechanism to notify callbacks.
Only the "failed" callback can run concurrently with other callbacks.
No other callback can run after the "complete" callback: a failure
concurrent with another callback will notify the "failed" callback,
finish the running callback and only then invoke the "complete" callback.
2014-07-21 16:48:21 +02:00
853e020210
Merge remote-tracking branch 'origin/master' into jetty-http2
2014-07-16 15:31:48 +10:00
745f757552
Guarded calls to LOG.debug() with if (LOG.isDebugEnabled()) to reduce allocation of varargs Object[].
2014-07-15 18:49:14 +02:00
4d2a580c2c
439375 preferred rfc7231 format is mime;charset=lowercase-9
2014-07-11 17:56:08 +10:00
5e281dd449
Merge remote-tracking branch 'origin/master' into jetty-http2
...
Conflicts:
jetty-util/src/main/java/org/eclipse/jetty/util/IteratingCallback.java
2014-07-10 14:43:39 +10:00
55ca09a00e
438190 findbug improvements
2014-07-10 14:41:32 +10:00
706fe1eba3
Merge remote-tracking branch 'origin/master' into jetty-http2
2014-07-03 16:01:37 +10:00
7fbf521d4e
438204 correctly wrap IPv6 hostnames in URIs generated by jetty
2014-07-03 10:11:16 +10:00
228600caf5
fixed race in HttpReceiverOverHTTPTest
2014-07-02 15:08:06 +10:00
2608af8f0d
Merged branch 'origin/master' into 'jetty-http2'.
2014-06-26 11:54:50 +02:00
f2f19ee3ba
Improved changes introduced by a746d78.
2014-06-26 10:08:13 +02:00
Greg Wilkins
Simone Bordet
Jesse McConnell
Joakim Erdfelt
Jan Bartel