22285 Commits

Author SHA1 Message Date
Lachlan Roberts
165beff3f3 add test for multiple WebSocketUpgradeFilters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-11-14 10:43:14 +11:00
Jan Bartel
1245df26a4 Log failure to delete session file.
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-11-13 12:46:15 +01:00
Lachlan Roberts
0493a11106 Use Filter name to identify the WebSocketUpgradeFilter.
Don't allow configuration of WebSocketMapping attribute.
The WebSocketUpgradeFilter is identified by it's name, which must be set as the fully qualified class name.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-11-13 22:06:20 +11:00
olivier lamy
26f1e0b723 use autobahn to not run it per default
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-11-13 15:24:27 +10:00
gregw
8884575f85 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x
Signed-off-by: gregw <gregw@webtide.com>
2020-11-12 17:17:55 +01:00
Simone Bordet
dd9bdc7ac3 Fixes #5633 - Allow to configure HttpClient request authority.
Updated after review.
Added more tests.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-12 17:13:36 +01:00
Simone Bordet
96e4b38624 Fixes #5633 - Allow to configure HttpClient request authority.
Fixed initial session recv window update: it was wrong if the initial value was less than the default value (65535).

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-12 17:13:17 +01:00
Greg Wilkins
f4c32e788a
Fix #5562 Improve HTTP Field cache allocation (#5565)
* Fix #5562 Improve HTTP Field cache allocation

Fix #5562 by initially putting cacheable fields into a inexpensive arraylist.
Only create the Trie (with space and complexity costs) if a second request is received.

* Fixed NPE

* Feedback from review

Create `HttpHeader.isPseudo()`` method
improved clarity with `createFieldCacheIfNeeded()``

* Feedback from review

Only defer Trie creation to first cacheable field, not until next request.

* Updates from review

* Update from review

 + more javadoc
 + empty set return
2020-11-12 17:05:32 +01:00
Lachlan
859cf6cd1c
Merge pull request #5563 from eclipse/jetty-10.0.x-5320-WebSocketHttpClient2
Issue #5320 - using jetty-websocket-httpclient.xml within webapp Jetty 10
2020-11-12 10:52:46 +11:00
Lachlan Roberts
a4160c4b5e Fix javadoc on websocket configuration classes.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-11-12 09:47:38 +11:00
Lachlan Roberts
8ff545f696 Merge remote-tracking branch 'origin/jetty-10.0.x' into jetty-10.0.x-5320-WebSocketHttpClient2 2020-11-12 09:42:48 +11:00
Chris Walker
f3278c1e81
Fixing link for secuirty reports in #5642 2020-11-11 14:24:55 -06:00
Chris Walker
d93fb0880b Merge branch 'jetty-9.4.x' into jetty-10.0.x
# Conflicts:
#	jetty-documentation/src/main/asciidoc/reference/troubleshooting/security-reports.adoc
2020-11-11 14:22:04 -06:00
Chris Walker
3660e38148
Fixes broken link to security reports. Resolves #5642 2020-11-11 14:18:50 -06:00
Joakim Erdfelt
5f2e8af9f2
Merge branch 'jetty-10.0.x' of github.com:eclipse/jetty.project into jetty-10.0.x 2020-11-11 12:46:04 -06:00
Joakim Erdfelt
00db5cea6e
Fixing jetty-jaas by not using apacheds-all
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-11-11 12:45:52 -06:00
Jan Bartel
0514fd5288 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x 2020-11-11 19:24:45 +01:00
Jan Bartel
3a99c89350
Issue #5486 PropertyFileLoginModule retains PropertyUserStores (#5518)
* Issue #5486 PropertyFileLoginModule retains PropertyUserStores

Signed-off-by: Jan Bartel <janb@webtide.com>
2020-11-11 18:21:06 +01:00
gregw
dd86adad66 Fixed file header 2020-11-11 18:18:50 +01:00
gregw
6ea9f11bc1 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x 2020-11-11 17:49:03 +01:00
Greg Wilkins
bb886ad932
Fix #5575 SEARCH method (#5576)
+ Added all IANA methods
 + Used Trie for most lookups
 + Fixed ArrayTernayTrie lookup
 + optimised GET, POST and HEAD

Co-authored-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-11-11 17:48:08 +01:00
Joakim Erdfelt
6c1a82fcbb
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x 2020-11-11 10:42:35 -06:00
Joakim Erdfelt
6b82637624
Merge pull request #5629 from eclipse/dependabot/maven/jetty-9.4.x/org.apache.maven.shared-maven-artifact-transfer-0.12.0
Bump maven-artifact-transfer from 0.11.0 to 0.12.0
2020-11-11 10:35:14 -06:00
Simone Bordet
a308881fab Fixes #5633 - Allow to configure HttpClient request authority.
Introduced HttpDestination.send(Request, Response.CompleteListener) to send a request using the given destination.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-11 17:13:00 +01:00
olivier lamy
b1b5cc3cd3 not needed anymore
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-11-11 19:32:13 +10:00
olivier lamy
bf01cf280e exclude autobahn via surefire property
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-11-11 18:59:56 +10:00
olivier lamy
c46920dafd activate autobahn tests only for ci profile
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-11-11 17:48:35 +10:00
Lachlan Roberts
6934b94261 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-11-11 14:21:58 +11:00
Lachlan
23f75a395b
Merge pull request #5599 from eclipse/jetty-9.4.x-XML-Review
Fixes to XML formatting and comments.
2020-11-11 13:55:26 +11:00
olivier lamy
0dae601a1f Merge branch 'jetty-9.4.x' into jetty-10.0.x 2020-11-11 11:12:03 +10:00
olivier lamy
8b3de3beb3 some build do not generate amnymore junit results
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-11-11 10:54:34 +10:00
olivier lamy
5ebc36c450 do not activate remote session tests for javadoc and compaact3 builds
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-11-11 07:36:50 +10:00
Ludovic Orban
30a916174d
Merge pull request #5571 from lorban/lorban-gpg-and-devtag
Add lorban's GPG key and developer tag
2020-11-10 19:54:36 +01:00
Joakim Erdfelt
9e22260377
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-10.0.x 2020-11-10 12:12:39 -06:00
Joakim Erdfelt
3b5bb78eed
Merge pull request #5625 from eclipse/dependabot/maven/jetty-9.4.x/com.puppycrawl.tools-checkstyle-8.37
Bump checkstyle from 8.36.2 to 8.37
2020-11-10 12:06:10 -06:00
Simone Bordet
298ddfd722 Issue 5310 - Review HTTP/2 GOAWAY handling.
Fixed javadocs and TODOs.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-10 17:38:05 +01:00
Simone Bordet
a02012fb3e Issue 5310 - Review HTTP/2 GOAWAY handling.
Fixed logic in onShutdown(): in case of abort the closing action must be
run as callback, so it executes at the end of all the other callbacks.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-10 16:17:32 +01:00
Simone Bordet
1de622f72f Issue 5310 - Review HTTP/2 GOAWAY handling.
Updates after initial review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-10 15:25:44 +01:00
Joakim Erdfelt
21c27f6370
Fixing checkstyle violations
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-11-10 06:33:04 -06:00
dependabot[bot]
0a345420ff
Bump checkstyle from 8.36.2 to 8.37
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.36.2 to 8.37.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](https://github.com/checkstyle/checkstyle/compare/checkstyle-8.36.2...checkstyle-8.37)

Signed-off-by: dependabot[bot] <support@github.com>
2020-11-10 11:53:24 +00:00
dependabot[bot]
5ed40b251c
Bump maven-artifact-transfer from 0.11.0 to 0.12.0
Bumps [maven-artifact-transfer](https://github.com/apache/maven-artifact-transfer) from 0.11.0 to 0.12.0.
- [Release notes](https://github.com/apache/maven-artifact-transfer/releases)
- [Commits](https://github.com/apache/maven-artifact-transfer/compare/maven-artifact-transfer-0.11.0...maven-artifact-transfer-0.12.0)

Signed-off-by: dependabot[bot] <support@github.com>
2020-11-10 11:53:07 +00:00
olivier lamy
2af2821a0e Revert "Bump maven-bundle-plugin from 3.5.1 to 5.1.1" until we figure out the problem
This reverts commit 1475e4e22596a8a79a26a4bc0b5782bbfb6571f5.
2020-11-10 20:34:23 +10:00
olivier lamy
f691ed81b9 derby 10.15 not supporting java8
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-11-10 20:31:49 +10:00
Simone Bordet
226d616a8a Issue 5310 - Review HTTP/2 GOAWAY handling.
Reimplemented close/idle_timeout/stop/onGoAway/input_shutdown following more closely the specification.

In particular, the semantic of sending a GOAWAY is now to:
* stop creation of new both local and remote streams
* record the last processed stream
* continue processing streams that are pending

This means that a GOAWAY is "graceful" in the sense that it allows for streams to be completed by applications.

The semantic of stop() and idle timeout is harsher: for pending streams a RST_STREAM is sent to the other peer and they are failed locally.

Added support for GOAWAY with 2^31-1 lastStreamId.

Added support for a peer to send and receive multiple GOAWAY frames.

Reviewed the stream creation/destruction mechanism so that when the last stream completes after a GOAWAY, proper actions can be run to tear down the connection.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-10 10:07:19 +01:00
Simone Bordet
044052d717 Issue 5310 - Review HTTP/2 GOAWAY handling.
Code cleanups: removed unnecessary final modifiers and fixed code warnings.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-10 09:56:33 +01:00
Simone Bordet
206050df7f Issue 5310 - Review HTTP/2 GOAWAY handling.
Refactored push code in a single place: HTTP2Session.push().

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-10 09:56:32 +01:00
Simone Bordet
0dc2894002 Issue 5310 - Review HTTP/2 GOAWAY handling.
Refactored reset code in a single place: HTTP2Session.reset().

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-10 09:56:32 +01:00
Simone Bordet
62e17da2d0 Issue 5310 - Review HTTP/2 GOAWAY handling.
Moved stream "close" event after returning from listener methods.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-11-10 09:56:32 +01:00
dependabot[bot]
949a89c15b
Bump geronimo-interceptor_1.2_spec from 1.1 to 1.2 (#5632)
Bumps geronimo-interceptor_1.2_spec from 1.1 to 1.2.

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-10 16:34:46 +10:00
dependabot[bot]
80bb1bce90
Bump javax.servlet.jsp.jstl from 1.2.2 to 1.2.5 (#5622)
Bumps [javax.servlet.jsp.jstl](https://github.com/javaee/jstl-api) from 1.2.2 to 1.2.5.
- [Release notes](https://github.com/javaee/jstl-api/releases)
- [Commits](https://github.com/javaee/jstl-api/compare/1.2.2...impl-1.2.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-10 16:33:58 +10:00