Commit Graph

114 Commits

Author SHA1 Message Date
Joakim Erdfelt 81894fb4ed Using property based lookup for Checkstyle suppressions filter.
+ This is to be maximally compatible across all plugins and scenarios
  where the Checkstyle suppressions filter can be used.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-06-24 13:58:23 -05:00
Joakim Erdfelt 16cf6a34e1 Adapting suppressions filter for various plugin's expectations.
Each plugin finds the suppressions in different ways.

+ Eclipse CS finds it via property ${config_loc}
+ Newest IntelliJ CS finds it via same property
+ Maven plugin finds it via classloader.getResource()

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-06-24 13:27:14 -05:00
Joakim Erdfelt 0cb56a8e21 Adding CheckStyle suppression's for src/test/java
+ No MethodNameCheck
+ No TypeNameCheck
+ No LocalVariableNameCheck

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-06-24 13:04:30 -05:00
Joakim Erdfelt 7b941098d0 Fixing version of build-resources 2019-06-24 11:12:47 -05:00
Greg Wilkins b7a7a53a18
Jetty 10.0.x reformat (#3812)
* Removing Legacy Method Separators
* Restyling branch `jetty-9.4.x`
* Applying changes highlighted by checkstyle
* Removing Legacy Method Separators
* Restyling branch `jetty-10.0.x`
* Applying checkstyle changes
* Applying checkstyle changes
* Applying XML restyling
* Restyling XML in branch `jetty-10.0.x`
* Fixing XML codestyle for IntelliJ
* Fixing XML style mistakes
* Fixing XML restyling in branch `jetty-10.0.x`
* Revert "Applying XML restyling"
* Updating checkstyle for XML codestyle
* Revert "Restyling XML in branch `jetty-10.0.x`"

# Conflicts:
#	jetty-xml/src/test/resources/org/eclipse/jetty/xml/configureWithAttr.xml
#	jetty-xml/src/test/resources/org/eclipse/jetty/xml/configureWithElements.xml

* Adding back build-resources
* Reformatting pom.xml files
* Disabling Checkstyle job
* fixed empty string on line wrap
* reformatted with latest intellij style
* misc checkstyle fixes

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-06-24 17:42:39 +02:00
Greg Wilkins 9706d70484
Jetty 9.4.x reformat (#3811)
* Removing Legacy Method Separators
* Restyling branch `jetty-9.4.x`
* Applying changes highlighted by checkstyle
* Applying XML restyling
* Fixing XML codestyle for IntelliJ
* Fixing XML style mistakes
* Revert "Applying XML restyling"
* Updating checkstyle for XML codestyle
* Reformatting pom.xml files
* Fixed empty string from line wraps
* Update intellij style to not do expression relative formatting. Reformatted code based on that.
* Increasing line split on Eclipse IDE Formatter to 512
* Restoring setting on internal default value.
+ IntelliJ will not export settings on things that set to their
  internal default values.
  We want to keep those values as a hedge against future default
  value changes in future releases of IntelliJ.
* Fixing intellij codestyle
* do not allow single line simple methods
* misc checkstyle fixes
* re-exported with correct name and all values

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-06-24 17:40:30 +02:00
Joakim Erdfelt 6e44a7cfd1 More changes from PR feedback
Both Formatters / CodeStyles
+ Maximum Line Length for wrapping is now 128
  (Sorry, cannot turn it off, but we can set it high)

Eclipse Formatter
+ javadoc formatting turned off
+ line comment formatting turned off
+ block comment formatting is turned off
+ preserving whitespace between code and comments
+ don't join already wrapped lines of code or comments
+ keeping empty array initializers on one line
+ brace position for array inializers are on next line

IntelliJ Formatter
+ turn off various javadoc / block / line formatting
+ consecutive blank lines capped at 1
+ align multiline array initializers
+ turned off brace force on if statements
+ array initializer braces on new line

Checkstyle Rules
+ disabled NeedBraces
+ NoWhitespaceAfter now allows lineBreaks without a violation

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-05-21 11:08:15 -05:00
Joakim Erdfelt 9cb8fb30fd Updating checkstyle rules from PR feedback.
+ NeedBraces is turned on, but excluded for single line IF statements
+ OperatorWrap is split into 2 rules.
  1. (OperatorWrapNextLine) for "?" and ":" tokens.
  2. (OperatorWrapSameLine) for all other tokens
+ NoWhitespaceAfter enabled with default tokens + TYPECAST
2019-05-20 14:40:53 -05:00
Joakim Erdfelt 3cb588b28b Updating IDE formatters / codestyles from PR feedback.
+ Lambda braces are always on new line
+ Space after (cast) is removed
+ Do not force braces on single line if statements, only on multi-line.
2019-05-20 14:23:44 -05:00
Joakim Erdfelt 40cdbc4056 Revert LeftCurly setting
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-05-08 16:51:12 -05:00
Joakim Erdfelt d50ed94baa Adding Eclipse IDE Code Style XML 2019-05-08 15:40:54 -05:00
Joakim Erdfelt 62ebcedc59 Updating checkstyle for lambdas 2019-05-08 15:40:41 -05:00
Joakim Erdfelt 371f828378 Update to jetty-checkstyle.xml + Intellij Style Def
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-05-08 14:22:04 -05:00
Joakim Erdfelt 8246011020 Initial /build-resources/ with jetty-checkstyle.xml
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-05-08 10:57:15 -05:00