8c7861d210
fixed spelling
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-20 10:34:07 +01:00
a855744aeb
release buffer in client as well
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-20 10:25:57 +01:00
b46b25b450
release buffer on overflow
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-19 22:38:58 +01:00
0c8860f131
Sort the executables so that non varargs variants are tried before empty var args.
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-19 19:35:52 +01:00
9dd8a53a6d
Work in progress on review comments
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-19 19:20:04 +01:00
01438e6f91
Code cleanup.
...
Changed the way the test directory was created: it was based on a
millisecond timestamp, but the tests run fast and it was possible that
two tests were creating the directory within the same millisecond.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-02-17 17:32:51 +01:00
ed7f337856
Issue #4518 - Add a mechanism that allows running multiple protocols on the same port.
...
Made test methods public, so that they will work fine in JDK 11 and JPMS.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-02-17 00:53:44 +01:00
9f7a82b128
Merge pull request #4519 from lorban/composable-conn-factories
...
Fixes #4518 - Add a mechanism that allows running multiple protocols on the same port.
2020-02-16 19:25:04 +01:00
7320b1de94
Merge pull request #4576 from eclipse/jetty-9.4.x-4575-stopping-reserved-threads
...
Fixes #4575 Stopping Reserved Thread
2020-02-16 17:25:15 +01:00
652428ad70
Tests #4573 X-Forwarded ordering
...
Added tests for header ordering
fixed cut-and-paste error of _for to _host
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-16 11:04:34 +01:00
ab5005b9f7
Fixes #4575 Stopping Reserved Thread
...
Fixes #4575 Stopping Reserved Thread by removing the `isRunning` check
from `reservedWait`. The main run loop is also simplified to improve
`isRunning` checks before the thread is put on the stack. Javadoc
improved to explain each step.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-16 09:43:31 +01:00
aaf6f17766
Merge pull request #4555 from eclipse/jetty-9.4.x-4537-WebSocketSpin
...
Issue #4537 - fix potential spin when discarding in WebSocketConnection
2020-02-13 09:14:06 +11:00
602e700e02
use pmd plugin 3.13.0 ( #4566 )
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-02-12 16:30:56 +10:00
636c6047ba
Merge pull request #4564 from SerCeMan/jetty-9.4.x
...
Improve performance of small websocket binary messages
2020-02-11 00:40:27 +11:00
66f4bda2ea
comments
...
Signed-off-by: Sergey Tselovalnikov <sergeicelov@gmail.com>
2020-02-10 21:02:36 +11:00
d371c1498c
Improve performance of small websocket messages
...
Signed-off-by: Sergey Tselovalnikov <sergeicelov@gmail.com>
2020-02-10 20:07:33 +11:00
20621b76fb
Issue #4537 - fix potential spin when discarding in WebSocketConnection
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-02-10 18:29:55 +11:00
f50c2654b9
Fixes #4541 Large Headers
...
Added a HEADER_OVERFLOW result as per review
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-06 21:17:58 +01:00
2c8d405b83
Fixes #4550 XmlConfiguration named parameters
...
Do not match a missing varArgs executable is there is a matching method with no varArgs.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-06 18:55:42 +01:00
d27f4ee556
Fixes #4550 XmlConfiguration named parameters
...
Fixed #4550 named parameters with a moderate refactor.
The named parameter matching was duplicated, only considering number of args and not applied to call arguments. This refactor puts all the behaviour in common methods and reorders the arguments to match parameters.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-06 14:11:58 +01:00
386d9348ca
Use contants for CR and LF fields index
...
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-02-06 10:06:33 +01:00
1b59e42294
Issue #4541 Large response header
...
Fix #4541 by initially allocated a header buffer of `min(_config.getResponseHeaderSize(), _config.getOutputBufferSize())`
Only allocate a buffer of `getResponseHeaderSize` if an overflow results.
This should have no effect on the majority of responses where `getOutputBufferSize` is greater than `getResponseHeaderSize` other than the cost of a min operation.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-05 10:29:41 +01:00
13458ab515
Fixed bad format
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-02-04 16:29:58 +01:00
5df1ad9b66
change the format of detector's generated protocol name
...
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-02-04 12:42:35 +01:00
58b1db610c
detectAndUpgrade() shortcut on empty buffer
...
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-02-04 10:49:27 +01:00
37edc016d2
improve debug logs
...
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-02-04 09:21:41 +01:00
75b4719592
Implement detector connection factory with protocol detection mechanism
...
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-02-03 16:56:53 +01:00
ecd0fe97f7
Issue #4520 Reinstate throw of UnreadableSessionDataException ( #4528 )
...
* Issue #4520 Reinstate throw of UnreadableSessionDataException
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-02-01 11:13:58 +01:00
4dbf8a3a9e
Issue #4495 ReservedThreadExecutor optimise ( #4499 )
...
* Issue #4495 ReservedThreadExecutor optimise
Use synchronousQueue for task handoff
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4495 ReservedThreadExecutor optimise
updates from review
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4495 ReservedThreadExecutor optimise
Use a linked queue rather than a deque(as a stack). This should be simpler, better optimised and less contended. Idling has been simplified so that a reserve thread is always dropped every idle period.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4495 ReservedThreadExecutor optimise
reverted RTE and added a JMH benchmark
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* More variants and longer tests
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Added LQ
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* removed SQ2
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4495 ReservedThreadExecutor optimise
Replaced real implementation with SQ
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4495 RTE optimise
Removed alternate implementations
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4495 RTE optimise
updates from review
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-01-31 19:54:44 +01:00
b6f2fd2432
Issue #4529 Servlet in error page ( #4530 )
...
Added option for #4529 to control showing the servlet in an error page.
Error configuration really needs a module, but will add in 10 with a refactor.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-01-31 19:53:05 +01:00
769cd9de69
Merge pull request #3364 from eclipse/jetty-9.4.x_maven_plugin_site
...
Issue #3247 Generate jetty-maven-plugin website
2020-01-31 07:14:24 -06:00
f88eb73a91
Issue #4533 Hard close from Dispatcher ( #4534 )
...
* Issue #4533 Hard close from Dispatcher
Signed-off-by: Greg Wilkins <gregw@webtide.com>
#4533 Do hard close from Dispatcher so response wrappers may intercept close.
* Issue #4533 Hard close from Dispatcher
Signed-off-by: Greg Wilkins <gregw@webtide.com>
#4533 improve test after review
* Issue #4533 Hard close from Dispatcher
Some renaming of methods to make it clear that softClose should only be used as part of sendError handling. If softClose is used by other components, then sendError can be prevented from setting the error status.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-01-31 11:55:14 +01:00
1ee26ba736
Merged branch 'jetty-9.3.x' into 'jetty-9.4.x'.
2020-01-30 12:09:35 +01:00
4139b67d8f
Replaced references to branch 'master' with 'jetty-9.3.x'.
...
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-01-30 11:32:37 +01:00
7746be770a
Merged branch 'jetty-9.3.x' into 'jetty-9.4.x'.
2020-01-30 10:17:10 +01:00
f52ed62f36
Merged branch 'jetty-9.2.x' into 'jetty-9.3.x'.
2020-01-30 10:09:34 +01:00
305e4609b2
Updated ALPN version for JDK 8u241 and 8u242.
...
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-01-30 10:03:38 +01:00
9850c29839
Issue #4247 use context default for samesite cookie attribute ( #4512 )
...
* Issue #4247 use context default for samesite cookie attribute
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-01-29 11:05:35 +01:00
56754f4a29
Issue #4504 Forwarded Host and Server ( #4511 )
...
X-Forwarded-Host has precedence of X-Forwarded-Server and outcome is not order dependent.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-01-24 11:20:52 +01:00
ff19bef4dc
alpn for jdk 1.8.0_242
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-01-24 19:59:28 +10:00
b64964113c
Merge pull request #4486 from eclipse/jetty-9.4.x-4475-WebSocketStreamMessageOrder
...
Issue #4475 - fix WebSocket streaming message ordering
2020-01-24 10:01:22 +11:00
a76fd0e948
updated Weld
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-01-21 10:21:52 +01:00
fedc7c6599
Issue #4360 Update to jasper 8.5.49 ( #4487 )
...
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-01-20 09:21:16 +01:00
92a2ceacbe
Merge branch 'jetty-9.4.x' of github.com:eclipse/jetty.project into jetty-9.4.x
2020-01-17 12:51:13 -06:00
20af3c1b13
Noted 9.3 is deprecated
2020-01-17 12:25:04 -06:00
56fc476d55
Updating to version 9.4.27-SNAPSHOT
2020-01-17 07:00:10 -06:00
7b38981d25
Updating to version 9.4.26.v20200117
2020-01-17 06:21:47 -06:00
692d901129
Merge pull request #4446 from eclipse/jetty-9.4.x-4444-tls_idle_timeout
...
Fixes #4444 - Connection timeout intermittently when using jetty 9.4…
2020-01-17 10:10:34 +01:00
fd52ff697e
Merged branch 'jetty-9.4.x' into 'jetty-9.4.x-4444-tls_idle_timeout'.
2020-01-17 09:58:10 +01:00
08b1be6ea8
Issue #4475 - improve testing for MessageInputStream
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-01-17 18:37:47 +11:00
Greg Wilkins
Simone Bordet
Lachlan
Olivier Lamy
Sergey Tselovalnikov
Ludovic Orban
Jan Bartel
Jesse McConnell
Joakim Erdfelt
Chris Walker