Commit Graph

17326 Commits

Author SHA1 Message Date
Joakim Erdfelt e9ac2c8c97
Fixing #4144 - handle wrapped requests better
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-10-01 17:49:30 -05:00
Joakim Erdfelt 6fc42d8ba2 Merge branch 'release-9.4.21' into jetty-9.4.x 2019-10-01 13:35:43 -05:00
Simone Bordet a380f6b7b9
Merge pull request #4081 from eclipse/jetty-9.4.x-HttpConnection_UpgradeCheck
Remove unnecessary Connection upgrade check
2019-10-01 18:10:23 +02:00
Simone Bordet 72d1a297a0
Merge pull request #4109 from mofleury/jetty-9.4.x
Support meaningful JMX ObjectNames for HttpDestinations by avoiding race condition at creation
2019-10-01 17:31:45 +02:00
Simone Bordet 5b829a10e4 Cosmetics.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-01 17:23:29 +02:00
Lachlan fef5975b86
Merge pull request #4108 from eclipse/jetty-9.4.x-4104-WSSession_SendAfterClose
Issue #4104 - WebSocketSession will reject outgoing frames if closed
2019-10-01 15:46:16 +10:00
Lachlan 4fff51361d
Merge pull request #4101 from eclipse/jetty-9.4.x-4096-ReservedThreadExecutor_stop
Issue #4096 - allow thread to exit ReservedThreadExecutor on stop
2019-10-01 15:44:37 +10:00
Lachlan e80ee375b6
Merge pull request #4131 from travisspencer/fix-4130
Issue #4130 - Don't add scopes if none are provided
2019-10-01 10:28:28 +10:00
Simone Bordet 062afc59ad
Merge pull request #4126 from eclipse/jetty-9.4.x-3787-httpclient_eofexception_instead_of_sslhandshakeexception
Issue #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors
2019-09-30 08:54:23 +02:00
Simone Bordet a85a18e0d8 Fixes #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors.
Fixed indent.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-30 08:53:12 +02:00
Marc-Olivier Fleury 8e51a4d532 adjusted formatting to follow standards
Signed-off-by: Marc-Olivier Fleury <mofleury@gmail.com>
2019-09-30 08:34:54 +02:00
Travis Spencer 201264d17b Don't add scopes if none are provided
Signed-off-by: Travis Spencer <travis@curity.io>
2019-09-28 18:05:48 +02:00
Simone Bordet 4d3423e88f Fixes #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors.
Marked the test with @Tag("external") since it
contacts the external server tools.ietf.org.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-27 15:18:57 +02:00
Simone Bordet ad2770ddc2 Fixes #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors.
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-27 00:15:34 +02:00
Simone Bordet 2c75e876a3 Fixes #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors.
Now exceptions thrown by fill() or flush() are stored in a field.
Further fill() operations will rethrow the original exception rather
than returning -1.

Returning -1 to application was causing them to close() with a generic
failure that was triggering the EOFException reported in this issue.

Now applications see the original exception and can close() with the
proper cause.

Re-enabled HostnameVerificationTest that was reproducing this issue
reliably but was @Disabled a while back and never re-enabled.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-26 18:30:43 +02:00
Simone Bordet d12df30df7 Issue #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors.
Code cleanups.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-26 18:18:13 +02:00
Joakim Erdfelt 7807eafad9 Updating to version 9.4.22-SNAPSHOT 2019-09-26 10:46:28 -05:00
Joakim Erdfelt 72970db61a Updating to version 9.4.21.v20190926 2019-09-26 09:59:15 -05:00
Lachlan ba728eee5d
Issue #4105 - atomically increment idle count when starting new thread in QTP (#4118)
* Issue #4105 - starting a thread in QTP now increments idle count

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>

* Issue #4105 - improve comments in test

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-09-26 08:15:07 +10:00
Joakim Erdfelt 39ee316a7f
Merge branch 'jetty-9.4.x' of github.com:eclipse/jetty.project into jetty-9.4.x 2019-09-25 12:42:47 -05:00
Joakim Erdfelt f6ca4f138a
Testing gpg signature setup 2019-09-25 12:42:32 -05:00
Lachlan 3edc6c9102
Issue #3734 - throw ISE for WebSocket suspend after close (jetty-9.4) (#4098)
* Issue #3734 - throw ISE for WebSocket suspend after close

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>

* Issue #3734 - suspend is error if onClose() has been called

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-09-25 14:55:13 +10:00
Greg Wilkins 11b60db4c3
Issue #4047 Graceful Write (#4100)
Added test to reproduce issue
Fixed bug from #2772 where output was shutdown on DONE without checking for END.
Fixed aggregation logic to aggregate last write if aggregation already started
Improved comments and clarify conditions

Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-09-25 12:13:56 +10:00
Joakim Erdfelt 7413483fc5 Removing JDK12 build
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-09-24 15:35:00 -05:00
Joakim Erdfelt 943a8c6fec
Merge pull request #4114 from eclipse/jetty-9.4.x-4113-httpclient_failure_jdk13_tls13
Fixes #4113 - HttpClient fails with JDK 13 and TLS 1.3.
2019-09-23 12:07:30 -05:00
Simone Bordet 2872253e6a Merged branch 'jetty-9.4.x' into 'jetty-9.4.x-4113-httpclient_failure_jdk13_tls13'. 2019-09-23 18:03:53 +02:00
Simone Bordet b3be28086b Fixes #4113 - HttpClient fails with JDK 13 and TLS 1.3.
1. Now forwarding the fillable event rather than assuming that is due
to garbage bytes or by a server close. This ensures that a HTTP read
consumes the TLS bytes and the `NewSessionTicket` message.
2. Avoid to set the `SslConnection` onto the `EndPoint` in
`SslClientConnectionFactory` - this allows upgrades to work properly,
for example when tunnelling through a secure proxy.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-23 17:59:37 +02:00
Joakim Erdfelt a6b1922473 Adding JDK13 to build
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-09-23 10:30:35 -05:00
Lachlan Roberts ac93ff6272 Issue #4096 resolve race between doStop and adding new threads to stack
Now using the _size AtomicInteger to resolve the race between stopping
and adding to the stack.

A _size of -1 now means no more threads can be added to the stack, and
the loop in doStop() will now only exit if it can set the size to -1.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-09-23 11:56:25 +10:00
Joakim Erdfelt c7a3dd4a27
Merge pull request #4107 from eclipse/jetty-9.4.x-4084-silence-blockingtimeout-warning
Issue #4084 - squelch deprecated warning on <Set> call.
2019-09-20 17:54:46 -05:00
Joakim Erdfelt a7856dd6d0 Issue #4084 - Removing System.err|out usage in tests
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-09-20 17:13:10 -05:00
Marc-Olivier Fleury ebe28c27e4 using computeIfAbsent to avoid the duplicate registering of Destinations in the MBean Server
Signed-off-by: Marc-Olivier Fleury <mofleury@gmail.com>
2019-09-20 14:55:45 +02:00
Lachlan Roberts 5a52235464 Issue #4104 - WebSocketSession will reject outgoing frames if closed
Outgoing frames will now go RemoteEndpoint->Session->ExtensionStack
instead of just RemoteEndpoint->ExtensionStack.

This will allow the Session to check whether it has been closed before
allowing the frame through the ExtensionStack.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-09-20 10:30:31 +10:00
Joakim Erdfelt bb659e0e58 Issue #4084 - squelch deprecated warning on <Set> call.
+ The XML warning on Deprecated will be squelched (set to DEBUG)
  if the <Set> call has a <Property> (or <SystemProperty>)
  that is using its default value.
  All other uses will still result in WARN level logging event.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-09-19 13:25:53 -05:00
Lachlan Roberts 168a95d334 Issue #4096 - allow thread to exit ReservedThreadExecutor on stop
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-09-19 08:56:01 +10:00
Joakim Erdfelt 2268983a39 Revert "Issue #4084 make deprecated warnings only with debug in jetty-9"
This reverts commit 157910d79a.
2019-09-18 16:18:41 -05:00
olivier lamy 69d52b2263 fix unit test
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-09-18 09:54:52 -04:00
Greg Wilkins 157910d79a Issue #4084 make deprecated warnings only with debug in jetty-9
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-09-18 15:58:46 +10:00
Simone Bordet f85382aa9d
Merge pull request #4086 from eclipse/jetty-9.4.x-1036-SchedulerThreads
Issue #1036 Configure Scheduler
2019-09-17 11:37:23 +02:00
Simone Bordet bb27fa6cc0 Issue #3747 - Make Jetty Demo work with JPMS.
Added distribution test for running with JPMS.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-17 11:18:14 +02:00
Simone Bordet 2124deca18
Merge pull request #4093 from eclipse/jetty-9.4.x-3747-make_demo_work_with_jpms
Fixes #3747 - Make Jetty Demo work with JPMS.
2019-09-17 10:56:54 +02:00
Lachlan Roberts a0cd331327 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-HttpConnection_UpgradeCheck 2019-09-17 13:11:43 +10:00
Greg Wilkins c37c62323c updates from review
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-09-17 12:41:06 +10:00
Greg Wilkins bcf6b4c581 Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-1036-SchedulerThreads 2019-09-17 12:36:23 +10:00
Lachlan Roberts 42f1214796 fix OpenID module after rename of authenticateNewUsers
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-09-17 10:54:22 +10:00
Simone Bordet 422b9bded5 Fixes #3747 - Make Jetty Demo work with JPMS.
Introduced module `jdbc` and made other modules that require JDBC depend on it.
Modified demo.ini to enable the `jdbc` module because some webapp descriptor
of the demo requires JDBC classes.

Now the demo can be run fine on the module-path just by adding --jpms.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-16 22:57:55 +02:00
Joakim Erdfelt e013c24326
Merge pull request #4038 from eclipse/jetty-9.4.x-OpenId
OpenID Connect Authentication
2019-09-13 16:42:17 -05:00
Simone Bordet b3912d54fe Fixes #137 - Support OAuth.
Review and code cleanups.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-13 22:01:57 +02:00
Joakim Erdfelt 8cd1759681
Merge pull request #4087 from eclipse/jetty-9.4.x-3982-WebSocketConnectionStatsTest
Issue #3982 - fix flaky test WebSocketStatsTest
2019-09-13 12:19:02 -05:00
Joakim Erdfelt 39c230f294
Merge pull request #4083 from eclipse/jetty-9.4.x-97-Unavailable
Issue #97 ServletHolder unavailable handling
2019-09-13 09:58:09 -05:00