Commit Graph

15474 Commits

Author SHA1 Message Date
Greg Wilkins a272fb6e39
Improve executorSizedThreadPool (#2253)
Improve executorSizedThreadPool (#2253)

* Improve executorSizedThreadPool

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Improved implementation.

Implemented name, thread priorities, thread group and daemon properties.
Implemented toString(), dump() and using a thread factory.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

* added threadpool benchmark;

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Renamed ExecutorSizedThreadPool to ExecutorThreadPool

Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-03-06 19:07:41 +11:00
Greg Wilkins daeaad7624 improve test timing
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-03-06 19:03:46 +11:00
Greg Wilkins 9f2e4fd1f4 extra debug on test failure
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-03-06 18:59:56 +11:00
Greg Wilkins 2905d081b4
Merge pull request #2265 from eclipse/jetty-9.4.x-2262-sanitize-osgi-code
Jetty 9.4.x 2262 sanitize osgi code
2018-03-06 17:36:57 +11:00
Lachlan Roberts 31347db71b changes after second review from gregw
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-03-06 17:21:15 +11:00
Lachlan Roberts 1b3ad11ef9 work in progress
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-03-06 16:22:03 +11:00
Greg Wilkins 1713a49551 improved timing on http2 reset stream test
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-03-06 15:43:07 +11:00
Greg Wilkins 87bd4e8730 more robust accept spin test
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-03-06 15:39:19 +11:00
Greg Wilkins 2291d12b87 more robust idle test
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-03-06 15:34:42 +11:00
Greg Wilkins f6d9393bb5 more robust test by avoiding sleep
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-03-06 14:35:31 +11:00
Greg Wilkins e99f28bc17 more robust test by avoiding SSL close race
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-03-06 14:29:53 +11:00
Lachlan Roberts 020ebde77c found additional ReferenceEquality warnings which have been resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-03-06 14:28:11 +11:00
Greg Wilkins 4b62ab6006 Handle tilde in java version options #2284
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-03-06 14:17:30 +11:00
Greg Wilkins e2b9351662 Avoid NPE in exception for bad version #2284
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-03-06 13:13:41 +11:00
Jan Bartel c73ecae431
Jetty 9.4.x 2059 make osgi tests work jre9 (#2264)
* Issue #2059 WIP: make osgi tests work with jdk9

Signed-off-by: Jan Bartel <janb@webtide.com>
2018-03-06 11:04:50 +11:00
Joakim Erdfelt 1373025dff Issue #2282 - removing EventQueue from websocket tests 2018-03-05 17:52:23 -06:00
Jan Bartel 1ecf774912 Issue #2267 Added extra asserts to o.e.j.s.session.CreationTest 2018-03-06 10:17:11 +11:00
Joakim Erdfelt 076f3a8ab2 Issue #2269 - reworking SessionTest to be more resilient 2018-03-05 14:34:23 -06:00
Joakim Erdfelt 2879d5a5a0
Merge pull request #2277 from eclipse/jetty-9.4.x-2255-notify_ssl_handshake_on_write_failures
Issue #2255 - Notify SSL handshake failures on write failures.
2018-03-02 09:45:38 -06:00
Joakim Erdfelt f432a50599 Merge branch 'jetty-9.4.x-muted-build' into jetty-9.4.x 2018-03-02 08:24:58 -06:00
Joakim Erdfelt 01938b3282
Merge pull request #2276 from olamy/bugfix/osgi_test_dependencies
fix build with empty repo. add pax property with local maven repo used
2018-03-02 06:55:23 -06:00
olivier lamy ee61f381ba add pax property with local maven repo used
Signed-off-by: olivier lamy <olamy@webtide.com>
2018-03-02 20:26:17 +10:00
Simone Bordet fde21a45f7 Fixes #2011 - Improve ALPN documentation.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-03-01 11:34:37 +01:00
Jan Bartel 1ff2c691ba Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-2262-sanitize-osgi-code
Signed-off-by: Jan Bartel <janb@webtide.com>
2018-03-01 17:35:24 +11:00
Jan Bartel 05e2527b5c Issue #2262 Sanitize osgi code
Signed-off-by: Jan Bartel <janb@webtide.com>
2018-03-01 17:31:39 +11:00
Greg Wilkins c684295f7e removed accidentally merged file 2018-03-01 16:35:25 +11:00
Greg Wilkins 45472bf10b
Merge pull request #2263 from lachlan-roberts/jetty-9.4.x-2206-MissingOverride
Resolved errorprone MissingOverride warnings #2206 
Built locally as CI is currently down.
2018-03-01 16:05:48 +11:00
Jan Bartel 1173be318c
Issue #2203 Provide module for using GlobalWebAppConfig with Deployer (#2215)
* Issue #2203 Provide module for using GlobalWebAppConfig with Deployer
2018-03-01 14:45:07 +11:00
Lachlan Roberts a639ee9275 Resolved errorprone MissingOverride warnings #2206
`@Override` was added to methods which were missing the annotation #2206

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-03-01 13:59:25 +11:00
Jan Bartel 8cf357a17d
Jetty 9.4.x 2247 2256 modernize osgi test code (#2258)
* Issue #2247 Ensure random unused ssl port for osgi tests

Signed-off-by: Jan Bartel <janb@webtide.com>

* Issue #2256 code cleanup of osgi tests

Signed-off-by: Jan Bartel <janb@webtide.com>
2018-03-01 10:14:37 +11:00
Joakim Erdfelt ae35ffdb38 Correcting jetty-bom versions 2018-02-28 16:43:11 -06:00
Joakim Erdfelt a05b157c03 Updating to version 9.3.24-SNAPSHOT 2018-02-28 16:39:30 -06:00
Joakim Erdfelt 0554f8d8b4 Updating to version 9.3.23.v20180228 2018-02-28 15:45:57 -06:00
Joakim Erdfelt d7ea895aeb Fixing VERSION.txt order 2018-02-28 15:43:53 -06:00
Simone Bordet 718ac76815 Issue #2255 - Notify SSL handshake failures on write failures.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-02-28 21:32:42 +01:00
Joakim Erdfelt 8728f2b2c7 Marking stages with jdk name too (helping in jenkins UI) 2018-02-28 12:43:03 -06:00
Lachlan Roberts 480c0e718a Merge branch 'jetty-9.4.x' into jetty-9.4.x-2206-ReferenceEquality 2018-02-28 16:14:49 +11:00
Lachlan Roberts 016c8076e0 updates after review #2206
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-02-28 16:02:47 +11:00
Jan Bartel 0b89ffd055 Issue #2247 Ensure random unused ssl port for osgi tests
Signed-off-by: Jan Bartel <janb@webtide.com>
2018-02-28 15:03:44 +11:00
Greg Wilkins 48eebacd6c more robust test
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-02-28 14:28:58 +11:00
Lachlan Roberts 0cfc25d4ed Resolved errorprone ReferenceEquality warnings #2206
Objects which inherit or implement an `equals()` method should not be compared with == or !=
When the comparison of references is intentional `@SuppressWarnings("ReferenceEquality")` can be used

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-02-28 14:26:02 +11:00
Simone Bordet cd7432da95 Issue #2238 - RoundRobinConnectionPoolTest.testRoundRobin test failure
Improved logging in case of test failures.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-02-27 18:49:23 +01:00
Joakim Erdfelt 72f4f13510 Making DosFilterTest.testDelayedIP more resilient 2018-02-27 11:28:26 -06:00
Joakim Erdfelt 8dc073e5ba Fixing Windows test. '/tmp' is invalid path on Windows 2018-02-27 09:56:43 -06:00
Simone Bordet f4b82755ad Now also logging the readyOps of the key that has been selected.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-02-27 12:03:36 +01:00
Greg Wilkins 04c0632d47
Merge pull request #2252 from lachlan-roberts/jetty-9.4.x-2206-OperatorPrecedence
Disabled errorprone OperatorPrecedence warnings #2206
2018-02-27 14:58:45 +11:00
Lachlan Roberts 27a0cbfacd Merge remote-tracking branch 'eclipse/jetty-9.4.x' into jetty-9.4.x-2206-OperatorPrecedence 2018-02-27 14:56:33 +11:00
Lachlan Roberts 6e3f581ae4 Disabled errorprone OperatorPrecedence warnings #2206
brackets can be used optionally for clarity but aren't manditory #2206

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-02-27 14:49:17 +11:00
Greg Wilkins 0cb4f5629d
Jetty 9.4.x 1803 proposal 0+2 (#2199)
Merging this PR for #2199 as we currently think it is not worse than previous and the code base is definitely simpler.   While JMH has shown significant benefits for this approach, we have yet been able to demonstrate them in full scale integration tests - however that is likely due to GC and thread pool issues dominating.

A `org.eclipse.jetty.http2.PEC_MODE` System property has been added to allow the EWYK scheduling to be disabled for HTTP/2 if need be.


* Implementation of #1803 proposal 2 - EITHER dispatch type for EWYK
* made code more readable
* increase small threadpools in tests for extra reserved thread
* clean up
* minor code simplifications
* Work in progress to simplify reserved thread pool
* use a single ReservedThreadPool built into the QueuedThreadPool
* fixed javadoc
* removed more old reserved thread references
* disable EWYK for h2
* fixes from review
* use EWYK for HTTP2
* Fixed javadocs, imports and QueuedThreadPool constructors.
* fix javadoc
* EWYK avoid unnecessary pendings
* after review
* fixed merge with jetty-threadpool.xml
* alternate EWYK implementations
* added jetty copyright headers
* Simplified EWYK code after review
* fixed bad merge
* Code cleanups.
* Improved Javadocs for deprecated property "reservedThreads".
* Improved Javadocs for deprecated property "reservedThreads".
* added a system property to enable only PEC for HTTP/2

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-02-27 14:29:59 +11:00
Greg Wilkins eb42a9e71f
Merge pull request #2251 from lachlan-roberts/jetty-9.4.x-2206-util-defaultCharset
Resolved default charset warning in jetty-util for #2206

Merging prior to CI as no substantive code changes (and CI is borked anyway at the moment)
2018-02-27 12:26:55 +11:00