Commit Graph

18877 Commits

Author SHA1 Message Date
Ludovic Orban b7b16a880b review comment: improve readability
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2021-05-19 09:38:18 +02:00
Ludovic Orban 593f4225f8 only release connection when channel got released to avoid double connection release race condition
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2021-05-19 09:38:18 +02:00
olivier lamy 97a2a9993f bump to next version 9.4.42-SNAPSHOT
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2021-05-18 13:06:42 +02:00
Jan Bartel 087f486b44
Issue #6277 Better handling of exceptions thrown in sessionDestroyed (#6278) (#6279)
* Issue #6277 Better handling of exceptions thrown in sessionDestroyed

Signed-off-by: Jan Bartel <janb@webtide.com>
2021-05-16 17:32:49 +10:00
Joakim Erdfelt edcaf70d9a
Copy ServletHolder class/instance properly during startWebapp (#6214)
ServletHolder.copyClassServlet() method added to correctly copy held class.


Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2021-05-16 11:28:22 +10:00
Lachlan 1c05b0bcb1
Fixes #6263 - Review URI encoding in ConcatServlet & WelcomeFilter.
Review URI encoding in ConcatServlet & WelcomeFilter and improve testing.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
2021-05-12 17:13:30 +02:00
Lachlan Roberts 9cb93432b3 Issue #6205 - Fix serialization issues in OpenIdAuthenticator
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-05-12 17:06:38 +02:00
Lachlan 2e7f5ebd2b Issue #6205 - Fix issues with OpenID redirecting to wrong URI (#6211)
Use the OpenID state param to map to the redirect URI.
2021-05-12 16:50:42 +02:00
Simone Bordet 88ac10439a Issue #6254 - Total timeout not enforced for queued requests.
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-05-12 01:30:07 +02:00
Simone Bordet da50e06b64 Fixes #6254 - Total timeout not enforced for queued requests.
Fixed logic in HttpDestination.RequestTimeouts, where now a timeout
is scheduled only when the expiration time is less than the existing one.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-05-12 01:30:07 +02:00
Simone Bordet 5f23689aa7 Issue #6254 - Total timeout not enforced for queued requests.
Various code cleanups.
Renamed HttpDestination.TimeoutTask to RequestTimeouts for clarity.
Improved javadocs, code comments and logging.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-05-12 01:30:07 +02:00
Olivier Lamy 003c3134ca
upgrade h2spec-maven-plugin 1.0.5 (#6247)
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2021-05-11 09:31:32 +10:00
Simone Bordet 68296911b7 Fixes #6099 - Cipher preference may break SNI if certificates have different key types.
Updated the logic in SslContextFactory.Server.sniSelect(...) to check if there is
any certificate that matches, and if so return a null alias in the hope to be called
again and pick the right alias for the SNI.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-05-10 10:38:42 +02:00
Simone Bordet e5f28dbc16 Added hint to use java -version to report the Java version/vendor.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-05-06 22:11:23 +02:00
Greg Wilkins ad6d23fc68
Fix #6227 Async timeout dispatch race (#6228)
Fix #6227 Async timeout dispatch race
Only allow the thread calling onTimeout to call dispatch and complete once timeout has expired.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2021-05-04 14:18:48 +10:00
Simone Bordet 2f19c67b41
Fixes #6208 - HTTP/2 max local stream count exceeded (#6220)
* Fixes #6208 - HTTP/2 max local stream count exceeded

Backported from Jetty 10 the "new stream" event so that the Stream can be set early on the client's `HttpChannelOverHTTP2`.
In this way, when a HEADERS frame stalled due to TCP congestion is failed, the corresponding Stream is closed and the connection released to the pool, fixing the "max stream exceeded" issue.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-04-29 09:30:23 +02:00
Joakim Erdfelt e3abe7b498
Merge pull request #6212 from eclipse/jetty-9.4.x-better-ontimeout-warnings
Improving logging for failure in onTimeout listener
2021-04-27 07:03:31 -05:00
Joakim Erdfelt cc7975206c
Improving logging for failure in onTimeout listener
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-04-26 15:01:14 -05:00
Joakim Erdfelt b15b37f944
Merge pull request #6187 from eclipse/jetty-9.4.x-6186-no-null-logger
Issue #6186 - Add null protection to Log/Logger API
2021-04-21 06:26:14 -05:00
Lachlan a4124b43a1
Merge pull request #6194 from eclipse/jetty-9.4.x-FileBufferedResponseHandler
Create FileBufferedResponseHandler to buffer responses into a file.
2021-04-21 11:05:55 +10:00
Lachlan eca8edcea5 Create FileBufferedResponseHandler to buffer responses into a file. (#6010)
FileBufferedResponseHandler adds an HttpOutput.Interceptor to buffer all responses into a file until the output is closed. This allows the commit to be delayed until the response is complete and thus headers and response status can be changed while writing the body.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-04-19 15:02:43 +10:00
Joakim Erdfelt ee29860b18
Issue #6186 - Add null protection to Log/Logger API
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-04-16 10:44:54 -05:00
Joakim Erdfelt 39fe2ecc4d
Merge pull request #6180 from eclipse/release-9.4.40
Merge Release 9.4.40 changes into `jetty-9.4.x`
2021-04-15 19:31:13 -05:00
Joakim Erdfelt 241ca2c2a0 Updating to version 9.4.41-SNAPSHOT 2021-04-13 16:24:42 -05:00
Joakim Erdfelt b881a57266 Updating to version 9.4.40.v20210413 2021-04-13 15:32:28 -05:00
Simone Bordet fe359ac117
Fixes #6168 - Improve handling of unconsumed content
Added or expanded the scope of catch blocks to properly handle exceptions thrown by `HttpInput.Interceptor`.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-04-13 16:54:53 +02:00
Jan Bartel 57d0bae2f9
Issue #5684 Reduce intensity and rename SameNodeLoadTest (#6143)
Signed-off-by: Jan Bartel <janb@webtide.com>
2021-04-13 17:12:47 +10:00
Joakim Erdfelt 23c45c094b
Merge pull request #6149 from eclipse/jetty-9.4.x-start-tag-name
Issue #6148 - update jetty.tag.version behavior
2021-04-12 09:03:18 -05:00
Joakim Erdfelt 19a1b0c74f
Issue #6148 - introduce jetty.build to show git sha for build
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-04-09 16:52:40 -05:00
Joakim Erdfelt 871560032e
Issue #6148 - update jetty.tag.version behavior
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-04-08 13:50:20 -05:00
Simone Bordet aed20abcbe
Fixes #6105 - HttpConnection.getBytesIn() incorrect for requests with… (#6108)
* Fixes #6105 - HttpConnection.getBytesIn() incorrect for requests with chunked content

Moved recording of bytes to fillRequestBuffer(),
so they are accounted also for async reads.
Added test case.
Fixed test that was too strictly comparing HttpConnection.bytesIn,
that now report a correct, but larger value.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-04-08 12:19:17 +02:00
Greg Wilkins 58538c90b5 Fix #6082 Reduce SSL buffer compaction (#6083)
Fix #6082 Reduce SSL buffer compaction
Only compact when buffer is underflown.  Note that BufferUtil will also do a cheap "compact" when flipping empty buffers.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
(cherry picked from commit 96f707f74b)
2021-04-07 09:21:58 +02:00
Lachlan 941d7fb369
Improve testing for temp directories (#5483)
Improve testing around WebAppContext temporary directories.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Co-authored-by: olivier lamy <oliver.lamy@gmail.com>
2021-04-06 10:29:08 +10:00
Joakim Erdfelt 45c6599bc7
Merge pull request #6134 from eclipse/jetty-9.4.x-version-cve-update
Update VERSION.txt
2021-04-05 13:32:00 -05:00
Joakim Erdfelt 3a86b0c430
Update VERSION.txt
+ Add CVE references
+ Remove reference to fixing testcases

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-04-05 12:14:40 -05:00
Jesse McConnell c50bed4e65
#6110 fix JDURL and plugin declaration. (#6111) 2021-03-29 09:35:03 -05:00
Jesse McConnell d23925809d
Updating to version 9.4.40-SNAPSHOT 2021-03-25 10:06:56 -05:00
Jesse McConnell 9fc7ca5a92
update VERSION.txt 2021-03-25 09:36:22 -05:00
Jesse McConnell ee95f92d70
Updating to version 9.4.39.v20210325 2021-03-25 09:33:14 -05:00
Jesse McConnell 0992dbd35f
reset Version.txt 2021-03-25 09:20:02 -05:00
Jesse McConnell 65c2da3de3
reset build-resources version 2021-03-25 09:14:45 -05:00
Jesse McConnell 7dacf1503f
reset release to 9.4.39-SNAPSHOT 2021-03-25 09:03:35 -05:00
Jesse McConnell be786489a8
reset release to 9.4.39-SNAPSHOT 2021-03-25 08:52:25 -05:00
Simone Bordet f6afdc5b01 Issue #6085 Fix duplicate valid session cookies to pick first valid.
Fixed typo and stopping server & client in testMulitpleIdenticalSessionCookies().

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-03-25 13:09:32 +01:00
Simone Bordet 64006c61c6 Issue #6085 Fix duplicate valid session cookies to pick first valid.
Cosmetic changes.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-03-25 13:09:32 +01:00
Jan Bartel af042ba297 Issue #6085 Fix duplicate valid session cookies to pick first valid.
Signed-off-by: Jan Bartel <janb@webtide.com>
2021-03-25 13:09:32 +01:00
Olivier Lamy e0111e581a Updating to version 9.4.40-SNAPSHOT 2021-03-25 03:39:19 +00:00
Olivier Lamy e56edccd03 Updating to version 9.4.39.v20210325 2021-03-25 03:20:25 +00:00
Joakim Erdfelt 1154f2ee4f
Issue #6063 - expose hazelcast.version (#6064)
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-03-25 09:23:50 +10:00
Greg Wilkins cb4b4d853d disable test on windows
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2021-03-25 09:37:23 +11:00