* Issue #1363
This is just some renaming withing HttpInput to improve it's understandability, plus a small
amount of refactoring for EOF handling.
This does not yet fix the deadlock, but is working towards better EOF handling so that state
can be pushed from HttpInput to HttpChannelState and avoid the need to query HttpInput state.
* Issue #1363Fixed#1363 deadlock by removing the call from HttpChannelState#unhandle to HttpInput This backed out the fix for #1317, which was fixed differently:
+ HttpChannelState#onReadEof now always sets _asyncReadPossible to true and _asyncRead to REGISTERED, so that the tests in both #handling and #unhandle will be true and return an Action.READ_CALLBACK
+ HttpInput#run now moves the state from AEOF to EOF if it directly consumes EOF from interceptedContent
+ HttpInput#run no longer calls onAllDataRead after a onDataAvailable, instead relying on the #onReadEof call to make #unhandle return Action.READ_CALLBACK
so that onAllDataRead is called on a subsequent execution of #run
Tidy up write side.
It cannot be the same as the read side as there is no registration for write interest. There is only write operations and the
callbacks associated with them.
Fixed by calling tryFillInterested() rather than fillInterested() to
cope with the race between reads scheduling read interest and
setWriteListener() that also executes code in
HttpChannelState.unhandle() that wants to schedule read interest.
+ Reverting change to HttpTester.parseResponse(Input)
+ Providing new HttpTester.parsePartialResponse(Input)
+ InsufficientBytes tests no longer assert content strings with invalid
characters (this was breaks the surefire report xml)
+ Reverting change to HttpTester.parseResponse(Input)
+ Providing new HttpTester.parsePartialResponse(Input)
+ InsufficientBytes tests no longer assert content strings with invalid
characters (this was breaks the surefire report xml)
Greg Wilkins
Joakim Erdfelt
Brandon Mintern
Jan Bartel
Simone Bordet