Checkstyle fixups.

This commit is contained in:
Chris Cranford 2017-06-12 11:40:38 -04:00
parent 699b50725d
commit 03053502e1
1 changed files with 28 additions and 28 deletions

View File

@ -285,8 +285,8 @@ public class ActionQueue {
} }
insert.makeEntityManaged(); insert.makeEntityManaged();
if( unresolvedInsertions != null ) { if( unresolvedInsertions != null ) {
for (AbstractEntityInsertAction resolvedAction : unresolvedInsertions.resolveDependentActions(insert.getInstance(), session)) { for ( AbstractEntityInsertAction resolvedAction : unresolvedInsertions.resolveDependentActions( insert.getInstance(), session ) ) {
addResolvedEntityInsertAction(resolvedAction); addResolvedEntityInsertAction( resolvedAction );
} }
} }
} }
@ -383,7 +383,7 @@ public class ActionQueue {
if( beforeTransactionProcesses == null ) { if( beforeTransactionProcesses == null ) {
beforeTransactionProcesses = new BeforeTransactionCompletionProcessQueue( session ); beforeTransactionProcesses = new BeforeTransactionCompletionProcessQueue( session );
} }
beforeTransactionProcesses.register(executable.getBeforeTransactionCompletionProcess()); beforeTransactionProcesses.register( executable.getBeforeTransactionCompletionProcess() );
} }
if ( session.getFactory().getSessionFactoryOptions().isQueryCacheEnabled() ) { if ( session.getFactory().getSessionFactoryOptions().isQueryCacheEnabled() ) {
invalidateSpaces( executable.getPropertySpaces() ); invalidateSpaces( executable.getPropertySpaces() );
@ -392,7 +392,7 @@ public class ActionQueue {
if( afterTransactionProcesses == null ) { if( afterTransactionProcesses == null ) {
afterTransactionProcesses = new AfterTransactionCompletionProcessQueue( session ); afterTransactionProcesses = new AfterTransactionCompletionProcessQueue( session );
} }
afterTransactionProcesses.register(executable.getAfterTransactionCompletionProcess()); afterTransactionProcesses.register( executable.getAfterTransactionCompletionProcess() );
} }
} }
@ -495,7 +495,7 @@ public class ActionQueue {
if ( !isTransactionCoordinatorShared ) { if ( !isTransactionCoordinatorShared ) {
// Execute completion actions only in transaction owner (aka parent session). // Execute completion actions only in transaction owner (aka parent session).
if( afterTransactionProcesses != null ) { if( afterTransactionProcesses != null ) {
afterTransactionProcesses.afterTransactionCompletion(success); afterTransactionProcesses.afterTransactionCompletion( success );
} }
} }
} }
@ -593,13 +593,13 @@ public class ActionQueue {
if( beforeTransactionProcesses == null ) { if( beforeTransactionProcesses == null ) {
beforeTransactionProcesses = new BeforeTransactionCompletionProcessQueue( session ); beforeTransactionProcesses = new BeforeTransactionCompletionProcessQueue( session );
} }
beforeTransactionProcesses.register(e.getBeforeTransactionCompletionProcess()); beforeTransactionProcesses.register( e.getBeforeTransactionCompletionProcess() );
} }
if( e.getAfterTransactionCompletionProcess() != null ) { if( e.getAfterTransactionCompletionProcess() != null ) {
if( afterTransactionProcesses == null ) { if( afterTransactionProcesses == null ) {
afterTransactionProcesses = new AfterTransactionCompletionProcessQueue( session ); afterTransactionProcesses = new AfterTransactionCompletionProcessQueue( session );
} }
afterTransactionProcesses.register(e.getAfterTransactionCompletionProcess()); afterTransactionProcesses.register( e.getAfterTransactionCompletionProcess() );
} }
} }
} }
@ -655,14 +655,14 @@ public class ActionQueue {
*/ */
@Override @Override
public String toString() { public String toString() {
return "ActionQueue[insertions=" + toString(insertions) return "ActionQueue[insertions=" + toString( insertions )
+ " updates=" + toString(updates) + " updates=" + toString( updates )
+ " deletions=" + toString(deletions) + " deletions=" + toString( deletions )
+ " orphanRemovals=" + toString(orphanRemovals) + " orphanRemovals=" + toString( orphanRemovals )
+ " collectionCreations=" + toString(collectionCreations) + " collectionCreations=" + toString( collectionCreations )
+ " collectionRemovals=" + toString(collectionRemovals) + " collectionRemovals=" + toString( collectionRemovals )
+ " collectionUpdates=" + toString(collectionUpdates) + " collectionUpdates=" + toString( collectionUpdates )
+ " collectionQueuedOps=" + toString(collectionQueuedOps) + " collectionQueuedOps=" + toString( collectionQueuedOps )
+ " unresolvedInsertDependencies=" + unresolvedInsertions + " unresolvedInsertDependencies=" + unresolvedInsertions
+ "]"; + "]";
} }
@ -811,25 +811,25 @@ public class ActionQueue {
public void unScheduleDeletion(EntityEntry entry, Object rescuedEntity) { public void unScheduleDeletion(EntityEntry entry, Object rescuedEntity) {
if ( rescuedEntity instanceof HibernateProxy ) { if ( rescuedEntity instanceof HibernateProxy ) {
LazyInitializer initializer = ( ( HibernateProxy ) rescuedEntity ).getHibernateLazyInitializer(); LazyInitializer initializer = ( (HibernateProxy) rescuedEntity ).getHibernateLazyInitializer();
if ( !initializer.isUninitialized() ) { if ( !initializer.isUninitialized() ) {
rescuedEntity = initializer.getImplementation( session ); rescuedEntity = initializer.getImplementation( session );
} }
} }
if( deletions != null ) { if( deletions != null ) {
for ( int i = 0; i < deletions.size(); i++ ) { for ( int i = 0; i < deletions.size(); i++ ) {
EntityDeleteAction action = deletions.get(i); EntityDeleteAction action = deletions.get( i );
if (action.getInstance() == rescuedEntity) { if (action.getInstance() == rescuedEntity) {
deletions.remove(i); deletions.remove( i );
return; return;
} }
} }
} }
if( orphanRemovals != null ) { if( orphanRemovals != null ) {
for ( int i = 0; i < orphanRemovals.size(); i++ ) { for ( int i = 0; i < orphanRemovals.size(); i++ ) {
EntityDeleteAction action = orphanRemovals.get(i); EntityDeleteAction action = orphanRemovals.get( i );
if (action.getInstance() == rescuedEntity) { if (action.getInstance() == rescuedEntity) {
orphanRemovals.remove(i); orphanRemovals.remove( i );
return; return;
} }
} }
@ -851,9 +851,9 @@ public class ActionQueue {
unresolvedInsertions.serialize( oos ); unresolvedInsertions.serialize( oos );
for ( ListProvider p : EXECUTABLE_LISTS_MAP.values() ) { for ( ListProvider p : EXECUTABLE_LISTS_MAP.values() ) {
ExecutableList<?> l = p.get(this); ExecutableList<?> l = p.get( this );
if( l == null ) { if( l == null ) {
oos.writeBoolean(false); oos.writeBoolean( false );
} }
else { else {
oos.writeBoolean( true ); oos.writeBoolean( true );
@ -874,18 +874,18 @@ public class ActionQueue {
public static ActionQueue deserialize(ObjectInputStream ois, SessionImplementor session) throws IOException, ClassNotFoundException { public static ActionQueue deserialize(ObjectInputStream ois, SessionImplementor session) throws IOException, ClassNotFoundException {
final boolean traceEnabled = LOG.isTraceEnabled(); final boolean traceEnabled = LOG.isTraceEnabled();
if ( traceEnabled ) { if ( traceEnabled ) {
LOG.trace("Deserializing action-queue"); LOG.trace( "Deserializing action-queue" );
} }
ActionQueue rtn = new ActionQueue( session ); ActionQueue rtn = new ActionQueue( session );
rtn.unresolvedInsertions = UnresolvedEntityInsertActions.deserialize( ois, session ); rtn.unresolvedInsertions = UnresolvedEntityInsertActions.deserialize( ois, session );
for ( ListProvider provider : EXECUTABLE_LISTS_MAP.values() ) { for ( ListProvider provider : EXECUTABLE_LISTS_MAP.values() ) {
ExecutableList<?> l = provider.get(rtn); ExecutableList<?> l = provider.get( rtn );
boolean notNull = ois.readBoolean(); boolean notNull = ois.readBoolean();
if( notNull ) { if( notNull ) {
if(l == null) { if(l == null) {
l = provider.init(rtn); l = provider.init( rtn );
} }
l.readExternal( ois ); l.readExternal( ois );
@ -899,7 +899,7 @@ public class ActionQueue {
return rtn; return rtn;
} }
private static abstract class AbstractTransactionCompletionProcessQueue<T> { private abstract static class AbstractTransactionCompletionProcessQueue<T> {
protected SessionImplementor session; protected SessionImplementor session;
// Concurrency handling required when transaction completion process is dynamically registered // Concurrency handling required when transaction completion process is dynamically registered
// inside event listener (HHH-7478). // inside event listener (HHH-7478).
@ -1111,7 +1111,7 @@ public class ActionQueue {
} }
addParentChildEntityNames( action, batchIdentifier ); addParentChildEntityNames( action, batchIdentifier );
entityBatchIdentifier.put( currentEntity, batchIdentifier ); entityBatchIdentifier.put( currentEntity, batchIdentifier );
addToBatch(batchIdentifier, action); addToBatch( batchIdentifier, action );
} }
insertions.clear(); insertions.clear();
@ -1220,7 +1220,7 @@ public class ActionQueue {
} }
private static abstract class ListProvider<T extends Executable & Comparable & Serializable> { private abstract static class ListProvider<T extends Executable & Comparable & Serializable> {
abstract ExecutableList<T> get(ActionQueue instance); abstract ExecutableList<T> get(ActionQueue instance);
abstract ExecutableList<T> init(ActionQueue instance); abstract ExecutableList<T> init(ActionQueue instance);
ExecutableList<T> getOrInit( ActionQueue instance ) { ExecutableList<T> getOrInit( ActionQueue instance ) {