HHH-5942 - Migrate to JUnit 4

hibernate-core/src/test/java/org/hibernate/test/hql/ASTParserLoadingOrderByTest.java

@@ -34,6 +34,8 @@
 import org.hibernate.cfg.Environment;
 import org.hibernate.hql.ast.ASTQueryTranslatorFactory;
 
+import org.junit.After;
+import org.junit.Before;
 import org.junit.Test;
 
 import org.hibernate.testing.FailureExpected;
@@ -75,12 +77,7 @@ public void configure(Configuration cfg) {
 		cfg.setProperty( Environment.QUERY_TRANSLATOR, ASTQueryTranslatorFactory.class.getName() );
 	}
 
-	@Override
+	private void createData() {
-	protected void prepareTest() {
-		cleanupData();
-	}
-
-	protected void createData() {
 		stateProvince = new StateProvince();
 		stateProvince.setName( "IL" );
 
@@ -156,7 +153,7 @@ protected void createData() {
 		zoosWithSameAddress.add( zoo2 );
 	}
 
-	protected void cleanupData() {
+	private void cleanupData() {
 		Session s = openSession();
 		Transaction t = s.beginTransaction();
 		if ( zoo1 != null ) {

hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseCoreFunctionalTestCase.java

@@ -61,7 +61,6 @@
 import org.hibernate.testing.OnFailure;
 import org.hibernate.testing.SkipLog;
 
-import static org.hibernate.testing.TestLogger.LOG;
 import static org.junit.Assert.fail;
 
 /**
@@ -110,7 +109,6 @@ protected org.hibernate.classic.Session openSession(Interceptor interceptor) thr
 
 	@BeforeClassOnce
 	private void buildSessionFactory() {
-		LOG.trace( "Building session factory" );
 		configuration = buildConfiguration();
 		serviceRegistry = buildServiceRegistry( configuration );
 		sessionFactory = (SessionFactoryImplementor) configuration.buildSessionFactory( serviceRegistry );
@@ -273,7 +271,6 @@ private void releaseSessionFactory() {
 		if ( sessionFactory == null ) {
 			return;
 		}
-		LOG.trace( "Releasing session factory" );
 		sessionFactory.close();
 		sessionFactory = null;
 		configuration = null;
@@ -282,12 +279,11 @@ private void releaseSessionFactory() {
 	@OnFailure
 	@OnExpectedFailure
 	public void onFailure() {
-		LOG.trace( "Processing failure-expected ignore" );
+//		cleanupSession();
-		if ( ! rebuildSessionFactoryOnError() ) {
-			return;
-		}
 
-		rebuildSessionFactory();
+		if ( rebuildSessionFactoryOnError() ) {
+			rebuildSessionFactory();
+		}
 	}
 
 	protected void rebuildSessionFactory() {
@@ -307,6 +303,7 @@ protected void rebuildSessionFactory() {
 
 	@Before
 	public final void beforeTest() throws Exception {
+		System.out.println( " IN @Before CALLBACK!" );
 		prepareTest();
 	}
 
@@ -315,21 +312,22 @@ protected void prepareTest() throws Exception {
 
 	@After
 	public final void afterTest() throws Exception {
+		System.out.println( " IN @After CALLBACK!" );
 		cleanupTest();
 
+		cleanupSession();
+
+		assertAllDataRemoved();
+	}
+
+	private void cleanupSession() {
 		if ( session != null && ! ( (SessionImplementor) session ).isClosed() ) {
 			if ( session.isConnected() ) {
 				session.doWork( new RollbackWork() );
 			}
 			session.close();
-			session = null;
-			LOG.debug( "unclosed session" );
 		}
-		else {
+		session = null;
-			session = null;
-		}
-
-		assertAllDataRemoved();
 	}
 
 	public class RollbackWork implements Work {

hibernate-testing/src/main/java/org/hibernate/testing/junit4/CustomRunner.java

@@ -90,20 +90,12 @@ protected Statement withAfterClasses(Statement statement) {
 		);
 	}
 
+
 	@Override
-	protected Statement methodInvoker(FrameworkMethod method, final Object test) {
+	protected Statement methodBlock(FrameworkMethod method) {
+		final Statement originalMethodBlock = super.methodBlock( method );
 		final ExtendedFrameworkMethod extendedFrameworkMethod = (ExtendedFrameworkMethod) method;
-
+		return new FailureExpectedHandler( originalMethodBlock, testClassMetadata, extendedFrameworkMethod, testInstance );
-
-		final Statement invoker = super.methodInvoker( method, test );
-
-		return new TestMethodInvoker( invoker, testClassMetadata, extendedFrameworkMethod, test );
-	}
-
-	public static class FailureExpectedTestPassedException extends Exception {
-		public FailureExpectedTestPassedException(FrameworkMethod frameworkMethod) {
-			super( "Test marked as FailureExpected, but did not fail : " + Helper.extractTestName( frameworkMethod ) );
-		}
 	}
 
 	private Object testInstance;

hibernate-testing/src/main/java/org/hibernate/testing/junit4/FailureExpectedHandler.java

@@ -23,6 +23,7 @@
  */
 package org.hibernate.testing.junit4;
 
+import org.junit.runners.model.FrameworkMethod;
 import org.junit.runners.model.Statement;
 
 import org.hibernate.testing.FailureExpected;
@@ -31,13 +32,13 @@
 /**
 * @author Steve Ebersole
 */
-class TestMethodInvoker extends Statement {
+class FailureExpectedHandler extends Statement {
 	private final TestClassMetadata testClassMetadata;
 	private final ExtendedFrameworkMethod extendedFrameworkMethod;
 	private final Statement realInvoker;
 	private final Object testInstance;
 
-	public TestMethodInvoker(
+	public FailureExpectedHandler(
 			Statement realInvoker,
 			TestClassMetadata testClassMetadata,
 			ExtendedFrameworkMethod extendedFrameworkMethod,
@@ -55,10 +56,10 @@ public void evaluate() throws Throwable {
 			realInvoker.evaluate();
 			// reaching here is expected, unless the test is marked as an expected failure
 			if ( failureExpected != null ) {
-				throw new CustomRunner.FailureExpectedTestPassedException( extendedFrameworkMethod );
+				throw new FailureExpectedTestPassedException( extendedFrameworkMethod );
 			}
 		}
-		catch (CustomRunner.FailureExpectedTestPassedException e) {
+		catch (FailureExpectedTestPassedException e) {
 			// just pass this along
 			throw e;
 		}
@@ -81,4 +82,10 @@ public void evaluate() throws Throwable {
 			}
 		}
 	}
+
+	public static class FailureExpectedTestPassedException extends Exception {
+		public FailureExpectedTestPassedException(FrameworkMethod frameworkMethod) {
+			super( "Test marked as FailureExpected, but did not fail : " + Helper.extractTestName( frameworkMethod ) );
+		}
+	}
 }