Hibernate/hibernate-orm
1
0
Fork 0
mirror of https://github.com/hibernate/hibernate-orm synced 2025-02-17 00:24:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

HHH-6866 Reverting to the char(1) mapping for Types.CHAR

Browse Source
This commit is contained in:
Hardy Ferentschik 2011-12-01 14:46:45 +01:00
parent b0573072e6
commit 0af7d0645d
2 changed files with 1 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hibernate-core/src/main/java/org/hibernate/dialect/DB2Dialect.java
View File

@ -51,8 +51,7 @@ public DB2Dialect() {
registerColumnType( Types.SMALLINT, "smallint" );
registerColumnType( Types.TINYINT, "smallint" );
registerColumnType( Types.INTEGER, "integer" );
registerColumnType( Types.CHAR, "varchar($l)" );
registerColumnType( Types.CHAR, 254, "char($l)" );
registerColumnType( Types.CHAR, "char(1)" );
registerColumnType( Types.VARCHAR, "varchar($l)" );
registerColumnType( Types.FLOAT, "float" );
registerColumnType( Types.DOUBLE, "double" );

39
hibernate-core/src/test/java/org/hibernate/dialect/DB2DialectTestCase.java
View File

@ -80,43 +80,4 @@ public void testGetExplicitBinaryTypeName() {
actual
);
}
@Test
@TestForIssue(jiraKey = "HHH-6866")
public void testGetDefaultCharTypeName() {
String actual = dialect.getTypeName( Types.CHAR );
assertEquals(
"The default column length is 255, but char length on DB2 is limited to 254",
"varchar($l)",
actual
);
}
@Test
@TestForIssue(jiraKey = "HHH-6866")
public void testGetExplicitCharTypeName() {
// lower bound
String actual = dialect.getTypeName( Types.CHAR, 1, Column.DEFAULT_PRECISION, Column.DEFAULT_SCALE );
assertEquals(
"Wrong char type",
"char(1)",
actual
);
// upper bound
actual = dialect.getTypeName( Types.CHAR, 254, Column.DEFAULT_PRECISION, Column.DEFAULT_SCALE );
assertEquals(
"Wrong char type. 254 is the max length in DB2",
"char(254)",
actual
);
// exceeding upper bound
actual = dialect.getTypeName( Types.CHAR, 255, Column.DEFAULT_PRECISION, Column.DEFAULT_SCALE );
assertEquals(
"Wrong char type. Should be varchar for length > 254",
"varchar(255)",
actual
);
}
}