Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-10419 Detect if the user inappropriately left @Convert.converter to void

This commit is contained in:
Emmanuel Bernard 2016-01-06 15:02:38 +01:00
parent bb7cb7636b
commit 0c38cfc9d7
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
hibernate-core/src/main/java/org/hibernate/cfg/AbstractPropertyHolder.java
View File

@ -94,10 +94,24 @@ public abstract class AbstractPropertyHolder implements PropertyHolder {
} }
protected IllegalStateException buildExceptionFromInstantiationError(AttributeConversionInfo info, Exception e) { protected IllegalStateException buildExceptionFromInstantiationError(AttributeConversionInfo info, Exception e) {
return new IllegalStateException( if ( void.class.equals( info.getConverterClass() ) ) {
String.format( "Unable to instantiate AttributeConverter [%s]", info.getConverterClass().getName() ), // the user forgot to set @Convert.converter
e // we already know it's not a @Convert.disableConversion
); return new IllegalStateException(
"Unable to instantiate AttributeConverter: you left @Convert.converter to its default value void.",
e
);
}
else {
return new IllegalStateException(
String.format(
"Unable to instantiate AttributeConverter [%s]",
info.getConverterClass().getName()
),
e
);
}
} }
protected AttributeConverterDescriptor makeAttributeConverterDescriptor(AttributeConversionInfo conversion) { protected AttributeConverterDescriptor makeAttributeConverterDescriptor(AttributeConversionInfo conversion) {