From 0dd2defc89aef14f339edaacbb387f9aa97f3cd5 Mon Sep 17 00:00:00 2001 From: Gavin King Date: Thu, 5 Sep 2024 08:28:33 +0200 Subject: [PATCH] @SuppressWarnings({"UnusedDeclaration"}) -> @SuppressWarnings("unused") Signed-off-by: Gavin King --- .../c3p0/internal/C3P0ConnectionProvider.java | 2 +- .../java/org/hibernate/ReplicationMode.java | 1 - .../spi/AbstractArchiveDescriptor.java | 2 +- .../beanvalidation/TypeSafeActivator.java | 4 +-- .../cache/internal/NaturalIdCacheKey.java | 6 ++-- .../collection/spi/PersistentArrayHolder.java | 2 +- .../collection/spi/PersistentBag.java | 4 +-- .../spi/PersistentIdentifierBag.java | 2 +- .../collection/spi/PersistentSortedMap.java | 2 +- .../collection/spi/PersistentSortedSet.java | 2 +- .../dialect/ColumnAliasExtractor.java | 2 +- .../DatasourceConnectionProviderImpl.java | 2 +- .../internal/jta/JtaStatusHelper.java | 2 +- .../BaselineSessionEventsListenerBuilder.java | 4 +-- .../internal/PluralAttributeMetadata.java | 2 +- .../hibernate/query/spi/AbstractQuery.java | 2 +- .../function/internal/PatternRenderer.java | 2 +- ...deEnhancedImmutableReferenceCacheTest.java | 2 +- .../orm/test/cache/ReferenceCacheTest.java | 2 +- .../CascadeToComponentCollectionTest.java | 2 +- .../connections/SuppliedConnectionTest.java | 4 +-- ...paOrNativeBootstrapFunctionalTestCase.java | 2 +- .../join/JoinFetchProfileTest.java | 2 +- .../orm/test/id/AbstractHolderTest.java | 2 +- .../AbstractEntityWithOneToManyTest.java | 2 +- .../BaseEntityManagerFunctionalTestCase.java | 2 +- .../orm/test/lob/LongStringTest.java | 2 +- .../converter/AttributeConverterTest.java | 12 ++++---- ...ctRecursiveBidirectionalOneToManyTest.java | 2 +- .../cachedcollections/ManagedObject.java | 2 +- .../test/sql/check/ResultCheckStyleTest.java | 2 +- .../sql/hand/custom/CustomSQLTestSupport.java | 2 +- .../custom/CustomStoredProcTestSupport.java | 2 +- .../sql/hand/query/NativeSQLQueriesTest.java | 2 +- .../enhanced/SequenceIdRevisionEntity.java | 2 +- ...rackingModifiedEntitiesRevisionEntity.java | 4 +-- .../BaseEnversJPAFunctionalTestCase.java | 4 +-- .../integration/accesstype/Country.java | 2 +- .../junit4/BaseCoreFunctionalTestCase.java | 4 +-- .../BaseNonConfigCoreFunctionalTestCase.java | 4 +-- .../tool/hbm2ddl/SchemaExportTask.java | 12 ++++---- .../tool/hbm2ddl/SchemaUpdateTask.java | 28 +++++++++---------- 42 files changed, 74 insertions(+), 75 deletions(-) diff --git a/hibernate-c3p0/src/main/java/org/hibernate/c3p0/internal/C3P0ConnectionProvider.java b/hibernate-c3p0/src/main/java/org/hibernate/c3p0/internal/C3P0ConnectionProvider.java index 299ef9e44b..61c1bc6b00 100644 --- a/hibernate-c3p0/src/main/java/org/hibernate/c3p0/internal/C3P0ConnectionProvider.java +++ b/hibernate-c3p0/src/main/java/org/hibernate/c3p0/internal/C3P0ConnectionProvider.java @@ -266,7 +266,7 @@ public class C3P0ConnectionProvider * * @deprecated Use {@link #stop} instead */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") @Deprecated public void close() { stop(); diff --git a/hibernate-core/src/main/java/org/hibernate/ReplicationMode.java b/hibernate-core/src/main/java/org/hibernate/ReplicationMode.java index 3e0b8f48f2..922ad904c0 100644 --- a/hibernate-core/src/main/java/org/hibernate/ReplicationMode.java +++ b/hibernate-core/src/main/java/org/hibernate/ReplicationMode.java @@ -71,7 +71,6 @@ public enum ReplicationMode { /** * Determine whether the mode dictates that the data being replicated should overwrite the data found. * - * @param entity The entity being replicated * @param currentVersion The version currently on the target database table. * @param newVersion The replicating version * @param versionType The version type diff --git a/hibernate-core/src/main/java/org/hibernate/boot/archive/spi/AbstractArchiveDescriptor.java b/hibernate-core/src/main/java/org/hibernate/boot/archive/spi/AbstractArchiveDescriptor.java index 1f2771d649..b95d5f386a 100644 --- a/hibernate-core/src/main/java/org/hibernate/boot/archive/spi/AbstractArchiveDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/boot/archive/spi/AbstractArchiveDescriptor.java @@ -41,7 +41,7 @@ public abstract class AbstractArchiveDescriptor implements ArchiveDescriptor { return entryBasePrefix.startsWith( "/" ) ? entryBasePrefix.substring( 1 ) : entryBasePrefix; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") protected ArchiveDescriptorFactory getArchiveDescriptorFactory() { return archiveDescriptorFactory; } diff --git a/hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java b/hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java index d91d956078..875ac91f38 100644 --- a/hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java +++ b/hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java @@ -68,7 +68,7 @@ class TypeSafeActivator { * * @param object The supplied ValidatorFactory instance. */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public static void validateSuppliedFactory(Object object) { if ( !(object instanceof ValidatorFactory) ) { throw new IntegrationException( @@ -78,7 +78,7 @@ class TypeSafeActivator { } } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public static void activate(ActivationContext activationContext) { final ValidatorFactory factory; try { diff --git a/hibernate-core/src/main/java/org/hibernate/cache/internal/NaturalIdCacheKey.java b/hibernate-core/src/main/java/org/hibernate/cache/internal/NaturalIdCacheKey.java index f201a86d15..7e37536d41 100644 --- a/hibernate-core/src/main/java/org/hibernate/cache/internal/NaturalIdCacheKey.java +++ b/hibernate-core/src/main/java/org/hibernate/cache/internal/NaturalIdCacheKey.java @@ -64,17 +64,17 @@ public class NaturalIdCacheKey implements Serializable { return from( naturalIdValues, persister, persister.getRootEntityName(), session ); } - @SuppressWarnings( {"UnusedDeclaration"}) + @SuppressWarnings("unused") public String getEntityName() { return entityName; } - @SuppressWarnings( {"UnusedDeclaration"}) + @SuppressWarnings("unused") public String getTenantId() { return tenantId; } - @SuppressWarnings( {"UnusedDeclaration"}) + @SuppressWarnings("unused") public Object getNaturalIdValues() { return naturalIdValues; } diff --git a/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentArrayHolder.java b/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentArrayHolder.java index 778dce7341..e470e7ef53 100644 --- a/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentArrayHolder.java +++ b/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentArrayHolder.java @@ -125,7 +125,7 @@ public class PersistentArrayHolder extends AbstractPersistentCollection { attributeMapping.getPropertyAccess().getSetter().set( getOwner(), array ); } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public Object getArray() { return array; } diff --git a/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentBag.java b/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentBag.java index 5dab6ac348..1f3253e33a 100644 --- a/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentBag.java +++ b/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentBag.java @@ -49,7 +49,7 @@ public class PersistentBag extends AbstractPersistentCollection implements /** * Constructs a PersistentBag. Needed for SOAP libraries, etc */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public PersistentBag() { } @@ -497,7 +497,7 @@ public class PersistentBag extends AbstractPersistentCollection implements * * @return The number of occurrences. */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public int occurrences(Object o) { read(); final Iterator itr = bag.iterator(); diff --git a/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentIdentifierBag.java b/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentIdentifierBag.java index 18983996b2..6e57543657 100644 --- a/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentIdentifierBag.java +++ b/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentIdentifierBag.java @@ -54,7 +54,7 @@ public class PersistentIdentifierBag extends AbstractPersistentCollection /** * Constructs a PersistentIdentifierBag. This form needed for SOAP libraries, etc */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public PersistentIdentifierBag() { } diff --git a/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentSortedMap.java b/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentSortedMap.java index d1a67e8984..0693f54586 100644 --- a/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentSortedMap.java +++ b/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentSortedMap.java @@ -36,7 +36,7 @@ public class PersistentSortedMap extends PersistentMap implements Sort /** * Constructs a PersistentSortedMap. This form needed for SOAP libraries, etc */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public PersistentSortedMap() { } diff --git a/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentSortedSet.java b/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentSortedSet.java index 26a645bbd7..b1d78e3444 100644 --- a/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentSortedSet.java +++ b/hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentSortedSet.java @@ -33,7 +33,7 @@ public class PersistentSortedSet extends PersistentSet implements SortedSe /** * Constructs a PersistentSortedSet. This form needed for SOAP libraries, etc */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public PersistentSortedSet() { } diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/ColumnAliasExtractor.java b/hibernate-core/src/main/java/org/hibernate/dialect/ColumnAliasExtractor.java index 107a4a13c7..35b4464b36 100644 --- a/hibernate-core/src/main/java/org/hibernate/dialect/ColumnAliasExtractor.java +++ b/hibernate-core/src/main/java/org/hibernate/dialect/ColumnAliasExtractor.java @@ -39,6 +39,6 @@ public interface ColumnAliasExtractor { /** * An extractor which uses {@link ResultSetMetaData#getColumnName} */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") ColumnAliasExtractor COLUMN_NAME_EXTRACTOR = ResultSetMetaData::getColumnName; } diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DatasourceConnectionProviderImpl.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DatasourceConnectionProviderImpl.java index 6f34d0b703..aa88e37d9d 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DatasourceConnectionProviderImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DatasourceConnectionProviderImpl.java @@ -58,7 +58,7 @@ public class DatasourceConnectionProviderImpl implements ConnectionProvider, Con } @InjectService( required = false ) - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setJndiService(JndiService jndiService) { this.jndiService = jndiService; } diff --git a/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jta/JtaStatusHelper.java b/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jta/JtaStatusHelper.java index bd5768c1d5..202e720725 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jta/JtaStatusHelper.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jta/JtaStatusHelper.java @@ -176,7 +176,7 @@ public final class JtaStatusHelper { * * @return True if the code indicates a roll back; false otherwise. */ - @SuppressWarnings( {"UnusedDeclaration"}) + @SuppressWarnings("unused") public static boolean isMarkedForRollback(int status) { return status == Status.STATUS_MARKED_ROLLBACK; } diff --git a/hibernate-core/src/main/java/org/hibernate/internal/BaselineSessionEventsListenerBuilder.java b/hibernate-core/src/main/java/org/hibernate/internal/BaselineSessionEventsListenerBuilder.java index abcd810775..0a4619bd1a 100644 --- a/hibernate-core/src/main/java/org/hibernate/internal/BaselineSessionEventsListenerBuilder.java +++ b/hibernate-core/src/main/java/org/hibernate/internal/BaselineSessionEventsListenerBuilder.java @@ -31,12 +31,12 @@ public class BaselineSessionEventsListenerBuilder { this.autoListener = autoListener; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public boolean isLogSessionMetrics() { return logSessionMetrics; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public Class getAutoListener() { return autoListener; } diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/internal/PluralAttributeMetadata.java b/hibernate-core/src/main/java/org/hibernate/metamodel/internal/PluralAttributeMetadata.java index 30aabcb4ac..369f83e3d1 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/internal/PluralAttributeMetadata.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/internal/PluralAttributeMetadata.java @@ -15,7 +15,7 @@ import org.hibernate.metamodel.CollectionClassification; * @param The attribute type (the collection type) * @param The collection element type */ -@SuppressWarnings("UnusedDeclaration") +@SuppressWarnings("unused") public interface PluralAttributeMetadata extends AttributeMetadata { /** * The classification of the collection, indicating the collection semantics diff --git a/hibernate-core/src/main/java/org/hibernate/query/spi/AbstractQuery.java b/hibernate-core/src/main/java/org/hibernate/query/spi/AbstractQuery.java index 9076e11be5..5bf155f2ac 100644 --- a/hibernate-core/src/main/java/org/hibernate/query/spi/AbstractQuery.java +++ b/hibernate-core/src/main/java/org/hibernate/query/spi/AbstractQuery.java @@ -332,7 +332,7 @@ public abstract class AbstractQuery // JPA hint handling - @SuppressWarnings( {"UnusedDeclaration"}) + @SuppressWarnings("unused") public Set getSupportedHints() { return AvailableHints.getDefinedHints(); } diff --git a/hibernate-core/src/main/java/org/hibernate/query/sqm/produce/function/internal/PatternRenderer.java b/hibernate-core/src/main/java/org/hibernate/query/sqm/produce/function/internal/PatternRenderer.java index 81c59a4f4e..9b2d224a48 100644 --- a/hibernate-core/src/main/java/org/hibernate/query/sqm/produce/function/internal/PatternRenderer.java +++ b/hibernate-core/src/main/java/org/hibernate/query/sqm/produce/function/internal/PatternRenderer.java @@ -141,7 +141,7 @@ public class PatternRenderer { * @param sqlAppender Target for appending * @param args The arguments to inject into the template */ - @SuppressWarnings({ "UnusedDeclaration" }) + @SuppressWarnings("unused") public void render( SqlAppender sqlAppender, List args, diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/cache/ByteCodeEnhancedImmutableReferenceCacheTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/cache/ByteCodeEnhancedImmutableReferenceCacheTest.java index 62b89061ad..f6c599ec59 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/cache/ByteCodeEnhancedImmutableReferenceCacheTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/cache/ByteCodeEnhancedImmutableReferenceCacheTest.java @@ -227,7 +227,7 @@ public class ByteCodeEnhancedImmutableReferenceCacheTest extends BaseCoreFunctio @Immutable @Cacheable @Cache(usage = CacheConcurrencyStrategy.READ_ONLY) - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public static class MyEnhancedReferenceData implements ManagedEntity { @Id private Integer id; diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/cache/ReferenceCacheTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/cache/ReferenceCacheTest.java index 7c06794fb3..7d46b2ae67 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/cache/ReferenceCacheTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/cache/ReferenceCacheTest.java @@ -89,7 +89,7 @@ public class ReferenceCacheTest extends BaseCoreFunctionalTestCase { @Immutable @Cacheable @Cache( usage = CacheConcurrencyStrategy.READ_ONLY ) - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public static class MyReferenceData { @Id private Integer id; diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/component/cascading/collection/CascadeToComponentCollectionTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/component/cascading/collection/CascadeToComponentCollectionTest.java index 7c39581cb7..f00a08dc87 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/component/cascading/collection/CascadeToComponentCollectionTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/component/cascading/collection/CascadeToComponentCollectionTest.java @@ -73,7 +73,7 @@ public class CascadeToComponentCollectionTest extends BaseCoreFunctionalTestCase session.close(); } - @SuppressWarnings( {"UnusedDeclaration"}) + @SuppressWarnings("unused") @Test public void testMergingOriginallyNullComponent() { // step1, we create a definition with one value, but with a null component diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/connections/SuppliedConnectionTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/connections/SuppliedConnectionTest.java index 7a1e2f8b8e..f2ca157e25 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/connections/SuppliedConnectionTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/connections/SuppliedConnectionTest.java @@ -41,13 +41,13 @@ public class SuppliedConnectionTest extends ConnectionManagementTestCase { private Connection connectionUnderTest; @BeforeClassOnce - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") private void prepareConnectionProvider() { cp = ConnectionProviderBuilder.buildConnectionProvider(); } @AfterClassOnce - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") private void releaseConnectionProvider() { try { if ( cp instanceof Stoppable ) { diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/exceptionhandling/BaseJpaOrNativeBootstrapFunctionalTestCase.java b/hibernate-core/src/test/java/org/hibernate/orm/test/exceptionhandling/BaseJpaOrNativeBootstrapFunctionalTestCase.java index e7ff1c88a5..719595eedd 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/exceptionhandling/BaseJpaOrNativeBootstrapFunctionalTestCase.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/exceptionhandling/BaseJpaOrNativeBootstrapFunctionalTestCase.java @@ -329,7 +329,7 @@ public abstract class BaseJpaOrNativeBootstrapFunctionalTestCase extends BaseUni } @AfterClassOnce - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") protected void releaseSessionFactory() { if ( sessionFactory == null ) { return; diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/fetchprofiles/join/JoinFetchProfileTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/fetchprofiles/join/JoinFetchProfileTest.java index b58fb1fa07..0168f9f48d 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/fetchprofiles/join/JoinFetchProfileTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/fetchprofiles/join/JoinFetchProfileTest.java @@ -50,7 +50,7 @@ public class JoinFetchProfileTest extends BaseCoreFunctionalTestCase { cfg.setProperty( Environment.GENERATE_STATISTICS, true ); } - @SuppressWarnings({ "UnusedDeclaration" }) + @SuppressWarnings("unused") private interface TestData { Long getStudentId(); diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/id/AbstractHolderTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/id/AbstractHolderTest.java index 9a127e37d4..47d8df4dac 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/id/AbstractHolderTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/id/AbstractHolderTest.java @@ -19,7 +19,7 @@ import static org.junit.jupiter.api.Assertions.fail; /** * @author Steve Ebersole */ -@SuppressWarnings({ "UnusedDeclaration" }) +@SuppressWarnings("unused") @BaseUnitTest public abstract class AbstractHolderTest { protected abstract IntegralDataTypeHolder makeHolder(); diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/immutable/entitywithmutablecollection/AbstractEntityWithOneToManyTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/immutable/entitywithmutablecollection/AbstractEntityWithOneToManyTest.java index e722b1f82b..f964563a86 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/immutable/entitywithmutablecollection/AbstractEntityWithOneToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/immutable/entitywithmutablecollection/AbstractEntityWithOneToManyTest.java @@ -41,7 +41,7 @@ import static org.junit.jupiter.api.Assertions.fail; /** * @author Gail Badner */ -@SuppressWarnings({ "UnusedDeclaration" }) +@SuppressWarnings("unused") @SessionFactory(generateStatistics = true) public abstract class AbstractEntityWithOneToManyTest { private boolean isContractPartiesInverse; diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/jpa/BaseEntityManagerFunctionalTestCase.java b/hibernate-core/src/test/java/org/hibernate/orm/test/jpa/BaseEntityManagerFunctionalTestCase.java index d0221a7ea9..6eb0cf6e9d 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/jpa/BaseEntityManagerFunctionalTestCase.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/jpa/BaseEntityManagerFunctionalTestCase.java @@ -275,7 +275,7 @@ public abstract class BaseEntityManagerFunctionalTestCase extends BaseUnitTestCa @After - @SuppressWarnings( {"UnusedDeclaration"}) + @SuppressWarnings("unused") public void releaseResources() { try { releaseUnclosedEntityManagers(); diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/lob/LongStringTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/lob/LongStringTest.java index 337d27de80..a3484430b2 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/lob/LongStringTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/lob/LongStringTest.java @@ -22,7 +22,7 @@ import static org.junit.jupiter.api.Assertions.assertNull; * * @author Steve Ebersole */ -@SuppressWarnings({ "UnusedDeclaration" }) +@SuppressWarnings("unused") @SessionFactory public abstract class LongStringTest { private static final int LONG_STRING_SIZE = 10000; diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/mapping/converted/converter/AttributeConverterTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/mapping/converted/converter/AttributeConverterTest.java index 30893430f7..52c9007ccd 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/mapping/converted/converter/AttributeConverterTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/mapping/converted/converter/AttributeConverterTest.java @@ -525,7 +525,7 @@ public class AttributeConverterTest extends BaseUnitTestCase { // Entity declarations used in the test ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @Entity(name = "T1") - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public static class Tester { @Id private Long id; @@ -541,7 +541,7 @@ public class AttributeConverterTest extends BaseUnitTestCase { } @Entity(name = "T2") - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public static class Tester2 { @Id private Long id; @@ -550,7 +550,7 @@ public class AttributeConverterTest extends BaseUnitTestCase { } @Entity(name = "T3") - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public static class Tester3 { @Id private Long id; @@ -559,7 +559,7 @@ public class AttributeConverterTest extends BaseUnitTestCase { } @Entity(name = "T4") - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public static class Tester4 { @Id private Long id; @@ -587,7 +587,7 @@ public class AttributeConverterTest extends BaseUnitTestCase { } @Entity(name = "T5") - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public static class Tester5 { @Id private Long id; @@ -606,7 +606,7 @@ public class AttributeConverterTest extends BaseUnitTestCase { @Entity @Table(name = "irrelevantInstantEntity") - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public static class IrrelevantInstantEntity { @Id private Long id; diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/onetomany/AbstractRecursiveBidirectionalOneToManyTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/onetomany/AbstractRecursiveBidirectionalOneToManyTest.java index c706bd4993..7fb26303f1 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/onetomany/AbstractRecursiveBidirectionalOneToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/onetomany/AbstractRecursiveBidirectionalOneToManyTest.java @@ -31,7 +31,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; * @author Burkhard Graves * @author Gail Badner */ -@SuppressWarnings({ "UnusedDeclaration" }) +@SuppressWarnings("unused") public abstract class AbstractRecursiveBidirectionalOneToManyTest extends BaseSessionFactoryFunctionalTest { @Override diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/propertyref/cachedcollections/ManagedObject.java b/hibernate-core/src/test/java/org/hibernate/orm/test/propertyref/cachedcollections/ManagedObject.java index 22a2c52078..31d17c6158 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/propertyref/cachedcollections/ManagedObject.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/propertyref/cachedcollections/ManagedObject.java @@ -12,7 +12,7 @@ import java.util.Set; /** * @author Steve Ebersole */ -@SuppressWarnings({"UnusedDeclaration"}) +@SuppressWarnings("unused") public class ManagedObject { private Long moid; private int version; diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/sql/check/ResultCheckStyleTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/sql/check/ResultCheckStyleTest.java index 5615bdfdfc..5e8b00d052 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/sql/check/ResultCheckStyleTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/sql/check/ResultCheckStyleTest.java @@ -16,7 +16,7 @@ import static org.junit.Assert.fail; /** * @author Steve Ebersole */ -@SuppressWarnings( {"UnusedDeclaration"}) +@SuppressWarnings("unused") public abstract class ResultCheckStyleTest extends BaseCoreFunctionalTestCase { public String getCacheConcurrencyStrategy() { return null; diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/custom/CustomSQLTestSupport.java b/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/custom/CustomSQLTestSupport.java index 6f89ca68b3..3db6dc9710 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/custom/CustomSQLTestSupport.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/custom/CustomSQLTestSupport.java @@ -32,7 +32,7 @@ import static org.junit.Assert.assertTrue; * * @author Steve Ebersole */ -@SuppressWarnings( {"UnusedDeclaration"}) +@SuppressWarnings("unused") public abstract class CustomSQLTestSupport extends BaseCoreFunctionalTestCase { public String getCacheConcurrencyStrategy() { return null; diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/custom/CustomStoredProcTestSupport.java b/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/custom/CustomStoredProcTestSupport.java index 1efa02f970..68519fbf63 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/custom/CustomStoredProcTestSupport.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/custom/CustomStoredProcTestSupport.java @@ -29,7 +29,7 @@ import static org.junit.Assert.fail; * * @author Gail Badner */ -@SuppressWarnings( {"UnusedDeclaration"}) +@SuppressWarnings("unused") public abstract class CustomStoredProcTestSupport extends CustomSQLTestSupport { @Override diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/query/NativeSQLQueriesTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/query/NativeSQLQueriesTest.java index 83084b5682..91d070efaa 100644 --- a/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/query/NativeSQLQueriesTest.java +++ b/hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/query/NativeSQLQueriesTest.java @@ -676,7 +676,7 @@ public class NativeSQLQueriesTest { } @Test - @SuppressWarnings( {"UnusedDeclaration"}) + @SuppressWarnings("unused") public void testExplicitReturnAPI(SessionFactoryScope scope) { Organization jboss = new Organization( "JBoss" ); Person me = new Person( "Steve" ); diff --git a/hibernate-envers/src/main/java/org/hibernate/envers/enhanced/SequenceIdRevisionEntity.java b/hibernate-envers/src/main/java/org/hibernate/envers/enhanced/SequenceIdRevisionEntity.java index 222ae92bfb..8111ebd571 100644 --- a/hibernate-envers/src/main/java/org/hibernate/envers/enhanced/SequenceIdRevisionEntity.java +++ b/hibernate-envers/src/main/java/org/hibernate/envers/enhanced/SequenceIdRevisionEntity.java @@ -63,7 +63,7 @@ public class SequenceIdRevisionEntity implements Serializable { return timestamp; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setTimestamp(long timestamp) { this.timestamp = timestamp; } diff --git a/hibernate-envers/src/main/java/org/hibernate/envers/enhanced/SequenceIdTrackingModifiedEntitiesRevisionEntity.java b/hibernate-envers/src/main/java/org/hibernate/envers/enhanced/SequenceIdTrackingModifiedEntitiesRevisionEntity.java index f665d9e397..02cb2047da 100644 --- a/hibernate-envers/src/main/java/org/hibernate/envers/enhanced/SequenceIdTrackingModifiedEntitiesRevisionEntity.java +++ b/hibernate-envers/src/main/java/org/hibernate/envers/enhanced/SequenceIdTrackingModifiedEntitiesRevisionEntity.java @@ -35,12 +35,12 @@ public class SequenceIdTrackingModifiedEntitiesRevisionEntity extends SequenceId @ModifiedEntityNames private Set modifiedEntityNames = new HashSet<>(); - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public Set getModifiedEntityNames() { return modifiedEntityNames; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setModifiedEntityNames(Set modifiedEntityNames) { this.modifiedEntityNames = modifiedEntityNames; } diff --git a/hibernate-envers/src/test/java/org/hibernate/orm/test/envers/BaseEnversJPAFunctionalTestCase.java b/hibernate-envers/src/test/java/org/hibernate/orm/test/envers/BaseEnversJPAFunctionalTestCase.java index d09df01a7d..dcd430bbe5 100644 --- a/hibernate-envers/src/test/java/org/hibernate/orm/test/envers/BaseEnversJPAFunctionalTestCase.java +++ b/hibernate-envers/src/test/java/org/hibernate/orm/test/envers/BaseEnversJPAFunctionalTestCase.java @@ -81,7 +81,7 @@ public abstract class BaseEnversJPAFunctionalTestCase extends AbstractEnversTest } @BeforeClassOnce - @SuppressWarnings({"UnusedDeclaration"}) + @SuppressWarnings("unused") public void buildEntityManagerFactory() throws Exception { log.trace( "Building EntityManagerFactory" ); @@ -223,7 +223,7 @@ public abstract class BaseEnversJPAFunctionalTestCase extends AbstractEnversTest } @After - @SuppressWarnings({"UnusedDeclaration"}) + @SuppressWarnings("unused") public void releaseUnclosedEntityManagers() { releaseUnclosedEntityManager( this.em ); auditReader = null; diff --git a/hibernate-envers/src/test/java/org/hibernate/orm/test/envers/integration/accesstype/Country.java b/hibernate-envers/src/test/java/org/hibernate/orm/test/envers/integration/accesstype/Country.java index 8f36089c1d..751a77fb90 100644 --- a/hibernate-envers/src/test/java/org/hibernate/orm/test/envers/integration/accesstype/Country.java +++ b/hibernate-envers/src/test/java/org/hibernate/orm/test/envers/integration/accesstype/Country.java @@ -25,7 +25,7 @@ public class Country { /** * Default constructor for persistence provider. */ - @SuppressWarnings({"UnusedDeclaration"}) + @SuppressWarnings("unused") private Country() { } diff --git a/hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseCoreFunctionalTestCase.java b/hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseCoreFunctionalTestCase.java index 741204d0af..6507cf98c4 100644 --- a/hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseCoreFunctionalTestCase.java +++ b/hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseCoreFunctionalTestCase.java @@ -335,7 +335,7 @@ public abstract class BaseCoreFunctionalTestCase extends BaseUnitTestCase { } @AfterClassOnce - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") protected void releaseSessionFactory() { if ( sessionFactory == null ) { return; @@ -358,7 +358,7 @@ public abstract class BaseCoreFunctionalTestCase extends BaseUnitTestCase { @OnFailure @OnExpectedFailure - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void onFailure() { if ( rebuildSessionFactoryOnError() ) { rebuildSessionFactory(); diff --git a/hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseNonConfigCoreFunctionalTestCase.java b/hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseNonConfigCoreFunctionalTestCase.java index 859db4e85b..81fb152683 100644 --- a/hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseNonConfigCoreFunctionalTestCase.java +++ b/hibernate-testing/src/main/java/org/hibernate/testing/junit4/BaseNonConfigCoreFunctionalTestCase.java @@ -387,7 +387,7 @@ public class BaseNonConfigCoreFunctionalTestCase extends BaseUnitTestCase { } @AfterClassOnce - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") protected void shutDown() { releaseResources(); } @@ -420,7 +420,7 @@ public class BaseNonConfigCoreFunctionalTestCase extends BaseUnitTestCase { @OnFailure @OnExpectedFailure - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void onFailure() { if ( rebuildSessionFactoryOnError() ) { rebuildSessionFactory(); diff --git a/tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/SchemaExportTask.java b/tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/SchemaExportTask.java index d0734501e7..6c1cae935c 100644 --- a/tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/SchemaExportTask.java +++ b/tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/SchemaExportTask.java @@ -73,7 +73,7 @@ public class SchemaExportTask extends MatchingTask { private String implicitNamingStrategy; private String physicalNamingStrategy; - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void addFileset(FileSet set) { fileSets.add(set); } @@ -105,7 +105,7 @@ public class SchemaExportTask extends MatchingTask { * written to standard out. * @param quiet true to enable quiet mode */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setQuiet(boolean quiet) { this.quiet = quiet; } @@ -141,7 +141,7 @@ public class SchemaExportTask extends MatchingTask { * Set the end of statement delimiter for the generated script * @param delimiter the delimiter */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setDelimiter(String delimiter) { this.delimiter = delimiter; } @@ -163,17 +163,17 @@ public class SchemaExportTask extends MatchingTask { DeprecationLogger.DEPRECATION_LOGGER.logDeprecatedNamingStrategyAntArgument(); } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setImplicitNamingStrategy(String implicitNamingStrategy) { this.implicitNamingStrategy = implicitNamingStrategy; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setPhysicalNamingStrategy(String physicalNamingStrategy) { this.physicalNamingStrategy = physicalNamingStrategy; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setHaltonerror(boolean haltOnError) { this.haltOnError = haltOnError; } diff --git a/tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/SchemaUpdateTask.java b/tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/SchemaUpdateTask.java index 647691315c..e1174829f6 100644 --- a/tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/SchemaUpdateTask.java +++ b/tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/SchemaUpdateTask.java @@ -65,7 +65,7 @@ public class SchemaUpdateTask extends MatchingTask { private String implicitNamingStrategy = null; private String physicalNamingStrategy = null; - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void addFileset(FileSet fileSet) { fileSets.add( fileSet ); } @@ -75,7 +75,7 @@ public class SchemaUpdateTask extends MatchingTask { * * @param propertiesFile the properties file name */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setProperties(File propertiesFile) { if ( !propertiesFile.exists() ) { throw new BuildException( "Properties file: " + propertiesFile + " does not exist." ); @@ -90,7 +90,7 @@ public class SchemaUpdateTask extends MatchingTask { * * @param configurationFile the file name */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setConfig(File configurationFile) { this.configurationFile = configurationFile; } @@ -100,7 +100,7 @@ public class SchemaUpdateTask extends MatchingTask { * * @param text true to enable text-only mode */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setText(boolean text) { this.text = text; } @@ -110,52 +110,52 @@ public class SchemaUpdateTask extends MatchingTask { * * @param quiet true to enable quiet mode */ - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setQuiet(boolean quiet) { this.quiet = quiet; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setNamingStrategy(String namingStrategy) { DeprecationLogger.DEPRECATION_LOGGER.logDeprecatedNamingStrategyAntArgument(); } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setImplicitNamingStrategy(String implicitNamingStrategy) { this.implicitNamingStrategy = implicitNamingStrategy; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setPhysicalNamingStrategy(String physicalNamingStrategy) { this.physicalNamingStrategy = physicalNamingStrategy; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public File getOutputFile() { return outputFile; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setOutputFile(File outputFile) { this.outputFile = outputFile; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public boolean isHaltOnError() { return haltOnError; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setHaltOnError(boolean haltOnError) { this.haltOnError = haltOnError; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public String getDelimiter() { return delimiter; } - @SuppressWarnings("UnusedDeclaration") + @SuppressWarnings("unused") public void setDelimiter(String delimiter) { this.delimiter = delimiter; }