diff --git a/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java b/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java index c5f7d50b05..053f19f8f8 100644 --- a/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java +++ b/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java @@ -1542,8 +1542,7 @@ private void buildUniqueKeyFromColumnNames(Table table, String keyName, String[] Set unboundNoLogical = new HashSet(); for ( int index = 0; index < size; index++ ) { String column = columnNames[index]; - boolean columnNameValid = !StringHelper.isEmpty(column); - final String logicalColumnName = columnNameValid ? normalizer.normalizeIdentifierQuoting( column ) : ""; + final String logicalColumnName = StringHelper.isNotEmpty( column ) ? normalizer.normalizeIdentifierQuoting( column ) : ""; try { final String columnName = createMappings().getPhysicalColumnName( logicalColumnName, table ); columns[index] = new Column( columnName ); diff --git a/hibernate-core/src/main/java/org/hibernate/mapping/Column.java b/hibernate-core/src/main/java/org/hibernate/mapping/Column.java index 4e28ab573a..39ec40ecfb 100644 --- a/hibernate-core/src/main/java/org/hibernate/mapping/Column.java +++ b/hibernate-core/src/main/java/org/hibernate/mapping/Column.java @@ -84,7 +84,7 @@ public String getName() { } public void setName(String name) { if ( - !name.isEmpty() && + StringHelper.isNotEmpty( name ) && Dialect.QUOTE.indexOf( name.charAt(0) ) > -1 //TODO: deprecated, remove eventually ) { quoted=true; diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/uniqueconstraint/UniqueConstraintValidationTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/uniqueconstraint/UniqueConstraintValidationTest.java index fd6693ddf8..ffab1eff4f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/uniqueconstraint/UniqueConstraintValidationTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/uniqueconstraint/UniqueConstraintValidationTest.java @@ -15,6 +15,10 @@ import org.hibernate.testing.junit4.BaseUnitTestCase; import org.junit.Test; +/** + * @author Nikolay Shestakov + * + */ public class UniqueConstraintValidationTest extends BaseUnitTestCase { @Test(expected = AnnotationException.class)