Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-8434 CriteriaUpdate with multiple assignments incorrect

This commit is contained in:
Brett Meyer 2013-10-08 13:24:23 -04:00
parent ceead77b62
commit 10383fb4bb
2 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hibernate-entitymanager/src/main/java/org/hibernate/jpa/criteria/CriteriaUpdateImpl.java
View File

@ -142,12 +142,12 @@ public class CriteriaUpdateImpl<T> extends AbstractManipulationCriteriaQuery<T>
jpaql.append( " set " );
boolean first = true;
for ( Assignment assignment : assignments ) {
jpaql.append( assignment.attributePath.render( renderingContext ) )
.append( " = " )
.append( assignment.value.render( renderingContext ) );
if ( ! first ) {
jpaql.append( ", " );
}
jpaql.append( assignment.attributePath.render( renderingContext ) )
.append( " = " )
.append( assignment.value.render( renderingContext ) );
first = false;
}
}

19
hibernate-entitymanager/src/test/java/org/hibernate/jpa/test/criteria/ManipulationCriteriaTest.java
View File

@ -39,6 +39,7 @@ import org.hibernate.jpa.test.metamodel.AbstractMetamodelSpecificTest;
import org.hibernate.jpa.test.metamodel.Customer;
import org.hibernate.jpa.test.metamodel.Customer_;
import org.hibernate.testing.SkipForDialect;
import org.hibernate.testing.TestForIssue;
import org.junit.Test;
/**
@ -116,6 +117,24 @@ public class ManipulationCriteriaTest extends AbstractMetamodelSpecificTest {
em.getTransaction().rollback();
em.close();
}
@Test
@TestForIssue(jiraKey = "HHH-8434")
public void basicMultipleAssignments() {
EntityManager em = getOrCreateEntityManager();
em.getTransaction().begin();
CriteriaBuilder builder = em.getCriteriaBuilder();
CriteriaUpdate<Customer> updateCriteria = builder.createCriteriaUpdate( Customer.class );
updateCriteria.from( Customer.class );
updateCriteria.set( Customer_.name, "Bob" );
updateCriteria.set( Customer_.age, 99 );
em.createQuery( updateCriteria ).executeUpdate();
em.getTransaction().commit();
em.close();
}
@Test
public void testJoinsAndFetchesDisallowed() {