Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-8954 Avoid LockOptions allocation in LoadEvent unless strictly required

This commit is contained in:
Sanne Grinovero 2014-02-11 01:19:08 +00:00 committed by Brett Meyer
parent f69e1a6b9f
commit 11ab464d9b
1 changed files with 43 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
hibernate-core/src/main/java/org/hibernate/event/spi/LoadEvent.java
View File

@ -25,6 +25,7 @@ package org.hibernate.event.spi;
import java.io.Serializable; import java.io.Serializable;
import org.hibernate.AssertionFailure;
import org.hibernate.LockMode; import org.hibernate.LockMode;
import org.hibernate.LockOptions; import org.hibernate.LockOptions;
@ -35,6 +36,25 @@ import org.hibernate.LockOptions;
*/ */
public class LoadEvent extends AbstractEvent { public class LoadEvent extends AbstractEvent {
public static final LockMode DEFAULT_LOCK_MODE = LockMode.NONE; public static final LockMode DEFAULT_LOCK_MODE = LockMode.NONE;
//Performance hotspot: avoid allocating unneeded LockOptions
public static final LockOptions DEFAULT_LOCK_OPTIONS = new LockOptions() {
@Override
public LockOptions setLockMode(LockMode lockMode) {
throw new AssertionFailure( "Should not be invoked: DEFAULT_LOCK_OPTIONS needs to be treated as immutable." );
}
@Override
public LockOptions setAliasSpecificLockMode(String alias, LockMode lockMode) {
throw new AssertionFailure( "Should not be invoked: DEFAULT_LOCK_OPTIONS needs to be treated as immutable." );
}
@Override
public LockOptions setTimeOut(int timeout) {
throw new AssertionFailure( "Should not be invoked: DEFAULT_LOCK_OPTIONS needs to be treated as immutable." );
}
@Override
public LockOptions setScope(boolean scope) {
throw new AssertionFailure( "Should not be invoked: DEFAULT_LOCK_OPTIONS needs to be treated as immutable." );
}
};
private Serializable entityId; private Serializable entityId;
private String entityClassName; private String entityClassName;
@ -44,7 +64,7 @@ public class LoadEvent extends AbstractEvent {
private Object result; private Object result;
public LoadEvent(Serializable entityId, Object instanceToLoad, EventSource source) { public LoadEvent(Serializable entityId, Object instanceToLoad, EventSource source) {
this(entityId, null, instanceToLoad, new LockOptions(), false, source); this(entityId, null, instanceToLoad, DEFAULT_LOCK_OPTIONS, false, source);
} }
public LoadEvent(Serializable entityId, String entityClassName, LockMode lockMode, EventSource source) { public LoadEvent(Serializable entityId, String entityClassName, LockMode lockMode, EventSource source) {
@ -56,7 +76,7 @@ public class LoadEvent extends AbstractEvent {
} }
public LoadEvent(Serializable entityId, String entityClassName, boolean isAssociationFetch, EventSource source) { public LoadEvent(Serializable entityId, String entityClassName, boolean isAssociationFetch, EventSource source) {
this(entityId, entityClassName, null, new LockOptions(), isAssociationFetch, source); this(entityId, entityClassName, null, DEFAULT_LOCK_OPTIONS, isAssociationFetch, source);
} }
public boolean isAssociationFetch() { public boolean isAssociationFetch() {
@ -70,7 +90,9 @@ public class LoadEvent extends AbstractEvent {
LockMode lockMode, LockMode lockMode,
boolean isAssociationFetch, boolean isAssociationFetch,
EventSource source) { EventSource source) {
this(entityId, entityClassName, instanceToLoad, new LockOptions().setLockMode(lockMode), isAssociationFetch, source ); this(entityId, entityClassName, instanceToLoad,
lockMode == DEFAULT_LOCK_MODE ? DEFAULT_LOCK_OPTIONS : new LockOptions().setLockMode(lockMode),
isAssociationFetch, source );
} }
private LoadEvent( private LoadEvent(
@ -134,11 +156,23 @@ public class LoadEvent extends AbstractEvent {
} }
public void setLockMode(LockMode lockMode) { public void setLockMode(LockMode lockMode) {
this.lockOptions.setLockMode(lockMode); if ( lockMode != lockOptions.getLockMode() ) {
writingOnLockOptions();
this.lockOptions.setLockMode(lockMode);
}
}
private void writingOnLockOptions() {
if ( lockOptions == DEFAULT_LOCK_OPTIONS ) {
this.lockOptions = new LockOptions();
}
} }
public void setLockTimeout(int timeout) { public void setLockTimeout(int timeout) {
this.lockOptions.setTimeOut(timeout); if ( timeout != lockOptions.getTimeOut() ) {
writingOnLockOptions();
this.lockOptions.setTimeOut(timeout);
}
} }
public int getLockTimeout() { public int getLockTimeout() {
@ -146,7 +180,10 @@ public class LoadEvent extends AbstractEvent {
} }
public void setLockScope(boolean cascade) { public void setLockScope(boolean cascade) {
this.lockOptions.setScope(cascade); if ( lockOptions.getScope() != cascade ) {
writingOnLockOptions();
this.lockOptions.setScope(cascade);
}
} }
public boolean getLockScope() { public boolean getLockScope() {