Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-16911 MapBackedClassValue ClassLoader leak

This commit is contained in:
Sanne Grinovero 2023-07-10 04:41:09 -04:00 committed by Sanne Grinovero
parent 3b05c27a56
commit 1642119648
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
hibernate-core/src/main/java/org/hibernate/internal/util/collections/MapBackedClassValue.java
View File

@ -40,7 +40,7 @@ public final class MapBackedClassValue<V> {
public MapBackedClassValue(final Map<Class<?>, V> map) { public MapBackedClassValue(final Map<Class<?>, V> map) {
//Defensive copy, and implicit null check. //Defensive copy, and implicit null check.
//Choose the Map.copyOf implementation as it has a compact layout; //Choose the Map.copyOf implementation as it has a compact layout;
//it doesn't have great get() performance but it's acceptable since we're performing that at most //it doesn't have great get() performance, but it's acceptable since we're performing that at most
//once per key before caching it via the ClassValue. //once per key before caching it via the ClassValue.
this.map = Map.copyOf( map ); this.map = Map.copyOf( map );
} }
@ -50,17 +50,17 @@ public final class MapBackedClassValue<V> {
} }
/** /**
* Use this to wipe the backing map, but N.B. * Use this to wipe the backing map, important
* we won't be clearing the ClassValue: this is useful * to avoid classloader leaks.
* only to avoid classloader leaks since the Map
* may hold references to user classes.
* Since ClassValue is also possibly caching state,
* it might be possible to retrieve some values after this
* but shouldn't be relied on.
* ClassValue doesn't leak references to classes.
*/ */
public void dispose() { public void dispose() {
Map<Class<?>, V> existing = this.map;
this.map = null; this.map = null;
if ( existing != null ) {
for ( Map.Entry<Class<?>, V> entry : existing.entrySet() ) {
this.classValue.remove( entry.getKey() );
}
}
} }
} }