Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-12362 - Allow both SQL query hints and comments 

- org.hibernate.test.queryhint.QueryHintTest uses
  assertNotNull(String#contains(String)) which always evaluates to true
This commit is contained in:
Jonathan Bregler 2018-05-02 13:02:18 +02:00 committed by Vlad Mihalcea
parent e944f64e41
commit 1651c804fb
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hibernate-core/src/test/java/org/hibernate/test/queryhint/QueryHintTest.java
View File

@ -29,7 +29,7 @@ import org.junit.Test;
import static org.hibernate.testing.transaction.TransactionUtil.doInHibernate; import static org.hibernate.testing.transaction.TransactionUtil.doInHibernate;
import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertTrue;
/** /**
* @author Brett Meyer * @author Brett Meyer
@ -100,7 +100,7 @@ public class QueryHintTest extends BaseNonConfigCoreFunctionalTestCase {
1, 1,
connectionProvider.getPreparedStatements().size() connectionProvider.getPreparedStatements().size()
); );
assertNotNull( connectionProvider.getPreparedSQLStatements().get( 0 ).contains( "select /*+ ALL_ROWS */" ) ); assertTrue( connectionProvider.getPreparedSQLStatements().get( 0 ).contains( "select /*+ ALL_ROWS */" ) );
connectionProvider.clear(); connectionProvider.clear();
// test multiple hints // test multiple hints
@ -118,7 +118,7 @@ public class QueryHintTest extends BaseNonConfigCoreFunctionalTestCase {
1, 1,
connectionProvider.getPreparedStatements().size() connectionProvider.getPreparedStatements().size()
); );
assertNotNull( connectionProvider.getPreparedSQLStatements().get( 0 ).contains( "select /*+ ALL_ROWS, USE_CONCAT */" ) ); assertTrue( connectionProvider.getPreparedSQLStatements().get( 0 ).contains( "select /*+ ALL_ROWS, USE_CONCAT */" ) );
connectionProvider.clear(); connectionProvider.clear();
// ensure the insertion logic can handle a comment appended to the front // ensure the insertion logic can handle a comment appended to the front
@ -136,7 +136,7 @@ public class QueryHintTest extends BaseNonConfigCoreFunctionalTestCase {
1, 1,
connectionProvider.getPreparedStatements().size() connectionProvider.getPreparedStatements().size()
); );
assertNotNull( connectionProvider.getPreparedSQLStatements().get( 0 ).contains( "select /*+ ALL_ROWS */" ) ); assertTrue( connectionProvider.getPreparedSQLStatements().get( 0 ).contains( "select /*+ ALL_ROWS */" ) );
connectionProvider.clear(); connectionProvider.clear();
// test Criteria // test Criteria
@ -153,7 +153,7 @@ public class QueryHintTest extends BaseNonConfigCoreFunctionalTestCase {
1, 1,
connectionProvider.getPreparedStatements().size() connectionProvider.getPreparedStatements().size()
); );
assertNotNull( connectionProvider.getPreparedSQLStatements().get( 0 ).contains( "select /*+ ALL_ROWS */" ) ); assertTrue( connectionProvider.getPreparedSQLStatements().get( 0 ).contains( "select /*+ ALL_ROWS */" ) );
connectionProvider.clear(); connectionProvider.clear();
} }
@ -176,7 +176,7 @@ public class QueryHintTest extends BaseNonConfigCoreFunctionalTestCase {
1, 1,
connectionProvider.getPreparedStatements().size() connectionProvider.getPreparedStatements().size()
); );
assertNotNull( connectionProvider.getPreparedSQLStatements().get( 0 ).contains( "/* My_Query */ select /*+ ALL_ROWS */" ) ); assertTrue( connectionProvider.getPreparedSQLStatements().get( 0 ).contains( "/* My_Query */ select /*+ ALL_ROWS */" ) );
connectionProvider.clear(); connectionProvider.clear();
} }