From 1825a4762c487135f0dd11b34c417210eb6ba100 Mon Sep 17 00:00:00 2001 From: Strong Liu Date: Sat, 13 Jul 2013 10:59:41 +0800 Subject: [PATCH] HHH-8211 Checkstyle and FindBugs fix-ups --- .../javassist/FieldInterceptorImpl.java | 69 +++++++++--------- .../cache/internal/StandardQueryCache.java | 4 +- .../org/hibernate/cache/spi/QueryCache.java | 3 +- .../cache/spi/UpdateTimestampsCache.java | 18 ++--- .../cache/spi/entry/StructuredCacheEntry.java | 3 +- .../java/org/hibernate/cfg/Configuration.java | 38 +++++----- .../hibernate/cfg/DefaultNamingStrategy.java | 2 +- .../org/hibernate/cfg/ExtendedMappings.java | 2 +- .../cfg/annotations/CollectionBinder.java | 2 +- .../collection/internal/PersistentBag.java | 3 +- .../collection/internal/PersistentList.java | 6 +- .../collection/internal/PersistentMap.java | 6 +- .../collection/internal/PersistentSet.java | 9 +-- .../org/hibernate/dialect/DerbyDialect.java | 5 +- .../dialect/function/TemplateRenderer.java | 1 - .../engine/internal/ForeignKeys.java | 7 +- .../org/hibernate/engine/jdbc/BlobProxy.java | 5 +- .../org/hibernate/engine/jdbc/ClobProxy.java | 5 +- .../engine/jdbc/ResultSetWrapperProxy.java | 6 +- .../DriverManagerConnectionProviderImpl.java | 7 +- .../internal/StandardRefCursorSupport.java | 4 +- .../jdbc/internal/BasicFormatterImpl.java | 8 +-- .../engine/query/spi/HQLQueryPlan.java | 2 +- .../engine/query/spi/ParameterMetadata.java | 2 +- .../engine/query/spi/QueryPlanCache.java | 1 - .../org/hibernate/engine/spi/ActionQueue.java | 2 - .../hibernate/engine/spi/AssociationKey.java | 2 +- .../hibernate/engine/spi/CascadingAction.java | 2 +- .../hibernate/engine/spi/CollectionKey.java | 2 +- .../hibernate/engine/spi/IdentifierValue.java | 2 +- .../spi/NamedQueryDefinitionBuilder.java | 2 +- .../engine/spi/NamedSQLQueryDefinition.java | 2 +- .../spi/NamedSQLQueryDefinitionBuilder.java | 2 +- .../engine/spi/NonFlushedChanges.java | 2 +- .../hibernate/engine/spi/VersionValue.java | 2 +- .../internal/jdbc/JdbcTransaction.java | 2 +- .../internal/jdbc/JdbcTransactionFactory.java | 2 +- .../internal/jta/JtaTransactionFactory.java | 2 +- .../WebSphereExtendedJtaPlatform.java | 3 +- .../spi/TransactionCoordinator.java | 2 +- .../hibernate/event/internal/EventCache.java | 2 +- .../EventListenerServiceInitiator.java | 2 +- .../hql/internal/ast/HqlSqlWalker.java | 4 +- .../hql/internal/ast/QueryTranslatorImpl.java | 3 +- .../ast/TypeDiscriminatorMetadata.java | 2 +- .../hql/internal/ast/util/ASTPrinter.java | 2 +- .../internal/ast/util/LiteralProcessor.java | 2 +- .../internal/classic/QueryTranslatorImpl.java | 11 +-- .../hibernate/hql/spi/QueryTranslator.java | 3 +- .../hql/spi/TemporaryTableBulkIdStrategy.java | 4 +- .../id/enhanced/OptimizerFactory.java | 4 +- .../hibernate/internal/AbstractQueryImpl.java | 33 ++++----- .../internal/AbstractSessionImpl.java | 2 - .../internal/FilterConfiguration.java | 2 +- .../internal/NonFlushedChangesImpl.java | 2 +- .../collections/BoundedConcurrentHashMap.java | 2 +- .../util/collections/IdentityMap.java | 2 +- .../java/org/hibernate/loader/Loader.java | 6 +- .../loader/criteria/CriteriaLoader.java | 3 +- .../hibernate/loader/custom/CustomLoader.java | 3 +- .../entity/CollectionElementLoader.java | 2 +- .../loader/entity/EntityJoinWalker.java | 2 +- .../hibernate/loader/entity/EntityLoader.java | 2 +- .../internal/AbstractLoadQueryImpl.java | 2 +- .../CollectionJoinableAssociationImpl.java | 2 +- .../EntityJoinableAssociationImpl.java | 2 +- .../loader/internal/EntityLoadQueryImpl.java | 2 +- .../loader/plan/spi/FetchOwnerDelegate.java | 2 +- .../org/hibernate/lob/ReaderInputStream.java | 2 +- .../org/hibernate/mapping/Collection.java | 2 +- .../hibernate/mapping/PersistentClass.java | 2 +- .../org/hibernate/mapping/SimpleValue.java | 2 +- .../java/org/hibernate/mapping/Value.java | 2 +- .../binding/ManyToOneAttributeBinding.java | 2 +- .../SingularAssociationAttributeBinding.java | 2 +- .../domain/AbstractAttributeContainer.java | 2 +- .../annotations/attribute/package-info.java | 2 +- .../attribute/type/package-info.java | 2 +- .../xml/filter/AbstractAnnotationFilter.java | 2 +- .../xml/mocker/AbstractAttributesBuilder.java | 2 +- .../source/hbm/HibernateMappingProcessor.java | 2 +- .../internal/SessionFactoryBuilderImpl.java | 2 +- .../collection/ElementPropertyMapping.java | 2 +- .../NamedQueryCollectionInitializer.java | 2 +- .../entity/AbstractEntityPersister.java | 5 +- .../persister/entity/NamedQueryLoader.java | 2 +- .../EntityIdentifierDefinitionHelper.java | 2 +- .../persister/walking/spi/package-info.java | 2 +- .../org/hibernate/procedure/package-info.java | 2 +- .../proxy/AbstractLazyInitializer.java | 2 +- .../proxy/pojo/BasicLazyInitializer.java | 3 +- .../org/hibernate/result/package-info.java | 2 +- .../org/hibernate/secure/package-info.java | 2 +- .../internal/ServiceDependencyException.java | 2 +- .../org/hibernate/sql/DecodeCaseFragment.java | 2 +- .../java/org/hibernate/stat/Statistics.java | 2 +- .../internal/ConcurrentStatisticsImpl.java | 71 +++++++++++++------ .../stat/spi/StatisticsImplementor.java | 2 +- .../AliasedTupleSubsetResultTransformer.java | 2 +- .../TupleSubsetResultTransformer.java | 2 +- .../hibernate/tuple/Dom4jInstantiator.java | 2 +- .../tuple/DynamicMapInstantiator.java | 2 +- .../org/hibernate/tuple/PojoInstantiator.java | 2 +- .../component/ComponentTuplizerFactory.java | 2 +- .../tuple/entity/EntityTuplizer.java | 2 +- .../type/AbstractLongBinaryType.java | 2 +- .../type/AbstractLongStringType.java | 2 +- ...AbstractSingleColumnStandardBasicType.java | 2 +- .../org/hibernate/type/BigDecimalType.java | 2 +- .../java/org/hibernate/type/BooleanType.java | 12 ++-- .../java/org/hibernate/type/ByteType.java | 24 +++---- .../java/org/hibernate/type/DoubleType.java | 11 ++- .../java/org/hibernate/type/FloatType.java | 11 ++- .../java/org/hibernate/type/IntegerType.java | 20 +++--- .../java/org/hibernate/type/LongType.java | 20 +++--- .../hibernate/type/MaterializedClobType.java | 2 +- .../hibernate/type/MaterializedNClobType.java | 2 +- .../hibernate/type/NumericBooleanType.java | 13 ++-- .../java/org/hibernate/type/ShortType.java | 22 +++--- .../org/hibernate/type/TrueFalseType.java | 13 ++-- .../java/org/hibernate/type/YesNoType.java | 13 ++-- .../java/BooleanTypeDescriptor.java | 22 +++--- .../java/ByteArrayTypeDescriptor.java | 19 +++-- .../descriptor/java/ByteTypeDescriptor.java | 9 +-- .../java/CalendarDateTypeDescriptor.java | 2 +- .../java/CharacterArrayTypeDescriptor.java | 13 ++-- .../java/CharacterTypeDescriptor.java | 15 ++-- .../descriptor/java/DateTypeDescriptor.java | 19 +++-- .../descriptor/java/DoubleTypeDescriptor.java | 10 +-- .../descriptor/java/FloatTypeDescriptor.java | 10 +-- .../java/IntegerTypeDescriptor.java | 10 +-- .../java/JdbcDateTypeDescriptor.java | 10 +-- .../java/JdbcTimeTypeDescriptor.java | 12 ++-- .../java/JdbcTimestampTypeDescriptor.java | 12 ++-- .../descriptor/java/LongTypeDescriptor.java | 10 +-- .../descriptor/java/ShortTypeDescriptor.java | 10 +-- .../sql/JdbcTypeFamilyInformation.java | 6 +- .../sql/JdbcTypeJavaClassMappings.java | 4 +- .../sql/SqlTypeDescriptorRegistry.java | 4 +- .../sql/TimestampTypeDescriptor.java | 2 +- .../hibernate/usertype/ParameterizedType.java | 2 +- .../java/org/hibernate/dialect/Mocks.java | 1 - .../hibernate/id/BigDecimalHolderTest.java | 2 +- .../SequenceHiLoGeneratorNoIncrementTest.java | 2 +- .../loader/plan/spi/LoadPlanBuilderTest.java | 2 +- .../metamodel/binding/package-info.java | 2 +- .../util/GenericTypeDiscoveryTest.java | 2 +- .../annotations/util/TypeDiscoveryTest.java | 2 +- .../java/org/hibernate/sql/TemplateTest.java | 2 +- .../hibernate/test/annotations/Flight.java | 2 +- .../test/annotations/access/Gardenshed.java | 2 +- .../access/jpa/AccessMappingTest.java | 2 +- .../annotations/access/jpa/AccessTest.java | 2 +- .../test/annotations/access/jpa/Animal.java | 2 +- .../test/annotations/access/jpa/Bed.java | 2 +- .../test/annotations/access/jpa/BigBed.java | 2 +- .../test/annotations/access/jpa/Chair.java | 2 +- .../test/annotations/access/jpa/Circle.java | 2 +- .../test/annotations/access/jpa/Color.java | 2 +- .../test/annotations/access/jpa/Course2.java | 2 +- .../test/annotations/access/jpa/Course3.java | 2 +- .../test/annotations/access/jpa/Course4.java | 2 +- .../test/annotations/access/jpa/Course5.java | 2 +- .../test/annotations/access/jpa/Course6.java | 2 +- .../test/annotations/access/jpa/Course7.java | 2 +- .../test/annotations/access/jpa/Course8.java | 2 +- .../annotations/access/jpa/Furniture.java | 2 +- .../annotations/access/jpa/Gardenshed.java | 2 +- .../test/annotations/access/jpa/Horse.java | 2 +- .../test/annotations/access/jpa/Position.java | 2 +- .../test/annotations/access/jpa/Shape.java | 2 +- .../test/annotations/access/jpa/Square.java | 2 +- .../test/annotations/access/jpa/Thingy.java | 2 +- .../test/annotations/access/jpa/User.java | 2 +- .../test/annotations/access/jpa/Woody.java | 2 +- .../test/annotations/access/xml/Cook.java | 2 +- .../test/annotations/access/xml/Driver.java | 2 +- .../test/annotations/access/xml/Knive.java | 2 +- .../annotations/access/xml/RentalCar.java | 2 +- .../annotations/access/xml/XmlAccessTest.java | 2 +- .../test/annotations/backquotes/Printer.java | 2 +- .../annotations/backquotes/PrinterCable.java | 2 +- .../BeanValidationGroupsTest.java | 2 +- .../BeanValidationProvidedFactoryTest.java | 2 +- .../annotations/beanvalidation/TvOwner.java | 2 +- .../org/hibernate/test/annotations/cid/B.java | 2 +- .../test/annotations/cid/TvProgram.java | 2 +- .../collectionelement/BugSystem.java | 2 +- .../collectionelement/Products.java | 2 +- .../collectionelement/TestCourse.java | 2 +- .../derivedidentities/Employer.java | 2 +- .../derivedidentities/EmployerId.java | 2 +- .../bidirectional/Dependent.java | 2 +- ...ntityWithBidirectionalAssociationTest.java | 2 +- .../bidirectional/Employee.java | 2 +- .../bidirectional/Person.java | 2 +- .../bidirectional/PersonInfo.java | 2 +- .../derivedidentities/e1/a/DependentId.java | 2 +- ...vedIdentitySimpleParentIdClassDepTest.java | 2 +- .../derivedidentities/e1/a/Employee.java | 2 +- .../derivedidentities/e2/a/Employee.java | 2 +- .../derivedidentities/e2/b/DependentId.java | 2 +- .../derivedidentities/e2/b/Employee.java | 2 +- .../derivedidentities/e2/b/EmployeeId.java | 2 +- .../derivedidentities/e3/b/Dependent.java | 2 +- ...ivedIdentitySimpleParentSimpleDepTest.java | 2 +- .../e4/a/FinancialHistory.java | 2 +- .../e4/a/MedicalHistory.java | 2 +- .../derivedidentities/e4/a/Person.java | 2 +- ...entitySimpleParentSimpleDepMapsIdTest.java | 2 +- .../derivedidentities/e4/b/Person.java | 2 +- .../e5/b/MedicalHistory.java | 2 +- .../e5/c/MedicalHistory.java | 2 +- .../derivedidentities/e5/c/Person.java | 2 +- ...eddedIdParentSameIdTypeIdClassDepTest.java | 2 +- ...edIdParentSameIdTypeEmbeddedIdDepTest.java | 2 +- .../e6/b/MedicalHistory.java | 2 +- .../derivedidentities/e6/b/Person.java | 2 +- .../derivedidentities/e6/b/PersonId.java | 2 +- .../annotations/embedded/EmbeddableB.java | 2 +- .../embedded/many2one/Country.java | 2 +- .../one2many/EmbeddableWithOne2ManyTest.java | 2 +- .../annotations/entity/CasterStringType.java | 2 +- .../test/annotations/entity/Flight.java | 2 +- .../test/annotations/entity/Player.java | 2 +- .../test/annotations/entity/SoccerTeam.java | 2 +- .../test/annotations/fetch/Stay.java | 2 +- .../annotations/fetchprofile/Customer2.java | 2 +- .../annotations/fetchprofile/Customer3.java | 2 +- .../annotations/fetchprofile/Customer4.java | 2 +- .../annotations/fetchprofile/Customer5.java | 2 +- .../fetchprofile/FetchProfileTest.java | 2 +- .../fkcircularity/FkCircularityTest.java | 2 +- .../test/annotations/generics/Dummy.java | 2 +- .../test/annotations/generics/WildEntity.java | 2 +- .../CompleteSequenceEntity.java | 2 +- .../MinimalTableEntity.java | 2 +- .../id/generationmappings/package-info.java | 2 +- .../test/annotations/idclass/DomainAdmin.java | 2 +- .../annotations/idclass/DomainAdminId.java | 2 +- .../idclass/xml/HabitatSpeciesLink.java | 2 +- .../idclass/xml/IdClassXmlTest.java | 2 +- .../idclassgeneratedvalue/Simple2.java | 2 +- .../idmanytoone/alphabetical/Acces.java | 2 +- .../indexcoll/GenerationGroup.java | 2 +- .../inheritance/joined/Customer.java | 2 +- .../inheritance/joined/SwimmingPool.java | 2 +- .../hibernate/test/annotations/join/Cat.java | 2 +- .../test/annotations/join/SysGroupsOrm.java | 2 +- .../test/annotations/lob/ImageHolder.java | 2 +- .../test/annotations/lob/ImageTest.java | 2 +- .../ManyToManyMaxFetchDepth0Test.java | 2 +- .../manytomany/ManyToManyTest.java | 2 +- .../test/annotations/manytoone/Carz.java | 2 +- .../annotations/manytoone/ManyToOneTest.java | 2 +- .../referencedcolumnname/Vendor.java | 2 +- .../intermediate/Account.java | 2 +- .../intermediate/AccountBase.java | 2 +- .../intermediate/SavingsAccount.java | 2 +- .../intermediate/SavingsAccountBase.java | 2 +- .../namingstrategy/AddressEntry.java | 2 +- .../annotations/onetomany/Manufacturer.java | 2 +- .../test/annotations/onetomany/Model.java | 2 +- .../test/annotations/onetomany/Order.java | 2 +- .../test/annotations/onetomany/OrderID.java | 2 +- .../test/annotations/onetomany/Post.java | 2 +- .../onetoone/OneToOneErrorTest.java | 2 +- .../onetoone/hhh4851/DeviceGroupConfig.java | 2 +- .../annotations/onetoone/hhh4851/Owner.java | 2 +- .../test/annotations/override/Addr.java | 2 +- .../annotations/override/PropertyRecord.java | 2 +- .../test/annotations/persister/Card.java | 2 +- .../persister/CollectionPersister.java | 2 +- .../test/annotations/persister/Deck.java | 2 +- .../persister/EntityPersister.java | 2 +- .../annotations/persister/PersisterTest.java | 2 +- .../test/annotations/query/AllTables.java | 2 +- .../test/annotations/quote/Person.java | 2 +- .../test/annotations/quote/Role.java | 2 +- .../referencedcolumnname/Item.java | 2 +- .../annotations/tableperclass/Component.java | 2 +- .../test/annotations/xml/hbm/BImpl.java | 2 +- .../CascadeTestWithAssignedParentIdTest.java | 1 - ...ascadeCheckNullFalseDelayedInsertTest.java | 2 +- ...CascadeCheckNullTrueDelayedInsertTest.java | 2 +- ...ircleCascadeCheckNullibilityFalseTest.java | 2 +- ...CircleCascadeCheckNullibilityTrueTest.java | 2 +- .../test/cascade/circle/Vehicle.java | 2 +- .../test/collection/map/hhh7557/MapKey.java | 2 +- .../collection/original/CollectionTest.java | 2 +- .../test/collection/original/Mammal.java | 2 +- .../set/PersistentSetNonLazyTest.java | 2 +- .../hibernate/test/component/basic2/Name.java | 2 +- .../test/constraint/ConstraintTest.java | 2 +- .../test/criteria/CourseMeeting.java | 2 +- .../test/criteria/CourseMeetingId.java | 2 +- .../org/hibernate/test/criteria/Order.java | 2 +- .../hibernate/test/criteria/OrderLine.java | 2 +- .../test/criteria/OuterJoinCriteriaTest.java | 2 +- .../hibernate/test/deletetransient/Note.java | 2 +- .../hibernate/test/deletetransient/Suite.java | 2 +- .../cache/SQLFunctionsInterSystemsTest.java | 10 --- .../ImprovedTuplizerDynamicEntityTest.java | 2 +- .../tuplizer2/MyEntityInstantiator.java | 2 +- .../tuplizer2/MyEntityTuplizer.java | 2 +- .../collection/BrokenCollectionEventTest.java | 2 +- ...tionalOneToManyBagCollectionEventTest.java | 2 +- ...eToManyBagSubclassCollectionEventTest.java | 2 +- ...entWithBidirectionalOneToManySubclass.java | 2 +- .../values/ParentWithCollectionOfValues.java | 2 +- .../JoinedFilteredBulkManipulationTest.java | 6 -- .../PartiallyGeneratedComponentTest.java | 2 +- .../test/hql/ASTParserLoadingOrderByTest.java | 2 +- .../test/hql/ASTParserLoadingTest.java | 5 -- .../test/hql/BulkManipulationTest.java | 5 -- .../hql/EntityWithFunctionAsColumnHolder.java | 2 +- .../test/hql/QueryTranslatorTestCase.java | 6 +- .../hibernate/test/hqlfetchscroll/Child.java | 2 +- .../hibernate/test/hqlfetchscroll/Parent.java | 2 +- .../BigIntegerIncrementGeneratorTest.java | 2 +- .../BigIntegerSequenceGeneratorTest.java | 2 +- .../idgen/biginteger/sequence/Entity.java | 2 +- .../org/hibernate/test/immutable/Info.java | 2 +- .../org/hibernate/test/immutable/Party.java | 2 +- .../org/hibernate/test/immutable/Plan.java | 2 +- .../AbstractEntityWithManyToManyTest.java | 2 +- .../AbstractEntityWithOneToManyTest.java | 22 +----- .../entitywithmutablecollection/Info.java | 2 +- .../entitywithmutablecollection/Owner.java | 2 +- .../entitywithmutablecollection/Party.java | 2 +- .../entitywithmutablecollection/Plan.java | 2 +- .../EntityWithInverseManyToManyTest.java | 2 +- .../EntityWithInverseOneToManyJoinTest.java | 2 +- .../EntityWithInverseOneToManyTest.java | 2 +- ...sionedEntityWithInverseManyToManyTest.java | 2 +- ...thInverseOneToManyFailureExpectedTest.java | 2 +- ...verseOneToManyJoinFailureExpectedTest.java | 2 +- ...nedEntityWithInverseOneToManyJoinTest.java | 2 +- ...rsionedEntityWithInverseOneToManyTest.java | 2 +- .../EntityWithNonInverseManyToManyTest.java | 2 +- ...ityWithNonInverseManyToManyUnidirTest.java | 2 +- ...EntityWithNonInverseOneToManyJoinTest.java | 2 +- .../EntityWithNonInverseOneToManyTest.java | 2 +- ...tityWithNonInverseOneToManyUnidirTest.java | 2 +- ...nedEntityWithNonInverseManyToManyTest.java | 2 +- ...EntityWithNonInverseOneToManyJoinTest.java | 2 +- ...onedEntityWithNonInverseOneToManyTest.java | 2 +- .../TestLazyPropertyCustomTypeExecutable.java | 2 +- .../instrument/domain/CustomBlobType.java | 2 +- .../interceptor/InstantiateInterceptor.java | 2 +- .../test/interfaceproxy/Document.java | 2 +- .../hibernate/test/interfaceproxy/Folder.java | 2 +- .../hibernate/test/interfaceproxy/Item.java | 2 +- .../test/interfaceproxy/SecureDocument.java | 2 +- .../naturalid/ClassWithIdentityColumn.java | 2 +- .../jpa/naturalid/ImmutableNaturalIdTest.java | 2 +- .../hibernate/test/jpa/naturalid/User.java | 2 +- .../org/hibernate/test/legacy/ABCTest.java | 1 - .../hibernate/test/legacy/CustomSQLTest.java | 2 - .../org/hibernate/test/legacy/FooBarTest.java | 1 - .../hibernate/test/legacy/LegacyTestCase.java | 1 - .../test/legacy/MultiplicityType.java | 2 +- .../test/legacy/ParentChildTest.java | 1 - .../test/legacy/SQLFunctionsTest.java | 1 - .../org/hibernate/test/lob/ImageTest.java | 2 +- .../hibernate/test/lob/JpaLargeBlobTest.java | 2 +- .../org/hibernate/test/lob/LobEntity.java | 2 +- .../test/lob/LongByteArrayHolder.java | 2 +- .../hibernate/test/lob/LongByteArrayTest.java | 2 +- .../hibernate/test/lob/LongStringHolder.java | 2 +- .../hibernate/test/lob/LongStringTest.java | 2 +- .../test/lob/MaterializedBlobTest.java | 2 +- .../test/lob/MaterializedClobTest.java | 2 +- .../test/lob/SerializableHolder.java | 2 +- .../java/org/hibernate/test/lob/TextTest.java | 2 +- ...yToManyAssociationClassAssignedIdTest.java | 1 - ...ToManyAssociationClassGeneratedIdTest.java | 2 +- .../test/map/MapIndexFormulaTest.java | 1 - .../naturalid/mutable/cached/AllCached.java | 2 +- .../hibernate/test/naturalid/nullable/A.java | 2 +- .../hibernate/test/naturalid/nullable/C.java | 2 +- .../test/nonflushedchanges/CreateTest.java | 3 +- .../test/nonflushedchanges/MergeTest.java | 4 -- .../nonflushedchanges/SaveOrUpdateTest.java | 3 - ...ctRecursiveBidirectionalOneToManyTest.java | 2 - ...edRecursiveBidirectionalOneToManyTest.java | 1 - ...siveBidirectionalOneToManyNoCacheTest.java | 2 +- .../org/hibernate/test/ops/CreateTest.java | 1 - .../org/hibernate/test/ops/MergeTest.java | 4 -- .../test/optlock/OptimisticLockTest.java | 1 - .../DeleteOneToOneOrphansTest.java | 2 +- .../one2one/fk/bidirectional/Employee.java | 2 +- .../fk/bidirectional/EmployeeInfo.java | 2 +- .../composite/DeleteOneToOneOrphansTest.java | 2 +- .../orphan/one2one/fk/composite/Employee.java | 2 +- .../one2one/fk/composite/EmployeeInfo.java | 2 +- .../DeleteOneToOneOrphansTest.java | 2 +- .../fk/reversed/bidirectional/Employee.java | 2 +- .../reversed/bidirectional/EmployeeInfo.java | 2 +- .../DeleteOneToOneOrphansTest.java | 2 +- .../fk/reversed/unidirectional/Employee.java | 2 +- .../reversed/unidirectional/EmployeeInfo.java | 2 +- .../DeleteOneToOneOrphansTest.java | 2 +- .../one2one/pk/unidirectional/Employee.java | 2 +- .../pk/unidirectional/EmployeeInfo.java | 2 +- .../test/propertyref/DoesNotWorkPk.java | 2 +- .../hibernate/test/querycache/Address.java | 2 +- .../org/hibernate/test/querycache/Course.java | 2 +- .../test/querycache/CourseMeeting.java | 2 +- .../test/querycache/CourseMeetingId.java | 2 +- .../hibernate/test/querycache/Enrolment.java | 2 +- .../hibernate/test/querycache/PersonName.java | 2 +- .../test/querycache/StringCompositeKey.java | 2 +- .../hibernate/test/querycache/Student.java | 2 +- .../hibernate/test/querycache/StudentDTO.java | 2 +- .../test/queryplan/GetHqlQueryPlanTest.java | 1 - ...veSQLQueryReturnEqualsAndHashCodeTest.java | 2 +- .../test/readonly/AbstractReadOnlyTest.java | 2 +- .../hibernate/test/readonly/Container.java | 2 +- .../org/hibernate/test/readonly/Info.java | 2 +- .../org/hibernate/test/readonly/Owner.java | 2 +- .../ReadOnlySessionLazyNonLazyTest.java | 2 +- .../test/resulttransformer/PartnerA.java | 2 +- .../SchemaExportManagedConnectionTest.java | 2 +- .../SchemaExportSuppliedConnectionTest.java | 2 +- .../test/sql/check/ResultCheckStyleTest.java | 4 -- .../hibernate/test/sql/hand/ImageHolder.java | 2 +- .../hibernate/test/sql/hand/TextHolder.java | 2 +- .../custom/CustomStoredProcTestSupport.java | 2 - .../sqlserver/SQLServerCustomSQLTest.java | 2 +- .../sql/hand/query/NativeSQLQueriesTest.java | 1 - .../test/sql/refcursor/NumValue.java | 2 +- .../hibernate/test/subselect/Employee.java | 2 +- .../org/hibernate/test/type/TypeTest.java | 1 - .../java/BigIntegerDescriptorTest.java | 2 +- .../descriptor/java/BlobDescriptorTest.java | 2 +- .../java/BooleanDescriptorTest.java | 2 +- .../typedescriptor/CharInNativeQueryTest.java | 2 +- .../hibernate/test/typedescriptor/Issue.java | 2 +- .../StoredPrefixedStringType.java | 2 +- .../typeparameters/TypeParameterTest.java | 3 +- .../org/hibernate/test/unidir/Parent1.java | 2 +- .../test/unionsubclass/UnionSubclassTest.java | 56 +++++++-------- .../test/unionsubclass/alias/SellCarTest.java | 1 - .../unionsubclass2/UnionSubclassTest.java | 1 - .../test/version/db/DbVersionTest.java | 2 +- .../sybase/SybaseTimestampVersioningTest.java | 2 +- 447 files changed, 723 insertions(+), 855 deletions(-) diff --git a/hibernate-core/src/main/java/org/hibernate/bytecode/instrumentation/internal/javassist/FieldInterceptorImpl.java b/hibernate-core/src/main/java/org/hibernate/bytecode/instrumentation/internal/javassist/FieldInterceptorImpl.java index 1d37ebd961..ae835a9b64 100644 --- a/hibernate-core/src/main/java/org/hibernate/bytecode/instrumentation/internal/javassist/FieldInterceptorImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/bytecode/instrumentation/internal/javassist/FieldInterceptorImpl.java @@ -46,7 +46,6 @@ import org.hibernate.proxy.LazyInitializer; * * @author Steve Ebersole */ -@SuppressWarnings( {"UnnecessaryUnboxing", "UnnecessaryBoxing"}) final class FieldInterceptorImpl extends AbstractFieldInterceptor implements FieldHandler, Serializable { FieldInterceptorImpl(SessionImplementor session, Set uninitializedFields, String entityName) { @@ -55,39 +54,39 @@ final class FieldInterceptorImpl extends AbstractFieldInterceptor implements Fie // FieldHandler impl ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - + @Override public boolean readBoolean(Object target, String name, boolean oldValue) { - return ( (Boolean) intercept( target, name, oldValue ) ).booleanValue(); + return (Boolean) intercept( target, name, oldValue ); } - + @Override public byte readByte(Object target, String name, byte oldValue) { - return ( (Byte) intercept( target, name, Byte.valueOf( oldValue ) ) ).byteValue(); + return (Byte) intercept( target, name, oldValue ); } - + @Override public char readChar(Object target, String name, char oldValue) { - return ( (Character) intercept( target, name, Character.valueOf( oldValue ) ) ).charValue(); + return (Character) intercept( target, name, oldValue ); } - + @Override public double readDouble(Object target, String name, double oldValue) { - return ( (Double) intercept( target, name, Double.valueOf( oldValue ) ) ).doubleValue(); + return (Double) intercept( target, name, oldValue ); } - + @Override public float readFloat(Object target, String name, float oldValue) { - return ( (Float) intercept( target, name, Float.valueOf( oldValue ) ) ).floatValue(); + return (Float) intercept( target, name, oldValue ); } - + @Override public int readInt(Object target, String name, int oldValue) { - return ( (Integer) intercept( target, name, Integer.valueOf( oldValue ) ) ); + return (Integer) intercept( target, name, oldValue ); } - + @Override public long readLong(Object target, String name, long oldValue) { - return ( (Long) intercept( target, name, Long.valueOf( oldValue ) ) ).longValue(); + return (Long) intercept( target, name, oldValue ); } - + @Override public short readShort(Object target, String name, short oldValue) { - return ( (Short) intercept( target, name, Short.valueOf( oldValue ) ) ).shortValue(); + return (Short) intercept( target, name, oldValue ); } - + @Override public Object readObject(Object target, String name, Object oldValue) { Object value = intercept( target, name, oldValue ); if ( value instanceof HibernateProxy ) { @@ -98,61 +97,61 @@ final class FieldInterceptorImpl extends AbstractFieldInterceptor implements Fie } return value; } - + @Override public boolean writeBoolean(Object target, String name, boolean oldValue, boolean newValue) { dirty(); intercept( target, name, oldValue ); return newValue; } - + @Override public byte writeByte(Object target, String name, byte oldValue, byte newValue) { dirty(); - intercept( target, name, Byte.valueOf( oldValue ) ); + intercept( target, name, oldValue ); return newValue; } - + @Override public char writeChar(Object target, String name, char oldValue, char newValue) { dirty(); - intercept( target, name, Character.valueOf( oldValue ) ); + intercept( target, name, oldValue ); return newValue; } - + @Override public double writeDouble(Object target, String name, double oldValue, double newValue) { dirty(); - intercept( target, name, Double.valueOf( oldValue ) ); + intercept( target, name, oldValue ); return newValue; } - + @Override public float writeFloat(Object target, String name, float oldValue, float newValue) { dirty(); - intercept( target, name, Float.valueOf( oldValue ) ); + intercept( target, name, oldValue ); return newValue; } - + @Override public int writeInt(Object target, String name, int oldValue, int newValue) { dirty(); - intercept( target, name, Integer.valueOf( oldValue ) ); + intercept( target, name, oldValue ); return newValue; } - + @Override public long writeLong(Object target, String name, long oldValue, long newValue) { dirty(); - intercept( target, name, Long.valueOf( oldValue ) ); + intercept( target, name, oldValue ); return newValue; } - + @Override public short writeShort(Object target, String name, short oldValue, short newValue) { dirty(); - intercept( target, name, Short.valueOf( oldValue ) ); + intercept( target, name, oldValue ); return newValue; } - + @Override public Object writeObject(Object target, String name, Object oldValue, Object newValue) { dirty(); intercept( target, name, oldValue ); return newValue; } - + @Override public String toString() { return "FieldInterceptorImpl(entityName=" + getEntityName() + ",dirty=" + isDirty() + diff --git a/hibernate-core/src/main/java/org/hibernate/cache/internal/StandardQueryCache.java b/hibernate-core/src/main/java/org/hibernate/cache/internal/StandardQueryCache.java index 9d2abf41fb..e5c92ed07e 100644 --- a/hibernate-core/src/main/java/org/hibernate/cache/internal/StandardQueryCache.java +++ b/hibernate-core/src/main/java/org/hibernate/cache/internal/StandardQueryCache.java @@ -153,7 +153,7 @@ public class StandardQueryCache implements QueryCache { final QueryKey key, final Type[] returnTypes, final boolean isNaturalKeyLookup, - final Set spaces, + final Set spaces, final SessionImplementor session) throws HibernateException { if ( DEBUGGING ) { LOG.debugf( "Checking cached query results in region: %s", cacheRegion.getName() ); @@ -223,7 +223,7 @@ public class StandardQueryCache implements QueryCache { return result; } - protected boolean isUpToDate(final Set spaces, final Long timestamp) { + protected boolean isUpToDate(final Set spaces, final Long timestamp) { if ( DEBUGGING ) { LOG.debugf( "Checking query spaces are up-to-date: %s", spaces ); } diff --git a/hibernate-core/src/main/java/org/hibernate/cache/spi/QueryCache.java b/hibernate-core/src/main/java/org/hibernate/cache/spi/QueryCache.java index ebbbc4e719..305dfbf4c9 100644 --- a/hibernate-core/src/main/java/org/hibernate/cache/spi/QueryCache.java +++ b/hibernate-core/src/main/java/org/hibernate/cache/spi/QueryCache.java @@ -23,6 +23,7 @@ */ package org.hibernate.cache.spi; +import java.io.Serializable; import java.util.List; import java.util.Set; @@ -75,7 +76,7 @@ public interface QueryCache { * * @throws HibernateException Indicates a problem delegating to the underlying cache. */ - public List get(QueryKey key, Type[] returnTypes, boolean isNaturalKeyLookup, Set spaces, SessionImplementor session) throws HibernateException; + public List get(QueryKey key, Type[] returnTypes, boolean isNaturalKeyLookup, Set spaces, SessionImplementor session) throws HibernateException; /** * Destroy the cache. diff --git a/hibernate-core/src/main/java/org/hibernate/cache/spi/UpdateTimestampsCache.java b/hibernate-core/src/main/java/org/hibernate/cache/spi/UpdateTimestampsCache.java index 470174044c..6879046284 100644 --- a/hibernate-core/src/main/java/org/hibernate/cache/spi/UpdateTimestampsCache.java +++ b/hibernate-core/src/main/java/org/hibernate/cache/spi/UpdateTimestampsCache.java @@ -46,7 +46,7 @@ import org.hibernate.internal.CoreMessageLogger; */ public class UpdateTimestampsCache { private static final CoreMessageLogger LOG = Logger.getMessageLogger( CoreMessageLogger.class, UpdateTimestampsCache.class.getName() ); - + private static final boolean DEBUG_ENABLED = LOG.isDebugEnabled(); /** * The region name of the update-timestamps cache. */ @@ -90,15 +90,13 @@ public class UpdateTimestampsCache { * * @throws CacheException Indicated problem delegating to underlying region. */ - @SuppressWarnings({"UnnecessaryBoxing"}) public void preinvalidate(Serializable[] spaces) throws CacheException { - final boolean debug = LOG.isDebugEnabled(); final boolean stats = factory != null && factory.getStatistics().isStatisticsEnabled(); final Long ts = region.nextTimestamp() + region.getTimeout(); for ( Serializable space : spaces ) { - if ( debug ) { + if ( DEBUG_ENABLED ) { LOG.debugf( "Pre-invalidating space [%s], timestamp: %s", space, ts ); } //put() has nowait semantics, is this really appropriate? @@ -117,15 +115,13 @@ public class UpdateTimestampsCache { * * @throws CacheException Indicated problem delegating to underlying region. */ - @SuppressWarnings({"UnnecessaryBoxing"}) public void invalidate(Serializable[] spaces) throws CacheException { - final boolean debug = LOG.isDebugEnabled(); final boolean stats = factory != null && factory.getStatistics().isStatisticsEnabled(); final Long ts = region.nextTimestamp(); for (Serializable space : spaces) { - if ( debug ) { + if ( DEBUG_ENABLED ) { LOG.debugf( "Invalidating space [%s], timestamp: %s", space, ts ); } //put() has nowait semantics, is this really appropriate? @@ -147,12 +143,10 @@ public class UpdateTimestampsCache { * * @throws CacheException Indicated problem delegating to underlying region. */ - @SuppressWarnings({"unchecked", "UnnecessaryUnboxing"}) - public boolean isUpToDate(Set spaces, Long timestamp) throws CacheException { - final boolean debug = LOG.isDebugEnabled(); + public boolean isUpToDate(Set spaces, Long timestamp) throws CacheException { final boolean stats = factory != null && factory.getStatistics().isStatisticsEnabled(); - for ( Serializable space : (Set) spaces ) { + for ( Serializable space : spaces ) { final Long lastUpdate = (Long) region.get( space ); if ( lastUpdate == null ) { if ( stats ) { @@ -164,7 +158,7 @@ public class UpdateTimestampsCache { //result = false; // safer } else { - if ( debug ) { + if ( DEBUG_ENABLED ) { LOG.debugf( "[%s] last update timestamp: %s", space, diff --git a/hibernate-core/src/main/java/org/hibernate/cache/spi/entry/StructuredCacheEntry.java b/hibernate-core/src/main/java/org/hibernate/cache/spi/entry/StructuredCacheEntry.java index e9107c4601..f62df21dbd 100755 --- a/hibernate-core/src/main/java/org/hibernate/cache/spi/entry/StructuredCacheEntry.java +++ b/hibernate-core/src/main/java/org/hibernate/cache/spi/entry/StructuredCacheEntry.java @@ -50,10 +50,9 @@ public class StructuredCacheEntry implements CacheEntryStructure { } @Override - @SuppressWarnings("UnnecessaryUnboxing") public Object destructure(Object structured, SessionFactoryImplementor factory) { final Map map = (Map) structured; - final boolean lazyPropertiesUnfetched = ( (Boolean) map.get( "_lazyPropertiesUnfetched" ) ).booleanValue(); + final boolean lazyPropertiesUnfetched = (Boolean) map.get( "_lazyPropertiesUnfetched" ); final String subclass = (String) map.get( "_subclass" ); final Object version = map.get( "_version" ); final EntityPersister subclassPersister = factory.getEntityPersister( subclass ); diff --git a/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java b/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java index ef240e4cb7..1b9a9954f5 100644 --- a/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java +++ b/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java @@ -81,7 +81,6 @@ import org.hibernate.annotations.common.reflection.java.JavaReflectionManager; import org.hibernate.boot.registry.StandardServiceRegistryBuilder; import org.hibernate.boot.registry.classloading.spi.ClassLoaderService; import org.hibernate.boot.registry.internal.StandardServiceRegistryImpl; -import org.hibernate.cache.spi.GeneralDataRegion; import org.hibernate.cfg.annotations.NamedEntityGraphDefinition; import org.hibernate.cfg.annotations.NamedProcedureCallDefinition; import org.hibernate.cfg.annotations.reflection.JPAMetadataProvider; @@ -876,12 +875,14 @@ public class Configuration implements Serializable { */ public Configuration addDirectory(File dir) throws MappingException { File[] files = dir.listFiles(); - for ( File file : files ) { - if ( file.isDirectory() ) { - addDirectory( file ); - } - else if ( file.getName().endsWith( ".hbm.xml" ) ) { - addFile( file ); + if ( files != null ) { + for ( File file : files ) { + if ( file.isDirectory() ) { + addDirectory( file ); + } + else if ( file.getName().endsWith( ".hbm.xml" ) ) { + addFile( file ); + } } } return this; @@ -1527,10 +1528,8 @@ public class Configuration implements Serializable { for ( FkSecondPass sp : dependencies ) { String dependentTable = quotedTableName(sp.getValue().getTable()); if ( dependentTable.compareTo( startTable ) == 0 ) { - StringBuilder sb = new StringBuilder( - "Foreign key circularity dependency involving the following tables: " - ); - throw new AnnotationException( sb.toString() ); + String sb = "Foreign key circularity dependency involving the following tables: "; + throw new AnnotationException( sb ); } buildRecursiveOrderedFkSecondPasses( orderedFkSecondPasses, isADependencyOf, startTable, dependentTable ); if ( !orderedFkSecondPasses.contains( sp ) ) { @@ -3151,7 +3150,7 @@ public class Configuration implements Serializable { } return finalName; } - + @Override public String getLogicalColumnName(String physicalName, Table table) throws MappingException { String logical = null; Table currentTable = table; @@ -3172,7 +3171,7 @@ public class Configuration implements Serializable { currentTable = null; } } - while ( logical == null && currentTable != null && description != null ); + while ( logical == null && currentTable != null ); if ( logical == null ) { throw new MappingException( "Unable to find logical column name from physical name " @@ -3294,41 +3293,38 @@ public class Configuration implements Serializable { } private Boolean useNewGeneratorMappings; - - @SuppressWarnings({ "UnnecessaryUnboxing" }) + @Override public boolean useNewGeneratorMappings() { if ( useNewGeneratorMappings == null ) { final String booleanName = getConfigurationProperties() .getProperty( AvailableSettings.USE_NEW_ID_GENERATOR_MAPPINGS ); useNewGeneratorMappings = Boolean.valueOf( booleanName ); } - return useNewGeneratorMappings.booleanValue(); + return useNewGeneratorMappings; } private Boolean useNationalizedCharacterData; @Override - @SuppressWarnings( {"UnnecessaryUnboxing"}) public boolean useNationalizedCharacterData() { if ( useNationalizedCharacterData == null ) { final String booleanName = getConfigurationProperties() .getProperty( AvailableSettings.USE_NATIONALIZED_CHARACTER_DATA ); useNationalizedCharacterData = Boolean.valueOf( booleanName ); } - return useNationalizedCharacterData.booleanValue(); + return useNationalizedCharacterData; } private Boolean forceDiscriminatorInSelectsByDefault; @Override - @SuppressWarnings( {"UnnecessaryUnboxing"}) public boolean forceDiscriminatorInSelectsByDefault() { if ( forceDiscriminatorInSelectsByDefault == null ) { final String booleanName = getConfigurationProperties() .getProperty( AvailableSettings.FORCE_DISCRIMINATOR_IN_SELECTS_BY_DEFAULT ); forceDiscriminatorInSelectsByDefault = Boolean.valueOf( booleanName ); } - return forceDiscriminatorInSelectsByDefault.booleanValue(); + return forceDiscriminatorInSelectsByDefault; } public IdGenerator getGenerator(String name) { @@ -3520,7 +3516,7 @@ public class Configuration implements Serializable { //Do not cache this value as we lazily set it in Hibernate Annotation (AnnotationConfiguration) //TODO use a dedicated protected useQuotedIdentifier flag in Configuration (overriden by AnnotationConfiguration) String setting = (String) properties.get( Environment.GLOBALLY_QUOTED_IDENTIFIERS ); - return setting != null && Boolean.valueOf( setting ).booleanValue(); + return setting != null && Boolean.valueOf( setting ); } public NamingStrategy getNamingStrategy() { diff --git a/hibernate-core/src/main/java/org/hibernate/cfg/DefaultNamingStrategy.java b/hibernate-core/src/main/java/org/hibernate/cfg/DefaultNamingStrategy.java index bea5024f9e..a3922b0c56 100644 --- a/hibernate-core/src/main/java/org/hibernate/cfg/DefaultNamingStrategy.java +++ b/hibernate-core/src/main/java/org/hibernate/cfg/DefaultNamingStrategy.java @@ -129,4 +129,4 @@ public class DefaultNamingStrategy implements NamingStrategy, Serializable { public String logicalCollectionColumnName(String columnName, String propertyName, String referencedColumn) { return StringHelper.isNotEmpty( columnName ) ? columnName : propertyName + "_" + referencedColumn; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/cfg/ExtendedMappings.java b/hibernate-core/src/main/java/org/hibernate/cfg/ExtendedMappings.java index e052340569..3cab0107e8 100644 --- a/hibernate-core/src/main/java/org/hibernate/cfg/ExtendedMappings.java +++ b/hibernate-core/src/main/java/org/hibernate/cfg/ExtendedMappings.java @@ -36,4 +36,4 @@ package org.hibernate.cfg; */ @Deprecated public interface ExtendedMappings extends Mappings { -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/cfg/annotations/CollectionBinder.java b/hibernate-core/src/main/java/org/hibernate/cfg/annotations/CollectionBinder.java index 358a72893c..5c6ddefbca 100644 --- a/hibernate-core/src/main/java/org/hibernate/cfg/annotations/CollectionBinder.java +++ b/hibernate-core/src/main/java/org/hibernate/cfg/annotations/CollectionBinder.java @@ -1528,4 +1528,4 @@ public abstract class CollectionBinder { public void setLocalGenerators(HashMap localGenerators) { this.localGenerators = localGenerators; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentBag.java b/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentBag.java index c90245bdf2..c452e9d692 100644 --- a/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentBag.java +++ b/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentBag.java @@ -284,10 +284,9 @@ public class PersistentBag extends AbstractPersistentCollection implements List } @Override - @SuppressWarnings("UnnecessaryUnboxing") public boolean contains(Object object) { final Boolean exists = readElementExistence( object ); - return exists == null ? bag.contains( object ) : exists.booleanValue(); + return exists == null ? bag.contains( object ) : exists; } @Override diff --git a/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentList.java b/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentList.java index bd24d1ac12..ac096cff95 100644 --- a/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentList.java +++ b/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentList.java @@ -136,12 +136,11 @@ public class PersistentList extends AbstractPersistentCollection implements List } @Override - @SuppressWarnings("UnnecessaryUnboxing") public boolean contains(Object object) { final Boolean exists = readElementExistence( object ); return exists == null ? list.contains( object ) - : exists.booleanValue(); + : exists; } @Override @@ -176,7 +175,6 @@ public class PersistentList extends AbstractPersistentCollection implements List } @Override - @SuppressWarnings("UnnecessaryUnboxing") public boolean remove(Object value) { final Boolean exists = isPutQueueEnabled() ? readElementExistence( value ) : null; if ( exists == null ) { @@ -189,7 +187,7 @@ public class PersistentList extends AbstractPersistentCollection implements List return false; } } - else if ( exists.booleanValue() ) { + else if ( exists ) { queueOperation( new SimpleRemove( value ) ); return true; } diff --git a/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentMap.java b/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentMap.java index 3b1c141c85..88aa3cfc31 100644 --- a/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentMap.java +++ b/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentMap.java @@ -146,19 +146,17 @@ public class PersistentMap extends AbstractPersistentCollection implements Map { } @Override - @SuppressWarnings("UnnecessaryUnboxing") public boolean containsKey(Object key) { final Boolean exists = readIndexExistence( key ); - return exists == null ? map.containsKey( key ) : exists.booleanValue(); + return exists == null ? map.containsKey( key ) : exists; } @Override - @SuppressWarnings("UnnecessaryUnboxing") public boolean containsValue(Object value) { final Boolean exists = readElementExistence( value ); return exists == null ? map.containsValue( value ) - : exists.booleanValue(); + : exists; } @Override diff --git a/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentSet.java b/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentSet.java index 331d840798..17dbe02be5 100644 --- a/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentSet.java +++ b/hibernate-core/src/main/java/org/hibernate/collection/internal/PersistentSet.java @@ -167,12 +167,11 @@ public class PersistentSet extends AbstractPersistentCollection implements java. } @Override - @SuppressWarnings({"unchecked", "UnnecessaryUnboxing"}) public boolean contains(Object object) { final Boolean exists = readElementExistence( object ); return exists == null ? set.contains( object ) - : exists.booleanValue(); + : exists; } @Override @@ -197,7 +196,6 @@ public class PersistentSet extends AbstractPersistentCollection implements java. } @Override - @SuppressWarnings({"unchecked", "UnnecessaryUnboxing"}) public boolean add(Object value) { final Boolean exists = isOperationQueueEnabled() ? readElementExistence( value ) : null; if ( exists == null ) { @@ -210,7 +208,7 @@ public class PersistentSet extends AbstractPersistentCollection implements java. return false; } } - else if ( exists.booleanValue() ) { + else if ( exists ) { return false; } else { @@ -220,7 +218,6 @@ public class PersistentSet extends AbstractPersistentCollection implements java. } @Override - @SuppressWarnings({"unchecked", "UnnecessaryUnboxing"}) public boolean remove(Object value) { final Boolean exists = isPutQueueEnabled() ? readElementExistence( value ) : null; if ( exists == null ) { @@ -233,7 +230,7 @@ public class PersistentSet extends AbstractPersistentCollection implements java. return false; } } - else if ( exists.booleanValue() ) { + else if ( exists ) { queueOperation( new SimpleRemove( value ) ); return true; } diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/DerbyDialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/DerbyDialect.java index e59662a49b..95740a318d 100755 --- a/hibernate-core/src/main/java/org/hibernate/dialect/DerbyDialect.java +++ b/hibernate-core/src/main/java/org/hibernate/dialect/DerbyDialect.java @@ -77,15 +77,14 @@ public class DerbyDialect extends DB2Dialect { } } - @SuppressWarnings({"UnnecessaryUnboxing", "unchecked"}) private void determineDriverVersion() { try { // locate the derby sysinfo class and query its version info final Class sysinfoClass = ReflectHelper.classForName( "org.apache.derby.tools.sysinfo", this.getClass() ); final Method majorVersionGetter = sysinfoClass.getMethod( "getMajorVersion", ReflectHelper.NO_PARAM_SIGNATURE ); final Method minorVersionGetter = sysinfoClass.getMethod( "getMinorVersion", ReflectHelper.NO_PARAM_SIGNATURE ); - driverVersionMajor = ( (Integer) majorVersionGetter.invoke( null, ReflectHelper.NO_PARAMS ) ).intValue(); - driverVersionMinor = ( (Integer) minorVersionGetter.invoke( null, ReflectHelper.NO_PARAMS ) ).intValue(); + driverVersionMajor = (Integer) majorVersionGetter.invoke( null, ReflectHelper.NO_PARAMS ); + driverVersionMinor = (Integer) minorVersionGetter.invoke( null, ReflectHelper.NO_PARAMS ); } catch ( Exception e ) { LOG.unableToLoadDerbyDriver( e.getMessage() ); diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/function/TemplateRenderer.java b/hibernate-core/src/main/java/org/hibernate/dialect/function/TemplateRenderer.java index b9c7ba7129..ce862cc1e4 100644 --- a/hibernate-core/src/main/java/org/hibernate/dialect/function/TemplateRenderer.java +++ b/hibernate-core/src/main/java/org/hibernate/dialect/function/TemplateRenderer.java @@ -50,7 +50,6 @@ public class TemplateRenderer { * * @param template The template */ - @SuppressWarnings({ "UnnecessaryUnboxing" }) public TemplateRenderer(String template) { this.template = template; diff --git a/hibernate-core/src/main/java/org/hibernate/engine/internal/ForeignKeys.java b/hibernate-core/src/main/java/org/hibernate/engine/internal/ForeignKeys.java index d60257e146..2d15ab1f29 100755 --- a/hibernate-core/src/main/java/org/hibernate/engine/internal/ForeignKeys.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/internal/ForeignKeys.java @@ -225,7 +225,6 @@ public final class ForeignKeys { * * @return {@code true} if the given entity is transient (unsaved) */ - @SuppressWarnings("UnnecessaryUnboxing") public static boolean isTransient(String entityName, Object entity, Boolean assumed, SessionImplementor session) { if ( entity == LazyPropertyInitializer.UNFETCHED_PROPERTY ) { // an unfetched association can only point to @@ -236,20 +235,20 @@ public final class ForeignKeys { // let the interceptor inspect the instance to decide Boolean isUnsaved = session.getInterceptor().isTransient( entity ); if ( isUnsaved != null ) { - return isUnsaved.booleanValue(); + return isUnsaved; } // let the persister inspect the instance to decide final EntityPersister persister = session.getEntityPersister( entityName, entity ); isUnsaved = persister.isTransient( entity, session ); if ( isUnsaved != null ) { - return isUnsaved.booleanValue(); + return isUnsaved; } // we use the assumed value, if there is one, to avoid hitting // the database if ( assumed != null ) { - return assumed.booleanValue(); + return assumed; } // hit the database, after checking the session cache for a snapshot diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/BlobProxy.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/BlobProxy.java index 102185cbd9..8dfef951a4 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/BlobProxy.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/BlobProxy.java @@ -104,13 +104,12 @@ public class BlobProxy implements InvocationHandler { * or toString/equals/hashCode are invoked. */ @Override - @SuppressWarnings({ "UnnecessaryBoxing" }) public Object invoke(Object proxy, Method method, Object[] args) throws Throwable { final String methodName = method.getName(); final int argCount = method.getParameterTypes().length; if ( "length".equals( methodName ) && argCount == 0 ) { - return Long.valueOf( getLength() ); + return getLength(); } if ( "getUnderlyingStream".equals( methodName ) ) { return getUnderlyingStream(); // Reset stream if needed. @@ -157,7 +156,7 @@ public class BlobProxy implements InvocationHandler { return this.toString(); } if ( "equals".equals( methodName ) && argCount == 1 ) { - return Boolean.valueOf( proxy == args[0] ); + return proxy == args[0]; } if ( "hashCode".equals( methodName ) && argCount == 0 ) { return this.hashCode(); diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/ClobProxy.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/ClobProxy.java index d693eb80e7..f1c0a54ed4 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/ClobProxy.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/ClobProxy.java @@ -104,13 +104,12 @@ public class ClobProxy implements InvocationHandler { * {@link Clob#free}, or toString/equals/hashCode are invoked. */ @Override - @SuppressWarnings({ "UnnecessaryBoxing" }) public Object invoke(Object proxy, Method method, Object[] args) throws Throwable { final String methodName = method.getName(); final int argCount = method.getParameterTypes().length; if ( "length".equals( methodName ) && argCount == 0 ) { - return Long.valueOf( getLength() ); + return getLength(); } if ( "getUnderlyingStream".equals( methodName ) ) { return getUnderlyingStream(); // Reset stream if needed. @@ -161,7 +160,7 @@ public class ClobProxy implements InvocationHandler { return this.toString(); } if ( "equals".equals( methodName ) && argCount == 1 ) { - return Boolean.valueOf( proxy == args[0] ); + return proxy == args[0]; } if ( "hashCode".equals( methodName ) && argCount == 0 ) { return this.hashCode(); diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/ResultSetWrapperProxy.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/ResultSetWrapperProxy.java index d162fbb2a6..51df139d81 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/ResultSetWrapperProxy.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/ResultSetWrapperProxy.java @@ -89,10 +89,9 @@ public class ResultSetWrapperProxy implements InvocationHandler { } @Override - @SuppressWarnings( {"UnnecessaryBoxing"}) public Object invoke(Object proxy, Method method, Object[] args) throws Throwable { if ( "findColumn".equals( method.getName() ) ) { - return Integer.valueOf( findColumn( (String) args[0] ) ); + return findColumn( (String) args[0] ); } if ( isFirstArgColumnLabel( method, args ) ) { @@ -168,10 +167,9 @@ public class ResultSetWrapperProxy implements InvocationHandler { return columnNameMethod.getDeclaringClass().getMethod( columnNameMethod.getName(), actualParameterTypes ); } - @SuppressWarnings( {"UnnecessaryBoxing"}) private Object[] buildColumnIndexMethodArgs(Object[] incomingArgs, int columnIndex) { final Object[] actualArgs = new Object[incomingArgs.length]; - actualArgs[0] = Integer.valueOf( columnIndex ); + actualArgs[0] = columnIndex; System.arraycopy( incomingArgs, 1, actualArgs, 1, incomingArgs.length - 1 ); return actualArgs; } diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DriverManagerConnectionProviderImpl.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DriverManagerConnectionProviderImpl.java index fd718b5357..b21f694879 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DriverManagerConnectionProviderImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/DriverManagerConnectionProviderImpl.java @@ -57,7 +57,6 @@ import org.jboss.logging.Logger; * @author Gavin King * @author Steve Ebersole */ -@SuppressWarnings( {"UnnecessaryUnboxing"}) public class DriverManagerConnectionProviderImpl implements ConnectionProvider, Configurable, Stoppable, ServiceRegistryAwareService { private static final CoreMessageLogger LOG = Logger.getMessageLogger( CoreMessageLogger.class, DriverManagerConnectionProviderImpl.class.getName() ); @@ -141,7 +140,7 @@ public class DriverManagerConnectionProviderImpl isolation = ConfigurationHelper.getInteger( AvailableSettings.ISOLATION, configurationValues ); if ( isolation != null ) { - LOG.jdbcIsolationLevel( Environment.isolationLevelToString( isolation.intValue() ) ); + LOG.jdbcIsolationLevel( Environment.isolationLevelToString( isolation ) ); } url = (String) configurationValues.get( AvailableSettings.URL ); @@ -195,7 +194,7 @@ public class DriverManagerConnectionProviderImpl } final Connection pooled = pool.remove( last ); if ( isolation != null ) { - pooled.setTransactionIsolation( isolation.intValue() ); + pooled.setTransactionIsolation( isolation ); } if ( pooled.getAutoCommit() != autocommit ) { pooled.setAutoCommit( autocommit ); @@ -225,7 +224,7 @@ public class DriverManagerConnectionProviderImpl } if ( isolation != null ) { - conn.setTransactionIsolation( isolation.intValue() ); + conn.setTransactionIsolation( isolation ); } if ( conn.getAutoCommit() != autocommit ) { conn.setAutoCommit( autocommit ); diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/cursor/internal/StandardRefCursorSupport.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/cursor/internal/StandardRefCursorSupport.java index c1c98ac215..c831ee009a 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/cursor/internal/StandardRefCursorSupport.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/cursor/internal/StandardRefCursorSupport.java @@ -174,12 +174,11 @@ public class StandardRefCursorSupport implements RefCursorSupport { * * @return {@code true} if the metadata indicates that the driver defines REF_CURSOR support */ - @SuppressWarnings("UnnecessaryUnboxing") public static boolean supportsRefCursors(DatabaseMetaData meta) { // Standard JDBC REF_CURSOR support was not added until Java 8, so we need to use reflection to attempt to // access these fields/methods... try { - return ( (Boolean) meta.getClass().getMethod( "supportsRefCursors" ).invoke( null ) ).booleanValue(); + return (Boolean) meta.getClass().getMethod( "supportsRefCursors" ).invoke( null ); } catch (NoSuchMethodException e) { log.trace( "JDBC DatabaseMetaData class does not define supportsRefCursors method..." ); @@ -193,7 +192,6 @@ public class StandardRefCursorSupport implements RefCursorSupport { private static Integer refCursorTypeCode; - @SuppressWarnings("UnnecessaryUnboxing") private int refCursorTypeCode() { if ( refCursorTypeCode == null ) { try { diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/BasicFormatterImpl.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/BasicFormatterImpl.java index f0fd816b7b..7ac399ef11 100755 --- a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/BasicFormatterImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/BasicFormatterImpl.java @@ -274,13 +274,12 @@ public class BasicFormatterImpl implements Formatter { } } - @SuppressWarnings( {"UnnecessaryBoxing"}) private void select() { out(); indent++; newline(); - parenCounts.addLast( Integer.valueOf( parensSinceSelect ) ); - afterByOrFromOrSelects.addLast( Boolean.valueOf( afterByOrSetOrFromOrSelect ) ); + parenCounts.addLast( parensSinceSelect ); + afterByOrFromOrSelects.addLast( afterByOrSetOrFromOrSelect ); parensSinceSelect = 0; afterByOrSetOrFromOrSelect = true; } @@ -332,13 +331,12 @@ public class BasicFormatterImpl implements Formatter { afterValues = true; } - @SuppressWarnings( {"UnnecessaryUnboxing"}) private void closeParen() { parensSinceSelect--; if ( parensSinceSelect < 0 ) { indent--; parensSinceSelect = parenCounts.removeLast(); - afterByOrSetOrFromOrSelect = afterByOrFromOrSelects.removeLast().booleanValue(); + afterByOrSetOrFromOrSelect = afterByOrFromOrSelects.removeLast(); } if ( inFunction > 0 ) { inFunction--; diff --git a/hibernate-core/src/main/java/org/hibernate/engine/query/spi/HQLQueryPlan.java b/hibernate-core/src/main/java/org/hibernate/engine/query/spi/HQLQueryPlan.java index 404000ea4b..640d717772 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/query/spi/HQLQueryPlan.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/query/spi/HQLQueryPlan.java @@ -106,7 +106,7 @@ public class HQLQueryPlan implements Serializable { this.translators = new QueryTranslator[length]; final List sqlStringList = new ArrayList(); - final Set combinedQuerySpaces = new HashSet(); + final Set combinedQuerySpaces = new HashSet(); final boolean hasCollectionRole = (collectionRole == null); final Map querySubstitutions = factory.getSettings().getQuerySubstitutions(); diff --git a/hibernate-core/src/main/java/org/hibernate/engine/query/spi/ParameterMetadata.java b/hibernate-core/src/main/java/org/hibernate/engine/query/spi/ParameterMetadata.java index d9c1ce5f26..19b4b77b77 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/query/spi/ParameterMetadata.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/query/spi/ParameterMetadata.java @@ -129,7 +129,7 @@ public class ParameterMetadata implements Serializable { * * @return The named parameter names */ - public Set getNamedParameterNames() { + public Set getNamedParameterNames() { return namedDescriptorMap.keySet(); } diff --git a/hibernate-core/src/main/java/org/hibernate/engine/query/spi/QueryPlanCache.java b/hibernate-core/src/main/java/org/hibernate/engine/query/spi/QueryPlanCache.java index 35c07194e9..19b4e16845 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/query/spi/QueryPlanCache.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/query/spi/QueryPlanCache.java @@ -321,7 +321,6 @@ public class QueryPlanCache implements Serializable { private final Map parameterMetadata; private final int hashCode; - @SuppressWarnings({ "UnnecessaryBoxing" }) private DynamicFilterKey(FilterImpl filter) { this.filterName = filter.getName(); if ( filter.getParameters().isEmpty() ) { diff --git a/hibernate-core/src/main/java/org/hibernate/engine/spi/ActionQueue.java b/hibernate-core/src/main/java/org/hibernate/engine/spi/ActionQueue.java index 99f8dc6933..bc5ad3b20d 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/spi/ActionQueue.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/spi/ActionQueue.java @@ -782,7 +782,6 @@ public class ActionQueue { /** * Sort the insert actions. */ - @SuppressWarnings({ "unchecked", "UnnecessaryBoxing" }) public void sort() { // the list of entity names that indicate the batch number for ( EntityInsertAction action : (List) insertions ) { @@ -831,7 +830,6 @@ public class ActionQueue { * * @return An appropriate batch number; todo document this process better */ - @SuppressWarnings({ "UnnecessaryBoxing", "unchecked" }) private Integer findBatchNumber( EntityInsertAction action, String entityName) { diff --git a/hibernate-core/src/main/java/org/hibernate/engine/spi/AssociationKey.java b/hibernate-core/src/main/java/org/hibernate/engine/spi/AssociationKey.java index 90bb0d380d..aad11579f3 100755 --- a/hibernate-core/src/main/java/org/hibernate/engine/spi/AssociationKey.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/spi/AssociationKey.java @@ -67,4 +67,4 @@ public final class AssociationKey implements Serializable { result = 31 * result + propertyName.hashCode(); return result; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/engine/spi/CascadingAction.java b/hibernate-core/src/main/java/org/hibernate/engine/spi/CascadingAction.java index 3a467f5691..e43103eefe 100755 --- a/hibernate-core/src/main/java/org/hibernate/engine/spi/CascadingAction.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/spi/CascadingAction.java @@ -101,4 +101,4 @@ public interface CascadingAction { * Should this action be performed (or noCascade consulted) in the case of lazy properties. */ public boolean performOnLazyProperty(); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/engine/spi/CollectionKey.java b/hibernate-core/src/main/java/org/hibernate/engine/spi/CollectionKey.java index 9df614a053..1b0cba1fbf 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/spi/CollectionKey.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/spi/CollectionKey.java @@ -155,4 +155,4 @@ public final class CollectionKey implements Serializable { (session == null ? null : session.getFactory()) ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/engine/spi/IdentifierValue.java b/hibernate-core/src/main/java/org/hibernate/engine/spi/IdentifierValue.java index f8dc5e64a6..f52be9eb68 100755 --- a/hibernate-core/src/main/java/org/hibernate/engine/spi/IdentifierValue.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/spi/IdentifierValue.java @@ -148,4 +148,4 @@ public class IdentifierValue implements UnsavedValueStrategy { public String toString() { return "identifier unsaved-value: " + value; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedQueryDefinitionBuilder.java b/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedQueryDefinitionBuilder.java index 4a18d82290..46f8fe09bf 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedQueryDefinitionBuilder.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedQueryDefinitionBuilder.java @@ -140,4 +140,4 @@ public class NamedQueryDefinitionBuilder { maxResults ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedSQLQueryDefinition.java b/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedSQLQueryDefinition.java index e1bf517ab8..a5840bdccf 100755 --- a/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedSQLQueryDefinition.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedSQLQueryDefinition.java @@ -239,4 +239,4 @@ public class NamedSQLQueryDefinition extends NamedQueryDefinition { getQueryReturns() ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedSQLQueryDefinitionBuilder.java b/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedSQLQueryDefinitionBuilder.java index 9917c9b889..61811cbcab 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedSQLQueryDefinitionBuilder.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/spi/NamedSQLQueryDefinitionBuilder.java @@ -181,4 +181,4 @@ public class NamedSQLQueryDefinitionBuilder extends NamedQueryDefinitionBuilder ? null : new ArrayList( querySpaces ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/engine/spi/NonFlushedChanges.java b/hibernate-core/src/main/java/org/hibernate/engine/spi/NonFlushedChanges.java index 5db49c8fe4..5f795bf2dd 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/spi/NonFlushedChanges.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/spi/NonFlushedChanges.java @@ -30,4 +30,4 @@ public interface NonFlushedChanges extends Serializable { * Remove the non-flushed changes from this NonFlushedChanges object. */ void clear(); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/engine/spi/VersionValue.java b/hibernate-core/src/main/java/org/hibernate/engine/spi/VersionValue.java index 8b56986347..3b9cda7e6e 100755 --- a/hibernate-core/src/main/java/org/hibernate/engine/spi/VersionValue.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/spi/VersionValue.java @@ -135,4 +135,4 @@ public class VersionValue implements UnsavedValueStrategy { public String toString() { return "version unsaved-value: " + value; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jdbc/JdbcTransaction.java b/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jdbc/JdbcTransaction.java index 4fb0320546..5614cab280 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jdbc/JdbcTransaction.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jdbc/JdbcTransaction.java @@ -205,4 +205,4 @@ public class JdbcTransaction extends AbstractTransactionImpl { public boolean isActive() throws HibernateException { return getLocalStatus() == LocalStatus.ACTIVE; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jdbc/JdbcTransactionFactory.java b/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jdbc/JdbcTransactionFactory.java index 833c238821..163683db05 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jdbc/JdbcTransactionFactory.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/transaction/internal/jdbc/JdbcTransactionFactory.java @@ -60,4 +60,4 @@ public final class JdbcTransactionFactory implements TransactionFactory } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/engine/transaction/jta/platform/internal/WebSphereExtendedJtaPlatform.java b/hibernate-core/src/main/java/org/hibernate/engine/transaction/jta/platform/internal/WebSphereExtendedJtaPlatform.java index 19a81bdde7..9983fd6a9c 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/transaction/jta/platform/internal/WebSphereExtendedJtaPlatform.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/transaction/jta/platform/internal/WebSphereExtendedJtaPlatform.java @@ -74,10 +74,9 @@ public class WebSphereExtendedJtaPlatform extends AbstractJtaPlatform { } @Override - @SuppressWarnings( {"UnnecessaryBoxing"}) public Object getTransactionIdentifier(Transaction transaction) { // WebSphere, however, is not a sane JEE/JTA container... - return Integer.valueOf( transaction.hashCode() ); + return transaction.hashCode(); } public class TransactionManagerAdapter implements TransactionManager { diff --git a/hibernate-core/src/main/java/org/hibernate/engine/transaction/spi/TransactionCoordinator.java b/hibernate-core/src/main/java/org/hibernate/engine/transaction/spi/TransactionCoordinator.java index 1babcac641..52f9054be0 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/transaction/spi/TransactionCoordinator.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/transaction/spi/TransactionCoordinator.java @@ -141,4 +141,4 @@ public interface TransactionCoordinator extends Serializable { public void sendBeforeTransactionCompletionNotifications(TransactionImplementor hibernateTransaction); public void sendAfterTransactionCompletionNotifications(TransactionImplementor hibernateTransaction, int status); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/event/internal/EventCache.java b/hibernate-core/src/main/java/org/hibernate/event/internal/EventCache.java index 7c4bc9a26a..757863637b 100644 --- a/hibernate-core/src/main/java/org/hibernate/event/internal/EventCache.java +++ b/hibernate-core/src/main/java/org/hibernate/event/internal/EventCache.java @@ -363,4 +363,4 @@ class EventCache implements Map { // Entity was not found in current persistence context. Use Object#toString() method. return "[" + entity + "]"; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/event/service/internal/EventListenerServiceInitiator.java b/hibernate-core/src/main/java/org/hibernate/event/service/internal/EventListenerServiceInitiator.java index c4eec7b474..76493f43d5 100644 --- a/hibernate-core/src/main/java/org/hibernate/event/service/internal/EventListenerServiceInitiator.java +++ b/hibernate-core/src/main/java/org/hibernate/event/service/internal/EventListenerServiceInitiator.java @@ -58,4 +58,4 @@ public class EventListenerServiceInitiator implements SessionFactoryServiceIniti ServiceRegistryImplementor registry) { return new EventListenerRegistryImpl(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/HqlSqlWalker.java b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/HqlSqlWalker.java index 8f32783230..81d312c93e 100644 --- a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/HqlSqlWalker.java +++ b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/HqlSqlWalker.java @@ -139,7 +139,7 @@ public class HqlSqlWalker extends HqlSqlBaseWalker implements ErrorReporter, Par **/ private Map selectExpressionsByResultVariable = new HashMap(); - private Set querySpaces = new HashSet(); + private Set querySpaces = new HashSet(); private int parameterCount; private Map namedParameters = new HashMap(); @@ -315,7 +315,7 @@ public class HqlSqlWalker extends HqlSqlBaseWalker implements ErrorReporter, Par * * @return A set of table names (Strings). */ - public Set getQuerySpaces() { + public Set getQuerySpaces() { return querySpaces; } diff --git a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/QueryTranslatorImpl.java b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/QueryTranslatorImpl.java index da87cb4f12..07f4b6887b 100644 --- a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/QueryTranslatorImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/QueryTranslatorImpl.java @@ -23,6 +23,7 @@ */ package org.hibernate.hql.internal.ast; +import java.io.Serializable; import java.util.ArrayList; import java.util.Collections; import java.util.HashMap; @@ -342,7 +343,7 @@ public class QueryTranslatorImpl implements FilterTranslator { return getWalker().getSelectClause().getColumnNames(); } @Override - public Set getQuerySpaces() { + public Set getQuerySpaces() { return getWalker().getQuerySpaces(); } diff --git a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/TypeDiscriminatorMetadata.java b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/TypeDiscriminatorMetadata.java index 6d8f78db16..b9b6006bf8 100644 --- a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/TypeDiscriminatorMetadata.java +++ b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/TypeDiscriminatorMetadata.java @@ -45,4 +45,4 @@ public interface TypeDiscriminatorMetadata { * @return The resolution type. */ public Type getResolutionType(); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/util/ASTPrinter.java b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/util/ASTPrinter.java index ca11a0ecba..3f67c69698 100644 --- a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/util/ASTPrinter.java +++ b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/util/ASTPrinter.java @@ -226,4 +226,4 @@ public class ASTPrinter { appendEscapedMultibyteChars(text,buf); return buf.toString(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/util/LiteralProcessor.java b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/util/LiteralProcessor.java index 25d743d211..bdafcab797 100644 --- a/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/util/LiteralProcessor.java +++ b/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/util/LiteralProcessor.java @@ -339,4 +339,4 @@ public class LiteralProcessor implements HqlSqlTokenTypes { public abstract DecimalFormatter getFormatter(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/hql/internal/classic/QueryTranslatorImpl.java b/hibernate-core/src/main/java/org/hibernate/hql/internal/classic/QueryTranslatorImpl.java index 79c248c62b..e51d7b0669 100644 --- a/hibernate-core/src/main/java/org/hibernate/hql/internal/classic/QueryTranslatorImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/hql/internal/classic/QueryTranslatorImpl.java @@ -31,6 +31,7 @@ import java.sql.ResultSet; import java.sql.SQLException; import java.util.ArrayList; import java.util.Arrays; +import java.util.Collections; import java.util.HashMap; import java.util.HashSet; import java.util.Iterator; @@ -107,7 +108,7 @@ public class QueryTranslatorImpl extends BasicLoader implements FilterTranslator private final Map joins = new LinkedHashMap(); private final List orderByTokens = new ArrayList(); private final List groupByTokens = new ArrayList(); - private final Set querySpaces = new HashSet(); + private final Set querySpaces = new HashSet(); private final Set entitiesToFetch = new HashSet(); private final Map pathAliases = new HashMap(); @@ -821,7 +822,7 @@ public class QueryTranslatorImpl extends BasicLoader implements FilterTranslator } - public final Set getQuerySpaces() { + public final Set getQuerySpaces() { return querySpaces; } @@ -835,9 +836,7 @@ public class QueryTranslatorImpl extends BasicLoader implements FilterTranslator } void addQuerySpaces(Serializable[] spaces) { - for ( int i = 0; i < spaces.length; i++ ) { - querySpaces.add( spaces[i] ); - } + Collections.addAll( querySpaces, spaces ); if ( superQuery != null ) superQuery.addQuerySpaces( spaces ); } @@ -936,6 +935,7 @@ public class QueryTranslatorImpl extends BasicLoader implements FilterTranslator pathJoins.put( path, joinSequence ); } + @Override public List list(SessionImplementor session, QueryParameters queryParameters) throws HibernateException { return list( session, queryParameters, getQuerySpaces(), actualReturnTypes ); @@ -944,6 +944,7 @@ public class QueryTranslatorImpl extends BasicLoader implements FilterTranslator /** * Return the query results as an iterator */ + @Override public Iterator iterate(QueryParameters queryParameters, EventSource session) throws HibernateException { diff --git a/hibernate-core/src/main/java/org/hibernate/hql/spi/QueryTranslator.java b/hibernate-core/src/main/java/org/hibernate/hql/spi/QueryTranslator.java index 4caebc6f99..7de8ef02cb 100644 --- a/hibernate-core/src/main/java/org/hibernate/hql/spi/QueryTranslator.java +++ b/hibernate-core/src/main/java/org/hibernate/hql/spi/QueryTranslator.java @@ -23,6 +23,7 @@ */ package org.hibernate.hql.spi; +import java.io.Serializable; import java.util.Iterator; import java.util.List; import java.util.Map; @@ -110,7 +111,7 @@ public interface QueryTranslator { * * @return A set of query spaces (table names). */ - Set getQuerySpaces(); + Set getQuerySpaces(); /** * Retrieve the query identifier for this translator. The query identifier is diff --git a/hibernate-core/src/main/java/org/hibernate/hql/spi/TemporaryTableBulkIdStrategy.java b/hibernate-core/src/main/java/org/hibernate/hql/spi/TemporaryTableBulkIdStrategy.java index 08b56cf6b5..44215de51e 100644 --- a/hibernate-core/src/main/java/org/hibernate/hql/spi/TemporaryTableBulkIdStrategy.java +++ b/hibernate-core/src/main/java/org/hibernate/hql/spi/TemporaryTableBulkIdStrategy.java @@ -162,16 +162,14 @@ public class TemporaryTableBulkIdStrategy implements MultiTableBulkIdStrategy { } } - @SuppressWarnings({ "UnnecessaryUnboxing" }) protected boolean shouldIsolateTemporaryTableDDL(SessionImplementor session) { Boolean dialectVote = session.getFactory().getDialect().performTemporaryTableDDLInIsolation(); if ( dialectVote != null ) { - return dialectVote.booleanValue(); + return dialectVote; } return session.getFactory().getSettings().isDataDefinitionImplicitCommit(); } - @SuppressWarnings({ "UnnecessaryUnboxing" }) protected boolean shouldTransactIsolatedTemporaryTableDDL(SessionImplementor session) { // is there ever a time when it makes sense to do this? // return session.getFactory().getSettings().isDataDefinitionInTransactionSupported(); diff --git a/hibernate-core/src/main/java/org/hibernate/id/enhanced/OptimizerFactory.java b/hibernate-core/src/main/java/org/hibernate/id/enhanced/OptimizerFactory.java index 9d4863655e..9e5b019ed2 100644 --- a/hibernate-core/src/main/java/org/hibernate/id/enhanced/OptimizerFactory.java +++ b/hibernate-core/src/main/java/org/hibernate/id/enhanced/OptimizerFactory.java @@ -67,7 +67,6 @@ public class OptimizerFactory { * @deprecated Use {@link #buildOptimizer(String, Class, int, long)} instead */ @Deprecated - @SuppressWarnings( {"UnnecessaryBoxing", "unchecked"}) public static Optimizer buildOptimizer(String type, Class returnClass, int incrementSize) { final Class optimizerClass; @@ -87,7 +86,7 @@ public class OptimizerFactory { try { final Constructor ctor = optimizerClass.getConstructor( CTOR_SIG ); - return (Optimizer) ctor.newInstance( returnClass, Integer.valueOf( incrementSize ) ); + return (Optimizer) ctor.newInstance( returnClass, incrementSize ); } catch( Throwable ignore ) { LOG.unableToInstantiateOptimizer( type ); @@ -110,7 +109,6 @@ public class OptimizerFactory { * * @return The built optimizer */ - @SuppressWarnings({ "UnnecessaryBoxing", "deprecation" }) public static Optimizer buildOptimizer(String type, Class returnClass, int incrementSize, long explicitInitialValue) { final Optimizer optimizer = buildOptimizer( type, returnClass, incrementSize ); if ( InitialValueAwareOptimizer.class.isInstance( optimizer ) ) { diff --git a/hibernate-core/src/main/java/org/hibernate/internal/AbstractQueryImpl.java b/hibernate-core/src/main/java/org/hibernate/internal/AbstractQueryImpl.java index a62ea7d243..62cfa9d945 100644 --- a/hibernate-core/src/main/java/org/hibernate/internal/AbstractQueryImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/internal/AbstractQueryImpl.java @@ -91,7 +91,7 @@ public abstract class AbstractQueryImpl implements Query { private List values = new ArrayList(4); private List types = new ArrayList(4); private Map namedParameters = new HashMap(4); - private Map namedParameterLists = new HashMap(4); + private Map namedParameterLists = new HashMap(4); private Object optionalObject; private Serializable optionalId; @@ -256,24 +256,20 @@ public abstract class AbstractQueryImpl implements Query { return this; } - /** - * {@inheritDoc} - */ + @Override public boolean isReadOnly() { return ( readOnly == null ? getSession().getPersistenceContext().isDefaultReadOnly() : - readOnly.booleanValue() + readOnly ); } - /** - * {@inheritDoc} - */ + @Override public Query setReadOnly(boolean readOnly) { - this.readOnly = Boolean.valueOf( readOnly ); + this.readOnly = readOnly; return this; } - + @Override public Query setResultTransformer(ResultTransformer transformer) { this.resultTransformer = transformer; return this; @@ -294,7 +290,7 @@ public abstract class AbstractQueryImpl implements Query { SessionImplementor getSession() { return session; } - + @Override public abstract LockOptions getLockOptions(); @@ -305,8 +301,8 @@ public abstract class AbstractQueryImpl implements Query { * * @return Shallow copy of the named parameter value map */ - protected Map getNamedParams() { - return new HashMap( namedParameters ); + protected Map getNamedParams() { + return new HashMap( namedParameters ); } /** @@ -323,6 +319,7 @@ public abstract class AbstractQueryImpl implements Query { * @return Array of named parameter names. * @throws HibernateException */ + @Override public String[] getNamedParameters() throws HibernateException { return ArrayHelper.toStringArray( parameterMetadata.getNamedParameterNames() ); } @@ -343,7 +340,7 @@ public abstract class AbstractQueryImpl implements Query { * * @return The parameter list value map. */ - protected Map getNamedParameterLists() { + protected Map getNamedParameterLists() { return namedParameterLists; } @@ -387,7 +384,7 @@ public abstract class AbstractQueryImpl implements Query { */ protected void verifyParameters(boolean reserveFirstParameter) throws HibernateException { if ( parameterMetadata.getNamedParameterNames().size() != namedParameters.size() + namedParameterLists.size() ) { - Set missingParams = new HashSet( parameterMetadata.getNamedParameterNames() ); + Set missingParams = new HashSet( parameterMetadata.getNamedParameterNames() ); missingParams.removeAll( namedParameterLists.keySet() ); missingParams.removeAll( namedParameters.keySet() ); throw new QueryException( "Not all named parameters have been set: " + missingParams, getQueryString() ); @@ -776,6 +773,7 @@ public abstract class AbstractQueryImpl implements Query { return this; } + @Override public Query setParameterList(String name, Collection vals, Type type) throws HibernateException { if ( !parameterMetadata.getNamedParameterNames().contains( name ) ) { throw new IllegalArgumentException("Parameter " + name + " does not exist as a named parameter in [" + getQueryString() + "]"); @@ -790,9 +788,8 @@ public abstract class AbstractQueryImpl implements Query { */ protected String expandParameterLists(Map namedParamsCopy) { String query = this.queryString; - Iterator iter = namedParameterLists.entrySet().iterator(); - while ( iter.hasNext() ) { - Map.Entry me = (Map.Entry) iter.next(); + for ( Map.Entry stringTypedValueEntry : namedParameterLists.entrySet() ) { + Map.Entry me = (Map.Entry) stringTypedValueEntry; query = expandParameterList( query, (String) me.getKey(), (TypedValue) me.getValue(), namedParamsCopy ); } return query; diff --git a/hibernate-core/src/main/java/org/hibernate/internal/AbstractSessionImpl.java b/hibernate-core/src/main/java/org/hibernate/internal/AbstractSessionImpl.java index 4ed1481626..8ba88d7655 100755 --- a/hibernate-core/src/main/java/org/hibernate/internal/AbstractSessionImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/internal/AbstractSessionImpl.java @@ -27,7 +27,6 @@ import java.io.Serializable; import java.sql.Connection; import java.sql.SQLException; import java.util.List; -import java.util.Map; import java.util.UUID; import org.hibernate.HibernateException; @@ -187,7 +186,6 @@ public abstract class AbstractSessionImpl return query; } - @SuppressWarnings("UnnecessaryUnboxing") private void initQuery(Query query, NamedQueryDefinition nqd) { // todo : cacheable and readonly should be Boolean rather than boolean... query.setCacheable( nqd.isCacheable() ); diff --git a/hibernate-core/src/main/java/org/hibernate/internal/FilterConfiguration.java b/hibernate-core/src/main/java/org/hibernate/internal/FilterConfiguration.java index f5bdbed323..633a2113b5 100644 --- a/hibernate-core/src/main/java/org/hibernate/internal/FilterConfiguration.java +++ b/hibernate-core/src/main/java/org/hibernate/internal/FilterConfiguration.java @@ -92,4 +92,4 @@ public class FilterConfiguration { } return ret; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/internal/NonFlushedChangesImpl.java b/hibernate-core/src/main/java/org/hibernate/internal/NonFlushedChangesImpl.java index e811077118..34b8bd886e 100644 --- a/hibernate-core/src/main/java/org/hibernate/internal/NonFlushedChangesImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/internal/NonFlushedChangesImpl.java @@ -72,4 +72,4 @@ public final class NonFlushedChangesImpl implements NonFlushedChanges, Serializa actionQueue.serialize( oos ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/internal/util/collections/BoundedConcurrentHashMap.java b/hibernate-core/src/main/java/org/hibernate/internal/util/collections/BoundedConcurrentHashMap.java index f8c39337b6..cc2d847041 100644 --- a/hibernate-core/src/main/java/org/hibernate/internal/util/collections/BoundedConcurrentHashMap.java +++ b/hibernate-core/src/main/java/org/hibernate/internal/util/collections/BoundedConcurrentHashMap.java @@ -2461,4 +2461,4 @@ public class BoundedConcurrentHashMap extends AbstractMap put(key, value); } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/internal/util/collections/IdentityMap.java b/hibernate-core/src/main/java/org/hibernate/internal/util/collections/IdentityMap.java index 6839eb47c0..2bdadd83a5 100644 --- a/hibernate-core/src/main/java/org/hibernate/internal/util/collections/IdentityMap.java +++ b/hibernate-core/src/main/java/org/hibernate/internal/util/collections/IdentityMap.java @@ -267,4 +267,4 @@ public final class IdentityMap implements Map { } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/loader/Loader.java b/hibernate-core/src/main/java/org/hibernate/loader/Loader.java index 685c7a778d..34a652cf1e 100644 --- a/hibernate-core/src/main/java/org/hibernate/loader/Loader.java +++ b/hibernate-core/src/main/java/org/hibernate/loader/Loader.java @@ -2325,7 +2325,7 @@ public abstract class Loader { protected List list( final SessionImplementor session, final QueryParameters queryParameters, - final Set querySpaces, + final Set querySpaces, final Type[] resultTypes) throws HibernateException { final boolean cacheable = factory.getSettings().isQueryCacheEnabled() && @@ -2346,7 +2346,7 @@ public abstract class Loader { private List listUsingQueryCache( final SessionImplementor session, final QueryParameters queryParameters, - final Set querySpaces, + final Set querySpaces, final Type[] resultTypes) { QueryCache queryCache = factory.getQueryCache( queryParameters.getCacheRegion() ); @@ -2423,7 +2423,7 @@ public abstract class Loader { private List getResultFromQueryCache( final SessionImplementor session, final QueryParameters queryParameters, - final Set querySpaces, + final Set querySpaces, final Type[] resultTypes, final QueryCache queryCache, final QueryKey key) { diff --git a/hibernate-core/src/main/java/org/hibernate/loader/criteria/CriteriaLoader.java b/hibernate-core/src/main/java/org/hibernate/loader/criteria/CriteriaLoader.java index d973d9c9ae..8bb73cc05a 100644 --- a/hibernate-core/src/main/java/org/hibernate/loader/criteria/CriteriaLoader.java +++ b/hibernate-core/src/main/java/org/hibernate/loader/criteria/CriteriaLoader.java @@ -23,6 +23,7 @@ * */ package org.hibernate.loader.criteria; +import java.io.Serializable; import java.sql.ResultSet; import java.sql.SQLException; import java.util.HashMap; @@ -68,7 +69,7 @@ public class CriteriaLoader extends OuterJoinLoader { // multithreaded, or cacheable!! private final CriteriaQueryTranslator translator; - private final Set querySpaces; + private final Set querySpaces; private final Type[] resultTypes; //the user visible aliases, which are unknown to the superclass, //these are not the actual "physical" SQL aliases diff --git a/hibernate-core/src/main/java/org/hibernate/loader/custom/CustomLoader.java b/hibernate-core/src/main/java/org/hibernate/loader/custom/CustomLoader.java index e8fd1013c6..77e3f15ebc 100755 --- a/hibernate-core/src/main/java/org/hibernate/loader/custom/CustomLoader.java +++ b/hibernate-core/src/main/java/org/hibernate/loader/custom/CustomLoader.java @@ -23,6 +23,7 @@ */ package org.hibernate.loader.custom; +import java.io.Serializable; import java.sql.ResultSet; import java.sql.ResultSetMetaData; import java.sql.SQLException; @@ -71,7 +72,7 @@ public class CustomLoader extends Loader { // Currently *not* cachable if autodiscover types is in effect (e.g. "select * ...") private final String sql; - private final Set querySpaces = new HashSet(); + private final Set querySpaces = new HashSet(); private final Map namedParameterBindPoints; private final Queryable[] entityPersisters; diff --git a/hibernate-core/src/main/java/org/hibernate/loader/entity/CollectionElementLoader.java b/hibernate-core/src/main/java/org/hibernate/loader/entity/CollectionElementLoader.java index cfcd015c6c..4a8f68c6ba 100755 --- a/hibernate-core/src/main/java/org/hibernate/loader/entity/CollectionElementLoader.java +++ b/hibernate-core/src/main/java/org/hibernate/loader/entity/CollectionElementLoader.java @@ -132,4 +132,4 @@ public class CollectionElementLoader extends OuterJoinLoader { protected boolean isSingleRowLoader() { return true; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/loader/entity/EntityJoinWalker.java b/hibernate-core/src/main/java/org/hibernate/loader/entity/EntityJoinWalker.java index e7fa8b5f7a..1b8f6fb6d6 100755 --- a/hibernate-core/src/main/java/org/hibernate/loader/entity/EntityJoinWalker.java +++ b/hibernate-core/src/main/java/org/hibernate/loader/entity/EntityJoinWalker.java @@ -255,4 +255,4 @@ public class EntityJoinWalker extends AbstractEntityJoinWalker { } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/loader/entity/EntityLoader.java b/hibernate-core/src/main/java/org/hibernate/loader/entity/EntityLoader.java index 0230c4c933..5aa490f944 100644 --- a/hibernate-core/src/main/java/org/hibernate/loader/entity/EntityLoader.java +++ b/hibernate-core/src/main/java/org/hibernate/loader/entity/EntityLoader.java @@ -170,4 +170,4 @@ public class EntityLoader extends AbstractEntityLoader { public int[][] getCompositeKeyManyToOneTargetIndices() { return compositeKeyManyToOneTargetIndices; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/loader/internal/AbstractLoadQueryImpl.java b/hibernate-core/src/main/java/org/hibernate/loader/internal/AbstractLoadQueryImpl.java index 37e6a8d3d7..15ba337255 100755 --- a/hibernate-core/src/main/java/org/hibernate/loader/internal/AbstractLoadQueryImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/loader/internal/AbstractLoadQueryImpl.java @@ -310,4 +310,4 @@ public abstract class AbstractLoadQueryImpl { association.getJoinable().whereJoinFragment( rhsAlias, false, true ) ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/loader/internal/CollectionJoinableAssociationImpl.java b/hibernate-core/src/main/java/org/hibernate/loader/internal/CollectionJoinableAssociationImpl.java index 254c1a9c33..9e516a4503 100644 --- a/hibernate-core/src/main/java/org/hibernate/loader/internal/CollectionJoinableAssociationImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/loader/internal/CollectionJoinableAssociationImpl.java @@ -90,4 +90,4 @@ public class CollectionJoinableAssociationImpl extends AbstractJoinableAssociati protected boolean isOneToOne() { return false; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/loader/internal/EntityJoinableAssociationImpl.java b/hibernate-core/src/main/java/org/hibernate/loader/internal/EntityJoinableAssociationImpl.java index 84830547d1..1f6b5aaa32 100644 --- a/hibernate-core/src/main/java/org/hibernate/loader/internal/EntityJoinableAssociationImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/loader/internal/EntityJoinableAssociationImpl.java @@ -86,4 +86,4 @@ public class EntityJoinableAssociationImpl extends AbstractJoinableAssociationIm EntityType entityType = (EntityType) joinableType; return entityType.isOneToOne() /*&& entityType.isReferenceToPrimaryKey()*/; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/loader/internal/EntityLoadQueryImpl.java b/hibernate-core/src/main/java/org/hibernate/loader/internal/EntityLoadQueryImpl.java index 148c6126c6..eb1612a68d 100755 --- a/hibernate-core/src/main/java/org/hibernate/loader/internal/EntityLoadQueryImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/loader/internal/EntityLoadQueryImpl.java @@ -65,4 +65,4 @@ public class EntityLoadQueryImpl extends AbstractEntityLoadQueryImpl { protected String getComment() { return "load " + getPersister().getEntityName(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/loader/plan/spi/FetchOwnerDelegate.java b/hibernate-core/src/main/java/org/hibernate/loader/plan/spi/FetchOwnerDelegate.java index a6b25a91dc..350169dab4 100644 --- a/hibernate-core/src/main/java/org/hibernate/loader/plan/spi/FetchOwnerDelegate.java +++ b/hibernate-core/src/main/java/org/hibernate/loader/plan/spi/FetchOwnerDelegate.java @@ -66,4 +66,4 @@ public interface FetchOwnerDelegate { * be located. */ public FetchMetadata locateFetchMetadata(Fetch fetch); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/lob/ReaderInputStream.java b/hibernate-core/src/main/java/org/hibernate/lob/ReaderInputStream.java index ba5d4cc43a..2f96eb9ca8 100644 --- a/hibernate-core/src/main/java/org/hibernate/lob/ReaderInputStream.java +++ b/hibernate-core/src/main/java/org/hibernate/lob/ReaderInputStream.java @@ -41,4 +41,4 @@ public class ReaderInputStream extends org.hibernate.engine.jdbc.ReaderInputStre return super.read(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/mapping/Collection.java b/hibernate-core/src/main/java/org/hibernate/mapping/Collection.java index 22cea240b7..b9fc9304f4 100644 --- a/hibernate-core/src/main/java/org/hibernate/mapping/Collection.java +++ b/hibernate-core/src/main/java/org/hibernate/mapping/Collection.java @@ -667,4 +667,4 @@ public abstract class Collection implements Fetchable, Value, Filterable { public String getComparatorClassName() { return comparatorClassName; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/mapping/PersistentClass.java b/hibernate-core/src/main/java/org/hibernate/mapping/PersistentClass.java index 41f1bb2346..96aef1247a 100644 --- a/hibernate-core/src/main/java/org/hibernate/mapping/PersistentClass.java +++ b/hibernate-core/src/main/java/org/hibernate/mapping/PersistentClass.java @@ -880,4 +880,4 @@ public abstract class PersistentClass implements Serializable, Filterable, MetaA // End of @Mappedsuperclass support -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java b/hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java index a9bbdb3619..57220006eb 100644 --- a/hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java +++ b/hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java @@ -608,4 +608,4 @@ public class SimpleValue implements KeyValue { return columns; } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/mapping/Value.java b/hibernate-core/src/main/java/org/hibernate/mapping/Value.java index 731216baf1..9a80b0d531 100644 --- a/hibernate-core/src/main/java/org/hibernate/mapping/Value.java +++ b/hibernate-core/src/main/java/org/hibernate/mapping/Value.java @@ -55,4 +55,4 @@ public interface Value extends Serializable { public boolean isValid(Mapping mapping) throws MappingException; public void setTypeUsingReflection(String className, String propertyName) throws MappingException; public Object accept(ValueVisitor visitor); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/binding/ManyToOneAttributeBinding.java b/hibernate-core/src/main/java/org/hibernate/metamodel/binding/ManyToOneAttributeBinding.java index 798ff70184..66a9f5376b 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/binding/ManyToOneAttributeBinding.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/binding/ManyToOneAttributeBinding.java @@ -238,4 +238,4 @@ public class ManyToOneAttributeBinding extends BasicAttributeBinding implements // } // //TODO: validate that the entity reference is resolved // } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/binding/SingularAssociationAttributeBinding.java b/hibernate-core/src/main/java/org/hibernate/metamodel/binding/SingularAssociationAttributeBinding.java index 73b7631558..eb1e60c88d 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/binding/SingularAssociationAttributeBinding.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/binding/SingularAssociationAttributeBinding.java @@ -62,4 +62,4 @@ public interface SingularAssociationAttributeBinding extends SingularAttributeBi public boolean isReferenceResolved(); public EntityBinding getReferencedEntityBinding(); public AttributeBinding getReferencedAttributeBinding(); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/domain/AbstractAttributeContainer.java b/hibernate-core/src/main/java/org/hibernate/metamodel/domain/AbstractAttributeContainer.java index d8bb0f35c1..3258f7de70 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/domain/AbstractAttributeContainer.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/domain/AbstractAttributeContainer.java @@ -305,4 +305,4 @@ public abstract class AbstractAttributeContainer implements AttributeContainer, this.indexType = indexType; } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/attribute/package-info.java b/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/attribute/package-info.java index 399dad768c..7a0ab7ea6a 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/attribute/package-info.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/attribute/package-info.java @@ -25,4 +25,4 @@ package org.hibernate.metamodel.source.annotations.attribute; /** * This package contains binding code for attributes. - */ \ No newline at end of file + */ diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/attribute/type/package-info.java b/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/attribute/type/package-info.java index 98888c4dcb..b7331a26aa 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/attribute/type/package-info.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/attribute/type/package-info.java @@ -25,4 +25,4 @@ package org.hibernate.metamodel.source.annotations.attribute.type; /** * This package contains type binding code for basic attributes. - */ \ No newline at end of file + */ diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/xml/filter/AbstractAnnotationFilter.java b/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/xml/filter/AbstractAnnotationFilter.java index 6e0fc9e300..103b5cea36 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/xml/filter/AbstractAnnotationFilter.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/xml/filter/AbstractAnnotationFilter.java @@ -76,4 +76,4 @@ abstract class AbstractAnnotationFilter implements IndexedAnnotationFilter { protected DotName[] targetAnnotation() { return EMPTY_DOTNAME_ARRAY; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/xml/mocker/AbstractAttributesBuilder.java b/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/xml/mocker/AbstractAttributesBuilder.java index 0c7dc1cfe3..af1ad00d1d 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/xml/mocker/AbstractAttributesBuilder.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/source/annotations/xml/mocker/AbstractAttributesBuilder.java @@ -124,4 +124,4 @@ abstract class AbstractAttributesBuilder { abstract List getOneToOne(); abstract JaxbEmbeddedId getEmbeddedId(); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/source/hbm/HibernateMappingProcessor.java b/hibernate-core/src/main/java/org/hibernate/metamodel/source/hbm/HibernateMappingProcessor.java index b7a4644b3b..1c40d99c1d 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/source/hbm/HibernateMappingProcessor.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/source/hbm/HibernateMappingProcessor.java @@ -284,4 +284,4 @@ public class HibernateMappingProcessor { } } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/source/internal/SessionFactoryBuilderImpl.java b/hibernate-core/src/main/java/org/hibernate/metamodel/source/internal/SessionFactoryBuilderImpl.java index 2a1f3cf45f..85a700a8af 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/source/internal/SessionFactoryBuilderImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/source/internal/SessionFactoryBuilderImpl.java @@ -96,4 +96,4 @@ public class SessionFactoryBuilderImpl implements SessionFactoryBuilder { return entityNotFoundDelegate; } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/persister/collection/ElementPropertyMapping.java b/hibernate-core/src/main/java/org/hibernate/persister/collection/ElementPropertyMapping.java index 495ac8a773..54b9012897 100644 --- a/hibernate-core/src/main/java/org/hibernate/persister/collection/ElementPropertyMapping.java +++ b/hibernate-core/src/main/java/org/hibernate/persister/collection/ElementPropertyMapping.java @@ -72,4 +72,4 @@ public class ElementPropertyMapping implements PropertyMapping { return type; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/persister/collection/NamedQueryCollectionInitializer.java b/hibernate-core/src/main/java/org/hibernate/persister/collection/NamedQueryCollectionInitializer.java index 335c5cb270..0a097d3377 100755 --- a/hibernate-core/src/main/java/org/hibernate/persister/collection/NamedQueryCollectionInitializer.java +++ b/hibernate-core/src/main/java/org/hibernate/persister/collection/NamedQueryCollectionInitializer.java @@ -74,4 +74,4 @@ public final class NamedQueryCollectionInitializer implements CollectionInitiali .list(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java b/hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java index 9552291f79..3ad089ffe0 100644 --- a/hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java +++ b/hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java @@ -771,7 +771,7 @@ public abstract class AbstractEntityPersister iter = definedBySubclass.iterator(); j = 0; while ( iter.hasNext() ) { - propertyDefinedOnSubclass[j++] = ( ( Boolean ) iter.next() ).booleanValue(); + propertyDefinedOnSubclass[j++] = (Boolean) iter.next(); } // Handle any filters applied to the class level @@ -4875,12 +4875,11 @@ public abstract class AbstractEntityPersister return generateEntityIdByNaturalIdSql( valueNullness ); } - @SuppressWarnings("UnnecessaryUnboxing") protected boolean isNaturalIdNonNullable() { if ( naturalIdIsNonNullable == null ) { naturalIdIsNonNullable = determineNaturalIdNullability(); } - return naturalIdIsNonNullable.booleanValue(); + return naturalIdIsNonNullable; } private boolean determineNaturalIdNullability() { diff --git a/hibernate-core/src/main/java/org/hibernate/persister/entity/NamedQueryLoader.java b/hibernate-core/src/main/java/org/hibernate/persister/entity/NamedQueryLoader.java index 4c61041cac..c112420896 100755 --- a/hibernate-core/src/main/java/org/hibernate/persister/entity/NamedQueryLoader.java +++ b/hibernate-core/src/main/java/org/hibernate/persister/entity/NamedQueryLoader.java @@ -92,4 +92,4 @@ public final class NamedQueryLoader implements UniqueEntityLoader { return session.getPersistenceContext().getEntity( session.generateEntityKey( id, persister ) ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/persister/walking/internal/EntityIdentifierDefinitionHelper.java b/hibernate-core/src/main/java/org/hibernate/persister/walking/internal/EntityIdentifierDefinitionHelper.java index bec4320dc2..6e6e7f5a2f 100644 --- a/hibernate-core/src/main/java/org/hibernate/persister/walking/internal/EntityIdentifierDefinitionHelper.java +++ b/hibernate-core/src/main/java/org/hibernate/persister/walking/internal/EntityIdentifierDefinitionHelper.java @@ -150,4 +150,4 @@ public class EntityIdentifierDefinitionHelper { return CompositionSingularSubAttributesHelper.getIdentifierSubAttributes( getEntityPersister() ); } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/persister/walking/spi/package-info.java b/hibernate-core/src/main/java/org/hibernate/persister/walking/spi/package-info.java index 90d0cd8faf..9c5f4e0a14 100644 --- a/hibernate-core/src/main/java/org/hibernate/persister/walking/spi/package-info.java +++ b/hibernate-core/src/main/java/org/hibernate/persister/walking/spi/package-info.java @@ -3,4 +3,4 @@ package org.hibernate.persister.walking.spi; /** * Package for "walking" associations through metadata definition. Ultimately want {@link org.hibernate.persister.walking.spi.AttributeDefinition} and * {@link AttributeSource} etc to become part of the persister model. - */ \ No newline at end of file + */ diff --git a/hibernate-core/src/main/java/org/hibernate/procedure/package-info.java b/hibernate-core/src/main/java/org/hibernate/procedure/package-info.java index dea61abc24..0ce80e69e9 100644 --- a/hibernate-core/src/main/java/org/hibernate/procedure/package-info.java +++ b/hibernate-core/src/main/java/org/hibernate/procedure/package-info.java @@ -34,4 +34,4 @@ package org.hibernate.procedure; * @see org.hibernate.Session#createStoredProcedureCall(String) * @see org.hibernate.Session#createStoredProcedureCall(String, Class[]) * @see org.hibernate.Session#createStoredProcedureCall(String, String...) - */ \ No newline at end of file + */ diff --git a/hibernate-core/src/main/java/org/hibernate/proxy/AbstractLazyInitializer.java b/hibernate-core/src/main/java/org/hibernate/proxy/AbstractLazyInitializer.java index cb8b81da89..19865c66a1 100755 --- a/hibernate-core/src/main/java/org/hibernate/proxy/AbstractLazyInitializer.java +++ b/hibernate-core/src/main/java/org/hibernate/proxy/AbstractLazyInitializer.java @@ -132,7 +132,7 @@ public abstract class AbstractLazyInitializer implements LazyInitializer { } else { // use the read-only/modifiable setting indicated during deserialization - setReadOnly( readOnlyBeforeAttachedToSession.booleanValue() ); + setReadOnly( readOnlyBeforeAttachedToSession ); readOnlyBeforeAttachedToSession = null; } } diff --git a/hibernate-core/src/main/java/org/hibernate/proxy/pojo/BasicLazyInitializer.java b/hibernate-core/src/main/java/org/hibernate/proxy/pojo/BasicLazyInitializer.java index 309be39f14..4ac2e9eca2 100644 --- a/hibernate-core/src/main/java/org/hibernate/proxy/pojo/BasicLazyInitializer.java +++ b/hibernate-core/src/main/java/org/hibernate/proxy/pojo/BasicLazyInitializer.java @@ -68,7 +68,6 @@ public abstract class BasicLazyInitializer extends AbstractLazyInitializer { protected abstract Object serializableProxy(); - @SuppressWarnings({ "UnnecessaryBoxing" }) protected final Object invoke(Method method, Object[] args, Object proxy) throws Throwable { String methodName = method.getName(); int params = args.length; @@ -78,7 +77,7 @@ public abstract class BasicLazyInitializer extends AbstractLazyInitializer { return getReplacement(); } else if ( !overridesEquals && "hashCode".equals(methodName) ) { - return Integer.valueOf( System.identityHashCode(proxy) ); + return System.identityHashCode(proxy); } else if ( isUninitialized() && method.equals(getIdentifierMethod) ) { return getIdentifier(); diff --git a/hibernate-core/src/main/java/org/hibernate/result/package-info.java b/hibernate-core/src/main/java/org/hibernate/result/package-info.java index 8aa9877fa3..4e7282e0a1 100644 --- a/hibernate-core/src/main/java/org/hibernate/result/package-info.java +++ b/hibernate-core/src/main/java/org/hibernate/result/package-info.java @@ -21,4 +21,4 @@ package org.hibernate.result; * } * } * - */ \ No newline at end of file + */ diff --git a/hibernate-core/src/main/java/org/hibernate/secure/package-info.java b/hibernate-core/src/main/java/org/hibernate/secure/package-info.java index 31a9b0b7ff..d9e366287f 100644 --- a/hibernate-core/src/main/java/org/hibernate/secure/package-info.java +++ b/hibernate-core/src/main/java/org/hibernate/secure/package-info.java @@ -2,4 +2,4 @@ package org.hibernate.secure; /** * Package defining support for declarative security of CRUD operations via JACC. - */ \ No newline at end of file + */ diff --git a/hibernate-core/src/main/java/org/hibernate/service/internal/ServiceDependencyException.java b/hibernate-core/src/main/java/org/hibernate/service/internal/ServiceDependencyException.java index e8cbe4cfa8..cfccd540e4 100644 --- a/hibernate-core/src/main/java/org/hibernate/service/internal/ServiceDependencyException.java +++ b/hibernate-core/src/main/java/org/hibernate/service/internal/ServiceDependencyException.java @@ -37,4 +37,4 @@ public class ServiceDependencyException extends HibernateException { public ServiceDependencyException(String s) { super( s ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/sql/DecodeCaseFragment.java b/hibernate-core/src/main/java/org/hibernate/sql/DecodeCaseFragment.java index abe84f8088..dd9c4a3acc 100644 --- a/hibernate-core/src/main/java/org/hibernate/sql/DecodeCaseFragment.java +++ b/hibernate-core/src/main/java/org/hibernate/sql/DecodeCaseFragment.java @@ -66,4 +66,4 @@ public class DecodeCaseFragment extends CaseFragment { return buf.toString(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/stat/Statistics.java b/hibernate-core/src/main/java/org/hibernate/stat/Statistics.java index f870e18f17..24e0d199f8 100755 --- a/hibernate-core/src/main/java/org/hibernate/stat/Statistics.java +++ b/hibernate-core/src/main/java/org/hibernate/stat/Statistics.java @@ -272,4 +272,4 @@ public interface Statistics { * that occurred */ public long getOptimisticFailureCount(); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/stat/internal/ConcurrentStatisticsImpl.java b/hibernate-core/src/main/java/org/hibernate/stat/internal/ConcurrentStatisticsImpl.java index e89e7c0384..7cc8b01e1e 100644 --- a/hibernate-core/src/main/java/org/hibernate/stat/internal/ConcurrentStatisticsImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/stat/internal/ConcurrentStatisticsImpl.java @@ -406,9 +406,9 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service } } - @SuppressWarnings({ "UnnecessaryBoxing" }) + @Override public void queryExecuted(String hql, int rows, long time) { - LOG.hql(hql, Long.valueOf(time), Long.valueOf(rows)); + LOG.hql(hql, time, (long) rows ); queryExecutionCount.getAndIncrement(); boolean isLongestQuery = false; for ( long old = queryExecutionMaxTime.get(); @@ -424,7 +424,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service qs.executed( rows, time ); } } - + @Override public void queryCacheHit(String hql, String regionName) { queryCacheHitCount.getAndIncrement(); if ( hql != null ) { @@ -436,7 +436,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service ); slcs.incrementHitCount(); } - + @Override public void queryCacheMiss(String hql, String regionName) { queryCacheMissCount.getAndIncrement(); if ( hql != null ) { @@ -448,7 +448,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service ); slcs.incrementMissCount(); } - + @Override public void queryCachePut(String hql, String regionName) { queryCachePutCount.getAndIncrement(); if ( hql != null ) { @@ -483,6 +483,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service * * @return QueryStatistics */ + @Override public QueryStatistics getQueryStatistics(String queryString) { ConcurrentQueryStatisticsImpl qs = (ConcurrentQueryStatisticsImpl) queryStatistics.get( queryString ); if ( qs == null ) { @@ -500,6 +501,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return entity deletion count */ + @Override public long getEntityDeleteCount() { return entityDeleteCount.get(); } @@ -507,6 +509,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return entity insertion count */ + @Override public long getEntityInsertCount() { return entityInsertCount.get(); } @@ -514,6 +517,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return entity load (from DB) */ + @Override public long getEntityLoadCount() { return entityLoadCount.get(); } @@ -521,6 +525,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return entity fetch (from DB) */ + @Override public long getEntityFetchCount() { return entityFetchCount.get(); } @@ -528,34 +533,35 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return entity update */ + @Override public long getEntityUpdateCount() { return entityUpdateCount.get(); } - + @Override public long getQueryExecutionCount() { return queryExecutionCount.get(); } - + @Override public long getQueryCacheHitCount() { return queryCacheHitCount.get(); } - + @Override public long getQueryCacheMissCount() { return queryCacheMissCount.get(); } - + @Override public long getQueryCachePutCount() { return queryCachePutCount.get(); } - + @Override public long getUpdateTimestampsCacheHitCount() { return updateTimestampsCacheHitCount.get(); } - + @Override public long getUpdateTimestampsCacheMissCount() { return updateTimestampsCacheMissCount.get(); } - + @Override public long getUpdateTimestampsCachePutCount() { return updateTimestampsCachePutCount.get(); } @@ -563,6 +569,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return flush */ + @Override public long getFlushCount() { return flushCount.get(); } @@ -570,6 +577,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return session connect */ + @Override public long getConnectCount() { return connectCount.get(); } @@ -577,6 +585,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return second level cache hit */ + @Override public long getSecondLevelCacheHitCount() { return secondLevelCacheHitCount.get(); } @@ -584,6 +593,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return second level cache miss */ + @Override public long getSecondLevelCacheMissCount() { return secondLevelCacheMissCount.get(); } @@ -591,6 +601,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return second level cache put */ + @Override public long getSecondLevelCachePutCount() { return secondLevelCachePutCount.get(); } @@ -628,6 +639,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return session closing */ + @Override public long getSessionCloseCount() { return sessionCloseCount.get(); } @@ -635,6 +647,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return session opening */ + @Override public long getSessionOpenCount() { return sessionOpenCount.get(); } @@ -642,6 +655,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return collection loading (from DB) */ + @Override public long getCollectionLoadCount() { return collectionLoadCount.get(); } @@ -649,6 +663,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return collection fetching (from DB) */ + @Override public long getCollectionFetchCount() { return collectionFetchCount.get(); } @@ -656,6 +671,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return collection update */ + @Override public long getCollectionUpdateCount() { return collectionUpdateCount.get(); } @@ -664,6 +680,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service * @return collection removal * FIXME: even if isInverse="true"? */ + @Override public long getCollectionRemoveCount() { return collectionRemoveCount.get(); } @@ -671,6 +688,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return collection recreation */ + @Override public long getCollectionRecreateCount() { return collectionRecreateCount.get(); } @@ -678,6 +696,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * @return start time in ms (JVM standards {@link System#currentTimeMillis()}) */ + @Override public long getStartTime() { return startTime; } @@ -685,6 +704,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * log in info level the main statistics */ + @Override public void logSummary() { LOG.loggingStatistics(); LOG.startTime( startTime ); @@ -728,6 +748,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * Are statistics logged */ + @Override public boolean isStatisticsEnabled() { return isStatisticsEnabled; } @@ -735,6 +756,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * Enable statistics logs (this is a dynamic parameter) */ + @Override public void setStatisticsEnabled(boolean b) { isStatisticsEnabled = b; } @@ -743,6 +765,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service * @return Returns the max query execution time, * for all queries */ + @Override public long getQueryExecutionMaxTime() { return queryExecutionMaxTime.get(); } @@ -750,6 +773,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * Get all executed query strings */ + @Override public String[] getQueries() { return ArrayHelper.toStringArray( queryStatistics.keySet() ); } @@ -757,6 +781,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * Get the names of all entities */ + @Override public String[] getEntityNames() { if ( sessionFactory == null ) { return ArrayHelper.toStringArray( entityStatistics.keySet() ); @@ -769,6 +794,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * Get the names of all collection roles */ + @Override public String[] getCollectionRoleNames() { if ( sessionFactory == null ) { return ArrayHelper.toStringArray( collectionStatistics.keySet() ); @@ -781,6 +807,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service /** * Get all second-level cache region names */ + @Override public String[] getSecondLevelCacheRegionNames() { if ( sessionFactory == null ) { return ArrayHelper.toStringArray( secondLevelCacheStatistics.keySet() ); @@ -789,43 +816,43 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service return ArrayHelper.toStringArray( sessionFactory.getAllSecondLevelCacheRegions().keySet() ); } } - + @Override public void endTransaction(boolean success) { transactionCount.getAndIncrement(); if ( success ) { committedTransactionCount.getAndIncrement(); } } - + @Override public long getSuccessfulTransactionCount() { return committedTransactionCount.get(); } - + @Override public long getTransactionCount() { return transactionCount.get(); } - + @Override public void closeStatement() { closeStatementCount.getAndIncrement(); } - + @Override public void prepareStatement() { prepareStatementCount.getAndIncrement(); } - + @Override public long getCloseStatementCount() { return closeStatementCount.get(); } - + @Override public long getPrepareStatementCount() { return prepareStatementCount.get(); } - + @Override public void optimisticFailure(String entityName) { optimisticFailureCount.getAndIncrement(); ( (ConcurrentEntityStatisticsImpl) getEntityStatistics( entityName ) ).incrementOptimisticFailureCount(); } - + @Override public long getOptimisticFailureCount() { return optimisticFailureCount.get(); } @@ -873,7 +900,7 @@ public class ConcurrentStatisticsImpl implements StatisticsImplementor, Service .append( ']' ) .toString(); } - + @Override public String getQueryExecutionMaxTimeQueryString() { return queryExecutionMaxTimeQueryString; } diff --git a/hibernate-core/src/main/java/org/hibernate/stat/spi/StatisticsImplementor.java b/hibernate-core/src/main/java/org/hibernate/stat/spi/StatisticsImplementor.java index 4373587f80..59b3f92ea8 100644 --- a/hibernate-core/src/main/java/org/hibernate/stat/spi/StatisticsImplementor.java +++ b/hibernate-core/src/main/java/org/hibernate/stat/spi/StatisticsImplementor.java @@ -249,4 +249,4 @@ public interface StatisticsImplementor extends Statistics, Service { * Callback indicating a put to the timestamp cache */ public void updateTimestampsCachePut(); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/transform/AliasedTupleSubsetResultTransformer.java b/hibernate-core/src/main/java/org/hibernate/transform/AliasedTupleSubsetResultTransformer.java index aeec27ee45..daadf88441 100644 --- a/hibernate-core/src/main/java/org/hibernate/transform/AliasedTupleSubsetResultTransformer.java +++ b/hibernate-core/src/main/java/org/hibernate/transform/AliasedTupleSubsetResultTransformer.java @@ -56,4 +56,4 @@ public abstract class AliasedTupleSubsetResultTransformer } return includeInTransform; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/transform/TupleSubsetResultTransformer.java b/hibernate-core/src/main/java/org/hibernate/transform/TupleSubsetResultTransformer.java index 4f6c0fb309..aebe2c77ce 100644 --- a/hibernate-core/src/main/java/org/hibernate/transform/TupleSubsetResultTransformer.java +++ b/hibernate-core/src/main/java/org/hibernate/transform/TupleSubsetResultTransformer.java @@ -82,4 +82,4 @@ public interface TupleSubsetResultTransformer extends ResultTransformer { * element of the tuple is included in the transformed value. */ boolean[] includeInTransform(String[] aliases, int tupleLength); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/tuple/Dom4jInstantiator.java b/hibernate-core/src/main/java/org/hibernate/tuple/Dom4jInstantiator.java index a00c4bea5e..38d2d4d65c 100755 --- a/hibernate-core/src/main/java/org/hibernate/tuple/Dom4jInstantiator.java +++ b/hibernate-core/src/main/java/org/hibernate/tuple/Dom4jInstantiator.java @@ -74,4 +74,4 @@ public class Dom4jInstantiator implements Instantiator { return false; } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/tuple/DynamicMapInstantiator.java b/hibernate-core/src/main/java/org/hibernate/tuple/DynamicMapInstantiator.java index 66627e064d..2b3b7ad8a2 100755 --- a/hibernate-core/src/main/java/org/hibernate/tuple/DynamicMapInstantiator.java +++ b/hibernate-core/src/main/java/org/hibernate/tuple/DynamicMapInstantiator.java @@ -92,4 +92,4 @@ public class DynamicMapInstantiator implements Instantiator { protected Map generateMap() { return new HashMap(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/tuple/PojoInstantiator.java b/hibernate-core/src/main/java/org/hibernate/tuple/PojoInstantiator.java index 2e107733ac..dcd5669072 100755 --- a/hibernate-core/src/main/java/org/hibernate/tuple/PojoInstantiator.java +++ b/hibernate-core/src/main/java/org/hibernate/tuple/PojoInstantiator.java @@ -140,4 +140,4 @@ public class PojoInstantiator implements Instantiator, Serializable { return mappedClass.isInstance(object) || ( proxyInterface!=null && proxyInterface.isInstance(object) ); //this one needed only for guessEntityMode() } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/tuple/component/ComponentTuplizerFactory.java b/hibernate-core/src/main/java/org/hibernate/tuple/component/ComponentTuplizerFactory.java index 5910eb6b48..c912708b3a 100644 --- a/hibernate-core/src/main/java/org/hibernate/tuple/component/ComponentTuplizerFactory.java +++ b/hibernate-core/src/main/java/org/hibernate/tuple/component/ComponentTuplizerFactory.java @@ -157,4 +157,4 @@ public class ComponentTuplizerFactory implements Serializable { map.put( EntityMode.MAP, DynamicMapComponentTuplizer.class ); return map; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/tuple/entity/EntityTuplizer.java b/hibernate-core/src/main/java/org/hibernate/tuple/entity/EntityTuplizer.java index b652105468..229656949b 100644 --- a/hibernate-core/src/main/java/org/hibernate/tuple/entity/EntityTuplizer.java +++ b/hibernate-core/src/main/java/org/hibernate/tuple/entity/EntityTuplizer.java @@ -302,4 +302,4 @@ public interface EntityTuplizer extends Tuplizer { * @return The getter for the version property. */ public Getter getVersionGetter(); -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/type/AbstractLongBinaryType.java b/hibernate-core/src/main/java/org/hibernate/type/AbstractLongBinaryType.java index 197dbc0143..1c6927fc19 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/AbstractLongBinaryType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/AbstractLongBinaryType.java @@ -44,4 +44,4 @@ public abstract class AbstractLongBinaryType extends AbstractBynaryType { protected byte[] toInternalFormat(Object bytes) { return ( byte[] ) bytes; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/type/AbstractLongStringType.java b/hibernate-core/src/main/java/org/hibernate/type/AbstractLongStringType.java index 9e46bd8162..0c4ec658a6 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/AbstractLongStringType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/AbstractLongStringType.java @@ -91,4 +91,4 @@ public abstract class AbstractLongStringType extends ImmutableType { return xml; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/type/AbstractSingleColumnStandardBasicType.java b/hibernate-core/src/main/java/org/hibernate/type/AbstractSingleColumnStandardBasicType.java index 64b6467684..88e69f7fcd 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/AbstractSingleColumnStandardBasicType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/AbstractSingleColumnStandardBasicType.java @@ -56,4 +56,4 @@ public abstract class AbstractSingleColumnStandardBasicType nullSafeSet( st, value, index, session ); } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/type/BigDecimalType.java b/hibernate-core/src/main/java/org/hibernate/type/BigDecimalType.java index aa9279f2c6..86fd6173d2 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/BigDecimalType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/BigDecimalType.java @@ -53,4 +53,4 @@ public class BigDecimalType extends AbstractSingleColumnStandardBasicType implements PrimitiveType, DiscriminatorType, VersionType { public static final ByteType INSTANCE = new ByteType(); - private static final Byte ZERO = Byte.valueOf( (byte)0 ); + private static final Byte ZERO = (byte) 0; public ByteType() { super( TinyIntTypeDescriptor.INSTANCE, ByteTypeDescriptor.INSTANCE ); } - + @Override public String getName() { return "byte"; } @@ -58,36 +57,35 @@ public class ByteType public String[] getRegistrationKeys() { return new String[] { getName(), byte.class.getName(), Byte.class.getName() }; } - + @Override public Serializable getDefaultValue() { return ZERO; } - + @Override public Class getPrimitiveClass() { return byte.class; } - + @Override public String objectToSQLString(Byte value, Dialect dialect) { return toString( value ); } - + @Override public Byte stringToObject(String xml) { return fromString( xml ); } - + @Override public Byte fromStringValue(String xml) { return fromString( xml ); } - - @SuppressWarnings({ "UnnecessaryUnboxing" }) + @Override public Byte next(Byte current, SessionImplementor session) { - return Byte.valueOf( (byte) ( current.byteValue() + 1 ) ); + return (byte) ( current + 1 ); } - + @Override public Byte seed(SessionImplementor session) { return ZERO; } - + @Override public Comparator getComparator() { return getJavaTypeDescriptor().getComparator(); } diff --git a/hibernate-core/src/main/java/org/hibernate/type/DoubleType.java b/hibernate-core/src/main/java/org/hibernate/type/DoubleType.java index 961aa41966..916eb5706b 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/DoubleType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/DoubleType.java @@ -37,13 +37,12 @@ import org.hibernate.type.descriptor.java.DoubleTypeDescriptor; public class DoubleType extends AbstractSingleColumnStandardBasicType implements PrimitiveType { public static final DoubleType INSTANCE = new DoubleType(); - @SuppressWarnings({ "UnnecessaryBoxing" }) - public static final Double ZERO = Double.valueOf( 0.0 ); + public static final Double ZERO = 0.0; public DoubleType() { super( org.hibernate.type.descriptor.sql.DoubleTypeDescriptor.INSTANCE, DoubleTypeDescriptor.INSTANCE ); } - + @Override public String getName() { return "double"; } @@ -52,15 +51,15 @@ public class DoubleType extends AbstractSingleColumnStandardBasicType im public String[] getRegistrationKeys() { return new String[] { getName(), double.class.getName(), Double.class.getName() }; } - + @Override public Serializable getDefaultValue() { return ZERO; } - + @Override public Class getPrimitiveClass() { return double.class; } - + @Override public String objectToSQLString(Double value, Dialect dialect) throws Exception { return toString( value ); } diff --git a/hibernate-core/src/main/java/org/hibernate/type/FloatType.java b/hibernate-core/src/main/java/org/hibernate/type/FloatType.java index 089d554e25..30ccbc5e88 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/FloatType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/FloatType.java @@ -37,13 +37,12 @@ import org.hibernate.type.descriptor.java.FloatTypeDescriptor; public class FloatType extends AbstractSingleColumnStandardBasicType implements PrimitiveType { public static final FloatType INSTANCE = new FloatType(); - @SuppressWarnings({ "UnnecessaryBoxing" }) - public static final Float ZERO = Float.valueOf( 0.0f ); + public static final Float ZERO = 0.0f; public FloatType() { super( org.hibernate.type.descriptor.sql.FloatTypeDescriptor.INSTANCE, FloatTypeDescriptor.INSTANCE ); } - + @Override public String getName() { return "float"; } @@ -52,15 +51,15 @@ public class FloatType extends AbstractSingleColumnStandardBasicType impl public String[] getRegistrationKeys() { return new String[] { getName(), float.class.getName(), Float.class.getName() }; } - + @Override public Serializable getDefaultValue() { return ZERO; } - + @Override public Class getPrimitiveClass() { return float.class; } - + @Override public String objectToSQLString(Float value, Dialect dialect) throws Exception { return toString( value ); } diff --git a/hibernate-core/src/main/java/org/hibernate/type/IntegerType.java b/hibernate-core/src/main/java/org/hibernate/type/IntegerType.java index 5a83d9b298..279f41d86a 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/IntegerType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/IntegerType.java @@ -41,13 +41,12 @@ public class IntegerType extends AbstractSingleColumnStandardBasicType public static final IntegerType INSTANCE = new IntegerType(); - @SuppressWarnings({ "UnnecessaryBoxing" }) - public static final Integer ZERO = Integer.valueOf( 0 ); + public static final Integer ZERO = 0; public IntegerType() { super( org.hibernate.type.descriptor.sql.IntegerTypeDescriptor.INSTANCE, IntegerTypeDescriptor.INSTANCE ); } - + @Override public String getName() { return "integer"; } @@ -56,32 +55,31 @@ public class IntegerType extends AbstractSingleColumnStandardBasicType public String[] getRegistrationKeys() { return new String[] { getName(), int.class.getName(), Integer.class.getName() }; } - + @Override public Serializable getDefaultValue() { return ZERO; } - + @Override public Class getPrimitiveClass() { return int.class; } - + @Override public String objectToSQLString(Integer value, Dialect dialect) throws Exception { return toString( value ); } - + @Override public Integer stringToObject(String xml) { return fromString( xml ); } - + @Override public Integer seed(SessionImplementor session) { return ZERO; } - - @SuppressWarnings({ "UnnecessaryBoxing", "UnnecessaryUnboxing" }) + @Override public Integer next(Integer current, SessionImplementor session) { return current+1; } - + @Override public Comparator getComparator() { return getJavaTypeDescriptor().getComparator(); } diff --git a/hibernate-core/src/main/java/org/hibernate/type/LongType.java b/hibernate-core/src/main/java/org/hibernate/type/LongType.java index f0e526f48b..4ce675a82f 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/LongType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/LongType.java @@ -43,13 +43,12 @@ public class LongType public static final LongType INSTANCE = new LongType(); - @SuppressWarnings({ "UnnecessaryBoxing" }) - private static final Long ZERO = Long.valueOf( 0 ); + private static final Long ZERO = (long) 0; public LongType() { super( BigIntTypeDescriptor.INSTANCE, LongTypeDescriptor.INSTANCE ); } - + @Override public String getName() { return "long"; } @@ -58,32 +57,31 @@ public class LongType public String[] getRegistrationKeys() { return new String[] { getName(), long.class.getName(), Long.class.getName() }; } - + @Override public Serializable getDefaultValue() { return ZERO; } - + @Override public Class getPrimitiveClass() { return long.class; } - + @Override public Long stringToObject(String xml) throws Exception { return Long.valueOf( xml ); } - - @SuppressWarnings({ "UnnecessaryBoxing", "UnnecessaryUnboxing" }) + @Override public Long next(Long current, SessionImplementor session) { return current + 1l; } - + @Override public Long seed(SessionImplementor session) { return ZERO; } - + @Override public Comparator getComparator() { return getJavaTypeDescriptor().getComparator(); } - + @Override public String objectToSQLString(Long value, Dialect dialect) throws Exception { return value.toString(); } diff --git a/hibernate-core/src/main/java/org/hibernate/type/MaterializedClobType.java b/hibernate-core/src/main/java/org/hibernate/type/MaterializedClobType.java index 569c5e0c60..bfb002291c 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/MaterializedClobType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/MaterializedClobType.java @@ -42,4 +42,4 @@ public class MaterializedClobType extends AbstractSingleColumnStandardBasicType< public String getName() { return "materialized_clob"; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/type/MaterializedNClobType.java b/hibernate-core/src/main/java/org/hibernate/type/MaterializedNClobType.java index 4a6de4ecd0..d558cf62a8 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/MaterializedNClobType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/MaterializedNClobType.java @@ -43,4 +43,4 @@ public class MaterializedNClobType extends AbstractSingleColumnStandardBasicType public String getName() { return "materialized_nclob"; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/type/NumericBooleanType.java b/hibernate-core/src/main/java/org/hibernate/type/NumericBooleanType.java index 83397a198a..261bff0b3d 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/NumericBooleanType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/NumericBooleanType.java @@ -43,25 +43,24 @@ public class NumericBooleanType public NumericBooleanType() { super( IntegerTypeDescriptor.INSTANCE, BooleanTypeDescriptor.INSTANCE ); } - + @Override public String getName() { return "numeric_boolean"; } - + @Override public Class getPrimitiveClass() { return boolean.class; } - + @Override public Serializable getDefaultValue() { return Boolean.FALSE; } - + @Override public Boolean stringToObject(String string) { return fromString( string ); } - - @SuppressWarnings({ "UnnecessaryUnboxing" }) + @Override public String objectToSQLString(Boolean value, Dialect dialect) { - return value.booleanValue() ? "1" : "0"; + return value ? "1" : "0"; } } diff --git a/hibernate-core/src/main/java/org/hibernate/type/ShortType.java b/hibernate-core/src/main/java/org/hibernate/type/ShortType.java index 296448d411..1ad220d6d7 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/ShortType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/ShortType.java @@ -43,13 +43,12 @@ public class ShortType public static final ShortType INSTANCE = new ShortType(); - @SuppressWarnings({ "UnnecessaryBoxing" }) - private static final Short ZERO = Short.valueOf( (short) 0 ); + private static final Short ZERO = (short) 0; public ShortType() { super( SmallIntTypeDescriptor.INSTANCE, ShortTypeDescriptor.INSTANCE ); } - + @Override public String getName() { return "short"; } @@ -58,32 +57,31 @@ public class ShortType public String[] getRegistrationKeys() { return new String[] { getName(), short.class.getName(), Short.class.getName() }; } - + @Override public Serializable getDefaultValue() { return ZERO; } - + @Override public Class getPrimitiveClass() { return short.class; } - + @Override public String objectToSQLString(Short value, Dialect dialect) throws Exception { return value.toString(); } - + @Override public Short stringToObject(String xml) throws Exception { return Short.valueOf( xml ); } - - @SuppressWarnings({ "UnnecessaryBoxing", "UnnecessaryUnboxing" }) + @Override public Short next(Short current, SessionImplementor session) { - return Short.valueOf( (short) ( current.shortValue() + 1 ) ); + return (short) ( current + 1 ); } - + @Override public Short seed(SessionImplementor session) { return ZERO; } - + @Override public Comparator getComparator() { return getJavaTypeDescriptor().getComparator(); } diff --git a/hibernate-core/src/main/java/org/hibernate/type/TrueFalseType.java b/hibernate-core/src/main/java/org/hibernate/type/TrueFalseType.java index 01e3ce8c66..a39c8b5e11 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/TrueFalseType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/TrueFalseType.java @@ -44,26 +44,25 @@ public class TrueFalseType public TrueFalseType() { super( CharTypeDescriptor.INSTANCE, new BooleanTypeDescriptor( 'T', 'F' ) ); } - + @Override public String getName() { return "true_false"; } - + @Override public Class getPrimitiveClass() { return boolean.class; } - + @Override public Boolean stringToObject(String xml) throws Exception { return fromString( xml ); } - + @Override public Serializable getDefaultValue() { return Boolean.FALSE; } - - @SuppressWarnings({ "UnnecessaryUnboxing" }) + @Override public String objectToSQLString(Boolean value, Dialect dialect) throws Exception { - return StringType.INSTANCE.objectToSQLString( value.booleanValue() ? "T" : "F", dialect ); + return StringType.INSTANCE.objectToSQLString( value ? "T" : "F", dialect ); } } diff --git a/hibernate-core/src/main/java/org/hibernate/type/YesNoType.java b/hibernate-core/src/main/java/org/hibernate/type/YesNoType.java index 6dbba3379d..bccd32cdd1 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/YesNoType.java +++ b/hibernate-core/src/main/java/org/hibernate/type/YesNoType.java @@ -44,25 +44,24 @@ public class YesNoType public YesNoType() { super( CharTypeDescriptor.INSTANCE, BooleanTypeDescriptor.INSTANCE ); } - + @Override public String getName() { return "yes_no"; } - + @Override public Class getPrimitiveClass() { return boolean.class; } - + @Override public Boolean stringToObject(String xml) throws Exception { return fromString( xml ); } - + @Override public Serializable getDefaultValue() { return Boolean.FALSE; } - - @SuppressWarnings({ "UnnecessaryUnboxing" }) + @Override public String objectToSQLString(Boolean value, Dialect dialect) throws Exception { - return StringType.INSTANCE.objectToSQLString( value.booleanValue() ? "Y" : "N", dialect ); + return StringType.INSTANCE.objectToSQLString( value ? "Y" : "N", dialect ); } } diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BooleanTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BooleanTypeDescriptor.java index a220af0d17..85e0fe231d 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BooleanTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BooleanTypeDescriptor.java @@ -58,16 +58,17 @@ public class BooleanTypeDescriptor extends AbstractTypeDescriptor { stringValueTrue = String.valueOf( characterValueTrue ); stringValueFalse = String.valueOf( characterValueFalse ); } - + @Override public String toString(Boolean value) { return value == null ? null : value.toString(); } - + @Override public Boolean fromString(String string) { return Boolean.valueOf( string ); } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Boolean value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -95,8 +96,7 @@ public class BooleanTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryUnboxing" }) + @Override public Boolean wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -109,7 +109,7 @@ public class BooleanTypeDescriptor extends AbstractTypeDescriptor { return intValue == 0 ? FALSE : TRUE; } if ( Character.class.isInstance( value ) ) { - return isTrue( ( (Character) value ).charValue() ) ? TRUE : FALSE; + return isTrue( (Character) value ) ? TRUE : FALSE; } if ( String.class.isInstance( value ) ) { return isTrue( ( (String) value ).charAt( 0 ) ) ? TRUE : FALSE; @@ -125,23 +125,19 @@ public class BooleanTypeDescriptor extends AbstractTypeDescriptor { return value ? 1 : 0; } - @SuppressWarnings({ "UnnecessaryBoxing" }) public Byte toByte(Boolean value) { - return Byte.valueOf( (byte) toInt( value ) ); + return (byte) toInt( value ); } - @SuppressWarnings({ "UnnecessaryBoxing" }) public Short toShort(Boolean value) { - return Short.valueOf( (short ) toInt( value ) ); + return (short) toInt( value ); } - @SuppressWarnings({ "UnnecessaryBoxing" }) public Integer toInteger(Boolean value) { - return Integer.valueOf( toInt( value ) ); + return toInt( value ); } - @SuppressWarnings({ "UnnecessaryBoxing" }) public Long toLong(Boolean value) { - return Long.valueOf( toInt( value ) ); + return (long) toInt( value ); } } diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ByteArrayTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ByteArrayTypeDescriptor.java index 9c15fdf719..c4a48f4bb2 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ByteArrayTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ByteArrayTypeDescriptor.java @@ -45,12 +45,11 @@ public class ByteArrayTypeDescriptor extends AbstractTypeDescriptor { public ByteArrayTypeDescriptor() { super( Byte[].class, ArrayMutabilityPlan.INSTANCE ); } - - @SuppressWarnings({ "UnnecessaryUnboxing" }) + @Override public String toString(Byte[] bytes) { final StringBuilder buf = new StringBuilder(); for ( Byte aByte : bytes ) { - final String hexStr = Integer.toHexString( aByte.byteValue() - Byte.MIN_VALUE ); + final String hexStr = Integer.toHexString( aByte - Byte.MIN_VALUE ); if ( hexStr.length() == 1 ) { buf.append( '0' ); } @@ -58,8 +57,7 @@ public class ByteArrayTypeDescriptor extends AbstractTypeDescriptor { } return buf.toString(); } - - @SuppressWarnings({ "UnnecessaryBoxing" }) + @Override public Byte[] fromString(String string) { if ( string == null ) { return null; @@ -70,12 +68,13 @@ public class ByteArrayTypeDescriptor extends AbstractTypeDescriptor { Byte[] bytes = new Byte[string.length() / 2]; for ( int i = 0; i < bytes.length; i++ ) { final String hexStr = string.substring( i * 2, (i + 1) * 2 ); - bytes[i] = Byte.valueOf( (byte) (Integer.parseInt(hexStr, 16) + Byte.MIN_VALUE) ); + bytes[i] = (byte) ( Integer.parseInt( hexStr, 16 ) + Byte.MIN_VALUE ); } return bytes; } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Byte[] value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -98,7 +97,7 @@ public class ByteArrayTypeDescriptor extends AbstractTypeDescriptor { throw unknownUnwrap( type ); } - + @Override public Byte[] wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -124,26 +123,24 @@ public class ByteArrayTypeDescriptor extends AbstractTypeDescriptor { throw unknownWrap( value.getClass() ); } - @SuppressWarnings({ "UnnecessaryBoxing" }) private Byte[] wrapBytes(byte[] bytes) { if ( bytes == null ) { return null; } final Byte[] result = new Byte[bytes.length]; for ( int i = 0; i < bytes.length; i++ ) { - result[i] = Byte.valueOf( bytes[i] ); + result[i] = bytes[i]; } return result; } - @SuppressWarnings({ "UnnecessaryUnboxing" }) private byte[] unwrapBytes(Byte[] bytes) { if ( bytes == null ) { return null; } final byte[] result = new byte[bytes.length]; for ( int i = 0; i < bytes.length; i++ ) { - result[i] = bytes[i].byteValue(); + result[i] = bytes[i]; } return result; } diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ByteTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ByteTypeDescriptor.java index c86d9cfdb3..95523bf51f 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ByteTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ByteTypeDescriptor.java @@ -37,15 +37,17 @@ public class ByteTypeDescriptor extends AbstractTypeDescriptor { super( Byte.class ); } + @Override public String toString(Byte value) { return value == null ? null : value.toString(); } - + @Override public Byte fromString(String string) { return Byte.valueOf( string ); } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Byte value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -73,8 +75,7 @@ public class ByteTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryBoxing" }) + @Override public Byte wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -83,7 +84,7 @@ public class ByteTypeDescriptor extends AbstractTypeDescriptor { return (Byte) value; } if ( Number.class.isInstance( value ) ) { - return Byte.valueOf( ( (Number) value ).byteValue() ); + return ( (Number) value ).byteValue(); } if ( String.class.isInstance( value ) ) { return Byte.valueOf( ( (String) value ) ); diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarDateTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarDateTypeDescriptor.java index 0a8f5d6346..6cb12139bc 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarDateTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarDateTypeDescriptor.java @@ -130,4 +130,4 @@ public class CalendarDateTypeDescriptor extends AbstractTypeDescriptor } return cal; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CharacterArrayTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CharacterArrayTypeDescriptor.java index 59ee39666f..ac74e6b7de 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CharacterArrayTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CharacterArrayTypeDescriptor.java @@ -44,11 +44,11 @@ public class CharacterArrayTypeDescriptor extends AbstractTypeDescriptor X unwrap(Character[] value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -90,7 +91,7 @@ public class CharacterArrayTypeDescriptor extends AbstractTypeDescriptor Character[] wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -110,26 +111,24 @@ public class CharacterArrayTypeDescriptor extends AbstractTypeDescriptor { public CharacterTypeDescriptor() { super( Character.class ); } - + @Override public String toString(Character value) { return value.toString(); } - - @SuppressWarnings({ "UnnecessaryBoxing" }) + @Override public Character fromString(String string) { if ( string.length() != 1 ) { throw new HibernateException( "multiple or zero characters found parsing string" ); } - return Character.valueOf( string.charAt( 0 ) ); + return string.charAt( 0 ); } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Character value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -65,8 +65,7 @@ public class CharacterTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryBoxing" }) + @Override public Character wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -76,11 +75,11 @@ public class CharacterTypeDescriptor extends AbstractTypeDescriptor { } if ( String.class.isInstance( value ) ) { final String str = (String) value; - return Character.valueOf( str.charAt(0) ); + return str.charAt( 0 ); } if ( Number.class.isInstance( value ) ) { final Number nbr = (Number) value; - return Character.valueOf( (char)nbr.shortValue() ); + return (char) nbr.shortValue(); } throw unknownWrap( value.getClass() ); } diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/DateTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/DateTypeDescriptor.java index 1882c725cd..17e90e49aa 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/DateTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/DateTypeDescriptor.java @@ -43,7 +43,7 @@ public class DateTypeDescriptor extends AbstractTypeDescriptor { public static class DateMutabilityPlan extends MutableMutabilityPlan { public static final DateMutabilityPlan INSTANCE = new DateMutabilityPlan(); - + @Override public Date deepCopyNotNull(Date value) { return new Date( value.getTime() ); } @@ -52,11 +52,11 @@ public class DateTypeDescriptor extends AbstractTypeDescriptor { public DateTypeDescriptor() { super( Date.class, DateMutabilityPlan.INSTANCE ); } - + @Override public String toString(Date value) { return new SimpleDateFormat( DATE_FORMAT ).format( value ); } - + @Override public Date fromString(String string) { try { return new SimpleDateFormat(DATE_FORMAT).parse( string ); @@ -71,11 +71,8 @@ public class DateTypeDescriptor extends AbstractTypeDescriptor { if ( one == another) { return true; } - if ( one == null || another == null ) { - return false; - } + return !( one == null || another == null ) && one.getTime() == another.getTime(); - return one.getTime() == another.getTime(); } @Override @@ -86,6 +83,7 @@ public class DateTypeDescriptor extends AbstractTypeDescriptor { } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Date value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -121,8 +119,7 @@ public class DateTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryUnboxing" }) + @Override public Date wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -132,7 +129,7 @@ public class DateTypeDescriptor extends AbstractTypeDescriptor { } if ( Long.class.isInstance( value ) ) { - return new Date( ( (Long) value ).longValue() ); + return new Date( (Long) value ); } if ( Calendar.class.isInstance( value ) ) { @@ -141,4 +138,4 @@ public class DateTypeDescriptor extends AbstractTypeDescriptor { throw unknownWrap( value.getClass() ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/DoubleTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/DoubleTypeDescriptor.java index ffcdcb429f..546cb8e4ef 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/DoubleTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/DoubleTypeDescriptor.java @@ -39,16 +39,17 @@ public class DoubleTypeDescriptor extends AbstractTypeDescriptor { public DoubleTypeDescriptor() { super( Double.class ); } - + @Override public String toString(Double value) { return value == null ? null : value.toString(); } - + @Override public Double fromString(String string) { return Double.valueOf( string ); } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Double value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -82,8 +83,7 @@ public class DoubleTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryBoxing" }) + @Override public Double wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -92,7 +92,7 @@ public class DoubleTypeDescriptor extends AbstractTypeDescriptor { return (Double) value; } if ( Number.class.isInstance( value ) ) { - return Double.valueOf( ( (Number) value ).doubleValue() ); + return ( (Number) value ).doubleValue(); } else if ( String.class.isInstance( value ) ) { return Double.valueOf( ( (String) value ) ); diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/FloatTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/FloatTypeDescriptor.java index 69bd4537a8..b1f271307f 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/FloatTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/FloatTypeDescriptor.java @@ -39,16 +39,17 @@ public class FloatTypeDescriptor extends AbstractTypeDescriptor { public FloatTypeDescriptor() { super( Float.class ); } - + @Override public String toString(Float value) { return value == null ? null : value.toString(); } - + @Override public Float fromString(String string) { return Float.valueOf( string ); } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Float value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -82,8 +83,7 @@ public class FloatTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryBoxing" }) + @Override public Float wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -92,7 +92,7 @@ public class FloatTypeDescriptor extends AbstractTypeDescriptor { return (Float) value; } if ( Number.class.isInstance( value ) ) { - return Float.valueOf( ( (Number) value ).floatValue() ); + return ( (Number) value ).floatValue(); } else if ( String.class.isInstance( value ) ) { return Float.valueOf( ( (String) value ) ); diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/IntegerTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/IntegerTypeDescriptor.java index 3fd7bf1d57..a009483333 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/IntegerTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/IntegerTypeDescriptor.java @@ -39,16 +39,17 @@ public class IntegerTypeDescriptor extends AbstractTypeDescriptor { public IntegerTypeDescriptor() { super( Integer.class ); } - + @Override public String toString(Integer value) { return value == null ? null : value.toString(); } - + @Override public Integer fromString(String string) { return string == null ? null : Integer.valueOf( string ); } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Integer value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -82,8 +83,7 @@ public class IntegerTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryBoxing" }) + @Override public Integer wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -92,7 +92,7 @@ public class IntegerTypeDescriptor extends AbstractTypeDescriptor { return (Integer) value; } if ( Number.class.isInstance( value ) ) { - return Integer.valueOf( ( (Number) value ).intValue() ); + return ( (Number) value ).intValue(); } if ( String.class.isInstance( value ) ) { return Integer.valueOf( ( (String) value ) ); diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcDateTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcDateTypeDescriptor.java index bc52ffba83..d7d293ac8a 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcDateTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcDateTypeDescriptor.java @@ -43,7 +43,7 @@ public class JdbcDateTypeDescriptor extends AbstractTypeDescriptor { public static class DateMutabilityPlan extends MutableMutabilityPlan { public static final DateMutabilityPlan INSTANCE = new DateMutabilityPlan(); - + @Override public Date deepCopyNotNull(Date value) { return java.sql.Date.class.isInstance( value ) ? new java.sql.Date( value.getTime() ) @@ -54,11 +54,11 @@ public class JdbcDateTypeDescriptor extends AbstractTypeDescriptor { public JdbcDateTypeDescriptor() { super( Date.class, DateMutabilityPlan.INSTANCE ); } - + @Override public String toString(Date value) { return new SimpleDateFormat( DATE_FORMAT ).format( value ); } - + @Override public Date fromString(String string) { try { return new Date( new SimpleDateFormat(DATE_FORMAT).parse( string ).getTime() ); @@ -103,6 +103,7 @@ public class JdbcDateTypeDescriptor extends AbstractTypeDescriptor { } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Date value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -138,8 +139,7 @@ public class JdbcDateTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryUnboxing" }) + @Override public Date wrap(X value, WrapperOptions options) { if ( value == null ) { return null; diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimeTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimeTypeDescriptor.java index d68fd029a2..6ef506b69e 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimeTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimeTypeDescriptor.java @@ -44,7 +44,7 @@ public class JdbcTimeTypeDescriptor extends AbstractTypeDescriptor { public static class TimeMutabilityPlan extends MutableMutabilityPlan { public static final TimeMutabilityPlan INSTANCE = new TimeMutabilityPlan(); - + @Override public Date deepCopyNotNull(Date value) { return Time.class.isInstance( value ) ? new Time( value.getTime() ) @@ -55,11 +55,11 @@ public class JdbcTimeTypeDescriptor extends AbstractTypeDescriptor { public JdbcTimeTypeDescriptor() { super( Date.class, TimeMutabilityPlan.INSTANCE ); } - + @Override public String toString(Date value) { return new SimpleDateFormat( TIME_FORMAT ).format( value ); } - + @Override public java.util.Date fromString(String string) { try { return new Time( new SimpleDateFormat( TIME_FORMAT ).parse( string ).getTime() ); @@ -106,6 +106,7 @@ public class JdbcTimeTypeDescriptor extends AbstractTypeDescriptor { } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Date value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -141,8 +142,7 @@ public class JdbcTimeTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryUnboxing" }) + @Override public Date wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -152,7 +152,7 @@ public class JdbcTimeTypeDescriptor extends AbstractTypeDescriptor { } if ( Long.class.isInstance( value ) ) { - return new Time( ( (Long) value ).longValue() ); + return new Time( (Long) value ); } if ( Calendar.class.isInstance( value ) ) { diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimestampTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimestampTypeDescriptor.java index bdb8732b2b..eba62a79b8 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimestampTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimestampTypeDescriptor.java @@ -44,7 +44,7 @@ public class JdbcTimestampTypeDescriptor extends AbstractTypeDescriptor { public static class TimestampMutabilityPlan extends MutableMutabilityPlan { public static final TimestampMutabilityPlan INSTANCE = new TimestampMutabilityPlan(); - + @Override public Date deepCopyNotNull(Date value) { if ( value instanceof Timestamp ) { Timestamp orig = (Timestamp) value; @@ -61,11 +61,11 @@ public class JdbcTimestampTypeDescriptor extends AbstractTypeDescriptor { public JdbcTimestampTypeDescriptor() { super( Date.class, TimestampMutabilityPlan.INSTANCE ); } - + @Override public String toString(Date value) { return new SimpleDateFormat( TIMESTAMP_FORMAT ).format( value ); } - + @Override public Date fromString(String string) { try { return new Timestamp( new SimpleDateFormat( TIMESTAMP_FORMAT ).parse( string ).getTime() ); @@ -115,6 +115,7 @@ public class JdbcTimestampTypeDescriptor extends AbstractTypeDescriptor { } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Date value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -150,8 +151,7 @@ public class JdbcTimestampTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryUnboxing" }) + @Override public Date wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -161,7 +161,7 @@ public class JdbcTimestampTypeDescriptor extends AbstractTypeDescriptor { } if ( Long.class.isInstance( value ) ) { - return new Timestamp( ( (Long) value ).longValue() ); + return new Timestamp( (Long) value ); } if ( Calendar.class.isInstance( value ) ) { diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LongTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LongTypeDescriptor.java index c881386140..e2ab576119 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LongTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LongTypeDescriptor.java @@ -39,16 +39,17 @@ public class LongTypeDescriptor extends AbstractTypeDescriptor { public LongTypeDescriptor() { super( Long.class ); } - + @Override public String toString(Long value) { return value == null ? null : value.toString(); } - + @Override public Long fromString(String string) { return Long.valueOf( string ); } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Long value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -82,8 +83,7 @@ public class LongTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryBoxing" }) + @Override public Long wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -92,7 +92,7 @@ public class LongTypeDescriptor extends AbstractTypeDescriptor { return (Long) value; } if ( Number.class.isInstance( value ) ) { - return Long.valueOf( ( (Number) value ).longValue() ); + return ( (Number) value ).longValue(); } else if ( String.class.isInstance( value ) ) { return Long.valueOf( ( (String) value ) ); diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ShortTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ShortTypeDescriptor.java index d914554c40..722259542e 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ShortTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ShortTypeDescriptor.java @@ -35,16 +35,17 @@ public class ShortTypeDescriptor extends AbstractTypeDescriptor { public ShortTypeDescriptor() { super( Short.class ); } - + @Override public String toString(Short value) { return value == null ? null : value.toString(); } - + @Override public Short fromString(String string) { return Short.valueOf( string ); } @SuppressWarnings({ "unchecked" }) + @Override public X unwrap(Short value, Class type, WrapperOptions options) { if ( value == null ) { return null; @@ -72,8 +73,7 @@ public class ShortTypeDescriptor extends AbstractTypeDescriptor { } throw unknownUnwrap( type ); } - - @SuppressWarnings({ "UnnecessaryBoxing" }) + @Override public Short wrap(X value, WrapperOptions options) { if ( value == null ) { return null; @@ -82,7 +82,7 @@ public class ShortTypeDescriptor extends AbstractTypeDescriptor { return (Short) value; } if ( Number.class.isInstance( value ) ) { - return Short.valueOf( ( (Number) value ).shortValue() ); + return ( (Number) value ).shortValue(); } if ( String.class.isInstance( value ) ) { return Short.valueOf( ( (String) value ) ); diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/JdbcTypeFamilyInformation.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/JdbcTypeFamilyInformation.java index 670cf7b3b4..e6799296e0 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/JdbcTypeFamilyInformation.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/JdbcTypeFamilyInformation.java @@ -45,12 +45,11 @@ public class JdbcTypeFamilyInformation { private final int[] typeCodes; - @SuppressWarnings("UnnecessaryBoxing") private Family(int... typeCodes) { this.typeCodes = typeCodes; - for ( int typeCode : typeCodes ) { - JdbcTypeFamilyInformation.INSTANCE.typeCodeToFamilyMap.put( Integer.valueOf( typeCode ), this ); + for ( final int typeCode : typeCodes ) { + JdbcTypeFamilyInformation.INSTANCE.typeCodeToFamilyMap.put( typeCode, this ); } } @@ -68,7 +67,6 @@ public class JdbcTypeFamilyInformation { * * @return The family of datatypes the type code belongs to, or {@code null} if it belongs to no known families. */ - @SuppressWarnings("UnnecessaryBoxing") public Family locateJdbcTypeFamilyByTypeCode(int typeCode) { return typeCodeToFamilyMap.get( Integer.valueOf( typeCode ) ); } diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/JdbcTypeJavaClassMappings.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/JdbcTypeJavaClassMappings.java index d7dd1c7cbd..9d894b5343 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/JdbcTypeJavaClassMappings.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/JdbcTypeJavaClassMappings.java @@ -58,7 +58,6 @@ public class JdbcTypeJavaClassMappings { private JdbcTypeJavaClassMappings() { } - @SuppressWarnings("UnnecessaryUnboxing") public int determineJdbcTypeCodeForJavaClass(Class cls) { Integer typeCode = JdbcTypeJavaClassMappings.javaClassToJdbcTypeCodeMap.get( cls ); if ( typeCode != null ) { @@ -72,7 +71,6 @@ public class JdbcTypeJavaClassMappings { return specialCode; } - @SuppressWarnings("UnnecessaryUnboxing") public Class determineJavaClassForJdbcTypeCode(int typeCode) { Class cls = jdbcTypeCodeToJavaClassMap.get( Integer.valueOf( typeCode ) ); if ( cls != null ) { @@ -131,4 +129,4 @@ public class JdbcTypeJavaClassMappings { return transposed; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/SqlTypeDescriptorRegistry.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/SqlTypeDescriptorRegistry.java index d9bceb0387..c0a6b1bbc7 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/SqlTypeDescriptorRegistry.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/SqlTypeDescriptorRegistry.java @@ -50,12 +50,10 @@ public class SqlTypeDescriptorRegistry { private ConcurrentHashMap descriptorMap = new ConcurrentHashMap(); - @SuppressWarnings("UnnecessaryBoxing") public void addDescriptor(SqlTypeDescriptor sqlTypeDescriptor) { - descriptorMap.put( Integer.valueOf( sqlTypeDescriptor.getSqlType() ), sqlTypeDescriptor ); + descriptorMap.put( sqlTypeDescriptor.getSqlType(), sqlTypeDescriptor ); } - @SuppressWarnings("UnnecessaryBoxing") public SqlTypeDescriptor getDescriptor(int jdbcTypeCode) { SqlTypeDescriptor descriptor = descriptorMap.get( Integer.valueOf( jdbcTypeCode ) ); if ( descriptor != null ) { diff --git a/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/TimestampTypeDescriptor.java b/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/TimestampTypeDescriptor.java index e71d7f17ba..424e2107df 100644 --- a/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/TimestampTypeDescriptor.java +++ b/hibernate-core/src/main/java/org/hibernate/type/descriptor/sql/TimestampTypeDescriptor.java @@ -86,4 +86,4 @@ public class TimestampTypeDescriptor implements SqlTypeDescriptor { } }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/main/java/org/hibernate/usertype/ParameterizedType.java b/hibernate-core/src/main/java/org/hibernate/usertype/ParameterizedType.java index 1a64dc8d4c..d57ca64ea3 100644 --- a/hibernate-core/src/main/java/org/hibernate/usertype/ParameterizedType.java +++ b/hibernate-core/src/main/java/org/hibernate/usertype/ParameterizedType.java @@ -40,4 +40,4 @@ public interface ParameterizedType { * the implementation. */ public void setParameterValues(Properties parameters); -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/dialect/Mocks.java b/hibernate-core/src/test/java/org/hibernate/dialect/Mocks.java index 8f5f371af3..7fbe67cc50 100644 --- a/hibernate-core/src/test/java/org/hibernate/dialect/Mocks.java +++ b/hibernate-core/src/test/java/org/hibernate/dialect/Mocks.java @@ -32,7 +32,6 @@ import java.sql.SQLException; /** * @author Steve Ebersole */ -@SuppressWarnings( {"UnnecessaryBoxing"}) public class Mocks { public static Connection createConnection(String databaseName, int majorVersion) { diff --git a/hibernate-core/src/test/java/org/hibernate/id/BigDecimalHolderTest.java b/hibernate-core/src/test/java/org/hibernate/id/BigDecimalHolderTest.java index c87af14445..0ac2380c21 100644 --- a/hibernate-core/src/test/java/org/hibernate/id/BigDecimalHolderTest.java +++ b/hibernate-core/src/test/java/org/hibernate/id/BigDecimalHolderTest.java @@ -31,4 +31,4 @@ public class BigDecimalHolderTest extends AbstractHolderTest { protected IntegralDataTypeHolder makeHolder() { return IdentifierGeneratorHelper.getIntegralDataTypeHolder( BigDecimal.class ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/id/SequenceHiLoGeneratorNoIncrementTest.java b/hibernate-core/src/test/java/org/hibernate/id/SequenceHiLoGeneratorNoIncrementTest.java index 97fd6f959e..763d5fcbc3 100644 --- a/hibernate-core/src/test/java/org/hibernate/id/SequenceHiLoGeneratorNoIncrementTest.java +++ b/hibernate-core/src/test/java/org/hibernate/id/SequenceHiLoGeneratorNoIncrementTest.java @@ -175,4 +175,4 @@ public class SequenceHiLoGeneratorNoIncrementTest extends BaseUnitTestCase { ( (Session) session ).doWork( work ); return work.value; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/loader/plan/spi/LoadPlanBuilderTest.java b/hibernate-core/src/test/java/org/hibernate/loader/plan/spi/LoadPlanBuilderTest.java index a5f6f84b2e..28bb284be9 100644 --- a/hibernate-core/src/test/java/org/hibernate/loader/plan/spi/LoadPlanBuilderTest.java +++ b/hibernate-core/src/test/java/org/hibernate/loader/plan/spi/LoadPlanBuilderTest.java @@ -138,4 +138,4 @@ public class LoadPlanBuilderTest extends BaseCoreFunctionalTestCase { private List messages; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/metamodel/binding/package-info.java b/hibernate-core/src/test/java/org/hibernate/metamodel/binding/package-info.java index c4b90dd158..95b316c2d1 100644 --- a/hibernate-core/src/test/java/org/hibernate/metamodel/binding/package-info.java +++ b/hibernate-core/src/test/java/org/hibernate/metamodel/binding/package-info.java @@ -1,4 +1,4 @@ @GenericGenerator(name = "myGenerator", strategy = "sequence") package org.hibernate.metamodel.binding; -import org.hibernate.annotations.GenericGenerator; \ No newline at end of file +import org.hibernate.annotations.GenericGenerator; diff --git a/hibernate-core/src/test/java/org/hibernate/metamodel/source/annotations/util/GenericTypeDiscoveryTest.java b/hibernate-core/src/test/java/org/hibernate/metamodel/source/annotations/util/GenericTypeDiscoveryTest.java index 2d536b02ca..4d29116a91 100644 --- a/hibernate-core/src/test/java/org/hibernate/metamodel/source/annotations/util/GenericTypeDiscoveryTest.java +++ b/hibernate-core/src/test/java/org/hibernate/metamodel/source/annotations/util/GenericTypeDiscoveryTest.java @@ -250,4 +250,4 @@ public class GenericTypeDiscoveryTest extends BaseAnnotationIndexTestCase { this.state = state; } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/metamodel/source/annotations/util/TypeDiscoveryTest.java b/hibernate-core/src/test/java/org/hibernate/metamodel/source/annotations/util/TypeDiscoveryTest.java index 40b4e66f67..2d2753440d 100644 --- a/hibernate-core/src/test/java/org/hibernate/metamodel/source/annotations/util/TypeDiscoveryTest.java +++ b/hibernate-core/src/test/java/org/hibernate/metamodel/source/annotations/util/TypeDiscoveryTest.java @@ -64,4 +64,4 @@ public class TypeDiscoveryTest extends BaseAnnotationIndexTestCase { @Type(type = "my.custom.Type", parameters = { @Parameter(name = "foo", value = "bar") }) private String customString; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/sql/TemplateTest.java b/hibernate-core/src/test/java/org/hibernate/sql/TemplateTest.java index 7421f5e554..2e1d5247ce 100644 --- a/hibernate-core/src/test/java/org/hibernate/sql/TemplateTest.java +++ b/hibernate-core/src/test/java/org/hibernate/sql/TemplateTest.java @@ -270,4 +270,4 @@ public class TemplateTest extends BaseUnitTestCase { public String doStandardRendering(String fragment) { return Template.renderOrderByStringTemplate( fragment, MAPPER, SESSION_FACTORY, DIALECT, FUNCTION_REGISTRY ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/Flight.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/Flight.java index 36967bc70f..662c55f0e2 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/Flight.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/Flight.java @@ -145,4 +145,4 @@ public class Flight implements Serializable { this.buyDate = buyDate; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/Gardenshed.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/Gardenshed.java index 9b9f17be66..dad5d73aa6 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/Gardenshed.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/Gardenshed.java @@ -51,4 +51,4 @@ public class Gardenshed public void setFloors(long floors) { this.floors = floors + 2; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/AccessMappingTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/AccessMappingTest.java index e51245e375..1d81847cf2 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/AccessMappingTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/AccessMappingTest.java @@ -248,4 +248,4 @@ public class AccessMappingTest { cfg.addAnnotatedClass( Student.class ); cfg.buildSessionFactory( serviceRegistry ).close(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/AccessTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/AccessTest.java index 18cdc28f68..3c69b829ff 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/AccessTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/AccessTest.java @@ -246,4 +246,4 @@ public class AccessTest extends BaseCoreFunctionalTestCase { Position.class }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Animal.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Animal.java index f914c95a36..416c32f030 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Animal.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Animal.java @@ -49,4 +49,4 @@ public class Animal { public void setId(long id) { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Bed.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Bed.java index 4db63d0dcf..4a0364c715 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Bed.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Bed.java @@ -45,4 +45,4 @@ public class Bed extends Furniture { public void setQuality(String quality) { this.quality = quality; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/BigBed.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/BigBed.java index 1f069a53bc..00230d10db 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/BigBed.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/BigBed.java @@ -33,4 +33,4 @@ import javax.persistence.Entity; public class BigBed extends Bed { @Column(name = "bed_size") public int size; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Chair.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Chair.java index 36a561d736..f3243e1a0b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Chair.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Chair.java @@ -42,4 +42,4 @@ public class Chair extends Furniture { public void setPillow(String pillow) { this.pillow = pillow; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Circle.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Circle.java index b9367b6c41..a04886f00b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Circle.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Circle.java @@ -45,4 +45,4 @@ public class Circle extends Shape { public void setColor(Color color) { this.color = color; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Color.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Color.java index bd757a9450..214aa877b6 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Color.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Color.java @@ -67,4 +67,4 @@ public class Color { public void setR(int r) { this.r = r; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course2.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course2.java index b18c69f167..a13809d57b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course2.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course2.java @@ -71,4 +71,4 @@ public class Course2 { public void setTitle(String title) { this.title = title; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course3.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course3.java index c70a4c1866..6e3a130971 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course3.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course3.java @@ -73,4 +73,4 @@ public class Course3 { public void setTitle(String title) { this.title = title; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course4.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course4.java index 67faf21203..38791f83f3 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course4.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course4.java @@ -71,4 +71,4 @@ public class Course4 { public void setTitle(String title) { this.title = title; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course5.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course5.java index 6d23f93390..36890f0215 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course5.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course5.java @@ -73,4 +73,4 @@ public class Course5 { public void setTitle(String title) { this.title = title; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course6.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course6.java index 672808cda3..a4c59969b1 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course6.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course6.java @@ -68,4 +68,4 @@ public class Course6 { public void setTitle(String title) { this.title = title; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course7.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course7.java index f596be201f..071ed6a8a5 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course7.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course7.java @@ -68,4 +68,4 @@ public class Course7 { public void setTitle(String title) { this.title = title; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course8.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course8.java index 546c8a6ef1..f2265a18ab 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course8.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Course8.java @@ -74,4 +74,4 @@ public class Course8 { public void setTitle(String title) { this.title = title; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Furniture.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Furniture.java index 0e15f65f67..7abd9a0b4c 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Furniture.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Furniture.java @@ -68,4 +68,4 @@ public class Furniture extends Woody { public void setWeight(long weight) { this.weight = weight + 1; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Gardenshed.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Gardenshed.java index 4cddbd4aaf..ad456887e0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Gardenshed.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Gardenshed.java @@ -74,4 +74,4 @@ public class Gardenshed public void setFloors(long floors) { this.floors = floors + 2; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Horse.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Horse.java index b2238665d5..a4d4e59c33 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Horse.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Horse.java @@ -41,4 +41,4 @@ public class Horse extends Animal { public void setName(String name) { this.name = name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Position.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Position.java index 6540514356..8d45c3c6a6 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Position.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Position.java @@ -60,4 +60,4 @@ public class Position { public void setY(int y) { this.y = y; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Shape.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Shape.java index f78f3e0a45..e006e92cfd 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Shape.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Shape.java @@ -44,4 +44,4 @@ public class Shape { public void setId(long id) { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Square.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Square.java index c9dfef0a6c..bc93f0d3ce 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Square.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Square.java @@ -57,4 +57,4 @@ public class Square { public void setPosition(Position position) { this.position = position; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Thingy.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Thingy.java index f690b88208..b2201373a5 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Thingy.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Thingy.java @@ -41,4 +41,4 @@ public class Thingy { public void setGod(String god) { this.god = god; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/User.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/User.java index bacde9cdd3..a9d3139451 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/User.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/User.java @@ -44,4 +44,4 @@ public class User extends Person { public void setFriends(List friends) { this.friends = friends; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Woody.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Woody.java index e9bb84ae8d..e11663cc28 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Woody.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/jpa/Woody.java @@ -51,4 +51,4 @@ public class Woody extends Thingy { public void setName(String name) { this.name = name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Cook.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Cook.java index 98dcef812c..7f0b171bdb 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Cook.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Cook.java @@ -47,4 +47,4 @@ public class Cook { public void setId(int id) { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Driver.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Driver.java index 8f65534ebe..2cda38951f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Driver.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Driver.java @@ -46,4 +46,4 @@ public class Driver { public void setName(String name) { this.name = name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Knive.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Knive.java index 3767924233..4bd1d71ed7 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Knive.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/Knive.java @@ -42,4 +42,4 @@ public class Knive { public void setBrand(String brand) { this.brand = brand; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/RentalCar.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/RentalCar.java index 545013a672..ea871747c7 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/RentalCar.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/RentalCar.java @@ -46,4 +46,4 @@ public class RentalCar { public void setDriver(Driver driver) { this.driver = driver; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/XmlAccessTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/XmlAccessTest.java index cffeff37b0..cd3c0a021b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/XmlAccessTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/access/xml/XmlAccessTest.java @@ -206,4 +206,4 @@ public class XmlAccessTest extends BaseUnitTestCase { ); } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/backquotes/Printer.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/backquotes/Printer.java index c275dac84f..02d0f66bde 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/backquotes/Printer.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/backquotes/Printer.java @@ -44,4 +44,4 @@ public class Printer { public void setId(Long id) { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/backquotes/PrinterCable.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/backquotes/PrinterCable.java index b0da052da3..0334746ba8 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/backquotes/PrinterCable.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/backquotes/PrinterCable.java @@ -54,4 +54,4 @@ public class PrinterCable { public void setPrinter(Printer a) { this.printer = a; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/BeanValidationGroupsTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/BeanValidationGroupsTest.java index 51e038b531..61cb9f60c9 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/BeanValidationGroupsTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/BeanValidationGroupsTest.java @@ -109,4 +109,4 @@ public class BeanValidationGroupsTest extends BaseCoreFunctionalTestCase { CupHolder.class }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/BeanValidationProvidedFactoryTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/BeanValidationProvidedFactoryTest.java index 21395333a7..9f473882e6 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/BeanValidationProvidedFactoryTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/BeanValidationProvidedFactoryTest.java @@ -88,4 +88,4 @@ public class BeanValidationProvidedFactoryTest extends BaseCoreFunctionalTestCas ValidatorFactory vf = configuration.buildValidatorFactory(); cfg.getProperties().put( "javax.persistence.validation.factory", vf ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/TvOwner.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/TvOwner.java index f5acc3cb2a..5dd2baef13 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/TvOwner.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/beanvalidation/TvOwner.java @@ -41,4 +41,4 @@ public class TvOwner { @ManyToOne @NotNull public Tv tv; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/cid/B.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/cid/B.java index 4399844216..a8314e4b51 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/cid/B.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/cid/B.java @@ -23,4 +23,4 @@ public class B { public void setId(Long id) { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/cid/TvProgram.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/cid/TvProgram.java index 5e18117023..63268c64d1 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/cid/TvProgram.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/cid/TvProgram.java @@ -34,4 +34,4 @@ public class TvProgram { @Column( name = "TXT", table = "TV_PROGRAM_EXT" ) public String text; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/BugSystem.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/BugSystem.java index 50c51bd8f9..7e528b739c 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/BugSystem.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/BugSystem.java @@ -34,4 +34,4 @@ public class BugSystem { this.bugs = bugs; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Products.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Products.java index 0ed2eb347f..b12f5fbbf0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Products.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Products.java @@ -34,4 +34,4 @@ public class Products { this.widgets = widgets; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/TestCourse.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/TestCourse.java index 49361bbb81..c6aa64df2b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/TestCourse.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/TestCourse.java @@ -38,4 +38,4 @@ public class TestCourse { public void setTitle(LocalizedString title) { this.title = title; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/Employer.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/Employer.java index be5006d585..d6abd53c5f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/Employer.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/Employer.java @@ -52,4 +52,4 @@ public class Employer { public String getName() { return name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/EmployerId.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/EmployerId.java index 702f940fb8..ce78815ded 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/EmployerId.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/EmployerId.java @@ -39,4 +39,4 @@ public class EmployerId implements Serializable { public void setEmployee(long employee) { this.employee = employee; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Dependent.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Dependent.java index d2867a93af..44423520ac 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Dependent.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Dependent.java @@ -38,4 +38,4 @@ public class Dependent implements Serializable { Employee emp; String name; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/DerivedIdentityWithBidirectionalAssociationTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/DerivedIdentityWithBidirectionalAssociationTest.java index d974500302..334857d80e 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/DerivedIdentityWithBidirectionalAssociationTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/DerivedIdentityWithBidirectionalAssociationTest.java @@ -72,4 +72,4 @@ public class DerivedIdentityWithBidirectionalAssociationTest extends BaseCoreFun Employee.class }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Employee.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Employee.java index a220ea52d7..b074e2be71 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Employee.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Employee.java @@ -39,4 +39,4 @@ public class Employee { @OneToMany(mappedBy = "emp", fetch = FetchType.LAZY) private Set dependents; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Person.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Person.java index 77a0727489..504a79c663 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Person.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/Person.java @@ -74,4 +74,4 @@ public class Person { this.personInfo = personInfo; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/PersonInfo.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/PersonInfo.java index 08a1ff9714..b209b4e95f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/PersonInfo.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/bidirectional/PersonInfo.java @@ -57,4 +57,4 @@ public class PersonInfo { return "nogroup.hibertest.PersonInfo[ id=" + this.id + " ]"; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/DependentId.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/DependentId.java index fde1fc0acf..b940a1305b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/DependentId.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/DependentId.java @@ -31,4 +31,4 @@ public class DependentId implements Serializable { public void setEmp(long emp) { this.emp = emp; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/DerivedIdentitySimpleParentIdClassDepTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/DerivedIdentitySimpleParentIdClassDepTest.java index 17daf24336..9ae6942783 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/DerivedIdentitySimpleParentIdClassDepTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/DerivedIdentitySimpleParentIdClassDepTest.java @@ -94,4 +94,4 @@ public class DerivedIdentitySimpleParentIdClassDepTest extends BaseCoreFunctiona Employee.class }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/Employee.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/Employee.java index 8cf009d011..f35de85fa0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/Employee.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e1/a/Employee.java @@ -45,4 +45,4 @@ public class Employee { public void setNickname(String nickname) { this.nickname = nickname; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/a/Employee.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/a/Employee.java index aa310e437b..43258364e1 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/a/Employee.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/a/Employee.java @@ -11,4 +11,4 @@ import javax.persistence.IdClass; public class Employee { @Id String firstName; @Id String lastName; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/DependentId.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/DependentId.java index e1a5c0105b..a55023c1bf 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/DependentId.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/DependentId.java @@ -9,4 +9,4 @@ import javax.persistence.Embeddable; public class DependentId implements Serializable { String name; EmployeeId empPK; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/Employee.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/Employee.java index 40681b64a7..faab774632 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/Employee.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/Employee.java @@ -13,4 +13,4 @@ public class Employee { String firstName; @Id String lastName; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/EmployeeId.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/EmployeeId.java index 461188837f..898c5187e0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/EmployeeId.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/b/EmployeeId.java @@ -7,4 +7,4 @@ import java.io.Serializable; public class EmployeeId implements Serializable { String firstName; String lastName; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e3/b/Dependent.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e3/b/Dependent.java index e4246677cb..8142866635 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e3/b/Dependent.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e3/b/Dependent.java @@ -27,4 +27,4 @@ public class Dependent { @ManyToOne Employee emp; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/DerivedIdentitySimpleParentSimpleDepTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/DerivedIdentitySimpleParentSimpleDepTest.java index 561c3b0a56..634a6b317a 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/DerivedIdentitySimpleParentSimpleDepTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/DerivedIdentitySimpleParentSimpleDepTest.java @@ -133,4 +133,4 @@ public class DerivedIdentitySimpleParentSimpleDepTest extends BaseCoreFunctional FinancialHistory.class }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/FinancialHistory.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/FinancialHistory.java index 348313b26f..1bf9edfdb9 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/FinancialHistory.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/FinancialHistory.java @@ -27,4 +27,4 @@ public class FinancialHistory implements Serializable { public FinancialHistory(Person patient) { this.patient = patient; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/MedicalHistory.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/MedicalHistory.java index e50fb34b91..a232e3ced7 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/MedicalHistory.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/MedicalHistory.java @@ -28,4 +28,4 @@ public class MedicalHistory implements Serializable { public MedicalHistory(Person patient) { this.patient = patient; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/Person.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/Person.java index 837e723bca..40c870f01a 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/Person.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/a/Person.java @@ -16,4 +16,4 @@ public class Person { public Person(String ssn) { this.ssn = ssn; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/b/DerivedIdentitySimpleParentSimpleDepMapsIdTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/b/DerivedIdentitySimpleParentSimpleDepMapsIdTest.java index 13f6054511..5e877a2185 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/b/DerivedIdentitySimpleParentSimpleDepMapsIdTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/b/DerivedIdentitySimpleParentSimpleDepMapsIdTest.java @@ -140,4 +140,4 @@ public class DerivedIdentitySimpleParentSimpleDepMapsIdTest extends BaseCoreFunc FinancialHistory.class }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/b/Person.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/b/Person.java index af7bf7dab7..5fd0c8b754 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/b/Person.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e4/b/Person.java @@ -16,4 +16,4 @@ public class Person { public Person(String ssn) { this.ssn = ssn; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/b/MedicalHistory.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/b/MedicalHistory.java index df9274b084..940deb0d27 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/b/MedicalHistory.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/b/MedicalHistory.java @@ -22,4 +22,4 @@ public class MedicalHistory { }) @OneToOne Person patient; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/c/MedicalHistory.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/c/MedicalHistory.java index 44d7e6c1ac..e1b14114a6 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/c/MedicalHistory.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/c/MedicalHistory.java @@ -19,4 +19,4 @@ public class MedicalHistory implements Serializable { @JoinColumn(name = "patient_id") @OneToOne Person patient; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/c/Person.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/c/Person.java index 9cb2602230..64386502bc 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/c/Person.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e5/c/Person.java @@ -10,4 +10,4 @@ import javax.persistence.Id; public class Person { @Id @GeneratedValue Integer id; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/a/DerivedIdentityEmbeddedIdParentSameIdTypeIdClassDepTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/a/DerivedIdentityEmbeddedIdParentSameIdTypeIdClassDepTest.java index cfa1b469e4..f848e1b259 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/a/DerivedIdentityEmbeddedIdParentSameIdTypeIdClassDepTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/a/DerivedIdentityEmbeddedIdParentSameIdTypeIdClassDepTest.java @@ -71,4 +71,4 @@ public class DerivedIdentityEmbeddedIdParentSameIdTypeIdClassDepTest extends Bas Person.class }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/DerivedIdentityEmbeddedIdParentSameIdTypeEmbeddedIdDepTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/DerivedIdentityEmbeddedIdParentSameIdTypeEmbeddedIdDepTest.java index cc21d75f27..ff97c4b81a 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/DerivedIdentityEmbeddedIdParentSameIdTypeEmbeddedIdDepTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/DerivedIdentityEmbeddedIdParentSameIdTypeEmbeddedIdDepTest.java @@ -69,4 +69,4 @@ public class DerivedIdentityEmbeddedIdParentSameIdTypeEmbeddedIdDepTest extends Person.class }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/MedicalHistory.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/MedicalHistory.java index b3a4f93138..66ff36f640 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/MedicalHistory.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/MedicalHistory.java @@ -22,4 +22,4 @@ public class MedicalHistory { }) @OneToOne Person patient; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/Person.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/Person.java index b09159664f..c003aa335a 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/Person.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/Person.java @@ -9,4 +9,4 @@ import javax.persistence.Entity; public class Person { @EmbeddedId PersonId id; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/PersonId.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/PersonId.java index ab8b941cb9..f2261159dc 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/PersonId.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e6/b/PersonId.java @@ -9,4 +9,4 @@ import javax.persistence.Embeddable; public class PersonId implements Serializable { String firstName; String lastName; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/EmbeddableB.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/EmbeddableB.java index 85f0e53728..5bb2c356cb 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/EmbeddableB.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/EmbeddableB.java @@ -37,4 +37,4 @@ public class EmbeddableB { public void setEmbedAttrB(String embedAttrB) { this.embedAttrB = embedAttrB; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/many2one/Country.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/many2one/Country.java index 65073a58cd..978c66cf23 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/many2one/Country.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/many2one/Country.java @@ -60,4 +60,4 @@ public class Country implements Serializable { public void setName(String name) { this.name = name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/one2many/EmbeddableWithOne2ManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/one2many/EmbeddableWithOne2ManyTest.java index fff1badbfe..a3ff3cea90 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/one2many/EmbeddableWithOne2ManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/embedded/one2many/EmbeddableWithOne2ManyTest.java @@ -78,4 +78,4 @@ public class EmbeddableWithOne2ManyTest extends BaseCoreFunctionalTestCase { session.getTransaction().commit(); session.close(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/CasterStringType.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/CasterStringType.java index 717dbe68cb..37f32503f3 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/CasterStringType.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/CasterStringType.java @@ -87,4 +87,4 @@ public class CasterStringType implements UserType, ParameterizedType { public void setParameterValues(Properties parameters) { this.parameters = parameters; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/Flight.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/Flight.java index 47be2d8481..2c5d066dd1 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/Flight.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/Flight.java @@ -45,4 +45,4 @@ public class Flight implements Serializable { public void setMaxAltitudeInMilimeter(long maxAltitudeInMilimeter) { this.maxAltitudeInMilimeter = maxAltitudeInMilimeter; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/Player.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/Player.java index 471f8315ee..7c101f39d7 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/Player.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/Player.java @@ -75,4 +75,4 @@ public class Player { public void setOneVoneTeam(SoccerTeam oneVoneTeam) { this.oneVoneTeam = oneVoneTeam; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/SoccerTeam.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/SoccerTeam.java index 9287172267..e21cac9697 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/SoccerTeam.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/entity/SoccerTeam.java @@ -83,4 +83,4 @@ public class SoccerTeam { this.oneVonePlayer = oneVonePlayer; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetch/Stay.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetch/Stay.java index 55adcc687f..acf8f714cb 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetch/Stay.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetch/Stay.java @@ -139,4 +139,4 @@ public class Stay implements Serializable { } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer2.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer2.java index 6e1897ad42..05d55085e5 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer2.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer2.java @@ -84,4 +84,4 @@ public class Customer2 { public void setOrders(Set orders) { this.orders = orders; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer3.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer3.java index 82430e8a95..a9f4e047e6 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer3.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer3.java @@ -84,4 +84,4 @@ public class Customer3 { public void setOrders(Set orders) { this.orders = orders; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer4.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer4.java index 140b1dc3a1..1e046e771f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer4.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer4.java @@ -84,4 +84,4 @@ public class Customer4 { public void setOrders(Set orders) { this.orders = orders; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer5.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer5.java index cff22ab9ed..2a6856f1c1 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer5.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/Customer5.java @@ -84,4 +84,4 @@ public class Customer5 { public void setOrders(Set orders) { this.orders = orders; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/FetchProfileTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/FetchProfileTest.java index e73b40ce03..93b9e3d526 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/FetchProfileTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/fetchprofile/FetchProfileTest.java @@ -190,4 +190,4 @@ public class FetchProfileTest extends BaseUnitTestCase { ); sessionImpl.close(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/fkcircularity/FkCircularityTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/fkcircularity/FkCircularityTest.java index f8829b2f24..adac9331f8 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/fkcircularity/FkCircularityTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/fkcircularity/FkCircularityTest.java @@ -70,4 +70,4 @@ public class FkCircularityTest { Assert.fail(e.getMessage()); } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/generics/Dummy.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/generics/Dummy.java index 5a6948581e..f288627bbc 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/generics/Dummy.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/generics/Dummy.java @@ -32,4 +32,4 @@ public class Dummy { this.dummyField = dummyField; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/generics/WildEntity.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/generics/WildEntity.java index 8200fb6eb5..4579f57889 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/generics/WildEntity.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/generics/WildEntity.java @@ -40,4 +40,4 @@ public class WildEntity implements Serializable { public void setProperty(String property) { this.property = property; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/CompleteSequenceEntity.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/CompleteSequenceEntity.java index cf0882a7fb..1fb4183de4 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/CompleteSequenceEntity.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/CompleteSequenceEntity.java @@ -54,4 +54,4 @@ public class CompleteSequenceEntity { public void setId(Long long1) { id = long1; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/MinimalTableEntity.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/MinimalTableEntity.java index 28e76970b4..b05d7f15b5 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/MinimalTableEntity.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/MinimalTableEntity.java @@ -51,4 +51,4 @@ public class MinimalTableEntity { public void setId(Long long1) { id = long1; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/package-info.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/package-info.java index 6b9e7e5c6f..c03458ec8d 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/package-info.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/id/generationmappings/package-info.java @@ -9,4 +9,4 @@ package org.hibernate.test.annotations.id.generationmappings; import org.hibernate.annotations.GenericGenerator; -import org.hibernate.annotations.Parameter; \ No newline at end of file +import org.hibernate.annotations.Parameter; diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/DomainAdmin.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/DomainAdmin.java index 600a7fda87..2dbfc57d43 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/DomainAdmin.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/DomainAdmin.java @@ -80,4 +80,4 @@ public class DomainAdmin implements Serializable { public void setNickName(String nickName) { this.nickName = nickName; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/DomainAdminId.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/DomainAdminId.java index 4e5b067976..c5796f3efc 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/DomainAdminId.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/DomainAdminId.java @@ -69,4 +69,4 @@ public class DomainAdminId implements Serializable { public int hashCode() { return ( domainName + adminUser ).hashCode(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/xml/HabitatSpeciesLink.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/xml/HabitatSpeciesLink.java index 3553fc04d2..7e8db4dd77 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/xml/HabitatSpeciesLink.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/xml/HabitatSpeciesLink.java @@ -144,4 +144,4 @@ public class HabitatSpeciesLink implements Serializable { return "habitatId[" + habitatId + "],speciesId[" + speciesId + "]"; } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/xml/IdClassXmlTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/xml/IdClassXmlTest.java index 74f016baff..fe61caa847 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/xml/IdClassXmlTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/idclass/xml/IdClassXmlTest.java @@ -64,4 +64,4 @@ public class IdClassXmlTest extends BaseCoreFunctionalTestCase { "org/hibernate/test/annotations/idclass/xml/HabitatSpeciesLink.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/idclassgeneratedvalue/Simple2.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/idclassgeneratedvalue/Simple2.java index 260009451f..9ea4ea3fb3 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/idclassgeneratedvalue/Simple2.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/idclassgeneratedvalue/Simple2.java @@ -73,4 +73,4 @@ public class Simple2 implements Serializable { public void setQuantity(int quantity) { this.quantity = quantity; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/idmanytoone/alphabetical/Acces.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/idmanytoone/alphabetical/Acces.java index 8716d1f0ee..94a2dcc5fb 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/idmanytoone/alphabetical/Acces.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/idmanytoone/alphabetical/Acces.java @@ -13,4 +13,4 @@ public class Acces implements Serializable { @ManyToOne private Droitacces idpkdracc; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/indexcoll/GenerationGroup.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/indexcoll/GenerationGroup.java index dabe3e6bb9..0b76874e18 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/indexcoll/GenerationGroup.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/indexcoll/GenerationGroup.java @@ -33,4 +33,4 @@ public class GenerationGroup { } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/inheritance/joined/Customer.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/inheritance/joined/Customer.java index 646f28914f..81ddb81d4d 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/inheritance/joined/Customer.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/inheritance/joined/Customer.java @@ -63,4 +63,4 @@ public class Customer extends LegalEntity { public void setCustomerCode(String val) { this.customerCode = val; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/inheritance/joined/SwimmingPool.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/inheritance/joined/SwimmingPool.java index a4d93447e3..6e2a578ef3 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/inheritance/joined/SwimmingPool.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/inheritance/joined/SwimmingPool.java @@ -7,4 +7,4 @@ import javax.persistence.Entity; */ @Entity public class SwimmingPool extends Pool { -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/join/Cat.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/join/Cat.java index d9222787b0..d187e5ab4a 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/join/Cat.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/join/Cat.java @@ -97,4 +97,4 @@ public class Cat implements Serializable { storyPart2 = string; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/join/SysGroupsOrm.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/join/SysGroupsOrm.java index d2ca917768..5d182b4a11 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/join/SysGroupsOrm.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/join/SysGroupsOrm.java @@ -22,4 +22,4 @@ public class SysGroupsOrm { this.groupId = groupId; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/lob/ImageHolder.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/lob/ImageHolder.java index 029ae45d07..ad2600585b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/lob/ImageHolder.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/lob/ImageHolder.java @@ -77,4 +77,4 @@ public class ImageHolder { this.picByteArray = picByteArray; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/lob/ImageTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/lob/ImageTest.java index 2f1308f643..7a0a8e1d16 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/lob/ImageTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/lob/ImageTest.java @@ -162,4 +162,4 @@ public class ImageTest extends BaseCoreFunctionalTestCase { return new Class[] { ImageHolder.class }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/manytomany/ManyToManyMaxFetchDepth0Test.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/manytomany/ManyToManyMaxFetchDepth0Test.java index 7d00524db6..d36bf821c6 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/manytomany/ManyToManyMaxFetchDepth0Test.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/manytomany/ManyToManyMaxFetchDepth0Test.java @@ -39,4 +39,4 @@ public class ManyToManyMaxFetchDepth0Test extends ManyToManyTest { cfg.setProperty( Environment.MAX_FETCH_DEPTH, "0" ); super.configure( cfg ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/manytomany/ManyToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/manytomany/ManyToManyTest.java index 2f75dce8f9..f2d27e1633 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/manytomany/ManyToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/manytomany/ManyToManyTest.java @@ -784,4 +784,4 @@ public class ManyToManyTest extends BaseCoreFunctionalTestCase { }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/Carz.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/Carz.java index e3ce9e16be..69e60c3290 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/Carz.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/Carz.java @@ -119,4 +119,4 @@ public class Carz implements Serializable { else if ( !this.model.equals( other.model ) ) return false; return true; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/ManyToOneTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/ManyToOneTest.java index 74737da101..ec61f61b2b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/ManyToOneTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/ManyToOneTest.java @@ -396,4 +396,4 @@ public class ManyToOneTest extends BaseCoreFunctionalTestCase { }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/referencedcolumnname/Vendor.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/referencedcolumnname/Vendor.java index 965f87ac4b..5d7900222c 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/referencedcolumnname/Vendor.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/manytoone/referencedcolumnname/Vendor.java @@ -4,4 +4,4 @@ import javax.persistence.Entity; @Entity public class Vendor extends GenericObject { -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/Account.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/Account.java index 26031ca3e5..821ed37e2c 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/Account.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/Account.java @@ -42,4 +42,4 @@ public class Account extends AccountBase { public Account(String accountNumber) { super( accountNumber ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/AccountBase.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/AccountBase.java index a16e05b9cb..0cc9f1e1df 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/AccountBase.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/AccountBase.java @@ -62,4 +62,4 @@ public abstract class AccountBase { public void setAccountNumber(String accountNumber) { this.accountNumber = accountNumber; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/SavingsAccount.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/SavingsAccount.java index 56812e11de..44a9fd572d 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/SavingsAccount.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/SavingsAccount.java @@ -42,4 +42,4 @@ public class SavingsAccount extends SavingsAccountBase { public SavingsAccount(String accountNumber, BigDecimal withdrawalLimit) { super( accountNumber, withdrawalLimit ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/SavingsAccountBase.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/SavingsAccountBase.java index 6399262fb0..0a11005753 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/SavingsAccountBase.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/mappedsuperclass/intermediate/SavingsAccountBase.java @@ -52,4 +52,4 @@ public abstract class SavingsAccountBase extends Account { public void setWithdrawalLimit(BigDecimal withdrawalLimit) { this.withdrawalLimit = withdrawalLimit; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/namingstrategy/AddressEntry.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/namingstrategy/AddressEntry.java index 6b6a7d96a4..4c87d527c0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/namingstrategy/AddressEntry.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/namingstrategy/AddressEntry.java @@ -41,4 +41,4 @@ public class AddressEntry implements java.io.Serializable { public void setZip(String zip) { this.zip = zip; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Manufacturer.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Manufacturer.java index d64a4e0f2f..0eda7163ce 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Manufacturer.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Manufacturer.java @@ -25,4 +25,4 @@ public class Manufacturer { public void setModels(Set models) { this.models = models; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Model.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Model.java index 0f3896237e..70f2400bcb 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Model.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Model.java @@ -32,4 +32,4 @@ public class Model { public void setManufacturer(Manufacturer manufacturer) { this.manufacturer = manufacturer; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Order.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Order.java index fcfa0aa2af..40754b863c 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Order.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Order.java @@ -64,4 +64,4 @@ public class Order { } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/OrderID.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/OrderID.java index a68b40498f..c4701680fb 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/OrderID.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/OrderID.java @@ -27,4 +27,4 @@ public class OrderID implements Serializable { public void setSchoolId(String schoolId) { this.schoolId = schoolId; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Post.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Post.java index 1a22d8ae4c..c61e36ba47 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Post.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetomany/Post.java @@ -29,4 +29,4 @@ public class Post extends Comment{ public void setComments(List comments) { this.comments = comments; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/OneToOneErrorTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/OneToOneErrorTest.java index 0ef63b9fca..0da443dc7a 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/OneToOneErrorTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/OneToOneErrorTest.java @@ -41,4 +41,4 @@ public class OneToOneErrorTest { } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/hhh4851/DeviceGroupConfig.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/hhh4851/DeviceGroupConfig.java index 377ece0479..9796939056 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/hhh4851/DeviceGroupConfig.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/hhh4851/DeviceGroupConfig.java @@ -31,4 +31,4 @@ public class DeviceGroupConfig extends BaseEntity { this.name = name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/hhh4851/Owner.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/hhh4851/Owner.java index f55e6b0ec3..362c0bd002 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/hhh4851/Owner.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/onetoone/hhh4851/Owner.java @@ -62,4 +62,4 @@ public class Owner { this.version = version; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/override/Addr.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/override/Addr.java index 9aa205e744..f8535c313b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/override/Addr.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/override/Addr.java @@ -62,4 +62,4 @@ public class Addr { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/override/PropertyRecord.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/override/PropertyRecord.java index a0675e227b..88aabe4939 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/override/PropertyRecord.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/override/PropertyRecord.java @@ -49,4 +49,4 @@ public class PropertyRecord { }) @ElementCollection public Set legacyUnsortedParcels; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/Card.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/Card.java index e2b16e6d9e..5d832a7e95 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/Card.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/Card.java @@ -17,4 +17,4 @@ public class Card implements Serializable { @ManyToOne() @JoinColumn() public Deck deck; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/CollectionPersister.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/CollectionPersister.java index 60ed39f1ac..ac7148edda 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/CollectionPersister.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/CollectionPersister.java @@ -15,4 +15,4 @@ public class CollectionPersister extends OneToManyPersister { SessionFactoryImplementor factory) throws MappingException, CacheException { super( collection, cache, cfg, factory ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/Deck.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/Deck.java index 33559b5fed..8d5a29382b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/Deck.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/Deck.java @@ -21,4 +21,4 @@ public class Deck implements Serializable { @OneToMany( mappedBy = "deck" ) @Persister( impl = org.hibernate.test.annotations.persister.CollectionPersister.class ) public Set cards; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/EntityPersister.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/EntityPersister.java index b8c0a3e7fa..0008378144 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/EntityPersister.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/EntityPersister.java @@ -16,4 +16,4 @@ public class EntityPersister extends SingleTableEntityPersister { SessionFactoryImplementor factory, Mapping cfg) throws HibernateException { super( persistentClass, cache, naturalIdRegionAccessStrategy, factory, cfg ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/PersisterTest.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/PersisterTest.java index 7dea55638c..5d357925ce 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/PersisterTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/persister/PersisterTest.java @@ -67,4 +67,4 @@ public class PersisterTest extends BaseCoreFunctionalTestCase { Deck.class }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/query/AllTables.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/query/AllTables.java index 1f6240379d..1ab91d18e5 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/query/AllTables.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/query/AllTables.java @@ -41,4 +41,4 @@ import org.hibernate.annotations.Formula; public void setDaysOld(String daysOld) { this.daysOld = daysOld; } - } \ No newline at end of file + } diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/quote/Person.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/quote/Person.java index 0705a3117b..b99e250d21 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/quote/Person.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/quote/Person.java @@ -53,4 +53,4 @@ public class Person { public void setName(String name) { this.name = name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/quote/Role.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/quote/Role.java index 3f25f20056..2123acc425 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/quote/Role.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/quote/Role.java @@ -18,4 +18,4 @@ public class Role implements Serializable { @GeneratedValue(strategy = GenerationType.AUTO) private long id; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/referencedcolumnname/Item.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/referencedcolumnname/Item.java index 1d826df66a..894d8c2496 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/referencedcolumnname/Item.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/referencedcolumnname/Item.java @@ -19,4 +19,4 @@ public class Item { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/tableperclass/Component.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/tableperclass/Component.java index 151a03797e..776647757f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/tableperclass/Component.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/tableperclass/Component.java @@ -49,4 +49,4 @@ public abstract class Component { public void setManufacturerPartNumber(String manufacturerPartNumber) { this.manufacturerPartNumber = manufacturerPartNumber; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/annotations/xml/hbm/BImpl.java b/hibernate-core/src/test/java/org/hibernate/test/annotations/xml/hbm/BImpl.java index 8e770906e4..cd909e3038 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/annotations/xml/hbm/BImpl.java +++ b/hibernate-core/src/test/java/org/hibernate/test/annotations/xml/hbm/BImpl.java @@ -22,4 +22,4 @@ public class BImpl extends AImpl implements B { public void setBId(Integer bId) { this.bId = bId; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/cascade/CascadeTestWithAssignedParentIdTest.java b/hibernate-core/src/test/java/org/hibernate/test/cascade/CascadeTestWithAssignedParentIdTest.java index 597b5b0ec1..00a0222c1f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/cascade/CascadeTestWithAssignedParentIdTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/cascade/CascadeTestWithAssignedParentIdTest.java @@ -48,7 +48,6 @@ public class CascadeTestWithAssignedParentIdTest extends BaseCoreFunctionalTestC } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testSaveChildWithParent() { Session session = openSession(); Transaction txn = session.beginTransaction(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullFalseDelayedInsertTest.java b/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullFalseDelayedInsertTest.java index acd562fa14..5f6acee73e 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullFalseDelayedInsertTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullFalseDelayedInsertTest.java @@ -35,4 +35,4 @@ public class MultiPathCircleCascadeCheckNullFalseDelayedInsertTest extends Multi super.configure( cfg ); cfg.setProperty( Environment.CHECK_NULLABILITY, "false" ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullTrueDelayedInsertTest.java b/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullTrueDelayedInsertTest.java index c47c964eb7..655b668aed 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullTrueDelayedInsertTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullTrueDelayedInsertTest.java @@ -35,4 +35,4 @@ public class MultiPathCircleCascadeCheckNullTrueDelayedInsertTest extends MultiP super.configure( cfg ); cfg.setProperty( Environment.CHECK_NULLABILITY, "true" ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullibilityFalseTest.java b/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullibilityFalseTest.java index de48c60850..4a822b2236 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullibilityFalseTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullibilityFalseTest.java @@ -35,4 +35,4 @@ public class MultiPathCircleCascadeCheckNullibilityFalseTest extends MultiPathCi super.configure( cfg ); cfg.setProperty( Environment.CHECK_NULLABILITY, "false" ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullibilityTrueTest.java b/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullibilityTrueTest.java index c440049c0b..407418209d 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullibilityTrueTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/MultiPathCircleCascadeCheckNullibilityTrueTest.java @@ -35,4 +35,4 @@ public class MultiPathCircleCascadeCheckNullibilityTrueTest extends MultiPathCir super.configure( cfg ); cfg.setProperty( Environment.CHECK_NULLABILITY, "true" ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/Vehicle.java b/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/Vehicle.java index e6c9b83e84..5ae90e2177 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/Vehicle.java +++ b/hibernate-core/src/test/java/org/hibernate/test/cascade/circle/Vehicle.java @@ -102,4 +102,4 @@ public class Vehicle { public void setTransientField(String transientField) { this.transientField = transientField; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/collection/map/hhh7557/MapKey.java b/hibernate-core/src/test/java/org/hibernate/test/collection/map/hhh7557/MapKey.java index 3bba1a0ae1..afc5913f5c 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/collection/map/hhh7557/MapKey.java +++ b/hibernate-core/src/test/java/org/hibernate/test/collection/map/hhh7557/MapKey.java @@ -151,4 +151,4 @@ public class MapKey { return builder.toString(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/collection/original/CollectionTest.java b/hibernate-core/src/test/java/org/hibernate/test/collection/original/CollectionTest.java index dbd503b391..8a754e5f99 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/collection/original/CollectionTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/collection/original/CollectionTest.java @@ -271,4 +271,4 @@ public class CollectionTest extends BaseCoreFunctionalTestCase { t.commit(); s.close(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/collection/original/Mammal.java b/hibernate-core/src/test/java/org/hibernate/test/collection/original/Mammal.java index cb32431bab..c71a0ae175 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/collection/original/Mammal.java +++ b/hibernate-core/src/test/java/org/hibernate/test/collection/original/Mammal.java @@ -32,4 +32,4 @@ public class Mammal extends Animal { -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/collection/set/PersistentSetNonLazyTest.java b/hibernate-core/src/test/java/org/hibernate/test/collection/set/PersistentSetNonLazyTest.java index cfa42457aa..4d49b0be70 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/collection/set/PersistentSetNonLazyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/collection/set/PersistentSetNonLazyTest.java @@ -49,4 +49,4 @@ public class PersistentSetNonLazyTest extends PersistentSetTest { public void testLoadChildCheckParentContainsChildCache() { super.testLoadChildCheckParentContainsChildCache(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/component/basic2/Name.java b/hibernate-core/src/test/java/org/hibernate/test/component/basic2/Name.java index efaa422c37..a978625783 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/component/basic2/Name.java +++ b/hibernate-core/src/test/java/org/hibernate/test/component/basic2/Name.java @@ -60,4 +60,4 @@ public class Name implements Serializable { public void setLastName(String lastName) { this.lastName = lastName; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/constraint/ConstraintTest.java b/hibernate-core/src/test/java/org/hibernate/test/constraint/ConstraintTest.java index 0e33a4ff83..1f6d093c43 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/constraint/ConstraintTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/constraint/ConstraintTest.java @@ -142,4 +142,4 @@ public class ConstraintTest extends BaseCoreFunctionalTestCase { @org.hibernate.annotations.ForeignKey(name = EXPLICIT_FK_NAME) public DataPoint explicit; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/criteria/CourseMeeting.java b/hibernate-core/src/test/java/org/hibernate/test/criteria/CourseMeeting.java index f544bce3a9..6b75bd9297 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/criteria/CourseMeeting.java +++ b/hibernate-core/src/test/java/org/hibernate/test/criteria/CourseMeeting.java @@ -27,4 +27,4 @@ public class CourseMeeting { public void setCourse(Course course) { this.course = course; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/criteria/CourseMeetingId.java b/hibernate-core/src/test/java/org/hibernate/test/criteria/CourseMeetingId.java index 595e11b541..1e97a8ad26 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/criteria/CourseMeetingId.java +++ b/hibernate-core/src/test/java/org/hibernate/test/criteria/CourseMeetingId.java @@ -43,4 +43,4 @@ public class CourseMeetingId implements Serializable { public void setLocation(String location) { this.location = location; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/criteria/Order.java b/hibernate-core/src/test/java/org/hibernate/test/criteria/Order.java index 36be1dec3c..e6998e35de 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/criteria/Order.java +++ b/hibernate-core/src/test/java/org/hibernate/test/criteria/Order.java @@ -49,4 +49,4 @@ public class Order { public String toString() { return "" + getOrderId() + " - " + getLines(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/criteria/OrderLine.java b/hibernate-core/src/test/java/org/hibernate/test/criteria/OrderLine.java index 77f35a7544..8af0d4a1b9 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/criteria/OrderLine.java +++ b/hibernate-core/src/test/java/org/hibernate/test/criteria/OrderLine.java @@ -55,4 +55,4 @@ public class OrderLine { public String toString() { return "[" + getLineId() + ":" + getArticleId() + "]"; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/criteria/OuterJoinCriteriaTest.java b/hibernate-core/src/test/java/org/hibernate/test/criteria/OuterJoinCriteriaTest.java index de0e913dc8..e17e6a150a 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/criteria/OuterJoinCriteriaTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/criteria/OuterJoinCriteriaTest.java @@ -425,4 +425,4 @@ public class OuterJoinCriteriaTest extends BaseCoreFunctionalTestCase { private static boolean isBlank(String s) { return s == null || s.trim().length() == 0; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/deletetransient/Note.java b/hibernate-core/src/test/java/org/hibernate/test/deletetransient/Note.java index 62020f8472..31358e3ffc 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/deletetransient/Note.java +++ b/hibernate-core/src/test/java/org/hibernate/test/deletetransient/Note.java @@ -31,4 +31,4 @@ public class Note { public void setDescription(String description) { this.description = description; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/deletetransient/Suite.java b/hibernate-core/src/test/java/org/hibernate/test/deletetransient/Suite.java index 8b80787475..9adc391a9f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/deletetransient/Suite.java +++ b/hibernate-core/src/test/java/org/hibernate/test/deletetransient/Suite.java @@ -41,4 +41,4 @@ public class Suite { public void setNotes(Set notes) { this.notes = notes; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/dialect/functional/cache/SQLFunctionsInterSystemsTest.java b/hibernate-core/src/test/java/org/hibernate/test/dialect/functional/cache/SQLFunctionsInterSystemsTest.java index 7ca70682c9..4e54f28b6f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/dialect/functional/cache/SQLFunctionsInterSystemsTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/dialect/functional/cache/SQLFunctionsInterSystemsTest.java @@ -78,7 +78,6 @@ public class SQLFunctionsInterSystemsTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testDialectSQLFunctions() throws Exception { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -138,7 +137,6 @@ public class SQLFunctionsInterSystemsTest extends BaseCoreFunctionalTestCase { s.close(); } - @SuppressWarnings( {"UnnecessaryBoxing", "unchecked"}) public void testSetProperties() throws Exception { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -173,7 +171,6 @@ public class SQLFunctionsInterSystemsTest extends BaseCoreFunctionalTestCase { s.close(); } - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testBroken() throws Exception { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -205,7 +202,6 @@ public class SQLFunctionsInterSystemsTest extends BaseCoreFunctionalTestCase { s.close(); } - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testNothinToUpdate() throws Exception { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -229,7 +225,6 @@ public class SQLFunctionsInterSystemsTest extends BaseCoreFunctionalTestCase { s.close(); } - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testCachedQuery() throws Exception { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -290,7 +285,6 @@ public class SQLFunctionsInterSystemsTest extends BaseCoreFunctionalTestCase { s.close(); } - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testCachedQueryRegion() throws Exception { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -344,7 +338,6 @@ public class SQLFunctionsInterSystemsTest extends BaseCoreFunctionalTestCase { s.close(); } - @SuppressWarnings( {"UnnecessaryBoxing", "unchecked"}) public void testSQLFunctions() throws Exception { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -542,7 +535,6 @@ public class SQLFunctionsInterSystemsTest extends BaseCoreFunctionalTestCase { s.close(); } - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testSqlFunctionAsAlias() throws Exception { String functionName = locateAppropriateDialectFunctionNameForAliasTest(); if (functionName == null) { @@ -583,7 +575,6 @@ public class SQLFunctionsInterSystemsTest extends BaseCoreFunctionalTestCase { return null; } - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testCachedQueryOnInsert() throws Exception { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -638,7 +629,6 @@ public class SQLFunctionsInterSystemsTest extends BaseCoreFunctionalTestCase { } - @SuppressWarnings( {"UnnecessaryBoxing", "UnnecessaryUnboxing"}) public void testInterSystemsFunctions() throws Exception { Calendar cal = new GregorianCalendar(); cal.set(1977,6,3,0,0,0); diff --git a/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/ImprovedTuplizerDynamicEntityTest.java b/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/ImprovedTuplizerDynamicEntityTest.java index 362e7d6006..cb993c2e37 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/ImprovedTuplizerDynamicEntityTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/ImprovedTuplizerDynamicEntityTest.java @@ -144,4 +144,4 @@ public class ImprovedTuplizerDynamicEntityTest extends BaseCoreFunctionalTestCas session.getTransaction().commit(); session.close(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/MyEntityInstantiator.java b/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/MyEntityInstantiator.java index 819745ad0e..ee0e80e64f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/MyEntityInstantiator.java +++ b/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/MyEntityInstantiator.java @@ -75,4 +75,4 @@ public class MyEntityInstantiator implements Instantiator { throw new HibernateException( "could not get handle to entity-name as interface : " + t ); } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/MyEntityTuplizer.java b/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/MyEntityTuplizer.java index 433919cfdd..80b971ab19 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/MyEntityTuplizer.java +++ b/hibernate-core/src/test/java/org/hibernate/test/dynamicentity/tuplizer2/MyEntityTuplizer.java @@ -88,4 +88,4 @@ public class MyEntityTuplizer extends PojoEntityTuplizer { return getClass().hashCode(); } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/event/collection/BrokenCollectionEventTest.java b/hibernate-core/src/test/java/org/hibernate/test/event/collection/BrokenCollectionEventTest.java index 6354edf4b0..5d659bf1df 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/event/collection/BrokenCollectionEventTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/event/collection/BrokenCollectionEventTest.java @@ -334,4 +334,4 @@ public class BrokenCollectionEventTest extends BaseCoreFunctionalTestCase { assertEquals( nEventsExpected, listeners.getListenersCalled().size() ); assertEquals( nEventsExpected, listeners.getEvents().size() ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/BidirectionalOneToManyBagCollectionEventTest.java b/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/BidirectionalOneToManyBagCollectionEventTest.java index f3f82918b2..b9b4959952 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/BidirectionalOneToManyBagCollectionEventTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/BidirectionalOneToManyBagCollectionEventTest.java @@ -52,4 +52,4 @@ public class BidirectionalOneToManyBagCollectionEventTest extends AbstractAssoci public Child createChild(String name) { return new ChildWithManyToOne( name ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/BidirectionalOneToManyBagSubclassCollectionEventTest.java b/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/BidirectionalOneToManyBagSubclassCollectionEventTest.java index 463f7cdb80..abfaccf928 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/BidirectionalOneToManyBagSubclassCollectionEventTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/BidirectionalOneToManyBagSubclassCollectionEventTest.java @@ -38,4 +38,4 @@ public class BidirectionalOneToManyBagSubclassCollectionEventTest extends Bidire public ParentWithCollection createParent(String name) { return new ParentWithBidirectionalOneToManySubclass( name ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/ParentWithBidirectionalOneToManySubclass.java b/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/ParentWithBidirectionalOneToManySubclass.java index 7f0be1b4c6..d819917544 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/ParentWithBidirectionalOneToManySubclass.java +++ b/hibernate-core/src/test/java/org/hibernate/test/event/collection/association/bidirectional/onetomany/ParentWithBidirectionalOneToManySubclass.java @@ -35,4 +35,4 @@ public class ParentWithBidirectionalOneToManySubclass extends ParentWithBidirect super( name ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/event/collection/values/ParentWithCollectionOfValues.java b/hibernate-core/src/test/java/org/hibernate/test/event/collection/values/ParentWithCollectionOfValues.java index 5532b3bc4f..903bf275cd 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/event/collection/values/ParentWithCollectionOfValues.java +++ b/hibernate-core/src/test/java/org/hibernate/test/event/collection/values/ParentWithCollectionOfValues.java @@ -39,4 +39,4 @@ public class ParentWithCollectionOfValues extends AbstractParentWithCollection { public Child createChild(String name) { return new ChildValue( name ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/filter/hql/JoinedFilteredBulkManipulationTest.java b/hibernate-core/src/test/java/org/hibernate/test/filter/hql/JoinedFilteredBulkManipulationTest.java index c36ddcab0f..7494fa5e64 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/filter/hql/JoinedFilteredBulkManipulationTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/filter/hql/JoinedFilteredBulkManipulationTest.java @@ -50,7 +50,6 @@ public class JoinedFilteredBulkManipulationTest extends BaseCoreFunctionalTestCa } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testFilteredJoinedSubclassHqlDeleteRoot() { Session s = openSession(); s.beginTransaction(); @@ -77,7 +76,6 @@ public class JoinedFilteredBulkManipulationTest extends BaseCoreFunctionalTestCa } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testFilteredJoinedSubclassHqlDeleteNonLeaf() { Session s = openSession(); s.beginTransaction(); @@ -104,7 +102,6 @@ public class JoinedFilteredBulkManipulationTest extends BaseCoreFunctionalTestCa } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testFilteredJoinedSubclassHqlDeleteLeaf() { Session s = openSession(); s.beginTransaction(); @@ -131,7 +128,6 @@ public class JoinedFilteredBulkManipulationTest extends BaseCoreFunctionalTestCa } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testFilteredJoinedSubclassHqlUpdateRoot() { Session s = openSession(); s.beginTransaction(); @@ -158,7 +154,6 @@ public class JoinedFilteredBulkManipulationTest extends BaseCoreFunctionalTestCa } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testFilteredJoinedSubclassHqlUpdateNonLeaf() { Session s = openSession(); s.beginTransaction(); @@ -188,7 +183,6 @@ public class JoinedFilteredBulkManipulationTest extends BaseCoreFunctionalTestCa } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testFilteredJoinedSubclassHqlUpdateLeaf() { Session s = openSession(); s.beginTransaction(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/generated/PartiallyGeneratedComponentTest.java b/hibernate-core/src/test/java/org/hibernate/test/generated/PartiallyGeneratedComponentTest.java index dd481f692d..838e26d5a1 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/generated/PartiallyGeneratedComponentTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/generated/PartiallyGeneratedComponentTest.java @@ -77,4 +77,4 @@ public class PartiallyGeneratedComponentTest extends BaseCoreFunctionalTestCase s.getTransaction().commit(); s.close(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/hql/ASTParserLoadingOrderByTest.java b/hibernate-core/src/test/java/org/hibernate/test/hql/ASTParserLoadingOrderByTest.java index da291a03d4..83ab99f135 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/hql/ASTParserLoadingOrderByTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/hql/ASTParserLoadingOrderByTest.java @@ -699,4 +699,4 @@ public class ASTParserLoadingOrderByTest extends BaseCoreFunctionalTestCase { assertEquals( zooExpected.getAddress(), ( ( Object[] ) result )[ 1 ] ); } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/hql/ASTParserLoadingTest.java b/hibernate-core/src/test/java/org/hibernate/test/hql/ASTParserLoadingTest.java index 2de5d359a3..cd44e6b24c 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/hql/ASTParserLoadingTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/hql/ASTParserLoadingTest.java @@ -1161,7 +1161,6 @@ public class ASTParserLoadingTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) @FailureExpected( jiraKey = "unknown" ) public void testParameterTypeMismatch() { Session s = openSession(); @@ -1478,7 +1477,6 @@ public class ASTParserLoadingTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryUnboxing"}) public void testArithmetic() { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -1796,7 +1794,6 @@ public class ASTParserLoadingTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testNumericExpressionReturnTypes() { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -1959,7 +1956,6 @@ public class ASTParserLoadingTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testIndexParams() { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -1992,7 +1988,6 @@ public class ASTParserLoadingTest extends BaseCoreFunctionalTestCase { @Test @SkipForDialect( value = SybaseASE15Dialect.class, jiraKey = "HHH-6424") - @SuppressWarnings( {"UnnecessaryUnboxing"}) public void testAggregation() { Session s = openSession(); s.beginTransaction(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/hql/BulkManipulationTest.java b/hibernate-core/src/test/java/org/hibernate/test/hql/BulkManipulationTest.java index fedb1cf891..a9ed92449e 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/hql/BulkManipulationTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/hql/BulkManipulationTest.java @@ -416,7 +416,6 @@ public class BulkManipulationTest extends BaseCoreFunctionalTestCase { s.close(); } - @SuppressWarnings( {"UnnecessaryUnboxing"}) @Test public void testInsertWithGeneratedVersionAndId() { // Make sure the env supports bulk inserts with generated ids... @@ -466,7 +465,6 @@ public class BulkManipulationTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryUnboxing"}) @RequiresDialectFeature( value = DialectChecks.SupportsParametersInInsertSelectCheck.class, comment = "dialect does not support parameter in INSERT ... SELECT" @@ -701,7 +699,6 @@ public class BulkManipulationTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryUnboxing"}) public void testUpdateOnComponent() { Session s = openSession(); Transaction t = s.beginTransaction(); @@ -792,7 +789,6 @@ public class BulkManipulationTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryUnboxing"}) public void testUpdateOnDiscriminatorSubclass() { TestData data = new TestData(); data.prepare(); @@ -1017,7 +1013,6 @@ public class BulkManipulationTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryUnboxing"}) @RequiresDialectFeature( value = DialectChecks.HasSelfReferentialForeignKeyBugCheck.class, comment = "self referential FK bug" diff --git a/hibernate-core/src/test/java/org/hibernate/test/hql/EntityWithFunctionAsColumnHolder.java b/hibernate-core/src/test/java/org/hibernate/test/hql/EntityWithFunctionAsColumnHolder.java index 5f48bf3be4..ffa008687e 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/hql/EntityWithFunctionAsColumnHolder.java +++ b/hibernate-core/src/test/java/org/hibernate/test/hql/EntityWithFunctionAsColumnHolder.java @@ -63,4 +63,4 @@ public class EntityWithFunctionAsColumnHolder { public void setEntityWithNoArgFunctionAsColumns(Set entityWithNoArgFunctionAsColumns) { this.entityWithNoArgFunctionAsColumns = entityWithNoArgFunctionAsColumns; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/hql/QueryTranslatorTestCase.java b/hibernate-core/src/test/java/org/hibernate/test/hql/QueryTranslatorTestCase.java index bfb03cfe3f..ab0cf0d992 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/hql/QueryTranslatorTestCase.java +++ b/hibernate-core/src/test/java/org/hibernate/test/hql/QueryTranslatorTestCase.java @@ -23,6 +23,7 @@ */ package org.hibernate.test.hql; +import java.io.Serializable; import java.util.Collections; import java.util.HashMap; import java.util.Map; @@ -227,8 +228,8 @@ public abstract class QueryTranslatorTestCase extends BaseCoreFunctionalTestCase private void checkQuerySpaces(QueryTranslator oldQueryTranslator, QueryTranslator newQueryTranslator) { // Check the query spaces for a regression. - Set oldQuerySpaces = oldQueryTranslator.getQuerySpaces(); - Set querySpaces = newQueryTranslator.getQuerySpaces(); + Set oldQuerySpaces = oldQueryTranslator.getQuerySpaces(); + Set querySpaces = newQueryTranslator.getQuerySpaces(); assertEquals( "Query spaces is not the right size!", oldQuerySpaces.size(), querySpaces.size() ); for ( Object o : oldQuerySpaces ) { assertTrue( "New query space does not contain " + o + "!", querySpaces.contains( o ) ); @@ -280,7 +281,6 @@ public abstract class QueryTranslatorTestCase extends BaseCoreFunctionalTestCase } - @SuppressWarnings( {"UnnecessaryBoxing", "UnnecessaryUnboxing"}) private Map getTokens(String sql) { Map result = new TreeMap(); if ( sql == null ) { diff --git a/hibernate-core/src/test/java/org/hibernate/test/hqlfetchscroll/Child.java b/hibernate-core/src/test/java/org/hibernate/test/hqlfetchscroll/Child.java index 54f6a9791d..7180428403 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/hqlfetchscroll/Child.java +++ b/hibernate-core/src/test/java/org/hibernate/test/hqlfetchscroll/Child.java @@ -33,4 +33,4 @@ public class Child { public String toString() { return name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/hqlfetchscroll/Parent.java b/hibernate-core/src/test/java/org/hibernate/test/hqlfetchscroll/Parent.java index 1ce74e3c5d..2d41eb5c6a 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/hqlfetchscroll/Parent.java +++ b/hibernate-core/src/test/java/org/hibernate/test/hqlfetchscroll/Parent.java @@ -49,4 +49,4 @@ public class Parent { public String toString() { return name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/increment/BigIntegerIncrementGeneratorTest.java b/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/increment/BigIntegerIncrementGeneratorTest.java index f4d5565ff8..a06a14861b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/increment/BigIntegerIncrementGeneratorTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/increment/BigIntegerIncrementGeneratorTest.java @@ -61,4 +61,4 @@ public class BigIntegerIncrementGeneratorTest extends BaseCoreFunctionalTestCase s.close(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/sequence/BigIntegerSequenceGeneratorTest.java b/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/sequence/BigIntegerSequenceGeneratorTest.java index 7d2d99342e..c6759a94c0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/sequence/BigIntegerSequenceGeneratorTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/sequence/BigIntegerSequenceGeneratorTest.java @@ -63,4 +63,4 @@ public class BigIntegerSequenceGeneratorTest extends BaseCoreFunctionalTestCase s.close(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/sequence/Entity.java b/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/sequence/Entity.java index 98df1b1a6c..0949fb6938 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/sequence/Entity.java +++ b/hibernate-core/src/test/java/org/hibernate/test/idgen/biginteger/sequence/Entity.java @@ -55,4 +55,4 @@ public class Entity { public void setName(String name) { this.name = name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/Info.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/Info.java index 9974797cf4..3a7aee5bf5 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/Info.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/Info.java @@ -39,4 +39,4 @@ public class Info implements Serializable { public void setId(long id) { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/Party.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/Party.java index 66c48cd72e..86f2d4250a 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/Party.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/Party.java @@ -59,4 +59,4 @@ public class Party implements Serializable { public void setInfos(Set infos) { this.infos = infos; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/Plan.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/Plan.java index 82813b71c4..b8ce10e296 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/Plan.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/Plan.java @@ -95,4 +95,4 @@ public class Plan implements Serializable { public void setInfos(Set infos) { this.infos = infos; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/AbstractEntityWithManyToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/AbstractEntityWithManyToManyTest.java index fd9e09215f..3f79b0b476 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/AbstractEntityWithManyToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/AbstractEntityWithManyToManyTest.java @@ -1125,4 +1125,4 @@ public abstract class AbstractEntityWithManyToManyTest extends BaseCoreFunctiona int deletes = ( int ) sessionFactory().getStatistics().getEntityDeleteCount(); assertEquals( "unexpected delete counts", expected, deletes ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/AbstractEntityWithOneToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/AbstractEntityWithOneToManyTest.java index 476924e558..e5133e65e9 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/AbstractEntityWithOneToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/AbstractEntityWithOneToManyTest.java @@ -86,7 +86,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testUpdateProperty() { clearCounts(); @@ -135,7 +134,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testCreateWithNonEmptyOneToManyCollectionOfNew() { clearCounts(); @@ -171,7 +169,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testCreateWithNonEmptyOneToManyCollectionOfExisting() { clearCounts(); @@ -227,7 +224,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testAddNewOneToManyElementToPersistentEntity() { clearCounts(); @@ -274,7 +270,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testAddExistingOneToManyElementToPersistentEntity() { clearCounts(); @@ -335,7 +330,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testCreateWithEmptyOneToManyCollectionUpdateWithExistingElement() { clearCounts(); @@ -393,7 +387,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testCreateWithNonEmptyOneToManyCollectionUpdateWithNewElement() { clearCounts(); @@ -453,7 +446,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnusedAssignment", "UnnecessaryBoxing"}) public void testCreateWithEmptyOneToManyCollectionMergeWithExistingElement() { clearCounts(); @@ -511,7 +503,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnusedAssignment", "UnnecessaryBoxing"}) public void testCreateWithNonEmptyOneToManyCollectionMergeWithNewElement() { clearCounts(); @@ -568,7 +559,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testMoveOneToManyElementToNewEntityCollection() { clearCounts(); @@ -638,7 +628,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testMoveOneToManyElementToExistingEntityCollection() { clearCounts(); @@ -709,7 +698,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testRemoveOneToManyElementUsingUpdate() { clearCounts(); @@ -774,7 +762,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnusedAssignment", "UnnecessaryBoxing"}) public void testRemoveOneToManyElementUsingMerge() { clearCounts(); @@ -839,7 +826,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testDeleteOneToManyElement() { clearCounts(); @@ -886,7 +872,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testRemoveOneToManyElementByDelete() { clearCounts(); @@ -936,7 +921,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testRemoveOneToManyOrphanUsingUpdate() { clearCounts(); @@ -988,7 +972,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnusedAssignment", "UnnecessaryBoxing"}) public void testRemoveOneToManyOrphanUsingMerge() { Contract c = new Contract( null, "gail", "phone"); ContractVariation cv = new ContractVariation( 1, c ); @@ -1038,7 +1021,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testDeleteOneToManyOrphan() { clearCounts(); @@ -1085,7 +1067,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional assertDeleteCount( 1 ); } - @SuppressWarnings( {"UnnecessaryBoxing"}) @Test public void testOneToManyCollectionOptimisticLockingWithMerge() { clearCounts(); @@ -1143,7 +1124,6 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional assertDeleteCount( 3 ); } - @SuppressWarnings( {"UnnecessaryBoxing"}) @Test public void testOneToManyCollectionOptimisticLockingWithUpdate() { clearCounts(); @@ -1219,4 +1199,4 @@ public abstract class AbstractEntityWithOneToManyTest extends BaseCoreFunctional int deletes = ( int ) sessionFactory().getStatistics().getEntityDeleteCount(); assertEquals( "unexpected delete counts", expected, deletes ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Info.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Info.java index 0b31f54158..5932498ed9 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Info.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Info.java @@ -62,4 +62,4 @@ public class Info implements Serializable { public void setId(long id) { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Owner.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Owner.java index f81b3d8f8e..864924e793 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Owner.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Owner.java @@ -72,4 +72,4 @@ public class Owner implements Serializable { this.plan = plan; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Party.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Party.java index 3672c7bb29..b6169c8c3c 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Party.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Party.java @@ -82,4 +82,4 @@ public class Party implements Serializable { public void setInfos(Set infos) { this.infos = infos; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Plan.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Plan.java index e7875f66a8..c211f97ee4 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Plan.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/Plan.java @@ -127,4 +127,4 @@ public class Plan implements Serializable { public void setOwner(Owner owner) { this.owner = owner; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseManyToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseManyToManyTest.java index fd6c41fd34..eaedc0c38d 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseManyToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseManyToManyTest.java @@ -33,4 +33,4 @@ public class EntityWithInverseManyToManyTest extends AbstractEntityWithManyToMan public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/inverse/ContractVariation.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseOneToManyJoinTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseOneToManyJoinTest.java index 913564f870..48c693a3c8 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseOneToManyJoinTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseOneToManyJoinTest.java @@ -39,4 +39,4 @@ public class EntityWithInverseOneToManyJoinTest extends AbstractEntityWithOneToM public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/inverse/ContractVariationOneToManyJoin.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseOneToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseOneToManyTest.java index 722b590bf7..c84291ec25 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseOneToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/EntityWithInverseOneToManyTest.java @@ -32,4 +32,4 @@ public class EntityWithInverseOneToManyTest extends AbstractEntityWithOneToManyT public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/inverse/ContractVariation.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseManyToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseManyToManyTest.java index 8dffa3b6be..54a6196d79 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseManyToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseManyToManyTest.java @@ -33,4 +33,4 @@ public class VersionedEntityWithInverseManyToManyTest extends AbstractEntityWith public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/inverse/ContractVariationVersioned.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyFailureExpectedTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyFailureExpectedTest.java index 0379ae0854..9135d5dc3b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyFailureExpectedTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyFailureExpectedTest.java @@ -87,4 +87,4 @@ public class VersionedEntityWithInverseOneToManyFailureExpectedTest extends Abst public void testRemoveOneToManyElementUsingMerge() { super.testRemoveOneToManyElementUsingMerge(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyJoinFailureExpectedTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyJoinFailureExpectedTest.java index 18e5b0b54f..ef1642834f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyJoinFailureExpectedTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyJoinFailureExpectedTest.java @@ -92,4 +92,4 @@ public class VersionedEntityWithInverseOneToManyJoinFailureExpectedTest extends public void testRemoveOneToManyElementUsingMerge() { super.testRemoveOneToManyElementUsingMerge(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyJoinTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyJoinTest.java index 57509a90a9..55fe3a2e55 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyJoinTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyJoinTest.java @@ -50,4 +50,4 @@ public class VersionedEntityWithInverseOneToManyJoinTest extends AbstractEntityW protected boolean checkUpdateCountsAfterRemovingElementWithoutDelete() { return false; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyTest.java index a0e01ebbc1..07d6a8c59e 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/inverse/VersionedEntityWithInverseOneToManyTest.java @@ -40,4 +40,4 @@ public class VersionedEntityWithInverseOneToManyTest extends AbstractEntityWithO protected boolean checkUpdateCountsAfterRemovingElementWithoutDelete() { return false; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseManyToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseManyToManyTest.java index 729745d13b..2d74e3caa9 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseManyToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseManyToManyTest.java @@ -33,4 +33,4 @@ public class EntityWithNonInverseManyToManyTest extends AbstractEntityWithManyTo public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/noninverse/ContractVariation.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseManyToManyUnidirTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseManyToManyUnidirTest.java index 68f8f236ee..9778ca81b3 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseManyToManyUnidirTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseManyToManyUnidirTest.java @@ -33,4 +33,4 @@ public class EntityWithNonInverseManyToManyUnidirTest extends AbstractEntityWith public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/noninverse/ContractVariationUnidir.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyJoinTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyJoinTest.java index 947d3fd69f..7f13f72c87 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyJoinTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyJoinTest.java @@ -39,4 +39,4 @@ public class EntityWithNonInverseOneToManyJoinTest extends AbstractEntityWithOne public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/noninverse/ContractVariationOneToManyJoin.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyTest.java index bf2ede12d8..84d2170aaa 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyTest.java @@ -32,4 +32,4 @@ public class EntityWithNonInverseOneToManyTest extends AbstractEntityWithOneToMa public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/noninverse/ContractVariation.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyUnidirTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyUnidirTest.java index a9c2cbb44b..3fe6c4c260 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyUnidirTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/EntityWithNonInverseOneToManyUnidirTest.java @@ -32,4 +32,4 @@ public class EntityWithNonInverseOneToManyUnidirTest extends AbstractEntityWithO public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/noninverse/ContractVariationUnidir.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseManyToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseManyToManyTest.java index 02ff97e3ad..2dfbf5d0e4 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseManyToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseManyToManyTest.java @@ -33,4 +33,4 @@ public class VersionedEntityWithNonInverseManyToManyTest extends AbstractEntityW public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/noninverse/ContractVariationVersioned.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseOneToManyJoinTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseOneToManyJoinTest.java index 11c71880fb..7f504bbcdc 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseOneToManyJoinTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseOneToManyJoinTest.java @@ -39,4 +39,4 @@ public class VersionedEntityWithNonInverseOneToManyJoinTest extends AbstractEnti public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/noninverse/ContractVariationVersionedOneToManyJoin.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseOneToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseOneToManyTest.java index 02ed983266..f4f239e1b0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseOneToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/immutable/entitywithmutablecollection/noninverse/VersionedEntityWithNonInverseOneToManyTest.java @@ -32,4 +32,4 @@ public class VersionedEntityWithNonInverseOneToManyTest extends AbstractEntityWi public String[] getMappings() { return new String[] { "immutable/entitywithmutablecollection/noninverse/ContractVariationVersioned.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/instrument/cases/TestLazyPropertyCustomTypeExecutable.java b/hibernate-core/src/test/java/org/hibernate/test/instrument/cases/TestLazyPropertyCustomTypeExecutable.java index b17afd2472..ea9a0407e1 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/instrument/cases/TestLazyPropertyCustomTypeExecutable.java +++ b/hibernate-core/src/test/java/org/hibernate/test/instrument/cases/TestLazyPropertyCustomTypeExecutable.java @@ -88,4 +88,4 @@ public class TestLazyPropertyCustomTypeExecutable extends AbstractExecutable { s.getTransaction().commit(); s.close(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/instrument/domain/CustomBlobType.java b/hibernate-core/src/test/java/org/hibernate/test/instrument/domain/CustomBlobType.java index b37d712827..02ce15bedf 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/instrument/domain/CustomBlobType.java +++ b/hibernate-core/src/test/java/org/hibernate/test/instrument/domain/CustomBlobType.java @@ -107,4 +107,4 @@ public class CustomBlobType implements UserType { throws HibernateException { return null; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/interceptor/InstantiateInterceptor.java b/hibernate-core/src/test/java/org/hibernate/test/interceptor/InstantiateInterceptor.java index 2ec32ae892..3566bedde0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/interceptor/InstantiateInterceptor.java +++ b/hibernate-core/src/test/java/org/hibernate/test/interceptor/InstantiateInterceptor.java @@ -50,4 +50,4 @@ public class InstantiateInterceptor extends EmptyInterceptor { instance.setInjectedString( injectedString ); return instance; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Document.java b/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Document.java index 804eb88e6c..d28fd5fda6 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Document.java +++ b/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Document.java @@ -20,4 +20,4 @@ public interface Document extends Item { public Calendar getCreated(); public Calendar getModified(); -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Folder.java b/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Folder.java index 258c8a642b..815181b532 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Folder.java +++ b/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Folder.java @@ -15,4 +15,4 @@ public interface Folder extends Item { * @param parent The parent to set. */ public void setParent(Folder parent); -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Item.java b/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Item.java index 9499d892d9..bcf28fac97 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Item.java +++ b/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/Item.java @@ -20,4 +20,4 @@ public interface Item { * @param name The name to set. */ public void setName(String name); -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/SecureDocument.java b/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/SecureDocument.java index f7c5862eff..1b14cb4f06 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/SecureDocument.java +++ b/hibernate-core/src/test/java/org/hibernate/test/interfaceproxy/SecureDocument.java @@ -25,4 +25,4 @@ public interface SecureDocument extends Document { * @param permissionBits The permissionBits to set. */ public void setPermissionBits(byte permissionBits); -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/ClassWithIdentityColumn.java b/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/ClassWithIdentityColumn.java index 6b8f8d3415..29b4589d51 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/ClassWithIdentityColumn.java +++ b/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/ClassWithIdentityColumn.java @@ -24,4 +24,4 @@ public class ClassWithIdentityColumn { this.name = name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/ImmutableNaturalIdTest.java b/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/ImmutableNaturalIdTest.java index 8cfc91aab2..bdc9001fbf 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/ImmutableNaturalIdTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/ImmutableNaturalIdTest.java @@ -346,4 +346,4 @@ public class ImmutableNaturalIdTest extends AbstractJPATest { s.close(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/User.java b/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/User.java index 86269b4327..04a2670c41 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/User.java +++ b/hibernate-core/src/test/java/org/hibernate/test/jpa/naturalid/User.java @@ -87,4 +87,4 @@ public class User implements java.io.Serializable { this.version = version; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/legacy/ABCTest.java b/hibernate-core/src/test/java/org/hibernate/test/legacy/ABCTest.java index ec14b03f73..3d638bb855 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/legacy/ABCTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/legacy/ABCTest.java @@ -35,7 +35,6 @@ import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; -@SuppressWarnings( {"UnnecessaryBoxing"}) public class ABCTest extends LegacyTestCase { public String[] getMappings() { return new String[] { "legacy/ABC.hbm.xml", "legacy/ABCExtends.hbm.xml" }; diff --git a/hibernate-core/src/test/java/org/hibernate/test/legacy/CustomSQLTest.java b/hibernate-core/src/test/java/org/hibernate/test/legacy/CustomSQLTest.java index a62a6a3d6a..c7bd7511be 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/legacy/CustomSQLTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/legacy/CustomSQLTest.java @@ -41,7 +41,6 @@ public class CustomSQLTest extends LegacyTestCase { @Test @RequiresDialectFeature( NonIdentityGeneratorChecker.class ) @SkipForDialect( value = {PostgreSQL81Dialect.class, PostgreSQLDialect.class}, jiraKey = "HHH-6704") - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testInsert() throws HibernateException, SQLException { Session s = openSession(); s.beginTransaction(); @@ -85,7 +84,6 @@ public class CustomSQLTest extends LegacyTestCase { } // @Test - @SuppressWarnings( {"UnnecessaryBoxing", "unchecked"}) // @RequiresDialectFeature( NonIdentityGeneratorChecker.class ) public void testCollectionCUD() throws HibernateException, SQLException { Role role = new Role(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/legacy/FooBarTest.java b/hibernate-core/src/test/java/org/hibernate/test/legacy/FooBarTest.java index c329f3dfdb..006c6fcaaa 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/legacy/FooBarTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/legacy/FooBarTest.java @@ -2476,7 +2476,6 @@ public class FooBarTest extends LegacyTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing", "unchecked"}) public void testPersistCollections() throws Exception { Session s = openSession(); Transaction txn = s.beginTransaction(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/legacy/LegacyTestCase.java b/hibernate-core/src/test/java/org/hibernate/test/legacy/LegacyTestCase.java index e88393d175..5919d147c5 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/legacy/LegacyTestCase.java +++ b/hibernate-core/src/test/java/org/hibernate/test/legacy/LegacyTestCase.java @@ -50,7 +50,6 @@ public abstract class LegacyTestCase extends BaseCoreFunctionalTestCase { private boolean useAntlrParser; @Before - @SuppressWarnings( {"UnnecessaryUnboxing"}) public void checkAntlrParserSetting() { useAntlrParser = Boolean.valueOf( extractFromSystem( USE_ANTLR_PARSER_PROP ) ); } diff --git a/hibernate-core/src/test/java/org/hibernate/test/legacy/MultiplicityType.java b/hibernate-core/src/test/java/org/hibernate/test/legacy/MultiplicityType.java index db5c9336a0..09acc4d7cf 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/legacy/MultiplicityType.java +++ b/hibernate-core/src/test/java/org/hibernate/test/legacy/MultiplicityType.java @@ -163,4 +163,4 @@ public class MultiplicityType implements CompositeUserType { return assemble( disassemble(original, session), session, owner); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/legacy/ParentChildTest.java b/hibernate-core/src/test/java/org/hibernate/test/legacy/ParentChildTest.java index dd97788db5..875ca2598e 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/legacy/ParentChildTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/legacy/ParentChildTest.java @@ -64,7 +64,6 @@ import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; -@SuppressWarnings( {"UnnecessaryBoxing"}) public class ParentChildTest extends LegacyTestCase { @Override public String[] getMappings() { diff --git a/hibernate-core/src/test/java/org/hibernate/test/legacy/SQLFunctionsTest.java b/hibernate-core/src/test/java/org/hibernate/test/legacy/SQLFunctionsTest.java index ace0447683..6956140ef3 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/legacy/SQLFunctionsTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/legacy/SQLFunctionsTest.java @@ -57,7 +57,6 @@ import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertTrue; -@SuppressWarnings( {"UnnecessaryUnboxing", "UnnecessaryBoxing"}) public class SQLFunctionsTest extends LegacyTestCase { private static final Logger log = Logger.getLogger( SQLFunctionsTest.class ); diff --git a/hibernate-core/src/test/java/org/hibernate/test/lob/ImageTest.java b/hibernate-core/src/test/java/org/hibernate/test/lob/ImageTest.java index 9a6cfe16f0..6392575151 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/lob/ImageTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/lob/ImageTest.java @@ -33,4 +33,4 @@ public class ImageTest extends LongByteArrayTest { public String[] getMappings() { return new String[] { "lob/ImageMappings.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/lob/JpaLargeBlobTest.java b/hibernate-core/src/test/java/org/hibernate/test/lob/JpaLargeBlobTest.java index 40e5f98942..92e592a0e3 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/lob/JpaLargeBlobTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/lob/JpaLargeBlobTest.java @@ -110,4 +110,4 @@ public class JpaLargeBlobTest extends BaseCoreFunctionalTestCase { return read; } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/lob/LobEntity.java b/hibernate-core/src/test/java/org/hibernate/test/lob/LobEntity.java index e66a27c1fe..2f945f1cfd 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/lob/LobEntity.java +++ b/hibernate-core/src/test/java/org/hibernate/test/lob/LobEntity.java @@ -57,4 +57,4 @@ public class LobEntity { public void setBlob(Blob blob) { this.blob = blob; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/lob/LongByteArrayHolder.java b/hibernate-core/src/test/java/org/hibernate/test/lob/LongByteArrayHolder.java index 6e6749350a..f995468266 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/lob/LongByteArrayHolder.java +++ b/hibernate-core/src/test/java/org/hibernate/test/lob/LongByteArrayHolder.java @@ -52,4 +52,4 @@ public class LongByteArrayHolder { public void setLongByteArray(byte[] longByteArray) { this.longByteArray = longByteArray; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/lob/LongByteArrayTest.java b/hibernate-core/src/test/java/org/hibernate/test/lob/LongByteArrayTest.java index 924aa9671c..bf73d62607 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/lob/LongByteArrayTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/lob/LongByteArrayTest.java @@ -141,4 +141,4 @@ public abstract class LongByteArrayTest extends BaseCoreFunctionalTestCase { throw new AssertionFailedError( "byte arrays did not match" ); } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/lob/LongStringHolder.java b/hibernate-core/src/test/java/org/hibernate/test/lob/LongStringHolder.java index 00eb06cc9e..9d262e00f9 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/lob/LongStringHolder.java +++ b/hibernate-core/src/test/java/org/hibernate/test/lob/LongStringHolder.java @@ -51,4 +51,4 @@ public class LongStringHolder { public void setLongString(String longString) { this.longString = longString; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/lob/LongStringTest.java b/hibernate-core/src/test/java/org/hibernate/test/lob/LongStringTest.java index 5546b53734..5feac68c19 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/lob/LongStringTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/lob/LongStringTest.java @@ -112,4 +112,4 @@ public abstract class LongStringTest extends BaseCoreFunctionalTestCase { } return buff.toString(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/lob/MaterializedBlobTest.java b/hibernate-core/src/test/java/org/hibernate/test/lob/MaterializedBlobTest.java index d760937d77..d774a23419 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/lob/MaterializedBlobTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/lob/MaterializedBlobTest.java @@ -40,4 +40,4 @@ public class MaterializedBlobTest extends LongByteArrayTest { public String[] getMappings() { return new String[] { "lob/MaterializedBlobMappings.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/lob/MaterializedClobTest.java b/hibernate-core/src/test/java/org/hibernate/test/lob/MaterializedClobTest.java index 351beb3494..d70effd8eb 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/lob/MaterializedClobTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/lob/MaterializedClobTest.java @@ -37,4 +37,4 @@ public class MaterializedClobTest extends LongStringTest { public String[] getMappings() { return new String[] { "lob/MaterializedClobMappings.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/lob/SerializableHolder.java b/hibernate-core/src/test/java/org/hibernate/test/lob/SerializableHolder.java index 9f64218a98..d65edd8a90 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/lob/SerializableHolder.java +++ b/hibernate-core/src/test/java/org/hibernate/test/lob/SerializableHolder.java @@ -52,4 +52,4 @@ public class SerializableHolder { public void setSerialData(Serializable serialData) { this.serialData = serialData; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/lob/TextTest.java b/hibernate-core/src/test/java/org/hibernate/test/lob/TextTest.java index 5b58d89c49..264ca530aa 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/lob/TextTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/lob/TextTest.java @@ -33,4 +33,4 @@ public class TextTest extends LongStringTest { public String[] getMappings() { return new String[] { "lob/TextMappings.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/manytomanyassociationclass/surrogateid/assigned/ManyToManyAssociationClassAssignedIdTest.java b/hibernate-core/src/test/java/org/hibernate/test/manytomanyassociationclass/surrogateid/assigned/ManyToManyAssociationClassAssignedIdTest.java index 8808908f29..05a81558c9 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/manytomanyassociationclass/surrogateid/assigned/ManyToManyAssociationClassAssignedIdTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/manytomanyassociationclass/surrogateid/assigned/ManyToManyAssociationClassAssignedIdTest.java @@ -38,7 +38,6 @@ public class ManyToManyAssociationClassAssignedIdTest extends AbstractManyToMany } @Override - @SuppressWarnings( {"UnnecessaryBoxing"}) public Membership createMembership(String name) { return new Membership( Long.valueOf( 1000 ), name ); } diff --git a/hibernate-core/src/test/java/org/hibernate/test/manytomanyassociationclass/surrogateid/generated/ManyToManyAssociationClassGeneratedIdTest.java b/hibernate-core/src/test/java/org/hibernate/test/manytomanyassociationclass/surrogateid/generated/ManyToManyAssociationClassGeneratedIdTest.java index a6bb8491ba..0eacb416da 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/manytomanyassociationclass/surrogateid/generated/ManyToManyAssociationClassGeneratedIdTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/manytomanyassociationclass/surrogateid/generated/ManyToManyAssociationClassGeneratedIdTest.java @@ -130,4 +130,4 @@ public class ManyToManyAssociationClassGeneratedIdTest extends AbstractManyToMan s.close(); } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/map/MapIndexFormulaTest.java b/hibernate-core/src/test/java/org/hibernate/test/map/MapIndexFormulaTest.java index 73e4b4554a..0084011815 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/map/MapIndexFormulaTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/map/MapIndexFormulaTest.java @@ -56,7 +56,6 @@ public class MapIndexFormulaTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"unchecked", "UnnecessaryBoxing"}) public void testIndexFormulaMap() { Session s = openSession(); Transaction t = s.beginTransaction(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/naturalid/mutable/cached/AllCached.java b/hibernate-core/src/test/java/org/hibernate/test/naturalid/mutable/cached/AllCached.java index 4439d84cc1..f4fdd4d5fa 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/naturalid/mutable/cached/AllCached.java +++ b/hibernate-core/src/test/java/org/hibernate/test/naturalid/mutable/cached/AllCached.java @@ -47,4 +47,4 @@ public class AllCached { public void setName(String name) { this.name = name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/naturalid/nullable/A.java b/hibernate-core/src/test/java/org/hibernate/test/naturalid/nullable/A.java index fbe5767a9d..3d3e481ac2 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/naturalid/nullable/A.java +++ b/hibernate-core/src/test/java/org/hibernate/test/naturalid/nullable/A.java @@ -54,4 +54,4 @@ public class A { @OneToMany(mappedBy="assA") public Set assB = new HashSet(); -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/naturalid/nullable/C.java b/hibernate-core/src/test/java/org/hibernate/test/naturalid/nullable/C.java index 32b27d2039..9ec41addee 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/naturalid/nullable/C.java +++ b/hibernate-core/src/test/java/org/hibernate/test/naturalid/nullable/C.java @@ -41,4 +41,4 @@ public class C { @NaturalId(mutable=true) public String name; -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/CreateTest.java b/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/CreateTest.java index 4f41193be4..d092a7b55e 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/CreateTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/CreateTest.java @@ -113,7 +113,6 @@ public class CreateTest extends AbstractOperationTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testCreateTreeWithGeneratedId() throws Exception { clearCounts(); @@ -291,4 +290,4 @@ public class CreateTest extends AbstractOperationTestCase { applyNonFlushedChangesToNewSessionCloseOldSession( s ); TestingJtaPlatformImpl.INSTANCE.getTransactionManager().commit(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/MergeTest.java b/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/MergeTest.java index c17f5444fc..13685650f0 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/MergeTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/MergeTest.java @@ -604,7 +604,6 @@ public class MergeTest extends AbstractOperationTestCase { } @Test - @SuppressWarnings( {"UnusedAssignment", "UnnecessaryBoxing"}) public void testMergeManaged() throws Exception { TestingJtaPlatformImpl.INSTANCE.getTransactionManager().begin(); @@ -658,7 +657,6 @@ public class MergeTest extends AbstractOperationTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testMergeManagedUninitializedCollection() throws Exception { TestingJtaPlatformImpl.INSTANCE.getTransactionManager().begin(); @@ -707,7 +705,6 @@ public class MergeTest extends AbstractOperationTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testMergeManagedInitializedCollection() throws Exception { TestingJtaPlatformImpl.INSTANCE.getTransactionManager().begin(); @@ -781,7 +778,6 @@ public class MergeTest extends AbstractOperationTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing", "UnusedAssignment"}) public void testDeleteAndMerge() throws Exception { TestingJtaPlatformImpl.INSTANCE.getTransactionManager().begin(); Session s = openSession(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/SaveOrUpdateTest.java b/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/SaveOrUpdateTest.java index 87ecff00ce..db176698f9 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/SaveOrUpdateTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/nonflushedchanges/SaveOrUpdateTest.java @@ -271,7 +271,6 @@ public class SaveOrUpdateTest extends AbstractOperationTestCase { } @Test - @SuppressWarnings( {"UnusedAssignment", "UnnecessaryBoxing"}) public void testSaveOrUpdateManaged() throws Exception { TestingJtaPlatformImpl.INSTANCE.getTransactionManager().begin(); Session s = openSession(); @@ -318,7 +317,6 @@ public class SaveOrUpdateTest extends AbstractOperationTestCase { } @Test - @SuppressWarnings( {"UnusedAssignment", "UnnecessaryBoxing"}) public void testSaveOrUpdateGot() throws Exception { boolean instrumented = FieldInterceptionHelper.isInstrumented( new NumberedNode() ); @@ -387,7 +385,6 @@ public class SaveOrUpdateTest extends AbstractOperationTestCase { } @Test - @SuppressWarnings( {"UnusedAssignment", "UnnecessaryBoxing"}) public void testSaveOrUpdateGotWithMutableProp() throws Exception { clearCounts(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/onetomany/AbstractRecursiveBidirectionalOneToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/onetomany/AbstractRecursiveBidirectionalOneToManyTest.java index 35da12cb2c..70a94b7bde 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/onetomany/AbstractRecursiveBidirectionalOneToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/onetomany/AbstractRecursiveBidirectionalOneToManyTest.java @@ -155,7 +155,6 @@ public abstract class AbstractRecursiveBidirectionalOneToManyTest extends BaseCo s.close(); } - @SuppressWarnings( {"UnnecessaryBoxing"}) void check(boolean simplePropertyUpdated) { Session s = openSession(); Transaction tx = s.beginTransaction(); @@ -181,7 +180,6 @@ public abstract class AbstractRecursiveBidirectionalOneToManyTest extends BaseCo s.close(); } - @SuppressWarnings( {"UnnecessaryBoxing"}) void delete() { Session s = openSession(); Transaction tx = s.beginTransaction(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/onetomany/AbstractVersionedRecursiveBidirectionalOneToManyTest.java b/hibernate-core/src/test/java/org/hibernate/test/onetomany/AbstractVersionedRecursiveBidirectionalOneToManyTest.java index a4b7902b6d..97ba8d8de5 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/onetomany/AbstractVersionedRecursiveBidirectionalOneToManyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/onetomany/AbstractVersionedRecursiveBidirectionalOneToManyTest.java @@ -39,7 +39,6 @@ public abstract class AbstractVersionedRecursiveBidirectionalOneToManyTest exten } @Override - @SuppressWarnings( {"UnnecessaryBoxing"}) void check(boolean simplePropertyUpdated) { super.check( simplePropertyUpdated ); Session s = openSession(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/onetomany/RecursiveBidirectionalOneToManyNoCacheTest.java b/hibernate-core/src/test/java/org/hibernate/test/onetomany/RecursiveBidirectionalOneToManyNoCacheTest.java index e60fea4b02..958fd87fe0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/onetomany/RecursiveBidirectionalOneToManyNoCacheTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/onetomany/RecursiveBidirectionalOneToManyNoCacheTest.java @@ -37,4 +37,4 @@ public class RecursiveBidirectionalOneToManyNoCacheTest extends AbstractRecursiv protected CacheMode getSessionCacheMode() { return CacheMode.IGNORE; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/ops/CreateTest.java b/hibernate-core/src/test/java/org/hibernate/test/ops/CreateTest.java index f35a0956dc..8a266493f7 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/ops/CreateTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/ops/CreateTest.java @@ -102,7 +102,6 @@ public class CreateTest extends AbstractOperationTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testCreateTreeWithGeneratedId() { clearCounts(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/ops/MergeTest.java b/hibernate-core/src/test/java/org/hibernate/test/ops/MergeTest.java index f3a01eb033..00b5dba4fb 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/ops/MergeTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/ops/MergeTest.java @@ -603,7 +603,6 @@ public class MergeTest extends AbstractOperationTestCase { cleanup(); } - @SuppressWarnings( {"UnnecessaryBoxing"}) @Test public void testMergeManaged() { Session s = openSession(); @@ -646,7 +645,6 @@ public class MergeTest extends AbstractOperationTestCase { cleanup(); } - @SuppressWarnings( {"UnnecessaryBoxing"}) @Test public void testMergeManagedUninitializedCollection() { Session s = openSession(); @@ -691,7 +689,6 @@ public class MergeTest extends AbstractOperationTestCase { cleanup(); } - @SuppressWarnings( {"UnnecessaryBoxing"}) @Test public void testMergeManagedInitializedCollection() { Session s = openSession(); @@ -759,7 +756,6 @@ public class MergeTest extends AbstractOperationTestCase { cleanup(); } - @SuppressWarnings( {"UnnecessaryBoxing"}) @Test public void testDeleteAndMerge() throws Exception { Session s = openSession(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/optlock/OptimisticLockTest.java b/hibernate-core/src/test/java/org/hibernate/test/optlock/OptimisticLockTest.java index d4abb8e636..5c236d1a80 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/optlock/OptimisticLockTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/optlock/OptimisticLockTest.java @@ -132,7 +132,6 @@ public class OptimisticLockTest extends BaseCoreFunctionalTestCase { mainSession.close(); } - @SuppressWarnings({ "UnnecessaryBoxing" }) private void testDeleteOptimisticLockFailure(String entityName) { Session mainSession = openSession(); mainSession.beginTransaction(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/DeleteOneToOneOrphansTest.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/DeleteOneToOneOrphansTest.java index 18a8cf33a4..b455adbad8 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/DeleteOneToOneOrphansTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/DeleteOneToOneOrphansTest.java @@ -91,4 +91,4 @@ public class DeleteOneToOneOrphansTest extends BaseCoreFunctionalTestCase { cleanupData(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/Employee.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/Employee.java index 7bc5ca7318..752078b7b8 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/Employee.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/Employee.java @@ -48,4 +48,4 @@ public class Employee { public void setInfo(EmployeeInfo info) { this.info = info; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/EmployeeInfo.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/EmployeeInfo.java index acf49d827e..af02c3f45e 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/EmployeeInfo.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/bidirectional/EmployeeInfo.java @@ -55,4 +55,4 @@ public class EmployeeInfo { public void setEmployee(Employee employee) { this.employee = employee; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/DeleteOneToOneOrphansTest.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/DeleteOneToOneOrphansTest.java index eff8102af5..25859be101 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/DeleteOneToOneOrphansTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/DeleteOneToOneOrphansTest.java @@ -91,4 +91,4 @@ public class DeleteOneToOneOrphansTest extends BaseCoreFunctionalTestCase { cleanupData(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/Employee.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/Employee.java index b50f920f67..45919e48af 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/Employee.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/Employee.java @@ -48,4 +48,4 @@ public class Employee { public void setInfo(EmployeeInfo info) { this.info = info; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/EmployeeInfo.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/EmployeeInfo.java index 61ee6c153c..12bbfafe6f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/EmployeeInfo.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/composite/EmployeeInfo.java @@ -102,4 +102,4 @@ public class EmployeeInfo { public void setId(Id id) { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/DeleteOneToOneOrphansTest.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/DeleteOneToOneOrphansTest.java index 516fae7382..a55a0ee55e 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/DeleteOneToOneOrphansTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/DeleteOneToOneOrphansTest.java @@ -90,4 +90,4 @@ public class DeleteOneToOneOrphansTest extends BaseCoreFunctionalTestCase { cleanupData(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/Employee.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/Employee.java index b8b1532325..d2c628eb92 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/Employee.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/Employee.java @@ -48,4 +48,4 @@ public class Employee { public void setInfo(EmployeeInfo info) { this.info = info; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/EmployeeInfo.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/EmployeeInfo.java index 816756eafb..40a3dbaada 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/EmployeeInfo.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/bidirectional/EmployeeInfo.java @@ -55,4 +55,4 @@ public class EmployeeInfo { public void setEmployee(Employee employee) { this.employee = employee; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/DeleteOneToOneOrphansTest.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/DeleteOneToOneOrphansTest.java index b7f56ad5fa..e6026c8664 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/DeleteOneToOneOrphansTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/DeleteOneToOneOrphansTest.java @@ -137,4 +137,4 @@ public class DeleteOneToOneOrphansTest extends BaseCoreFunctionalTestCase { cleanupData(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/Employee.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/Employee.java index 84e8b7e1d8..4d1c13d863 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/Employee.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/Employee.java @@ -48,4 +48,4 @@ public class Employee { public void setInfo(EmployeeInfo info) { this.info = info; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/EmployeeInfo.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/EmployeeInfo.java index c61d909d2e..d003529bc8 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/EmployeeInfo.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/fk/reversed/unidirectional/EmployeeInfo.java @@ -42,4 +42,4 @@ public class EmployeeInfo { public void setId(Long id) { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/DeleteOneToOneOrphansTest.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/DeleteOneToOneOrphansTest.java index d60246cea6..00c855d46d 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/DeleteOneToOneOrphansTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/DeleteOneToOneOrphansTest.java @@ -98,4 +98,4 @@ public class DeleteOneToOneOrphansTest extends BaseCoreFunctionalTestCase { cleanupData(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/Employee.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/Employee.java index c0a538e8a7..68c4f55fce 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/Employee.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/Employee.java @@ -48,4 +48,4 @@ public class Employee { public void setInfo(EmployeeInfo info) { this.info = info; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/EmployeeInfo.java b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/EmployeeInfo.java index 552b7f43a8..87f566f81e 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/EmployeeInfo.java +++ b/hibernate-core/src/test/java/org/hibernate/test/orphan/one2one/pk/unidirectional/EmployeeInfo.java @@ -46,4 +46,4 @@ public class EmployeeInfo { public void setId(Long id) { this.id = id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/propertyref/DoesNotWorkPk.java b/hibernate-core/src/test/java/org/hibernate/test/propertyref/DoesNotWorkPk.java index f753f19313..28c4a0fefb 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/propertyref/DoesNotWorkPk.java +++ b/hibernate-core/src/test/java/org/hibernate/test/propertyref/DoesNotWorkPk.java @@ -97,4 +97,4 @@ public class DoesNotWorkPk implements Serializable { return true; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/querycache/Address.java b/hibernate-core/src/test/java/org/hibernate/test/querycache/Address.java index 8ab9331393..68edc2d15e 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/querycache/Address.java +++ b/hibernate-core/src/test/java/org/hibernate/test/querycache/Address.java @@ -132,4 +132,4 @@ public class Address { result = 31 * result + ( country != null ? country.hashCode() : 0 ); return result; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/querycache/Course.java b/hibernate-core/src/test/java/org/hibernate/test/querycache/Course.java index c0bb069d29..2b454560c5 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/querycache/Course.java +++ b/hibernate-core/src/test/java/org/hibernate/test/querycache/Course.java @@ -56,4 +56,4 @@ public class Course implements Serializable { result = 31 * result + ( description != null ? description.hashCode() : 0 ); return result; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/querycache/CourseMeeting.java b/hibernate-core/src/test/java/org/hibernate/test/querycache/CourseMeeting.java index d917c4786e..30ec34aa90 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/querycache/CourseMeeting.java +++ b/hibernate-core/src/test/java/org/hibernate/test/querycache/CourseMeeting.java @@ -53,4 +53,4 @@ public class CourseMeeting { result = 31 * result + ( course != null ? course.hashCode() : 0 ); return result; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/querycache/CourseMeetingId.java b/hibernate-core/src/test/java/org/hibernate/test/querycache/CourseMeetingId.java index ce6f5c197f..0b44aab3d9 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/querycache/CourseMeetingId.java +++ b/hibernate-core/src/test/java/org/hibernate/test/querycache/CourseMeetingId.java @@ -77,4 +77,4 @@ public class CourseMeetingId implements Serializable { result = 31 * result + ( location != null ? location.hashCode() : 0 ); return result; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/querycache/Enrolment.java b/hibernate-core/src/test/java/org/hibernate/test/querycache/Enrolment.java index b00b7dd407..7c7a8cc4b8 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/querycache/Enrolment.java +++ b/hibernate-core/src/test/java/org/hibernate/test/querycache/Enrolment.java @@ -83,4 +83,4 @@ public class Enrolment implements Serializable { result = 31 * result + ( int ) semester; return result; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/querycache/PersonName.java b/hibernate-core/src/test/java/org/hibernate/test/querycache/PersonName.java index 8b107934ae..ca2ea1f22b 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/querycache/PersonName.java +++ b/hibernate-core/src/test/java/org/hibernate/test/querycache/PersonName.java @@ -94,4 +94,4 @@ public class PersonName { result = 31 * result + ( last != null ? last.hashCode() : 0 ); return result; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/querycache/StringCompositeKey.java b/hibernate-core/src/test/java/org/hibernate/test/querycache/StringCompositeKey.java index 01024f0b38..7fac34c6f0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/querycache/StringCompositeKey.java +++ b/hibernate-core/src/test/java/org/hibernate/test/querycache/StringCompositeKey.java @@ -57,4 +57,4 @@ public class StringCompositeKey implements Serializable { public void setAnalog(String analog) { this.analog = analog; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/querycache/Student.java b/hibernate-core/src/test/java/org/hibernate/test/querycache/Student.java index dae8271fdc..6762db85d1 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/querycache/Student.java +++ b/hibernate-core/src/test/java/org/hibernate/test/querycache/Student.java @@ -98,4 +98,4 @@ public class Student { result = 31 * result + ( name != null ? name.hashCode() : 0 ); return result; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/querycache/StudentDTO.java b/hibernate-core/src/test/java/org/hibernate/test/querycache/StudentDTO.java index 67fb53ba3d..de4a6cd13c 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/querycache/StudentDTO.java +++ b/hibernate-core/src/test/java/org/hibernate/test/querycache/StudentDTO.java @@ -58,4 +58,4 @@ public class StudentDTO { result = 31 * result + ( courseDescription != null ? courseDescription.hashCode() : 0 ); return result; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/queryplan/GetHqlQueryPlanTest.java b/hibernate-core/src/test/java/org/hibernate/test/queryplan/GetHqlQueryPlanTest.java index 3efdefd681..041951a619 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/queryplan/GetHqlQueryPlanTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/queryplan/GetHqlQueryPlanTest.java @@ -81,7 +81,6 @@ public class GetHqlQueryPlanTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testHqlQueryPlanWithEnabledFilter() { Session s = openSession(); QueryPlanCache cache = ( (SessionImplementor) s ).getFactory().getQueryPlanCache(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/queryplan/NativeSQLQueryReturnEqualsAndHashCodeTest.java b/hibernate-core/src/test/java/org/hibernate/test/queryplan/NativeSQLQueryReturnEqualsAndHashCodeTest.java index f51687be2d..9dfea18b99 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/queryplan/NativeSQLQueryReturnEqualsAndHashCodeTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/queryplan/NativeSQLQueryReturnEqualsAndHashCodeTest.java @@ -274,4 +274,4 @@ public class NativeSQLQueryReturnEqualsAndHashCodeTest extends BaseCoreFunctiona assertFalse( queryReturn1.hashCode() == queryReturn2.hashCode() ); } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/readonly/AbstractReadOnlyTest.java b/hibernate-core/src/test/java/org/hibernate/test/readonly/AbstractReadOnlyTest.java index cf19688a51..d2d25e3d71 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/readonly/AbstractReadOnlyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/readonly/AbstractReadOnlyTest.java @@ -74,4 +74,4 @@ public abstract class AbstractReadOnlyTest extends BaseCoreFunctionalTestCase { int deletes = ( int ) sessionFactory().getStatistics().getEntityDeleteCount(); assertEquals( "unexpected delete counts", expected, deletes ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/readonly/Container.java b/hibernate-core/src/test/java/org/hibernate/test/readonly/Container.java index da8442e279..80124c6c45 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/readonly/Container.java +++ b/hibernate-core/src/test/java/org/hibernate/test/readonly/Container.java @@ -113,4 +113,4 @@ public class Container implements Serializable { public void setNonLazySelectDataPoints(Set nonLazySelectDataPoints) { this.nonLazySelectDataPoints = nonLazySelectDataPoints; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/readonly/Info.java b/hibernate-core/src/test/java/org/hibernate/test/readonly/Info.java index 80cc92d209..67179573c0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/readonly/Info.java +++ b/hibernate-core/src/test/java/org/hibernate/test/readonly/Info.java @@ -32,4 +32,4 @@ public class Info { public void setDetails(String details) { this.details = details; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/readonly/Owner.java b/hibernate-core/src/test/java/org/hibernate/test/readonly/Owner.java index 208af25805..a4a0002448 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/readonly/Owner.java +++ b/hibernate-core/src/test/java/org/hibernate/test/readonly/Owner.java @@ -30,4 +30,4 @@ public class Owner implements Serializable { public void setName(String name) { this.name = name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/readonly/ReadOnlySessionLazyNonLazyTest.java b/hibernate-core/src/test/java/org/hibernate/test/readonly/ReadOnlySessionLazyNonLazyTest.java index 9bde45d620..88e8577e82 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/readonly/ReadOnlySessionLazyNonLazyTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/readonly/ReadOnlySessionLazyNonLazyTest.java @@ -1389,4 +1389,4 @@ public class ReadOnlySessionLazyNonLazyTest extends AbstractReadOnlyTest { } } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/resulttransformer/PartnerA.java b/hibernate-core/src/test/java/org/hibernate/test/resulttransformer/PartnerA.java index 552055b7e5..ac96506e72 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/resulttransformer/PartnerA.java +++ b/hibernate-core/src/test/java/org/hibernate/test/resulttransformer/PartnerA.java @@ -53,4 +53,4 @@ public class PartnerA { this.name = name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/schemaupdate/SchemaExportManagedConnectionTest.java b/hibernate-core/src/test/java/org/hibernate/test/schemaupdate/SchemaExportManagedConnectionTest.java index da607b6e15..5ec0f4e4f6 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/schemaupdate/SchemaExportManagedConnectionTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/schemaupdate/SchemaExportManagedConnectionTest.java @@ -34,4 +34,4 @@ public class SchemaExportManagedConnectionTest extends SchemaExportTest { protected SchemaExport createSchemaExport(Configuration cfg) { return new SchemaExport( cfg ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/schemaupdate/SchemaExportSuppliedConnectionTest.java b/hibernate-core/src/test/java/org/hibernate/test/schemaupdate/SchemaExportSuppliedConnectionTest.java index 4fc2d0fcb2..451f66be42 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/schemaupdate/SchemaExportSuppliedConnectionTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/schemaupdate/SchemaExportSuppliedConnectionTest.java @@ -41,4 +41,4 @@ public class SchemaExportSuppliedConnectionTest extends SchemaExportTest { protected SchemaExport createSchemaExport(Configuration cfg) { return new SchemaExport( serviceRegistry, cfg ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/sql/check/ResultCheckStyleTest.java b/hibernate-core/src/test/java/org/hibernate/test/sql/check/ResultCheckStyleTest.java index 9449d4148f..19f23acfea 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/sql/check/ResultCheckStyleTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/sql/check/ResultCheckStyleTest.java @@ -80,7 +80,6 @@ public abstract class ResultCheckStyleTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testUpdateFailureWithExceptionChecking() { Session s = openSession(); s.beginTransaction(); @@ -101,7 +100,6 @@ public abstract class ResultCheckStyleTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testUpdateFailureWithParamChecking() { Session s = openSession(); s.beginTransaction(); @@ -122,7 +120,6 @@ public abstract class ResultCheckStyleTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testDeleteWithExceptionChecking() { Session s = openSession(); s.beginTransaction(); @@ -143,7 +140,6 @@ public abstract class ResultCheckStyleTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testDeleteWithParamChecking() { Session s = openSession(); s.beginTransaction(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/sql/hand/ImageHolder.java b/hibernate-core/src/test/java/org/hibernate/test/sql/hand/ImageHolder.java index 6ee23fbe47..b6e5f107d0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/sql/hand/ImageHolder.java +++ b/hibernate-core/src/test/java/org/hibernate/test/sql/hand/ImageHolder.java @@ -63,4 +63,4 @@ public class ImageHolder { public void setPhoto(byte[] photo) { this.photo = photo; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/sql/hand/TextHolder.java b/hibernate-core/src/test/java/org/hibernate/test/sql/hand/TextHolder.java index f77382a857..7f4ebfe9e9 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/sql/hand/TextHolder.java +++ b/hibernate-core/src/test/java/org/hibernate/test/sql/hand/TextHolder.java @@ -63,4 +63,4 @@ public class TextHolder { public void setDescription(String description) { this.description = description; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/sql/hand/custom/CustomStoredProcTestSupport.java b/hibernate-core/src/test/java/org/hibernate/test/sql/hand/custom/CustomStoredProcTestSupport.java index b43ccac65f..80e6b46126 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/sql/hand/custom/CustomStoredProcTestSupport.java +++ b/hibernate-core/src/test/java/org/hibernate/test/sql/hand/custom/CustomStoredProcTestSupport.java @@ -47,7 +47,6 @@ import static org.junit.Assert.assertTrue; @SuppressWarnings( {"UnusedDeclaration"}) public abstract class CustomStoredProcTestSupport extends CustomSQLTestSupport { @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testScalarStoredProcedure() throws HibernateException, SQLException { Session s = openSession(); Query namedQuery = s.getNamedQuery( "simpleScalar" ); @@ -60,7 +59,6 @@ public abstract class CustomStoredProcTestSupport extends CustomSQLTestSupport { } @Test - @SuppressWarnings( {"UnnecessaryBoxing"}) public void testParameterHandling() throws HibernateException, SQLException { Session s = openSession(); diff --git a/hibernate-core/src/test/java/org/hibernate/test/sql/hand/custom/sqlserver/SQLServerCustomSQLTest.java b/hibernate-core/src/test/java/org/hibernate/test/sql/hand/custom/sqlserver/SQLServerCustomSQLTest.java index 051dc85fbb..5f39f6bc43 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/sql/hand/custom/sqlserver/SQLServerCustomSQLTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/sql/hand/custom/sqlserver/SQLServerCustomSQLTest.java @@ -37,4 +37,4 @@ public class SQLServerCustomSQLTest extends CustomStoredProcTestSupport { public String[] getMappings() { return new String[] { "sql/hand/custom/sqlserver/Mappings.hbm.xml" }; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/sql/hand/query/NativeSQLQueriesTest.java b/hibernate-core/src/test/java/org/hibernate/test/sql/hand/query/NativeSQLQueriesTest.java index b7ae12442f..9251269f1f 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/sql/hand/query/NativeSQLQueriesTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/sql/hand/query/NativeSQLQueriesTest.java @@ -57,7 +57,6 @@ import static org.junit.Assert.fail; * * @author Steve Ebersole */ -@SuppressWarnings({ "UnnecessaryBoxing", "UnnecessaryUnboxing" }) public class NativeSQLQueriesTest extends BaseCoreFunctionalTestCase { public String[] getMappings() { return new String[] { "sql/hand/query/NativeSQLQueries.hbm.xml" }; diff --git a/hibernate-core/src/test/java/org/hibernate/test/sql/refcursor/NumValue.java b/hibernate-core/src/test/java/org/hibernate/test/sql/refcursor/NumValue.java index 2f73207acb..486e563764 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/sql/refcursor/NumValue.java +++ b/hibernate-core/src/test/java/org/hibernate/test/sql/refcursor/NumValue.java @@ -92,4 +92,4 @@ public class NumValue implements Serializable { public void setValue(String value) { this.value = value; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/subselect/Employee.java b/hibernate-core/src/test/java/org/hibernate/test/subselect/Employee.java index 17852a2f0c..ed5cc80b22 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/subselect/Employee.java +++ b/hibernate-core/src/test/java/org/hibernate/test/subselect/Employee.java @@ -50,4 +50,4 @@ public class Employee { public String toString() { return name; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/type/TypeTest.java b/hibernate-core/src/test/java/org/hibernate/test/type/TypeTest.java index 3f6a6de910..67f3c0d2f0 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/type/TypeTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/type/TypeTest.java @@ -86,7 +86,6 @@ import static org.junit.Assert.assertTrue; /** * @author Steve Ebersole */ -@SuppressWarnings( {"UnnecessaryBoxing"}) public class TypeTest extends BaseUnitTestCase { private SessionImplementor session; diff --git a/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BigIntegerDescriptorTest.java b/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BigIntegerDescriptorTest.java index 76ec3e94bb..1b34fbe892 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BigIntegerDescriptorTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BigIntegerDescriptorTest.java @@ -47,4 +47,4 @@ public class BigIntegerDescriptorTest extends AbstractDescriptorTest protected boolean shouldBeMutable() { return false; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BlobDescriptorTest.java b/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BlobDescriptorTest.java index c79c0b233b..52cceb20fc 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BlobDescriptorTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BlobDescriptorTest.java @@ -98,4 +98,4 @@ public class BlobDescriptorTest extends AbstractDescriptorTest { // Call to BlobImplementer#getUnderlyingStream() should mark input stream for reset. assertEquals( bytes.length, blob.getUnderlyingStream().getInputStream().available() ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BooleanDescriptorTest.java b/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BooleanDescriptorTest.java index a045f548c6..da7a032157 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BooleanDescriptorTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BooleanDescriptorTest.java @@ -47,4 +47,4 @@ public class BooleanDescriptorTest extends AbstractDescriptorTest { protected boolean shouldBeMutable() { return false; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/typedescriptor/CharInNativeQueryTest.java b/hibernate-core/src/test/java/org/hibernate/test/typedescriptor/CharInNativeQueryTest.java index 1a8548af7b..a14e704757 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/typedescriptor/CharInNativeQueryTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/typedescriptor/CharInNativeQueryTest.java @@ -69,4 +69,4 @@ public class CharInNativeQueryTest extends BaseCoreFunctionalTestCase { } - } \ No newline at end of file + } diff --git a/hibernate-core/src/test/java/org/hibernate/test/typedescriptor/Issue.java b/hibernate-core/src/test/java/org/hibernate/test/typedescriptor/Issue.java index 2f162719f9..52a7063030 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/typedescriptor/Issue.java +++ b/hibernate-core/src/test/java/org/hibernate/test/typedescriptor/Issue.java @@ -64,4 +64,4 @@ import javax.persistence.Id; public void setIssueNumber(String issueNumber) { this.issueNumber = issueNumber; } - } \ No newline at end of file + } diff --git a/hibernate-core/src/test/java/org/hibernate/test/typeoverride/StoredPrefixedStringType.java b/hibernate-core/src/test/java/org/hibernate/test/typeoverride/StoredPrefixedStringType.java index 18601dd2eb..a9bc8effbd 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/typeoverride/StoredPrefixedStringType.java +++ b/hibernate-core/src/test/java/org/hibernate/test/typeoverride/StoredPrefixedStringType.java @@ -124,4 +124,4 @@ public class StoredPrefixedStringType public String toString(String value) { return StringType.INSTANCE.toString( value ); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/typeparameters/TypeParameterTest.java b/hibernate-core/src/test/java/org/hibernate/test/typeparameters/TypeParameterTest.java index f87fcdd776..4ac8c9b213 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/typeparameters/TypeParameterTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/typeparameters/TypeParameterTest.java @@ -52,7 +52,6 @@ public class TypeParameterTest extends BaseCoreFunctionalTestCase { } @Test - @SuppressWarnings( {"UnnecessaryUnboxing"}) public void testSave() throws Exception { deleteData(); @@ -150,4 +149,4 @@ public class TypeParameterTest extends BaseCoreFunctionalTestCase { t.commit(); s.close(); } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/unidir/Parent1.java b/hibernate-core/src/test/java/org/hibernate/test/unidir/Parent1.java index fcc21838ed..b896b1afe5 100644 --- a/hibernate-core/src/test/java/org/hibernate/test/unidir/Parent1.java +++ b/hibernate-core/src/test/java/org/hibernate/test/unidir/Parent1.java @@ -32,4 +32,4 @@ public class Parent1 { public Long getId() { return this.id; } -} \ No newline at end of file +} diff --git a/hibernate-core/src/test/java/org/hibernate/test/unionsubclass/UnionSubclassTest.java b/hibernate-core/src/test/java/org/hibernate/test/unionsubclass/UnionSubclassTest.java index 1708acbe90..42a63fc9d5 100755 --- a/hibernate-core/src/test/java/org/hibernate/test/unionsubclass/UnionSubclassTest.java +++ b/hibernate-core/src/test/java/org/hibernate/test/unionsubclass/UnionSubclassTest.java @@ -23,7 +23,6 @@ */ package org.hibernate.test.unionsubclass; -import java.util.Iterator; import java.util.List; import org.junit.Test; @@ -45,6 +44,7 @@ import static org.junit.Assert.assertTrue; /** * @author Gavin King */ +@SuppressWarnings("unchecked") public class UnionSubclassTest extends BaseCoreFunctionalTestCase { @Override public String[] getMappings() { @@ -105,14 +105,14 @@ public class UnionSubclassTest extends BaseCoreFunctionalTestCase { .setFetchMode("location", FetchMode.JOIN) .setFetchMode("location.beings", FetchMode.JOIN) .list(); - - for (int i=0; i