Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-15654 Fix failing criteria set-ordered tests for some dbs

This commit is contained in:
Marco Belladelli 2022-12-16 12:55:13 +01:00 committed by Christian Beikov
parent 1ee34ac0a1
commit 1ce4135145
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hibernate-core/src/test/java/org/hibernate/orm/test/query/criteria/CriteriaOrderedSetAggregateTest.java
View File

@ -10,11 +10,10 @@ import java.util.Arrays;
import java.util.Date; import java.util.Date;
import java.util.List; import java.util.List;
import org.hibernate.dialect.DB2Dialect; import org.hibernate.dialect.CockroachDialect;
import org.hibernate.dialect.H2Dialect; import org.hibernate.dialect.H2Dialect;
import org.hibernate.dialect.PostgreSQLDialect; import org.hibernate.dialect.PostgreSQLDialect;
import org.hibernate.dialect.PostgresPlusDialect; import org.hibernate.dialect.PostgresPlusDialect;
import org.hibernate.dialect.SQLServerDialect;
import org.hibernate.query.criteria.HibernateCriteriaBuilder; import org.hibernate.query.criteria.HibernateCriteriaBuilder;
import org.hibernate.query.criteria.JpaExpression; import org.hibernate.query.criteria.JpaExpression;
import org.hibernate.query.criteria.JpaWindow; import org.hibernate.query.criteria.JpaWindow;
@ -244,9 +243,11 @@ public class CriteriaOrderedSetAggregateTest {
@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsInverseDistributionFunctions.class) @RequiresDialectFeature(feature = DialectFeatureChecks.SupportsInverseDistributionFunctions.class)
@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsWindowFunctions.class) @RequiresDialectFeature(feature = DialectFeatureChecks.SupportsWindowFunctions.class)
@SkipForDialect(dialectClass = PostgreSQLDialect.class) @SkipForDialect(dialectClass = PostgreSQLDialect.class)
@SkipForDialect(dialectClass = CockroachDialect.class)
@SkipForDialect(dialectClass = PostgresPlusDialect.class) @SkipForDialect(dialectClass = PostgresPlusDialect.class)
public void testInverseDistributionWithWindow(SessionFactoryScope scope) { public void testInverseDistributionWithWindow(SessionFactoryScope scope) {
// note : PostgreSQL and EDB currently does not support ordered-set aggregate functions with OVER clause // note : PostgreSQL, CockroachDB and EDB currently do not support
// ordered-set aggregate functions with OVER clause
scope.inTransaction( session -> { scope.inTransaction( session -> {
HibernateCriteriaBuilder cb = session.getCriteriaBuilder(); HibernateCriteriaBuilder cb = session.getCriteriaBuilder();
CriteriaQuery<Integer> cr = cb.createQuery( Integer.class ); CriteriaQuery<Integer> cr = cb.createQuery( Integer.class );
@ -306,10 +307,9 @@ public class CriteriaOrderedSetAggregateTest {
@Test @Test
@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsHypotheticalSetFunctions.class) @RequiresDialectFeature(feature = DialectFeatureChecks.SupportsHypotheticalSetFunctions.class)
@SkipForDialect(dialectClass = SQLServerDialect.class) @RequiresDialect(H2Dialect.class)
@SkipForDialect(dialectClass = DB2Dialect.class)
public void testHypotheticalSetRankWithGroupByHavingOrderByLimit(SessionFactoryScope scope) { public void testHypotheticalSetRankWithGroupByHavingOrderByLimit(SessionFactoryScope scope) {
// note : this query is not translated correctly for SQLServer and DB2, skip for now // note : cross joins are not supported in criteria and this query structure causes problems with many dbs
scope.inTransaction( session -> { scope.inTransaction( session -> {
HibernateCriteriaBuilder cb = session.getCriteriaBuilder(); HibernateCriteriaBuilder cb = session.getCriteriaBuilder();
CriteriaQuery<Tuple> cr = cb.createQuery( Tuple.class ); CriteriaQuery<Tuple> cr = cb.createQuery( Tuple.class );