From 1f9a6f43f119862636a7edc1180e9ff73d69f4b1 Mon Sep 17 00:00:00 2001 From: Steve Ebersole Date: Mon, 28 Nov 2022 15:10:36 -0600 Subject: [PATCH] HHH-15393 - Improve write-paths to use mapping model --- .../org/hibernate/engine/jdbc/batch/internal/BatchImpl.java | 1 - .../mapping/internal/AbstractEntityCollectionPart.java | 2 -- .../metamodel/mapping/internal/OneToManyCollectionPart.java | 2 -- 3 files changed, 5 deletions(-) diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/internal/BatchImpl.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/internal/BatchImpl.java index 9497642691..b37a843ad5 100644 --- a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/internal/BatchImpl.java +++ b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/internal/BatchImpl.java @@ -144,7 +144,6 @@ public class BatchImpl implements Batch { ); } finally { - // todo (mutation) : is this needed? jdbcValueBindings.afterStatement( statementDetails.getMutatingTableDetails(), session ); } } ); diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/AbstractEntityCollectionPart.java b/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/AbstractEntityCollectionPart.java index ea2f2c7053..bc7654f412 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/AbstractEntityCollectionPart.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/AbstractEntityCollectionPart.java @@ -221,8 +221,6 @@ public abstract class AbstractEntityCollectionPart implements EntityCollectionPa NavigablePath fetchablePath, FromClauseAccess fromClauseAccess, DomainResultCreationState creationState) { - - // todo (mutation) : account for `@MapKey( name = "someManyToOne" )` return collectionTableGroup.getIndexTableGroup(); } diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/OneToManyCollectionPart.java b/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/OneToManyCollectionPart.java index 9c6a4951bc..3c34120041 100644 --- a/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/OneToManyCollectionPart.java +++ b/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/OneToManyCollectionPart.java @@ -116,8 +116,6 @@ public class OneToManyCollectionPart extends AbstractEntityCollectionPart implem // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ // TableGroupJoinProducer - // todo (mutation) : this is only needed for `AbstractEntityCollectionPart#generateFetch` - // to create the map-key join @Override public SqlAstJoinType getDefaultSqlAstJoinType(TableGroup parentTableGroup) {