Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-14216 Implement isDirty for OneToOneType and always check if it is dirty or not.

This commit is contained in:
David Ellingsworth 2020-10-13 17:02:29 -04:00 committed by Steve Ebersole
parent ef5c944c86
commit 24035d7f2c
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
hibernate-core/src/main/java/org/hibernate/type/OneToOneType.java
View File

@ -151,12 +151,19 @@ public class OneToOneType extends EntityType {
@Override @Override
public boolean isDirty(Object old, Object current, SharedSessionContractImplementor session) { public boolean isDirty(Object old, Object current, SharedSessionContractImplementor session) {
return false; if ( isSame( old, current ) ) {
return false;
}
Object oldid = getIdentifier( old, session );
Object newid = getIdentifier( current, session );
return getIdentifierType( session ).isDirty( oldid, newid, session );
} }
@Override @Override
public boolean isDirty(Object old, Object current, boolean[] checkable, SharedSessionContractImplementor session) { public boolean isDirty(Object old, Object current, boolean[] checkable, SharedSessionContractImplementor session) {
return false; return isDirty(old, current, session);
} }
@Override @Override
@ -218,14 +225,8 @@ public class OneToOneType extends EntityType {
return resolveIdentifier( id, session ); return resolveIdentifier( id, session );
} }
/**
* We don't need to dirty check one-to-one because of how
* assemble/disassemble is implemented and because a one-to-one
* association is never dirty
*/
@Override @Override
public boolean isAlwaysDirtyChecked() { public boolean isAlwaysDirtyChecked() {
//TODO: this is kinda inconsistent with CollectionType return true;
return false;
} }
} }