Hibernate/hibernate-orm
1
0
Fork 0
mirror of https://github.com/hibernate/hibernate-orm synced 2025-02-27 14:30:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

note down an important TODO for later

Browse Source
This commit is contained in:
Gavin 2022-12-19 21:25:48 +01:00 committed by Gavin King
parent 0f4cdc3bdb
commit 250995336b
3 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hibernate-core/src/main/java/org/hibernate/dialect/H2SqlAstTranslator.java
View File

@ -66,6 +66,10 @@ public void visitReturningInsertStatement(TableInsertStandard tableInsert) {
assert tableInsert.getReturningColumns() != null
&& !tableInsert.getReturningColumns().isEmpty();
//TODO: This is a terrible way to solve this problem, please fix it!
// Not every "returning insert" statement has something to do
// with identity columns! (Nor is it an elegant implementation.)
final H2IdentityColumnSupport identitySupport = (H2IdentityColumnSupport) getSessionFactory()
.getJdbcServices()
.getDialect()

1
hibernate-core/src/main/java/org/hibernate/dialect/identity/H2FinalTableIdentityColumnSupport.java
View File

@ -34,6 +34,7 @@ public String appendIdentitySelectToInsert(String identityColumnName, String ins
return "select " + identityColumnName + " from final table ( " + insertString + " )";
}
@Deprecated //TODO: move this logic back to H2SqlAstTranslator
public void render(
TableInsert tableInsert,
Consumer<String> sqlAppender,

1
hibernate-core/src/main/java/org/hibernate/dialect/identity/H2IdentityColumnSupport.java
View File

@ -48,6 +48,7 @@ public interface InsertValuesHandler {
void renderInsertValues();
}
@Deprecated //TODO: get rid of this layer-breaking method!
public void render(
TableInsert tableInsert,
Consumer<String> sqlAppender,