Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-15184 Improve efficiency of Component#getSelectables()

This commit is contained in:
Sanne Grinovero 2022-04-06 15:12:51 +01:00 committed by Sanne Grinovero
parent 84cf4524ea
commit 25aec8d1b7
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
hibernate-core/src/main/java/org/hibernate/mapping/Component.java
View File

@ -59,6 +59,9 @@ public class Component extends SimpleValue implements MetaAttributable, Sortable
// cache the status of the type
private volatile Type type;
// lazily computed based on 'properties' field: invalidate by setting to null when properties are modified
private List<Selectable> cachedSelectables;
public Component(MetadataBuildingContext metadata, PersistentClass owner) throws MappingException {
this( metadata, owner.getTable(), owner );
}
@ -117,6 +120,11 @@ public class Component extends SimpleValue implements MetaAttributable, Sortable
public void addProperty(Property p) {
properties.add( p );
propertiesListModified();
}
private void propertiesListModified() {
cachedSelectables = null;
}
@Override
@ -146,9 +154,15 @@ public class Component extends SimpleValue implements MetaAttributable, Sortable
@Override
public List<Selectable> getSelectables() {
return properties.stream()
.flatMap( p -> p.getSelectables().stream() )
.collect(Collectors.toList());
if ( cachedSelectables != null ) {
return cachedSelectables;
}
else {
cachedSelectables = properties.stream()
.flatMap( p -> p.getSelectables().stream() )
.collect( Collectors.toList() );
return cachedSelectables;
}
}
@Override
@ -568,6 +582,7 @@ public class Component extends SimpleValue implements MetaAttributable, Sortable
}
}
}
propertiesListModified();
return this.originalPropertyOrder = originalPropertyOrder;
}