Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-6815: Overrode SQLServerDialect.getSqlTypeDescriptorOverride(int) to return a SmallIntTypeDescriptor instead when the datatype being updated is a TINYINT

This commit is contained in:
John Verhaeg 2011-11-09 12:52:51 -06:00
parent 8bb51c7acb
commit 25e8a43d81
1 changed files with 46 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
hibernate-core/src/main/java/org/hibernate/dialect/SQLServerDialect.java
View File

@ -29,6 +29,8 @@ import org.hibernate.dialect.function.AnsiTrimEmulationFunction;
import org.hibernate.dialect.function.SQLFunctionTemplate; import org.hibernate.dialect.function.SQLFunctionTemplate;
import org.hibernate.dialect.function.StandardSQLFunction; import org.hibernate.dialect.function.StandardSQLFunction;
import org.hibernate.type.StandardBasicTypes; import org.hibernate.type.StandardBasicTypes;
import org.hibernate.type.descriptor.sql.SmallIntTypeDescriptor;
import org.hibernate.type.descriptor.sql.SqlTypeDescriptor;
/** /**
* A dialect for Microsoft SQL Server 2000 * A dialect for Microsoft SQL Server 2000
@ -57,7 +59,8 @@ public class SQLServerDialect extends AbstractTransactSQLDialect {
registerKeyword( "top" ); registerKeyword( "top" );
} }
public String getNoColumnsInsertString() { @Override
public String getNoColumnsInsertString() {
return "default values"; return "default values";
} }
@ -67,7 +70,8 @@ public class SQLServerDialect extends AbstractTransactSQLDialect {
return selectIndex + ( selectDistinctIndex == selectIndex ? 15 : 6 ); return selectIndex + ( selectDistinctIndex == selectIndex ? 15 : 6 );
} }
public String getLimitString(String querySelect, int offset, int limit) { @Override
public String getLimitString(String querySelect, int offset, int limit) {
if ( offset > 0 ) { if ( offset > 0 ) {
throw new UnsupportedOperationException( "query result offset is not supported" ); throw new UnsupportedOperationException( "query result offset is not supported" );
} }
@ -80,38 +84,46 @@ public class SQLServerDialect extends AbstractTransactSQLDialect {
/** /**
* Use <tt>insert table(...) values(...) select SCOPE_IDENTITY()</tt> * Use <tt>insert table(...) values(...) select SCOPE_IDENTITY()</tt>
*/ */
public String appendIdentitySelectToInsert(String insertSQL) { @Override
public String appendIdentitySelectToInsert(String insertSQL) {
return insertSQL + " select scope_identity()"; return insertSQL + " select scope_identity()";
} }
public boolean supportsLimit() { @Override
public boolean supportsLimit() {
return true; return true;
} }
public boolean useMaxForLimit() { @Override
public boolean useMaxForLimit() {
return true; return true;
} }
public boolean supportsLimitOffset() { @Override
public boolean supportsLimitOffset() {
return false; return false;
} }
public boolean supportsVariableLimit() { @Override
public boolean supportsVariableLimit() {
return false; return false;
} }
public char closeQuote() { @Override
public char closeQuote() {
return ']'; return ']';
} }
public char openQuote() { @Override
public char openQuote() {
return '['; return '[';
} }
public String appendLockHint(LockMode mode, String tableName) { @Override
public String appendLockHint(LockMode mode, String tableName) {
if ( ( mode == LockMode.UPGRADE ) || if ( ( mode == LockMode.UPGRADE ) ||
( mode == LockMode.UPGRADE_NOWAIT ) || ( mode == LockMode.UPGRADE_NOWAIT ) ||
( mode == LockMode.PESSIMISTIC_WRITE ) || ( mode == LockMode.PESSIMISTIC_WRITE ) ||
( mode == LockMode.WRITE ) ) { ( mode == LockMode.WRITE ) ) {
return tableName + " with (updlock, rowlock)"; return tableName + " with (updlock, rowlock)";
} }
@ -125,39 +137,55 @@ public class SQLServerDialect extends AbstractTransactSQLDialect {
// The current_timestamp is more accurate, but only known to be supported // The current_timestamp is more accurate, but only known to be supported
// in SQL Server 7.0 and later (i.e., Sybase not known to support it at all) // in SQL Server 7.0 and later (i.e., Sybase not known to support it at all)
public String getCurrentTimestampSelectString() { @Override
public String getCurrentTimestampSelectString() {
return "select current_timestamp"; return "select current_timestamp";
} }
// Overridden informational metadata ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ // Overridden informational metadata ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
public boolean areStringComparisonsCaseInsensitive() { @Override
public boolean areStringComparisonsCaseInsensitive() {
return true; return true;
} }
public boolean supportsResultSetPositionQueryMethodsOnForwardOnlyCursor() { @Override
public boolean supportsResultSetPositionQueryMethodsOnForwardOnlyCursor() {
return false; return false;
} }
public boolean supportsCircularCascadeDeleteConstraints() { @Override
public boolean supportsCircularCascadeDeleteConstraints() {
// SQL Server (at least up through 2005) does not support defining // SQL Server (at least up through 2005) does not support defining
// cascade delete constraints which can circle back to the mutating // cascade delete constraints which can circle back to the mutating
// table // table
return false; return false;
} }
public boolean supportsLobValueChangePropogation() { @Override
public boolean supportsLobValueChangePropogation() {
// note: at least my local SQL Server 2005 Express shows this not working... // note: at least my local SQL Server 2005 Express shows this not working...
return false; return false;
} }
public boolean doesReadCommittedCauseWritersToBlockReaders() { @Override
public boolean doesReadCommittedCauseWritersToBlockReaders() {
return false; // here assume SQLServer2005 using snapshot isolation, which does not have this problem return false; // here assume SQLServer2005 using snapshot isolation, which does not have this problem
} }
public boolean doesRepeatableReadCauseReadersToBlockWriters() { @Override
public boolean doesRepeatableReadCauseReadersToBlockWriters() {
return false; // here assume SQLServer2005 using snapshot isolation, which does not have this problem return false; // here assume SQLServer2005 using snapshot isolation, which does not have this problem
} }
/**
* {@inheritDoc}
*
* @see org.hibernate.dialect.Dialect#getSqlTypeDescriptorOverride(int)
*/
@Override
protected SqlTypeDescriptor getSqlTypeDescriptorOverride( int sqlCode ) {
return sqlCode == Types.TINYINT ? SmallIntTypeDescriptor.INSTANCE : super.getSqlTypeDescriptorOverride(sqlCode);
}
} }