Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-7840 org.hibernate.id.IncrementGenerator very slow

This commit is contained in:
brmeyer 2012-12-07 11:16:48 -05:00
parent 1f690e7aa6
commit 263a84154e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hibernate-core/src/main/java/org/hibernate/id/IncrementGenerator.java
View File

@ -53,6 +53,7 @@ import org.hibernate.type.Type;
* *
* @author Gavin King * @author Gavin King
* @author Steve Ebersole * @author Steve Ebersole
* @author Brett Meyer
*/ */
public class IncrementGenerator implements IdentifierGenerator, Configurable { public class IncrementGenerator implements IdentifierGenerator, Configurable {
@ -103,7 +104,7 @@ public class IncrementGenerator implements IdentifierGenerator, Configurable {
for ( int i=0; i < tables.length; i++ ) { for ( int i=0; i < tables.length; i++ ) {
final String tableName = dialect.quote( normalizer.normalizeIdentifierQuoting( tables[i] ) ); final String tableName = dialect.quote( normalizer.normalizeIdentifierQuoting( tables[i] ) );
if ( tables.length > 1 ) { if ( tables.length > 1 ) {
buf.append( "select " ).append( column ).append( " from " ); buf.append( "select max(" ).append( column ).append( ") as mx from " );
} }
buf.append( Table.qualify( catalog, schema, tableName ) ); buf.append( Table.qualify( catalog, schema, tableName ) );
if ( i < tables.length-1 ) { if ( i < tables.length-1 ) {
@ -112,7 +113,7 @@ public class IncrementGenerator implements IdentifierGenerator, Configurable {
} }
if ( tables.length > 1 ) { if ( tables.length > 1 ) {
buf.insert( 0, "( " ).append( " ) ids_" ); buf.insert( 0, "( " ).append( " ) ids_" );
column = "ids_." + column; column = "ids_.mx";
} }
sql = "select max(" + column + ") from " + buf.toString(); sql = "select max(" + column + ") from " + buf.toString();