Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fixed concurrency problem uncovered during JMH-based throughput testing (Act 3)

This commit is contained in:
Steve Ebersole 2019-11-21 20:56:48 -06:00
parent 1b2aa85fa7
commit 2b65c73fb7
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hibernate-core/src/main/java/org/hibernate/query/sqm/internal/ConcreteSqmSelectQueryPlan.java
View File

@ -181,10 +181,14 @@ public class ConcreteSqmSelectQueryPlan<R> implements SelectQueryPlan<R> {
// The other option would be to leverage `java.util.concurrent.locks.ReadWriteLock` // The other option would be to leverage `java.util.concurrent.locks.ReadWriteLock`
// to protect access. However, synchronized is much simpler here. We will verify // to protect access. However, synchronized is much simpler here. We will verify
// during throughput testing whether this is an issue and consider changes then // during throughput testing whether this is an issue and consider changes then
if ( cacheableSqmInterpretation == null ) {
CacheableSqmInterpretation localCopy = cacheableSqmInterpretation;
if ( localCopy == null ) {
synchronized ( this ) { synchronized ( this ) {
if ( cacheableSqmInterpretation == null ) { localCopy = cacheableSqmInterpretation;
cacheableSqmInterpretation = buildCacheableSqmInterpretation( if ( localCopy == null ) {
cacheableSqmInterpretation = localCopy = buildCacheableSqmInterpretation(
sqm, sqm,
domainParameterXref, domainParameterXref,
executionContext executionContext
@ -193,7 +197,7 @@ public class ConcreteSqmSelectQueryPlan<R> implements SelectQueryPlan<R> {
} }
} }
return cacheableSqmInterpretation; return localCopy;
} }
private static CacheableSqmInterpretation buildCacheableSqmInterpretation( private static CacheableSqmInterpretation buildCacheableSqmInterpretation(